X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/ddb45d457a6e56461f506cba0add22902ef2c7d7..1590bc9ec710e9849ddfd70a02b0842ca0206dbf:/src/kernel/actor/ActorImpl.cpp diff --git a/src/kernel/actor/ActorImpl.cpp b/src/kernel/actor/ActorImpl.cpp index bd04da8f0f..17aa4afda3 100644 --- a/src/kernel/actor/ActorImpl.cpp +++ b/src/kernel/actor/ActorImpl.cpp @@ -1,27 +1,26 @@ -/* Copyright (c) 2007-2021. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2007-2022. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ -#include "mc/mc.h" -#include "simgrid/Exception.hpp" -#include "simgrid/s4u/Actor.hpp" -#include "simgrid/s4u/Exec.hpp" -#include "src/kernel/activity/CommImpl.hpp" -#include "src/kernel/activity/ExecImpl.hpp" -#include "src/kernel/activity/IoImpl.hpp" -#include "src/kernel/activity/SleepImpl.hpp" -#include "src/kernel/activity/SynchroRaw.hpp" -#include "src/mc/mc_replay.hpp" -#include "src/mc/remote/AppSide.hpp" -#include "src/simix/smx_private.hpp" +#include +#include +#include + +#define SIMIX_H_NO_DEPRECATED_WARNING // avoid deprecation warning on include (remove with XBT_ATTRIB_DEPRECATED_v333) +#include + +#include "src/kernel/EngineImpl.hpp" +#if HAVE_SMPI +#include "src/smpi/include/private.hpp" +#endif #include "src/surf/HostImpl.hpp" -#include "src/surf/cpu_interface.hpp" #include +#include #include -XBT_LOG_NEW_DEFAULT_SUBCATEGORY(simix_process, simix, "Logging specific to SIMIX (process)"); +XBT_LOG_NEW_DEFAULT_SUBCATEGORY(ker_actor, kernel, "Logging specific to Actor's kernel side"); /** * @brief Returns the current agent. @@ -30,7 +29,7 @@ XBT_LOG_NEW_DEFAULT_SUBCATEGORY(simix_process, simix, "Logging specific to SIMIX * * @return The SIMIX process */ -smx_actor_t SIMIX_process_self() +smx_actor_t SIMIX_process_self() // XBT_ATTRIB_DEPRECATED_v333 { return simgrid::kernel::actor::ActorImpl::self(); } @@ -39,6 +38,7 @@ namespace simgrid { namespace kernel { namespace actor { +/*------------------------- [ ActorIDTrait ] -------------------------*/ static unsigned long maxpid = 0; unsigned long get_maxpid() { @@ -48,17 +48,11 @@ unsigned long* get_maxpid_addr() { return &maxpid; } +ActorIDTrait::ActorIDTrait(std::string name, aid_t ppid) : name_(std::move(name)), pid_(maxpid++), ppid_(ppid) {} + ActorImpl* ActorImpl::by_pid(aid_t pid) { - auto item = simix_global->process_list.find(pid); - if (item != simix_global->process_list.end()) - return item->second; - - // Search the trash - for (auto& a : simix_global->actors_to_destroy) - if (a.get_pid() == pid) - return &a; - return nullptr; // Not found, even in the trash + return EngineImpl::get_instance()->get_actor_by_pid(pid); } ActorImpl* ActorImpl::self() @@ -68,16 +62,16 @@ ActorImpl* ActorImpl::self() return (self_context != nullptr) ? self_context->get_actor() : nullptr; } -ActorImpl::ActorImpl(xbt::string name, s4u::Host* host) : host_(host), name_(std::move(name)), piface_(this) +ActorImpl::ActorImpl(xbt::string name, s4u::Host* host, aid_t ppid) + : ActorIDTrait(std::move(name), ppid), host_(host), piface_(this) { - pid_ = maxpid++; simcall_.issuer_ = this; - stacksize_ = smx_context_stack_size; + stacksize_ = context::stack_size; } ActorImpl::~ActorImpl() { - if (simix_global != nullptr && this != simix_global->maestro_) + if (EngineImpl::has_instance() && not EngineImpl::get_instance()->is_maestro(this)) s4u::Actor::on_destruction(*get_ciface()); } @@ -92,7 +86,7 @@ ActorImpl::~ActorImpl() ActorImplPtr ActorImpl::attach(const std::string& name, void* data, s4u::Host* host) { // This is mostly a copy/paste from create(), it'd be nice to share some code between those two functions. - + auto* engine = EngineImpl::get_instance(); XBT_DEBUG("Attach actor %s on host '%s'", name.c_str(), host->get_cname()); if (not host->is_on()) { @@ -100,22 +94,20 @@ ActorImplPtr ActorImpl::attach(const std::string& name, void* data, s4u::Host* h throw HostFailureException(XBT_THROW_POINT, "Cannot attach actor on failed host."); } - auto* actor = new ActorImpl(xbt::string(name), host); + auto* actor = new ActorImpl(xbt::string(name), host, /*ppid*/ -1); /* Actor data */ - actor->set_user_data(data); + actor->piface_.set_data(data); actor->code_ = nullptr; XBT_VERB("Create context %s", actor->get_cname()); - xbt_assert(simix_global != nullptr, "simix is not initialized, please call MSG_init first"); - actor->context_.reset(simix_global->context_factory->attach(actor)); + actor->context_.reset(engine->get_context_factory()->attach(actor)); /* Add the actor to it's host actor list */ host->get_impl()->add_actor(actor); /* Now insert it in the global actor list and in the actors to run list */ - simix_global->process_list[actor->get_pid()] = actor; - XBT_DEBUG("Inserting [%p] %s(%s) in the to_run list", actor, actor->get_cname(), host->get_cname()); - simix_global->actors_to_run.push_back(actor); + engine->add_actor(actor->get_pid(), actor); + engine->add_actor_to_run_list_no_check(actor); intrusive_ptr_add_ref(actor); auto* context = dynamic_cast(actor->context_.get()); @@ -138,27 +130,27 @@ void ActorImpl::detach() auto* context = dynamic_cast(context::Context::self()); xbt_assert(context != nullptr, "Not a suitable context"); - context->get_actor()->cleanup(); + context->get_actor()->cleanup_from_self(); context->attach_stop(); } -void ActorImpl::cleanup_from_simix() +/** Whether this actor is actually maestro */ +bool ActorImpl::is_maestro() const { - const std::lock_guard lock(simix_global->mutex); - simix_global->process_list.erase(pid_); - if (host_ && host_actor_list_hook.is_linked()) - host_->get_impl()->remove_actor(this); - if (not smx_destroy_list_hook.is_linked()) { -#if SIMGRID_HAVE_MC - xbt_dynar_push_as(simix_global->dead_actors_vector, ActorImpl*, this); -#endif - simix_global->actors_to_destroy.push_back(*this); - } + return context_->is_maestro(); } -void ActorImpl::cleanup() +void ActorImpl::cleanup_from_kernel() { - finished_ = true; + xbt_assert(s4u::Actor::is_maestro(), "Cleanup_from_kernel called from '%s' on '%s'", ActorImpl::self()->get_cname(), + get_cname()); + + auto* engine = EngineImpl::get_instance(); + engine->remove_actor(get_pid()); + if (host_ && host_actor_list_hook.is_linked()) + host_->get_impl()->remove_actor(this); + if (not kernel_destroy_list_hook.is_linked()) + engine->add_actor_to_destroy_list(*this); if (has_to_auto_restart() && not get_host()->is_on()) { XBT_DEBUG("Insert host %s to watched_hosts because it's off and %s needs to restart", get_host()->get_cname(), @@ -166,14 +158,26 @@ void ActorImpl::cleanup() watched_hosts().insert(get_host()->get_name()); } + undaemonize(); + + while (not mailboxes_.empty()) + mailboxes_.back()->set_receiver(nullptr); +} + +/* Do all the cleanups from the actor context. Warning, the simcall mechanism was not reignited so doing simcalls in + * this context is dangerous */ +void ActorImpl::cleanup_from_self() +{ + xbt_assert(not ActorImpl::is_maestro(), "Cleanup_from_self called from maestro on '%s'", get_cname()); + set_to_be_freed(); + if (on_exit) { // Execute the termination callbacks - bool failed = context_->wannadie(); + bool failed = wannadie(); for (auto exit_fun = on_exit->crbegin(); exit_fun != on_exit->crend(); ++exit_fun) (*exit_fun)(failed); on_exit.reset(); } - undaemonize(); /* cancel non-blocking activities */ for (auto activity : activities_) @@ -182,11 +186,6 @@ void ActorImpl::cleanup() XBT_DEBUG("%s@%s(%ld) should not run anymore", get_cname(), get_host()->get_cname(), get_pid()); - if (this == simix_global->maestro_) /* Do not cleanup maestro */ - return; - - XBT_DEBUG("Cleanup actor %s (%p), waiting synchro %p", get_cname(), this, waiting_synchro_.get()); - /* Unregister associated timers if any */ if (kill_timer_ != nullptr) { kill_timer_->remove(); @@ -197,38 +196,30 @@ void ActorImpl::cleanup() simcall_.timeout_cb_ = nullptr; } - cleanup_from_simix(); - - context_->set_wannadie(false); // don't let the simcall's yield() do a Context::stop(), to avoid infinite loops - actor::simcall([this] { s4u::Actor::on_termination(*get_ciface()); }); - context_->set_wannadie(); + set_wannadie(false); // don't let the simcall's yield() do a Context::stop(), to avoid infinite loops + actor::simcall_answered([this] { s4u::Actor::on_termination(*get_ciface()); }); + set_wannadie(); } void ActorImpl::exit() { - context_->set_wannadie(); - suspended_ = false; - exception_ = nullptr; + set_wannadie(); + suspended_ = false; + exception_ = nullptr; - /* destroy the blocking synchro if any */ if (waiting_synchro_ != nullptr) { - waiting_synchro_->cancel(); - waiting_synchro_->state_ = activity::State::FAILED; - - activity::ExecImplPtr exec = boost::dynamic_pointer_cast(waiting_synchro_); - activity::CommImplPtr comm = boost::dynamic_pointer_cast(waiting_synchro_); - - if (exec != nullptr) { - exec->clean_action(); - } else if (comm != nullptr) { - comm->unregister_simcall(&simcall_); - } else { - activity::ActivityImplPtr(waiting_synchro_)->finish(); - } + /* Take an extra reference on the activity object that may be unref by Comm::finish() or friends */ + activity::ActivityImplPtr activity = waiting_synchro_; + activity->cancel(); + activity->set_state(activity::State::FAILED); + activity->post(); activities_.remove(waiting_synchro_); waiting_synchro_ = nullptr; } + for (auto const& activity : activities_) + activity->cancel(); + activities_.clear(); // Forcefully kill the actor if its host is turned off. Not a HostFailureException because you should not survive that this->throw_exception(std::make_exception_ptr(ForcefulKillException(host_->is_on() ? "exited" : "host failed"))); @@ -236,8 +227,8 @@ void ActorImpl::exit() void ActorImpl::kill(ActorImpl* actor) const { - xbt_assert(actor != simix_global->maestro_, "Killing maestro is a rather bad idea"); - if (actor->finished_) { + xbt_assert(not actor->is_maestro(), "Killing maestro is a rather bad idea."); + if (actor->wannadie()) { XBT_DEBUG("Ignoring request to kill actor %s@%s that is already dead", actor->get_cname(), actor->host_->get_cname()); return; @@ -250,36 +241,32 @@ void ActorImpl::kill(ActorImpl* actor) const if (actor == this) { XBT_DEBUG("Go on, this is a suicide,"); - } else if (std::find(begin(simix_global->actors_to_run), end(simix_global->actors_to_run), actor) != - end(simix_global->actors_to_run)) { - XBT_DEBUG("Actor %s is already in the to_run list", actor->get_cname()); - } else { - XBT_DEBUG("Inserting %s in the to_run list", actor->get_cname()); - simix_global->actors_to_run.push_back(actor); - } + } else + EngineImpl::get_instance()->add_actor_to_run_list(actor); } void ActorImpl::kill_all() const { - for (auto const& kv : simix_global->process_list) + for (auto const& kv : EngineImpl::get_instance()->get_actor_list()) if (kv.second != this) this->kill(kv.second); } void ActorImpl::set_kill_time(double kill_time) { - if (kill_time <= SIMIX_get_clock()) + if (kill_time <= s4u::Engine::get_clock()) return; XBT_DEBUG("Set kill time %f for actor %s@%s", kill_time, get_cname(), host_->get_cname()); - kill_timer_ = simix::Timer::set(kill_time, [this] { + kill_timer_ = timer::Timer::set(kill_time, [this] { this->exit(); kill_timer_ = nullptr; + EngineImpl::get_instance()->add_actor_to_run_list(this); }); } double ActorImpl::get_kill_time() const { - return kill_timer_ ? kill_timer_->date : 0.0; + return kill_timer_ ? kill_timer_->get_date() : 0.0; } void ActorImpl::yield() @@ -288,11 +275,10 @@ void ActorImpl::yield() /* Go into sleep and return control to maestro */ context_->suspend(); - /* Ok, maestro returned control to us */ XBT_DEBUG("Control returned to me: '%s'", get_cname()); - if (context_->wannadie()) { + if (wannadie()) { XBT_DEBUG("Actor %s@%s is dead", get_cname(), host_->get_cname()); context_->stop(); THROW_IMPOSSIBLE; @@ -300,12 +286,7 @@ void ActorImpl::yield() if (suspended_) { XBT_DEBUG("Hey! I'm suspended."); - xbt_assert(exception_ == nullptr, "Gasp! This exception may be lost by subsequent calls."); - - if (waiting_synchro_ != nullptr) // Not sure of when this will happen. Maybe when suspending early in the SR when a - waiting_synchro_->suspend(); // waiting_synchro was terminated - yield(); // Yield back to maestro without proceeding with my execution. I'll get rescheduled by resume() } @@ -319,10 +300,10 @@ void ActorImpl::yield() e.rethrow_nested(XBT_THROW_POINT, boost::core::demangle(typeid(e).name()) + " raised in kernel mode."); } } - - if (SMPI_switch_data_segment && not finished_) { - SMPI_switch_data_segment(get_iface()); - } +#if HAVE_SMPI + if (not wannadie()) + smpi_switch_data_segment(get_iface()); +#endif } /** This actor will be terminated automatically when the last non-daemon actor finishes */ @@ -330,44 +311,32 @@ void ActorImpl::daemonize() { if (not daemon_) { daemon_ = true; - simix_global->daemons.push_back(this); + EngineImpl::get_instance()->add_daemon(this); } } void ActorImpl::undaemonize() { if (daemon_) { - auto& vect = simix_global->daemons; - auto it = std::find(vect.begin(), vect.end(), this); - xbt_assert(it != vect.end(), "The dying daemon is not a daemon after all. Please report that bug."); - /* Don't move the whole content since we don't really care about the order */ - - std::swap(*it, vect.back()); - vect.pop_back(); daemon_ = false; + EngineImpl::get_instance()->remove_daemon(this); } } s4u::Actor* ActorImpl::restart() { - xbt_assert(this != simix_global->maestro_, "Restarting maestro is not supported"); + xbt_assert(not this->is_maestro(), "Restarting maestro is not supported"); XBT_DEBUG("Restarting actor %s on %s", get_cname(), host_->get_cname()); // retrieve the arguments of the old actor - ProcessArg arg(host_, this); + ProcessArg args(host_, this); // kill the old actor context::Context::self()->get_actor()->kill(this); // start the new actor - ActorImplPtr actor = ActorImpl::create(arg.name, arg.code, arg.data, arg.host, nullptr); - actor->set_properties(arg.properties); - *actor->on_exit = std::move(*arg.on_exit); - actor->set_kill_time(arg.kill_time); - actor->set_auto_restart(arg.auto_restart); - - return actor->get_ciface(); + return create(&args)->get_ciface(); } void ActorImpl::suspend() @@ -379,18 +348,17 @@ void ActorImpl::suspend() suspended_ = true; - /* If the suspended actor is waiting on a sync, suspend its synchronization. - * Otherwise, it will suspend itself when scheduled, ie, very soon. */ - if (waiting_synchro_ != nullptr) - waiting_synchro_->suspend(); + /* Suspend the activities associated with this actor. */ + for (auto const& activity : activities_) + activity->suspend(); } void ActorImpl::resume() { XBT_IN("actor = %p", this); - if (context_->wannadie()) { - XBT_VERB("Ignoring request to suspend an actor that is currently dying."); + if (wannadie()) { + XBT_VERB("Ignoring request to resume an actor that is currently dying."); return; } @@ -398,11 +366,11 @@ void ActorImpl::resume() return; suspended_ = false; - /* resume the activity that was blocking the resumed actor. */ - if (waiting_synchro_) - waiting_synchro_->resume(); - else // Reschedule the actor if it was forcefully unscheduled in yield() - simix_global->actors_to_run.push_back(this); + /* resume the activities that were blocked when suspending the actor. */ + for (auto const& activity : activities_) + activity->resume(); + if (not waiting_synchro_) // Reschedule the actor if it was forcefully unscheduled in yield() + EngineImpl::get_instance()->add_actor_to_run_list_no_check(this); XBT_OUT(); } @@ -410,10 +378,15 @@ void ActorImpl::resume() activity::ActivityImplPtr ActorImpl::join(const ActorImpl* actor, double timeout) { activity::ActivityImplPtr sleep = this->sleep(timeout); - actor->on_exit->emplace_back([sleep](bool) { + if (actor->wannadie() || actor->to_be_freed()) { if (sleep->surf_action_) sleep->surf_action_->finish(resource::Action::State::FINISHED); - }); + } else { + actor->on_exit->emplace_back([sleep](bool) { + if (sleep->surf_action_) + sleep->surf_action_->finish(resource::Action::State::FINISHED); + }); + } return sleep; } @@ -445,15 +418,16 @@ void ActorImpl::throw_exception(std::exception_ptr e) void ActorImpl::simcall_answer() { - if (this != simix_global->maestro_) { - XBT_DEBUG("Answer simcall %s issued by %s (%p)", SIMIX_simcall_name(simcall_), get_cname(), this); - xbt_assert(simcall_.call_ != simix::Simcall::NONE); - simcall_.call_ = simix::Simcall::NONE; - xbt_assert(not XBT_LOG_ISENABLED(simix_process, xbt_log_priority_debug) || - std::find(begin(simix_global->actors_to_run), end(simix_global->actors_to_run), this) == - end(simix_global->actors_to_run), + auto* engine = EngineImpl::get_instance(); + if (not this->is_maestro()) { + XBT_DEBUG("Answer simcall %s issued by %s (%p)", simcall_.get_cname(), get_cname(), this); + xbt_assert(simcall_.call_ != Simcall::Type::NONE); + simcall_.call_ = Simcall::Type::NONE; + const auto& actors_to_run = engine->get_actors_to_run(); + xbt_assert(not XBT_LOG_ISENABLED(ker_actor, xbt_log_priority_debug) || + std::find(begin(actors_to_run), end(actors_to_run), this) == end(actors_to_run), "Actor %p should not exist in actors_to_run!", this); - simix_global->actors_to_run.push_back(this); + engine->add_actor_to_run_list_no_check(this); } } @@ -466,8 +440,7 @@ void ActorImpl::set_host(s4u::Host* dest) ActorImplPtr ActorImpl::init(const std::string& name, s4u::Host* host) const { - auto* actor = new ActorImpl(xbt::string(name), host); - actor->set_ppid(this->pid_); + auto* actor = new ActorImpl(xbt::string(name), host, get_pid()); intrusive_ptr_add_ref(actor); /* The on_creation() signal must be delayed until there, where the pid and everything is set */ @@ -479,26 +452,26 @@ ActorImplPtr ActorImpl::init(const std::string& name, s4u::Host* host) const ActorImpl* ActorImpl::start(const ActorCode& code) { xbt_assert(code && host_ != nullptr, "Invalid parameters"); + auto* engine = EngineImpl::get_instance(); if (not host_->is_on()) { - XBT_WARN("Cannot launch actor '%s' on failed host '%s'", name_.c_str(), host_->get_cname()); + XBT_WARN("Cannot launch actor '%s' on failed host '%s'", get_cname(), host_->get_cname()); intrusive_ptr_release(this); throw HostFailureException(XBT_THROW_POINT, "Cannot start actor on failed host."); } this->code_ = code; XBT_VERB("Create context %s", get_cname()); - context_.reset(simix_global->context_factory->create_context(ActorCode(code), this)); + context_.reset(engine->get_context_factory()->create_context(ActorCode(code), this)); XBT_DEBUG("Start context '%s'", get_cname()); /* Add the actor to its host's actor list */ host_->get_impl()->add_actor(this); - simix_global->process_list[pid_] = this; + engine->add_actor(get_pid(), this); /* Now insert it in the global actor list and in the actor to run list */ - XBT_DEBUG("Inserting [%p] %s(%s) in the to_run list", this, get_cname(), host_->get_cname()); - simix_global->actors_to_run.push_back(this); + engine->add_actor_to_run_list_no_check(this); return this; } @@ -514,74 +487,61 @@ ActorImplPtr ActorImpl::create(const std::string& name, const ActorCode& code, v else actor = self()->init(xbt::string(name), host); - /* actor data */ - actor->set_user_data(data); + actor->piface_.set_data(data); /* actor data */ actor->start(code); return actor; } +ActorImplPtr ActorImpl::create(ProcessArg* args) +{ + ActorImplPtr actor = ActorImpl::create(args->name, args->code, nullptr, args->host, nullptr); + actor->restart_count_ = args->restart_count_; + actor->set_properties(args->properties); + if (args->on_exit) + *actor->on_exit = *args->on_exit; + if (args->kill_time >= 0) + actor->set_kill_time(args->kill_time); + if (args->auto_restart) + actor->set_auto_restart(args->auto_restart); + if (args->daemon_) + actor->daemonize(); + return actor; +} +void ActorImpl::set_wannadie(bool value) +{ + XBT_DEBUG("Actor %s gonna die.", get_cname()); + iwannadie_ = value; +} void create_maestro(const std::function& code) { + auto* engine = EngineImpl::get_instance(); /* Create maestro actor and initialize it */ - auto* maestro = new ActorImpl(xbt::string(""), /*host*/ nullptr); + auto* maestro = new ActorImpl(xbt::string(""), /*host*/ nullptr, /*ppid*/ -1); if (not code) { - maestro->context_.reset(simix_global->context_factory->create_context(ActorCode(), maestro)); + maestro->context_.reset(engine->get_context_factory()->create_context(ActorCode(), maestro)); } else { - maestro->context_.reset(simix_global->context_factory->create_maestro(ActorCode(code), maestro)); + maestro->context_.reset(engine->get_context_factory()->create_maestro(ActorCode(code), maestro)); } - maestro->simcall_.issuer_ = maestro; - simix_global->maestro_ = maestro; + maestro->simcall_.issuer_ = maestro; + engine->set_maestro(maestro); } } // namespace actor } // namespace kernel } // namespace simgrid -int SIMIX_process_count() // XBT_ATTRIB_DEPRECATED_v329 -{ - return simix_global->process_list.size(); -} - -void* SIMIX_process_self_get_data() // XBT_ATTRIB_DEPRECATED_v329 -{ - smx_actor_t self = simgrid::kernel::actor::ActorImpl::self(); - - if (self == nullptr) { - return nullptr; - } - return self->get_user_data(); -} - -void SIMIX_process_self_set_data(void* data) // XBT_ATTRIB_DEPRECATED_v329 -{ - simgrid::kernel::actor::ActorImpl::self()->set_user_data(data); -} - -/* needs to be public and without simcall because it is called - by exceptions and logging events */ -const char* SIMIX_process_self_get_name() -{ - return SIMIX_is_maestro() ? "maestro" : simgrid::kernel::actor::ActorImpl::self()->get_cname(); -} - -/** @brief Returns the process from PID. */ -smx_actor_t SIMIX_process_from_PID(aid_t pid) -{ - return simgrid::kernel::actor::ActorImpl::by_pid(pid); -} - -void SIMIX_process_on_exit(smx_actor_t actor, - const std::function& fun) // XBT_ATTRIB_DEPRECATED_v329 +/* needs to be public and without simcall because it is called by exceptions and logging events */ +const char* SIMIX_process_self_get_name() // XBT_ATTRIB_DEPRECATED_v333 { - xbt_assert(actor, "current process not found: are you in maestro context ?"); - actor->on_exit->emplace_back(fun); + return simgrid::s4u::Actor::is_maestro() ? "maestro" : simgrid::kernel::actor::ActorImpl::self()->get_cname(); } -void simcall_process_set_data(smx_actor_t process, void* data) // XBT_ATTRIB_DEPRECATED_v329 +int SIMIX_is_maestro() // XBT_ATTRIB_DEPRECATED_v333 { - simgrid::kernel::actor::simcall([process, data] { process->set_user_data(data); }); + const auto* self = simgrid::kernel::actor::ActorImpl::self(); + return self != nullptr && self->is_maestro(); }