X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/dbb714754efd44f72bf3b18e5dc973d8669ed735..220a0c6c5a2edccc979b3c7f8ebc1409ff77ae0f:/src/simix/smx_vm.c

diff --git a/src/simix/smx_vm.c b/src/simix/smx_vm.c
index d68acb2c00..ce340c2082 100644
--- a/src/simix/smx_vm.c
+++ b/src/simix/smx_vm.c
@@ -22,25 +22,15 @@ XBT_LOG_NEW_DEFAULT_SUBCATEGORY(simix_vm, simix, "Logging specific to SIMIX (vms
  */
 smx_host_t SIMIX_vm_create(const char *name, smx_host_t ind_phys_host)
 {
-
-  smx_host_priv_t smx_host = xbt_new0(s_smx_host_priv_t, 1);
-  s_smx_process_t proc;
-
-  // TODO check why we do not have any VM here and why we have the host_proc_hookup  ?
-
-  /* Host structure */
-  smx_host->data = NULL;
-  smx_host->process_list =
-      xbt_swag_new(xbt_swag_offset(proc, host_proc_hookup));
-
-  /* Update global variables */
-  xbt_lib_set(host_lib,name,SIMIX_HOST_LEVEL,smx_host);
-
   /* Create surf associated resource */
-  // TODO change phys_host into the right workstation surf model
   surf_vm_workstation_model->extension.vm_workstation.create(name, ind_phys_host);
 
-  return xbt_lib_get_elm_or_null(host_lib, name);
+  smx_host_t smx_host = SIMIX_host_create(name, ind_phys_host, NULL);
+
+  /* We will be able to register the VM to its physical host, so that we can promptly
+   * retrieve the list VMs on the physical host. */
+
+  return smx_host;
 }
 
 
@@ -50,52 +40,79 @@ smx_host_t SIMIX_pre_vm_create(smx_simcall_t simcall, const char *name, smx_host
 }
 
 
-static int get_host_property_as_integer(smx_host_t host, const char *name)
+/* works for VMs and PMs */
+static long host_get_ramsize(smx_host_t vm, int *overcommit)
 {
-  xbt_dict_t dict = SIMIX_host_get_properties(host);
-
-  char *value = xbt_dict_get_or_null(dict, name);
-  return atoi(value);
-}
+  s_ws_params_t params;
+  surf_workstation_model->extension.workstation.get_params(vm, &params);
 
+  if (overcommit)
+    *overcommit = params.overcommit;
 
+  return params.ramsize;
+}
 
 /* **** start a VM **** */
 static int __can_be_started(smx_host_t vm)
 {
-	// TODO add checking code related to overcommitment or not.
+  smx_host_t pm = surf_vm_workstation_model->extension.vm_workstation.get_pm(vm);
 
-#if 0
-  int overcommit = get_host_property_as_integer(vm, "OverCommit");
-  int core_nb = get_host_property_as_integer(vm, "CORE_NB");
-  int mem_cap = get_host_property_as_integer(vm, "MEM_CAP");
-  int net_cap = get_host_property_as_integer(vm, "NET_CAP");
-#endif
+  int pm_overcommit = 0;
+  long pm_ramsize = host_get_ramsize(pm, &pm_overcommit);
+  long vm_ramsize = host_get_ramsize(vm, NULL);
 
-  /* we need to get other VM objects on this physical host. */
+  if (!pm_ramsize) {
+    /* We assume users do not want to care about ramsize. */
+    return 1;
+  }
+
+  if (pm_overcommit) {
+    XBT_INFO("%s allows memory overcommit.", pm->key);
+    return 1;
+  }
 
+  long total_ramsize_of_vms = 0;
+  xbt_dynar_t dyn_vms = surf_workstation_model->extension.workstation.get_vms(pm);
+  {
+    unsigned int cursor = 0;
+    smx_host_t another_vm;
+    xbt_dynar_foreach(dyn_vms, cursor, another_vm) {
+      long another_vm_ramsize = host_get_ramsize(vm, NULL);
+      total_ramsize_of_vms += another_vm_ramsize;
+    }
+  }
 
+  if (vm_ramsize > pm_ramsize - total_ramsize_of_vms) {
+    XBT_WARN("cannnot start %s@%s due to memory shortage: vm_ramsize %ld, free %ld, pm_ramsize %ld (bytes).",
+        vm->key, pm->key, vm_ramsize, pm_ramsize - total_ramsize_of_vms, pm_ramsize);
+    xbt_dynar_free(&dyn_vms);
+    return 0;
+  }
 
+  xbt_dynar_free(&dyn_vms);
 	return 1;
 }
 
 void SIMIX_vm_start(smx_host_t ind_vm)
 {
-  //TODO only start the VM if you can
   if (__can_be_started(ind_vm))
     SIMIX_vm_set_state(ind_vm, SURF_VM_STATE_RUNNING);
   else
     THROWF(vm_error, 0, "The VM %s cannot be started", SIMIX_host_get_name(ind_vm));
 }
 
+
+
 void SIMIX_pre_vm_start(smx_simcall_t simcall, smx_host_t ind_vm)
 {
   SIMIX_vm_start(ind_vm);
+  SIMIX_simcall_answer(simcall);
 }
 
 /* ***** set/get state of a VM ***** */
 void SIMIX_vm_set_state(smx_host_t ind_vm, int state)
 {
+  /* jump to vm_ws_set_state */
   surf_vm_workstation_model->extension.vm_workstation.set_state(ind_vm, state);
 }
 
@@ -122,10 +139,9 @@ int SIMIX_pre_vm_get_state(smx_simcall_t simcall, smx_host_t ind_vm)
  */
 void SIMIX_vm_migrate(smx_host_t ind_vm, smx_host_t ind_dst_pm)
 {
-  const char *name = SIMIX_host_get_name(ind_vm);
-
-  if (SIMIX_vm_get_state(ind_vm) != SURF_VM_STATE_RUNNING)
-    THROWF(vm_error, 0, "VM(%s) is not running", name);
+  /* precopy migration makes the VM temporally paused */
+  e_surf_vm_state_t state = SIMIX_vm_get_state(ind_vm);
+  xbt_assert(state == SURF_VM_STATE_SUSPENDED);
 
   /* jump to vm_ws_migrate(). this will update the vm location. */
   surf_vm_workstation_model->extension.vm_workstation.migrate(ind_vm, ind_dst_pm);
@@ -134,6 +150,7 @@ void SIMIX_vm_migrate(smx_host_t ind_vm, smx_host_t ind_dst_pm)
 void SIMIX_pre_vm_migrate(smx_simcall_t simcall, smx_host_t ind_vm, smx_host_t ind_dst_pm)
 {
   SIMIX_vm_migrate(ind_vm, ind_dst_pm);
+  SIMIX_simcall_answer(simcall);
 }
 
 
@@ -343,8 +360,6 @@ void SIMIX_vm_destroy(smx_host_t ind_vm)
   xbt_assert((ind_vm != NULL), "Invalid parameters");
   const char *hostname = SIMIX_host_get_name(ind_vm);
 
-  smx_host_priv_t host_priv = SIMIX_host_priv(ind_vm);
-
   /* this will call the registered callback function, i.e., SIMIX_host_destroy().  */
   xbt_lib_unset(host_lib, hostname, SIMIX_HOST_LEVEL, 1);
 
@@ -352,6 +367,8 @@ void SIMIX_vm_destroy(smx_host_t ind_vm)
   surf_vm_workstation_model->extension.vm_workstation.destroy(ind_vm);
 }
 
-void SIMIX_pre_vm_destroy(smx_simcall_t simcall, smx_host_t ind_vm){
-   SIMIX_vm_destroy(ind_vm);
+void SIMIX_pre_vm_destroy(smx_simcall_t simcall, smx_host_t ind_vm)
+{
+  SIMIX_vm_destroy(ind_vm);
+  SIMIX_simcall_answer(simcall);
 }