X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/d70128f70514554704db4f73ce52cde5b8380b5e..eda8761162ea40271daf72d84c25b8c030f510e9:/src/smpi/smpi_pmpi.cpp diff --git a/src/smpi/smpi_pmpi.cpp b/src/smpi/smpi_pmpi.cpp index 57075dfe69..6e89a6d9a6 100644 --- a/src/smpi/smpi_pmpi.cpp +++ b/src/smpi/smpi_pmpi.cpp @@ -4,10 +4,8 @@ * under the terms of the license (GNU LGPL) which comes with this package. */ #include -#include #include "private.h" -#include "smpi_mpi_dt_private.h" XBT_LOG_NEW_DEFAULT_SUBCATEGORY(smpi_pmpi, smpi, "Logging specific to SMPI (pmpi)"); @@ -153,7 +151,7 @@ int PMPI_Type_free(MPI_Datatype * datatype) if (*datatype == MPI_DATATYPE_NULL) { return MPI_ERR_ARG; } else { - smpi_datatype_unuse(*datatype); + Datatype::unref(*datatype); return MPI_SUCCESS; } } @@ -165,7 +163,7 @@ int PMPI_Type_size(MPI_Datatype datatype, int *size) } else if (size == nullptr) { return MPI_ERR_ARG; } else { - *size = static_cast(smpi_datatype_size(datatype)); + *size = static_cast(datatype->size()); return MPI_SUCCESS; } } @@ -177,7 +175,7 @@ int PMPI_Type_size_x(MPI_Datatype datatype, MPI_Count *size) } else if (size == nullptr) { return MPI_ERR_ARG; } else { - *size = static_cast(smpi_datatype_size(datatype)); + *size = static_cast(datatype->size()); return MPI_SUCCESS; } } @@ -189,7 +187,7 @@ int PMPI_Type_get_extent(MPI_Datatype datatype, MPI_Aint * lb, MPI_Aint * extent } else if (lb == nullptr || extent == nullptr) { return MPI_ERR_ARG; } else { - return smpi_datatype_extent(datatype, lb, extent); + return datatype->extent(lb, extent); } } @@ -205,7 +203,7 @@ int PMPI_Type_extent(MPI_Datatype datatype, MPI_Aint * extent) } else if (extent == nullptr) { return MPI_ERR_ARG; } else { - *extent = smpi_datatype_get_extent(datatype); + *extent = datatype->get_extent(); return MPI_SUCCESS; } } @@ -217,7 +215,7 @@ int PMPI_Type_lb(MPI_Datatype datatype, MPI_Aint * disp) } else if (disp == nullptr) { return MPI_ERR_ARG; } else { - *disp = smpi_datatype_lb(datatype); + *disp = datatype->lb(); return MPI_SUCCESS; } } @@ -229,17 +227,24 @@ int PMPI_Type_ub(MPI_Datatype datatype, MPI_Aint * disp) } else if (disp == nullptr) { return MPI_ERR_ARG; } else { - *disp = smpi_datatype_ub(datatype); + *disp = datatype->ub(); return MPI_SUCCESS; } } int PMPI_Type_dup(MPI_Datatype datatype, MPI_Datatype *newtype){ + int retval = MPI_SUCCESS; if (datatype == MPI_DATATYPE_NULL) { - return MPI_ERR_TYPE; + retval=MPI_ERR_TYPE; } else { - return smpi_datatype_dup(datatype, newtype); + *newtype = new Datatype(datatype, &retval); + //error when duplicating, free the new datatype + if(retval!=MPI_SUCCESS){ + Datatype::unref(*newtype); + *newtype = MPI_DATATYPE_NULL; + } } + return retval; } int PMPI_Op_create(MPI_User_function * function, int commute, MPI_Op * op) @@ -247,7 +252,7 @@ int PMPI_Op_create(MPI_User_function * function, int commute, MPI_Op * op) if (function == nullptr || op == nullptr) { return MPI_ERR_ARG; } else { - *op = smpi_op_new(function, (commute!=0)); + *op = new Op(function, (commute!=0)); return MPI_SUCCESS; } } @@ -259,7 +264,7 @@ int PMPI_Op_free(MPI_Op * op) } else if (*op == MPI_OP_NULL) { return MPI_ERR_OP; } else { - smpi_op_destroy(*op); + delete (*op); *op = MPI_OP_NULL; return MPI_SUCCESS; } @@ -270,7 +275,8 @@ int PMPI_Group_free(MPI_Group * group) if (group == nullptr) { return MPI_ERR_ARG; } else { - (*group)->destroy(); + if(*group != MPI_COMM_WORLD->group() && *group != MPI_GROUP_EMPTY) + Group::unref(*group); *group = MPI_GROUP_NULL; return MPI_SUCCESS; } @@ -386,7 +392,7 @@ int PMPI_Group_excl(MPI_Group group, int n, int *ranks, MPI_Group * newgroup) *newgroup = group; if (group != MPI_COMM_WORLD->group() && group != MPI_COMM_SELF->group() && group != MPI_GROUP_EMPTY) - group->use(); + group->ref(); return MPI_SUCCESS; } else if (n == group->size()) { *newgroup = MPI_GROUP_EMPTY; @@ -424,7 +430,7 @@ int PMPI_Group_range_excl(MPI_Group group, int n, int ranges[][3], MPI_Group * n *newgroup = group; if (group != MPI_COMM_WORLD->group() && group != MPI_COMM_SELF->group() && group != MPI_GROUP_EMPTY) - group->use(); + group->ref(); return MPI_SUCCESS; } else { return group->range_excl(n,ranges,newgroup); @@ -477,7 +483,7 @@ int PMPI_Comm_group(MPI_Comm comm, MPI_Group * group) } else { *group = comm->group(); if (*group != MPI_COMM_WORLD->group() && *group != MPI_GROUP_NULL && *group != MPI_GROUP_EMPTY) - (*group)->use(); + (*group)->ref(); return MPI_SUCCESS; } } @@ -524,8 +530,8 @@ int PMPI_Comm_create(MPI_Comm comm, MPI_Group group, MPI_Comm * newcomm) *newcomm= MPI_COMM_NULL; return MPI_SUCCESS; }else{ - group->use(); - *newcomm = new simgrid::SMPI::Comm(group, nullptr); + group->ref(); + *newcomm = new Comm(group, nullptr); return MPI_SUCCESS; } } @@ -537,7 +543,7 @@ int PMPI_Comm_free(MPI_Comm * comm) } else if (*comm == MPI_COMM_NULL) { return MPI_ERR_COMM; } else { - (*comm)->destroy(); + Comm::destroy(*comm); *comm = MPI_COMM_NULL; return MPI_SUCCESS; } @@ -551,7 +557,7 @@ int PMPI_Comm_disconnect(MPI_Comm * comm) } else if (*comm == MPI_COMM_NULL) { return MPI_ERR_COMM; } else { - (*comm)->destroy(); + Comm::destroy(*comm); *comm = MPI_COMM_NULL; return MPI_SUCCESS; } @@ -601,12 +607,12 @@ int PMPI_Send_init(void *buf, int count, MPI_Datatype datatype, int dst, int tag retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (dst == MPI_PROC_NULL) { retval = MPI_SUCCESS; } else { - *request = smpi_mpi_send_init(buf, count, datatype, dst, tag, comm); + *request = Request::send_init(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -624,12 +630,12 @@ int PMPI_Recv_init(void *buf, int count, MPI_Datatype datatype, int src, int tag retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (src == MPI_PROC_NULL) { retval = MPI_SUCCESS; } else { - *request = smpi_mpi_recv_init(buf, count, datatype, src, tag, comm); + *request = Request::recv_init(buf, count, datatype, src, tag, comm); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -647,12 +653,12 @@ int PMPI_Ssend_init(void* buf, int count, MPI_Datatype datatype, int dst, int ta retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (dst == MPI_PROC_NULL) { retval = MPI_SUCCESS; } else { - *request = smpi_mpi_ssend_init(buf, count, datatype, dst, tag, comm); + *request = Request::ssend_init(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -669,7 +675,7 @@ int PMPI_Start(MPI_Request * request) if (request == nullptr || *request == MPI_REQUEST_NULL) { retval = MPI_ERR_REQUEST; } else { - smpi_mpi_start(*request); + (*request)->start(); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -690,7 +696,7 @@ int PMPI_Startall(int count, MPI_Request * requests) } } if(retval != MPI_ERR_REQUEST) { - smpi_mpi_startall(count, requests); + Request::startall(count, requests); } } smpi_bench_begin(); @@ -705,7 +711,7 @@ int PMPI_Request_free(MPI_Request * request) if (*request == MPI_REQUEST_NULL) { retval = MPI_ERR_ARG; } else { - smpi_mpi_request_free(request); + Request::unref(request); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -729,7 +735,7 @@ int PMPI_Irecv(void *buf, int count, MPI_Datatype datatype, int src, int tag, MP retval = MPI_ERR_RANK; } else if ((count < 0) || (buf==nullptr && count > 0)) { retval = MPI_ERR_COUNT; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if(tag<0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; @@ -746,15 +752,14 @@ int PMPI_Irecv(void *buf, int count, MPI_Datatype datatype, int src, int tag, MP extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if(known==0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count*dt_size_send; TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, extra); - *request = smpi_mpi_irecv(buf, count, datatype, src, tag, comm); + *request = Request::irecv(buf, count, datatype, src, tag, comm); retval = MPI_SUCCESS; TRACE_smpi_ptp_out(rank, src_traced, rank, __FUNCTION__); - (*request)->recv = 1; } smpi_bench_begin(); @@ -780,7 +785,7 @@ int PMPI_Isend(void *buf, int count, MPI_Datatype datatype, int dst, int tag, MP retval = MPI_ERR_RANK; } else if ((count < 0) || (buf==nullptr && count > 0)) { retval = MPI_ERR_COUNT; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if(tag<0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; @@ -795,16 +800,15 @@ int PMPI_Isend(void *buf, int count, MPI_Datatype datatype, int dst, int tag, MP extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if(known==0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count*dt_size_send; TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra); - TRACE_smpi_send(rank, rank, dst_traced, tag, count*smpi_datatype_size(datatype)); + TRACE_smpi_send(rank, rank, dst_traced, tag, count*datatype->size()); - *request = smpi_mpi_isend(buf, count, datatype, dst, tag, comm); + *request = Request::isend(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__); - (*request)->send = 1; } smpi_bench_begin(); @@ -829,7 +833,7 @@ int PMPI_Issend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, M retval = MPI_ERR_RANK; } else if ((count < 0)|| (buf==nullptr && count > 0)) { retval = MPI_ERR_COUNT; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if(tag<0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; @@ -844,16 +848,15 @@ int PMPI_Issend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, M extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if(known==0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count*dt_size_send; TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra); - TRACE_smpi_send(rank, rank, dst_traced, tag, count*smpi_datatype_size(datatype)); + TRACE_smpi_send(rank, rank, dst_traced, tag, count*datatype->size()); - *request = smpi_mpi_issend(buf, count, datatype, dst, tag, comm); + *request = Request::issend(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__); - (*request)->send = 1; } smpi_bench_begin(); @@ -877,7 +880,7 @@ int PMPI_Recv(void *buf, int count, MPI_Datatype datatype, int src, int tag, MPI retval = MPI_ERR_RANK; } else if ((count < 0) || (buf==nullptr && count > 0)) { retval = MPI_ERR_COUNT; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if(tag<0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; @@ -892,11 +895,11 @@ int PMPI_Recv(void *buf, int count, MPI_Datatype datatype, int src, int tag, MPI extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count * dt_size_send; TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, extra); - smpi_mpi_recv(buf, count, datatype, src, tag, comm, status); + Request::recv(buf, count, datatype, src, tag, comm, status); retval = MPI_SUCCESS; // the src may not have been known at the beginning of the recv (MPI_ANY_SOURCE) @@ -927,7 +930,7 @@ int PMPI_Send(void *buf, int count, MPI_Datatype datatype, int dst, int tag, MPI retval = MPI_ERR_RANK; } else if ((count < 0) || (buf == nullptr && count > 0)) { retval = MPI_ERR_COUNT; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if(tag < 0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; @@ -942,15 +945,15 @@ int PMPI_Send(void *buf, int count, MPI_Datatype datatype, int dst, int tag, MPI extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) { - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); } extra->send_size = count*dt_size_send; TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra); if (!TRACE_smpi_view_internals()) { - TRACE_smpi_send(rank, rank, dst_traced, tag,count*smpi_datatype_size(datatype)); + TRACE_smpi_send(rank, rank, dst_traced, tag,count*datatype->size()); } - smpi_mpi_send(buf, count, datatype, dst, tag, comm); + Request::send(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__); @@ -973,7 +976,7 @@ int PMPI_Ssend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, MP retval = MPI_ERR_RANK; } else if ((count < 0) || (buf==nullptr && count > 0)) { retval = MPI_ERR_COUNT; - } else if (!is_datatype_valid(datatype)){ + } else if (!datatype->is_valid()){ retval = MPI_ERR_TYPE; } else if(tag<0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; @@ -988,13 +991,13 @@ int PMPI_Ssend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, MP extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if(known == 0) { - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); } extra->send_size = count*dt_size_send; TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra); - TRACE_smpi_send(rank, rank, dst_traced, tag,count*smpi_datatype_size(datatype)); + TRACE_smpi_send(rank, rank, dst_traced, tag,count*datatype->size()); - smpi_mpi_ssend(buf, count, datatype, dst, tag, comm); + Request::ssend(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__); @@ -1013,7 +1016,7 @@ int PMPI_Sendrecv(void *sendbuf, int sendcount, MPI_Datatype sendtype, int dst, if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(sendtype) || !is_datatype_valid(recvtype)) { + } else if (!sendtype->is_valid() || !recvtype->is_valid()) { retval = MPI_ERR_TYPE; } else if (src == MPI_PROC_NULL || dst == MPI_PROC_NULL) { smpi_empty_status(status); @@ -1040,18 +1043,18 @@ int PMPI_Sendrecv(void *sendbuf, int sendcount, MPI_Datatype sendtype, int dst, extra->datatype1 = encode_datatype(sendtype, &known); int dt_size_send = 1; if(known==0) - dt_size_send = smpi_datatype_size(sendtype); + dt_size_send = sendtype->size(); extra->send_size = sendcount*dt_size_send; extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; if(known==0) - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); extra->recv_size = recvcount*dt_size_recv; TRACE_smpi_ptp_in(rank, src_traced, dst_traced, __FUNCTION__, extra); - TRACE_smpi_send(rank, rank, dst_traced, sendtag,sendcount*smpi_datatype_size(sendtype)); + TRACE_smpi_send(rank, rank, dst_traced, sendtag,sendcount*sendtype->size()); - smpi_mpi_sendrecv(sendbuf, sendcount, sendtype, dst, sendtag, recvbuf, recvcount, recvtype, src, recvtag, comm, + Request::sendrecv(sendbuf, sendcount, sendtype, dst, sendtag, recvbuf, recvcount, recvtype, src, recvtag, comm, status); retval = MPI_SUCCESS; @@ -1067,16 +1070,16 @@ int PMPI_Sendrecv_replace(void* buf, int count, MPI_Datatype datatype, int dst, MPI_Comm comm, MPI_Status* status) { int retval = 0; - if (!is_datatype_valid(datatype)) { + if (!datatype->is_valid()) { return MPI_ERR_TYPE; } else if (count < 0) { return MPI_ERR_COUNT; } else { - int size = smpi_datatype_get_extent(datatype) * count; + int size = datatype->get_extent() * count; void* recvbuf = xbt_new0(char, size); retval = MPI_Sendrecv(buf, count, datatype, dst, sendtag, recvbuf, count, datatype, src, recvtag, comm, status); if(retval==MPI_SUCCESS){ - smpi_datatype_copy(recvbuf, count, datatype, buf, count, datatype); + Datatype::copy(recvbuf, count, datatype, buf, count, datatype); } xbt_free(recvbuf); @@ -1095,13 +1098,13 @@ int PMPI_Test(MPI_Request * request, int *flag, MPI_Status * status) smpi_empty_status(status); retval = MPI_SUCCESS; } else { - int rank = ((*request)->comm != MPI_COMM_NULL) ? smpi_process_index() : -1; + int rank = ((*request)->comm() != MPI_COMM_NULL) ? smpi_process_index() : -1; instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); extra->type = TRACING_TEST; TRACE_smpi_testing_in(rank, extra); - *flag = smpi_mpi_test(request, status); + *flag = Request::test(request,status); TRACE_smpi_testing_out(rank); retval = MPI_SUCCESS; @@ -1118,7 +1121,7 @@ int PMPI_Testany(int count, MPI_Request requests[], int *index, int *flag, MPI_S if (index == nullptr || flag == nullptr) { retval = MPI_ERR_ARG; } else { - *flag = smpi_mpi_testany(count, requests, index, status); + *flag = Request::testany(count, requests, index, status); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -1133,7 +1136,7 @@ int PMPI_Testall(int count, MPI_Request* requests, int* flag, MPI_Status* status if (flag == nullptr) { retval = MPI_ERR_ARG; } else { - *flag = smpi_mpi_testall(count, requests, statuses); + *flag = Request::testall(count, requests, statuses); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -1153,7 +1156,7 @@ int PMPI_Probe(int source, int tag, MPI_Comm comm, MPI_Status* status) { status->MPI_SOURCE = MPI_PROC_NULL; retval = MPI_SUCCESS; } else { - smpi_mpi_probe(source, tag, comm, status); + Request::probe(source, tag, comm, status); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -1174,7 +1177,7 @@ int PMPI_Iprobe(int source, int tag, MPI_Comm comm, int* flag, MPI_Status* statu status->MPI_SOURCE = MPI_PROC_NULL; retval = MPI_SUCCESS; } else { - smpi_mpi_iprobe(source, tag, comm, flag, status); + Request::iprobe(source, tag, comm, flag, status); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -1195,18 +1198,18 @@ int PMPI_Wait(MPI_Request * request, MPI_Status * status) retval = MPI_SUCCESS; } else { - int rank = (request!=nullptr && (*request)->comm != MPI_COMM_NULL) ? smpi_process_index() : -1; + int rank = (request!=nullptr && (*request)->comm() != MPI_COMM_NULL) ? smpi_process_index() : -1; - int src_traced = (*request)->src; - int dst_traced = (*request)->dst; - int tag_traced= (*request)->tag; - MPI_Comm comm = (*request)->comm; - int is_wait_for_receive = (*request)->recv; + int src_traced = (*request)->src(); + int dst_traced = (*request)->dst(); + int tag_traced= (*request)->tag(); + MPI_Comm comm = (*request)->comm(); + int is_wait_for_receive = ((*request)->flags() & RECV); instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); extra->type = TRACING_WAIT; TRACE_smpi_ptp_in(rank, src_traced, dst_traced, __FUNCTION__, extra); - smpi_mpi_wait(request, status); + Request::wait(request, status); retval = MPI_SUCCESS; //the src may not have been known at the beginning of the recv (MPI_ANY_SOURCE) @@ -1245,7 +1248,7 @@ int PMPI_Waitany(int count, MPI_Request requests[], int *index, MPI_Status * sta for (int i = 0; i < count; i++) { MPI_Request req = requests[i]; //already received requests are no longer valid if (req) { - savedvals[i]=(savedvalstype){req->src, req->dst, req->recv, req->tag, req->comm}; + savedvals[i]=(savedvalstype){req->src(), req->dst(), (req->flags() & RECV), req->tag(), req->comm()}; } } int rank_traced = smpi_process_index(); @@ -1254,7 +1257,7 @@ int PMPI_Waitany(int count, MPI_Request requests[], int *index, MPI_Status * sta extra->send_size=count; TRACE_smpi_ptp_in(rank_traced, -1, -1, __FUNCTION__,extra); - *index = smpi_mpi_waitany(count, requests, status); + *index = Request::waitany(count, requests, status); if(*index!=MPI_UNDEFINED){ int src_traced = savedvals[*index].src; @@ -1293,7 +1296,7 @@ int PMPI_Waitall(int count, MPI_Request requests[], MPI_Status status[]) for (int i = 0; i < count; i++) { MPI_Request req = requests[i]; if(req!=MPI_REQUEST_NULL){ - savedvals[i]=(savedvalstype){req->src, req->dst, req->recv, req->tag, 1, req->comm}; + savedvals[i]=(savedvalstype){req->src(), req->dst(), (req->flags() & RECV), req->tag(), 1, req->comm()}; }else{ savedvals[i].valid=0; } @@ -1304,7 +1307,7 @@ int PMPI_Waitall(int count, MPI_Request requests[], MPI_Status status[]) extra->send_size=count; TRACE_smpi_ptp_in(rank_traced, -1, -1, __FUNCTION__,extra); - int retval = smpi_mpi_waitall(count, requests, status); + int retval =Request::waitall(count, requests, status); for (int i = 0; i < count; i++) { if(savedvals[i].valid){ @@ -1335,7 +1338,7 @@ int PMPI_Waitsome(int incount, MPI_Request requests[], int *outcount, int *indic if (outcount == nullptr) { retval = MPI_ERR_ARG; } else { - *outcount = smpi_mpi_waitsome(incount, requests, indices, status); + *outcount = Request::waitsome(incount, requests, indices, status); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -1350,7 +1353,7 @@ int PMPI_Testsome(int incount, MPI_Request requests[], int* outcount, int* indic if (outcount == nullptr) { retval = MPI_ERR_ARG; } else { - *outcount = smpi_mpi_testsome(incount, requests, indices, status); + *outcount = Request::testsome(incount, requests, indices, status); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -1366,7 +1369,7 @@ int PMPI_Bcast(void *buf, int count, MPI_Datatype datatype, int root, MPI_Comm c if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_ARG; } else { int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; @@ -1379,7 +1382,7 @@ int PMPI_Bcast(void *buf, int count, MPI_Datatype datatype, int root, MPI_Comm c extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count * dt_size_send; TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); if (comm->size() > 1) @@ -1448,12 +1451,12 @@ int PMPI_Gather(void *sendbuf, int sendcount, MPI_Datatype sendtype,void *recvbu extra->datatype1 = encode_datatype(sendtmptype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(sendtmptype); + dt_size_send = sendtmptype->size(); extra->send_size = sendtmpcount * dt_size_send; extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; if ((comm->rank() == root) && known == 0) - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); extra->recv_size = recvcount * dt_size_recv; TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); @@ -1505,12 +1508,12 @@ int PMPI_Gatherv(void *sendbuf, int sendcount, MPI_Datatype sendtype, void *recv extra->datatype1 = encode_datatype(sendtmptype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(sendtype); + dt_size_send = sendtype->size(); extra->send_size = sendtmpcount * dt_size_send; extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; if (known == 0) - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); if ((comm->rank() == root)) { extra->recvcounts = xbt_new(int, size); for (i = 0; i < size; i++) // copy data to avoid bad free @@ -1544,7 +1547,7 @@ int PMPI_Allgather(void *sendbuf, int sendcount, MPI_Datatype sendtype, retval = MPI_ERR_COUNT; } else { if(sendbuf == MPI_IN_PLACE) { - sendbuf=static_cast(recvbuf)+smpi_datatype_get_extent(recvtype)*recvcount*comm->rank(); + sendbuf=static_cast(recvbuf)+recvtype->get_extent()*recvcount*comm->rank(); sendcount=recvcount; sendtype=recvtype; } @@ -1555,12 +1558,12 @@ int PMPI_Allgather(void *sendbuf, int sendcount, MPI_Datatype sendtype, extra->datatype1 = encode_datatype(sendtype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(sendtype); + dt_size_send = sendtype->size(); extra->send_size = sendcount * dt_size_send; extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; if (known == 0) - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); extra->recv_size = recvcount * dt_size_recv; TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); @@ -1591,7 +1594,7 @@ int PMPI_Allgatherv(void *sendbuf, int sendcount, MPI_Datatype sendtype, } else { if(sendbuf == MPI_IN_PLACE) { - sendbuf=static_cast(recvbuf)+smpi_datatype_get_extent(recvtype)*displs[comm->rank()]; + sendbuf=static_cast(recvbuf)+recvtype->get_extent()*displs[comm->rank()]; sendcount=recvcounts[comm->rank()]; sendtype=recvtype; } @@ -1605,12 +1608,12 @@ int PMPI_Allgatherv(void *sendbuf, int sendcount, MPI_Datatype sendtype, extra->datatype1 = encode_datatype(sendtype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(sendtype); + dt_size_send = sendtype->size(); extra->send_size = sendcount * dt_size_send; extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; if (known == 0) - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); extra->recvcounts = xbt_new(int, size); for (i = 0; i < size; i++) // copy data to avoid bad free extra->recvcounts[i] = recvcounts[i] * dt_size_recv; @@ -1635,8 +1638,8 @@ int PMPI_Scatter(void *sendbuf, int sendcount, MPI_Datatype sendtype, if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (((comm->rank() == root) && (!is_datatype_valid(sendtype))) || - ((recvbuf != MPI_IN_PLACE) && (!is_datatype_valid(recvtype)))) { + } else if (((comm->rank() == root) && (!sendtype->is_valid())) || + ((recvbuf != MPI_IN_PLACE) && (!recvtype->is_valid()))) { retval = MPI_ERR_TYPE; } else if ((sendbuf == recvbuf) || ((comm->rank()==root) && sendcount>0 && (sendbuf == nullptr))){ @@ -1656,12 +1659,12 @@ int PMPI_Scatter(void *sendbuf, int sendcount, MPI_Datatype sendtype, extra->datatype1 = encode_datatype(sendtype, &known); int dt_size_send = 1; if ((comm->rank() == root) && known == 0) - dt_size_send = smpi_datatype_size(sendtype); + dt_size_send = sendtype->size(); extra->send_size = sendcount * dt_size_send; extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; if (known == 0) - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); extra->recv_size = recvcount * dt_size_recv; TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); @@ -1705,7 +1708,7 @@ int PMPI_Scatterv(void *sendbuf, int *sendcounts, int *displs, extra->datatype1 = encode_datatype(sendtype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(sendtype); + dt_size_send = sendtype->size(); if ((comm->rank() == root)) { extra->sendcounts = xbt_new(int, size); for (i = 0; i < size; i++) // copy data to avoid bad free @@ -1714,7 +1717,7 @@ int PMPI_Scatterv(void *sendbuf, int *sendcounts, int *displs, extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; if (known == 0) - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); extra->recv_size = recvcount * dt_size_recv; TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); @@ -1736,7 +1739,7 @@ int PMPI_Reduce(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype) || op == MPI_OP_NULL) { + } else if (!datatype->is_valid() || op == MPI_OP_NULL) { retval = MPI_ERR_ARG; } else { int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; @@ -1747,7 +1750,7 @@ int PMPI_Reduce(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count * dt_size_send; extra->root = root_traced; @@ -1767,10 +1770,10 @@ int PMPI_Reduce_local(void *inbuf, void *inoutbuf, int count, MPI_Datatype datat int retval = 0; smpi_bench_end(); - if (!is_datatype_valid(datatype) || op == MPI_OP_NULL) { + if (!datatype->is_valid() || op == MPI_OP_NULL) { retval = MPI_ERR_ARG; } else { - smpi_op_apply(op, inbuf, inoutbuf, &count, &datatype); + op->apply(inbuf, inoutbuf, &count, datatype); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -1785,7 +1788,7 @@ int PMPI_Allreduce(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatyp if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; @@ -1793,8 +1796,8 @@ int PMPI_Allreduce(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatyp char* sendtmpbuf = static_cast(sendbuf); if( sendbuf == MPI_IN_PLACE ) { - sendtmpbuf = static_cast(xbt_malloc(count*smpi_datatype_get_extent(datatype))); - smpi_datatype_copy(recvbuf, count, datatype,sendtmpbuf, count, datatype); + sendtmpbuf = static_cast(xbt_malloc(count*datatype->get_extent())); + Datatype::copy(recvbuf, count, datatype,sendtmpbuf, count, datatype); } int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); @@ -1803,7 +1806,7 @@ int PMPI_Allreduce(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatyp extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count * dt_size_send; TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); @@ -1829,7 +1832,7 @@ int PMPI_Scan(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, MP if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; @@ -1841,7 +1844,7 @@ int PMPI_Scan(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, MP extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count * dt_size_send; TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); @@ -1863,7 +1866,7 @@ int PMPI_Exscan(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; @@ -1875,12 +1878,12 @@ int PMPI_Exscan(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count * dt_size_send; void* sendtmpbuf = sendbuf; if (sendbuf == MPI_IN_PLACE) { - sendtmpbuf = static_cast(xbt_malloc(count * smpi_datatype_size(datatype))); - memcpy(sendtmpbuf, recvbuf, count * smpi_datatype_size(datatype)); + sendtmpbuf = static_cast(xbt_malloc(count * datatype->size())); + memcpy(sendtmpbuf, recvbuf, count * datatype->size()); } TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); @@ -1902,7 +1905,7 @@ int PMPI_Reduce_scatter(void *sendbuf, void *recvbuf, int *recvcounts, MPI_Datat if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; @@ -1919,7 +1922,7 @@ int PMPI_Reduce_scatter(void *sendbuf, void *recvbuf, int *recvcounts, MPI_Datat extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = 0; extra->recvcounts = xbt_new(int, size); int totalcount = 0; @@ -1929,8 +1932,8 @@ int PMPI_Reduce_scatter(void *sendbuf, void *recvbuf, int *recvcounts, MPI_Datat } void* sendtmpbuf = sendbuf; if (sendbuf == MPI_IN_PLACE) { - sendtmpbuf = static_cast(xbt_malloc(totalcount * smpi_datatype_size(datatype))); - memcpy(sendtmpbuf, recvbuf, totalcount * smpi_datatype_size(datatype)); + sendtmpbuf = static_cast(xbt_malloc(totalcount * datatype->size())); + memcpy(sendtmpbuf, recvbuf, totalcount * datatype->size()); } TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); @@ -1955,7 +1958,7 @@ int PMPI_Reduce_scatter_block(void *sendbuf, void *recvbuf, int recvcount, if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; @@ -1972,15 +1975,15 @@ int PMPI_Reduce_scatter_block(void *sendbuf, void *recvbuf, int recvcount, extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = 0; extra->recvcounts = xbt_new(int, count); for (int i = 0; i < count; i++) // copy data to avoid bad free extra->recvcounts[i] = recvcount * dt_size_send; void* sendtmpbuf = sendbuf; if (sendbuf == MPI_IN_PLACE) { - sendtmpbuf = static_cast(xbt_malloc(recvcount * count * smpi_datatype_size(datatype))); - memcpy(sendtmpbuf, recvbuf, recvcount * count * smpi_datatype_size(datatype)); + sendtmpbuf = static_cast(xbt_malloc(recvcount * count * datatype->size())); + memcpy(sendtmpbuf, recvbuf, recvcount * count * datatype->size()); } TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); @@ -2021,8 +2024,8 @@ int PMPI_Alltoall(void* sendbuf, int sendcount, MPI_Datatype sendtype, void* rec int sendtmpcount = sendcount; MPI_Datatype sendtmptype = sendtype; if (sendbuf == MPI_IN_PLACE) { - sendtmpbuf = static_cast(xbt_malloc(recvcount * comm->size() * smpi_datatype_size(recvtype))); - memcpy(sendtmpbuf, recvbuf, recvcount * comm->size() * smpi_datatype_size(recvtype)); + sendtmpbuf = static_cast(xbt_malloc(recvcount * comm->size() * recvtype->size())); + memcpy(sendtmpbuf, recvbuf, recvcount * comm->size() * recvtype->size()); sendtmpcount = recvcount; sendtmptype = recvtype; } @@ -2030,12 +2033,12 @@ int PMPI_Alltoall(void* sendbuf, int sendcount, MPI_Datatype sendtype, void* rec int known = 0; extra->datatype1 = encode_datatype(sendtmptype, &known); if (known == 0) - extra->send_size = sendtmpcount * smpi_datatype_size(sendtmptype); + extra->send_size = sendtmpcount * sendtmptype->size(); else extra->send_size = sendtmpcount; extra->datatype2 = encode_datatype(recvtype, &known); if (known == 0) - extra->recv_size = recvcount * smpi_datatype_size(recvtype); + extra->recv_size = recvcount * recvtype->size(); else extra->recv_size = recvcount; @@ -2080,7 +2083,7 @@ int PMPI_Alltoallv(void* sendbuf, int* sendcounts, int* senddisps, MPI_Datatype int known = 0; int dt_size_recv = 1; extra->datatype2 = encode_datatype(recvtype, &known); - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); void* sendtmpbuf = static_cast(sendbuf); int* sendtmpcounts = sendcounts; @@ -2106,7 +2109,7 @@ int PMPI_Alltoallv(void* sendbuf, int* sendcounts, int* senddisps, MPI_Datatype extra->datatype1 = encode_datatype(sendtmptype, &known); int dt_size_send = 1; - dt_size_send = smpi_datatype_size(sendtmptype); + dt_size_send = sendtmptype->size(); for (i = 0; i < size; i++) { // copy data to avoid bad free extra->send_size += sendtmpcounts[i] * dt_size_send; @@ -2144,10 +2147,10 @@ int PMPI_Get_count(MPI_Status * status, MPI_Datatype datatype, int *count) { if (status == nullptr || count == nullptr) { return MPI_ERR_ARG; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { return MPI_ERR_TYPE; } else { - size_t size = smpi_datatype_size(datatype); + size_t size = datatype->size(); if (size == 0) { *count = 0; return MPI_SUCCESS; @@ -2166,7 +2169,7 @@ int PMPI_Type_contiguous(int count, MPI_Datatype old_type, MPI_Datatype* new_typ } else if (count<0){ return MPI_ERR_COUNT; } else { - return smpi_datatype_contiguous(count, old_type, new_type, 0); + return Datatype::create_contiguous(count, old_type, 0, new_type); } } @@ -2174,7 +2177,7 @@ int PMPI_Type_commit(MPI_Datatype* datatype) { if (datatype == nullptr || *datatype == MPI_DATATYPE_NULL) { return MPI_ERR_TYPE; } else { - smpi_datatype_commit(datatype); + (*datatype)->commit(); return MPI_SUCCESS; } } @@ -2185,7 +2188,7 @@ int PMPI_Type_vector(int count, int blocklen, int stride, MPI_Datatype old_type, } else if (count<0 || blocklen<0){ return MPI_ERR_COUNT; } else { - return smpi_datatype_vector(count, blocklen, stride, old_type, new_type); + return Datatype::create_vector(count, blocklen, stride, old_type, new_type); } } @@ -2195,7 +2198,7 @@ int PMPI_Type_hvector(int count, int blocklen, MPI_Aint stride, MPI_Datatype old } else if (count<0 || blocklen<0){ return MPI_ERR_COUNT; } else { - return smpi_datatype_hvector(count, blocklen, stride, old_type, new_type); + return Datatype::create_hvector(count, blocklen, stride, old_type, new_type); } } @@ -2209,7 +2212,7 @@ int PMPI_Type_indexed(int count, int* blocklens, int* indices, MPI_Datatype old_ } else if (count<0){ return MPI_ERR_COUNT; } else { - return smpi_datatype_indexed(count, blocklens, indices, old_type, new_type); + return Datatype::create_indexed(count, blocklens, indices, old_type, new_type); } } @@ -2219,7 +2222,7 @@ int PMPI_Type_create_indexed(int count, int* blocklens, int* indices, MPI_Dataty } else if (count<0){ return MPI_ERR_COUNT; } else { - return smpi_datatype_indexed(count, blocklens, indices, old_type, new_type); + return Datatype::create_indexed(count, blocklens, indices, old_type, new_type); } } @@ -2234,7 +2237,7 @@ int PMPI_Type_create_indexed_block(int count, int blocklength, int* indices, MPI int* blocklens=static_cast(xbt_malloc(blocklength*count*sizeof(int))); for (int i = 0; i < count; i++) blocklens[i]=blocklength; - int retval = smpi_datatype_indexed(count, blocklens, indices, old_type, new_type); + int retval = Datatype::create_indexed(count, blocklens, indices, old_type, new_type); xbt_free(blocklens); return retval; } @@ -2247,7 +2250,7 @@ int PMPI_Type_hindexed(int count, int* blocklens, MPI_Aint* indices, MPI_Datatyp } else if (count<0){ return MPI_ERR_COUNT; } else { - return smpi_datatype_hindexed(count, blocklens, indices, old_type, new_type); + return Datatype::create_hindexed(count, blocklens, indices, old_type, new_type); } } @@ -2266,7 +2269,7 @@ int PMPI_Type_create_hindexed_block(int count, int blocklength, MPI_Aint* indice int* blocklens=(int*)xbt_malloc(blocklength*count*sizeof(int)); for (int i = 0; i < count; i++) blocklens[i] = blocklength; - int retval = smpi_datatype_hindexed(count, blocklens, indices, old_type, new_type); + int retval = Datatype::create_hindexed(count, blocklens, indices, old_type, new_type); xbt_free(blocklens); return retval; } @@ -2276,7 +2279,7 @@ int PMPI_Type_struct(int count, int* blocklens, MPI_Aint* indices, MPI_Datatype* if (count<0){ return MPI_ERR_COUNT; } else { - return smpi_datatype_struct(count, blocklens, indices, old_types, new_type); + return Datatype::create_struct(count, blocklens, indices, old_types, new_type); } } @@ -2306,7 +2309,8 @@ int PMPI_Cart_create(MPI_Comm comm_old, int ndims, int* dims, int* periodic, int } else if (ndims < 0 || (ndims > 0 && (dims == nullptr || periodic == nullptr)) || comm_cart == nullptr) { return MPI_ERR_ARG; } else{ - return smpi_mpi_cart_create(comm_old, ndims, dims, periodic, reorder, comm_cart); + new Topo_Cart(comm_old, ndims, dims, periodic, reorder, comm_cart); + return MPI_SUCCESS; } } @@ -2317,7 +2321,11 @@ int PMPI_Cart_rank(MPI_Comm comm, int* coords, int* rank) { if (coords == nullptr) { return MPI_ERR_ARG; } - return smpi_mpi_cart_rank(comm, coords, rank); + MPIR_Cart_Topology topo = static_cast(comm->topo()); + if (topo==nullptr) { + return MPI_ERR_ARG; + } + return topo->rank(coords, rank); } int PMPI_Cart_shift(MPI_Comm comm, int direction, int displ, int* source, int* dest) { @@ -2327,7 +2335,11 @@ int PMPI_Cart_shift(MPI_Comm comm, int direction, int displ, int* source, int* d if (source == nullptr || dest == nullptr || direction < 0 ) { return MPI_ERR_ARG; } - return smpi_mpi_cart_shift(comm, direction, displ, source, dest); + MPIR_Cart_Topology topo = static_cast(comm->topo()); + if (topo==nullptr) { + return MPI_ERR_ARG; + } + return topo->shift(direction, displ, source, dest); } int PMPI_Cart_coords(MPI_Comm comm, int rank, int maxdims, int* coords) { @@ -2343,7 +2355,11 @@ int PMPI_Cart_coords(MPI_Comm comm, int rank, int maxdims, int* coords) { if(coords == nullptr) { return MPI_ERR_ARG; } - return smpi_mpi_cart_coords(comm, rank, maxdims, coords); + MPIR_Cart_Topology topo = static_cast(comm->topo()); + if (topo==nullptr) { + return MPI_ERR_ARG; + } + return topo->coords(rank, maxdims, coords); } int PMPI_Cart_get(MPI_Comm comm, int maxdims, int* dims, int* periods, int* coords) { @@ -2353,7 +2369,11 @@ int PMPI_Cart_get(MPI_Comm comm, int maxdims, int* dims, int* periods, int* coor if(maxdims <= 0 || dims == nullptr || periods == nullptr || coords == nullptr) { return MPI_ERR_ARG; } - return smpi_mpi_cart_get(comm, maxdims, dims, periods, coords); + MPIR_Cart_Topology topo = static_cast(comm->topo()); + if (topo==nullptr) { + return MPI_ERR_ARG; + } + return topo->get(maxdims, dims, periods, coords); } int PMPI_Cartdim_get(MPI_Comm comm, int* ndims) { @@ -2363,7 +2383,11 @@ int PMPI_Cartdim_get(MPI_Comm comm, int* ndims) { if (ndims == nullptr) { return MPI_ERR_ARG; } - return smpi_mpi_cartdim_get(comm, ndims); + MPIR_Cart_Topology topo = static_cast(comm->topo()); + if (topo==nullptr) { + return MPI_ERR_ARG; + } + return topo->dim_get(ndims); } int PMPI_Dims_create(int nnodes, int ndims, int* dims) { @@ -2373,8 +2397,7 @@ int PMPI_Dims_create(int nnodes, int ndims, int* dims) { if (ndims < 1 || nnodes < 1) { return MPI_ERR_DIMS; } - - return smpi_mpi_dims_create(nnodes, ndims, dims); + return Dims_create(nnodes, ndims, dims); } int PMPI_Cart_sub(MPI_Comm comm, int* remain_dims, MPI_Comm* comm_new) { @@ -2384,7 +2407,14 @@ int PMPI_Cart_sub(MPI_Comm comm, int* remain_dims, MPI_Comm* comm_new) { if (comm_new == nullptr) { return MPI_ERR_ARG; } - return smpi_mpi_cart_sub(comm, remain_dims, comm_new); + MPIR_Cart_Topology topo = static_cast(comm->topo()); + if (topo==nullptr) { + return MPI_ERR_ARG; + } + MPIR_Cart_Topology cart = topo->sub(remain_dims, comm_new); + if(cart==nullptr) + return MPI_ERR_ARG; + return MPI_SUCCESS; } int PMPI_Type_create_resized(MPI_Datatype oldtype,MPI_Aint lb, MPI_Aint extent, MPI_Datatype *newtype){ @@ -2395,10 +2425,9 @@ int PMPI_Type_create_resized(MPI_Datatype oldtype,MPI_Aint lb, MPI_Aint extent, MPI_Aint disps[3] = {lb, 0, lb + extent}; MPI_Datatype types[3] = {MPI_LB, oldtype, MPI_UB}; - s_smpi_mpi_struct_t* subtype = smpi_datatype_struct_create(blocks, disps, 3, types); - smpi_datatype_create(newtype, oldtype->size, lb, lb + extent, sizeof(s_smpi_mpi_struct_t), subtype, DT_FLAG_VECTOR); + *newtype = new Type_Struct(oldtype->size(), lb, lb + extent, DT_FLAG_DERIVED, 3, blocks, disps, types); - (*newtype)->flags &= ~DT_FLAG_COMMITED; + (*newtype)->addflag(~DT_FLAG_COMMITED); return MPI_SUCCESS; } @@ -2410,7 +2439,7 @@ int PMPI_Win_create( void *base, MPI_Aint size, int disp_unit, MPI_Info info, MP }else if ((base == nullptr && size != 0) || disp_unit <= 0 || size < 0 ){ retval= MPI_ERR_OTHER; }else{ - *win = smpi_mpi_win_create( base, size, disp_unit, info, comm); + *win = new Win( base, size, disp_unit, info, comm); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -2423,7 +2452,8 @@ int PMPI_Win_free( MPI_Win* win){ if (win == nullptr || *win == MPI_WIN_NULL) { retval = MPI_ERR_WIN; }else{ - retval=smpi_mpi_win_free(win); + delete *win; + retval=MPI_SUCCESS; } smpi_bench_begin(); return retval; @@ -2436,7 +2466,7 @@ int PMPI_Win_set_name(MPI_Win win, char * name) } else if (name == nullptr) { return MPI_ERR_ARG; } else { - smpi_mpi_win_set_name(win, name); + win->set_name(name); return MPI_SUCCESS; } } @@ -2448,7 +2478,7 @@ int PMPI_Win_get_name(MPI_Win win, char * name, int* len) } else if (name == nullptr) { return MPI_ERR_ARG; } else { - smpi_mpi_win_get_name(win, name, len); + win->get_name(name, len); return MPI_SUCCESS; } } @@ -2457,8 +2487,8 @@ int PMPI_Win_get_group(MPI_Win win, MPI_Group * group){ if (win == MPI_WIN_NULL) { return MPI_ERR_WIN; }else { - smpi_mpi_win_get_group(win, group); - (*group)->use(); + win->get_group(group); + (*group)->ref(); return MPI_SUCCESS; } } @@ -2471,7 +2501,7 @@ int PMPI_Win_fence( int assert, MPI_Win win){ } else { int rank = smpi_process_index(); TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); - retval = smpi_mpi_win_fence(assert, win); + retval = win->fence(assert); TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } smpi_bench_begin(); @@ -2493,17 +2523,17 @@ int PMPI_Get( void *origin_addr, int origin_count, MPI_Datatype origin_datatype, } else if ((origin_count < 0 || target_count < 0) || (origin_addr==nullptr && origin_count > 0)){ retval = MPI_ERR_COUNT; - } else if ((!is_datatype_valid(origin_datatype)) || (!is_datatype_valid(target_datatype))) { + } else if ((!origin_datatype->is_valid()) || (!target_datatype->is_valid())) { retval = MPI_ERR_TYPE; } else { int rank = smpi_process_index(); MPI_Group group; - smpi_mpi_win_get_group(win, &group); + win->get_group(&group); int src_traced = group->index(target_rank); TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, nullptr); - retval = smpi_mpi_get( origin_addr, origin_count, origin_datatype, target_rank, target_disp, target_count, - target_datatype, win); + retval = win->get( origin_addr, origin_count, origin_datatype, target_rank, target_disp, target_count, + target_datatype); TRACE_smpi_ptp_out(rank, src_traced, rank, __FUNCTION__); } @@ -2526,18 +2556,18 @@ int PMPI_Put( void *origin_addr, int origin_count, MPI_Datatype origin_datatype, } else if ((origin_count < 0 || target_count < 0) || (origin_addr==nullptr && origin_count > 0)){ retval = MPI_ERR_COUNT; - } else if ((!is_datatype_valid(origin_datatype)) || (!is_datatype_valid(target_datatype))) { + } else if ((!origin_datatype->is_valid()) || (!target_datatype->is_valid())) { retval = MPI_ERR_TYPE; } else { int rank = smpi_process_index(); MPI_Group group; - smpi_mpi_win_get_group(win, &group); + win->get_group(&group); int dst_traced = group->index(target_rank); TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, nullptr); - TRACE_smpi_send(rank, rank, dst_traced, SMPI_RMA_TAG, origin_count*smpi_datatype_size(origin_datatype)); + TRACE_smpi_send(rank, rank, dst_traced, SMPI_RMA_TAG, origin_count*origin_datatype->size()); - retval = smpi_mpi_put( origin_addr, origin_count, origin_datatype, target_rank, target_disp, target_count, - target_datatype, win); + retval = win->put( origin_addr, origin_count, origin_datatype, target_rank, target_disp, target_count, + target_datatype); TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__); } @@ -2560,20 +2590,20 @@ int PMPI_Accumulate( void *origin_addr, int origin_count, MPI_Datatype origin_da } else if ((origin_count < 0 || target_count < 0) || (origin_addr==nullptr && origin_count > 0)){ retval = MPI_ERR_COUNT; - } else if ((!is_datatype_valid(origin_datatype)) || - (!is_datatype_valid(target_datatype))) { + } else if ((!origin_datatype->is_valid()) || + (!target_datatype->is_valid())) { retval = MPI_ERR_TYPE; } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; } else { int rank = smpi_process_index(); MPI_Group group; - smpi_mpi_win_get_group(win, &group); + win->get_group(&group); int src_traced = group->index(target_rank); TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, nullptr); - retval = smpi_mpi_accumulate( origin_addr, origin_count, origin_datatype, target_rank, target_disp, target_count, - target_datatype, op, win); + retval = win->accumulate( origin_addr, origin_count, origin_datatype, target_rank, target_disp, target_count, + target_datatype, op); TRACE_smpi_ptp_out(rank, src_traced, rank, __FUNCTION__); } @@ -2591,7 +2621,7 @@ int PMPI_Win_post(MPI_Group group, int assert, MPI_Win win){ } else { int rank = smpi_process_index(); TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); - retval = smpi_mpi_win_post(group,assert,win); + retval = win->post(group,assert); TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } smpi_bench_begin(); @@ -2608,7 +2638,7 @@ int PMPI_Win_start(MPI_Group group, int assert, MPI_Win win){ } else { int rank = smpi_process_index(); TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); - retval = smpi_mpi_win_start(group,assert,win); + retval = win->start(group,assert); TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } smpi_bench_begin(); @@ -2624,7 +2654,7 @@ int PMPI_Win_complete(MPI_Win win){ int rank = smpi_process_index(); TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); - retval = smpi_mpi_win_complete(win); + retval = win->complete(); TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } @@ -2641,7 +2671,7 @@ int PMPI_Win_wait(MPI_Win win){ int rank = smpi_process_index(); TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); - retval = smpi_mpi_win_wait(win); + retval = win->wait(); TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } @@ -2671,7 +2701,7 @@ int PMPI_Type_set_name(MPI_Datatype datatype, char * name) } else if (name == nullptr) { return MPI_ERR_ARG; } else { - smpi_datatype_set_name(datatype, name); + datatype->set_name(name); return MPI_SUCCESS; } } @@ -2683,65 +2713,65 @@ int PMPI_Type_get_name(MPI_Datatype datatype, char * name, int* len) } else if (name == nullptr) { return MPI_ERR_ARG; } else { - smpi_datatype_get_name(datatype, name, len); + datatype->get_name(name, len); return MPI_SUCCESS; } } MPI_Datatype PMPI_Type_f2c(MPI_Fint datatype){ - return smpi_type_f2c(datatype); + return static_cast(F2C::f2c(datatype)); } MPI_Fint PMPI_Type_c2f(MPI_Datatype datatype){ - return smpi_type_c2f( datatype); + return datatype->c2f(); } MPI_Group PMPI_Group_f2c(MPI_Fint group){ - return smpi_group_f2c( group); + return Group::f2c(group); } MPI_Fint PMPI_Group_c2f(MPI_Group group){ - return smpi_group_c2f(group); + return group->c2f(); } MPI_Request PMPI_Request_f2c(MPI_Fint request){ - return smpi_request_f2c(request); + return static_cast(Request::f2c(request)); } MPI_Fint PMPI_Request_c2f(MPI_Request request) { - return smpi_request_c2f(request); + return request->c2f(); } MPI_Win PMPI_Win_f2c(MPI_Fint win){ - return smpi_win_f2c(win); + return static_cast(Win::f2c(win)); } MPI_Fint PMPI_Win_c2f(MPI_Win win){ - return smpi_win_c2f(win); + return win->c2f(); } MPI_Op PMPI_Op_f2c(MPI_Fint op){ - return smpi_op_f2c(op); + return static_cast(Op::f2c(op)); } MPI_Fint PMPI_Op_c2f(MPI_Op op){ - return smpi_op_c2f(op); + return op->c2f(); } MPI_Comm PMPI_Comm_f2c(MPI_Fint comm){ - return smpi_comm_f2c(comm); + return static_cast(Comm::f2c(comm)); } MPI_Fint PMPI_Comm_c2f(MPI_Comm comm){ - return smpi_comm_c2f(comm); + return comm->c2f(); } MPI_Info PMPI_Info_f2c(MPI_Fint info){ - return smpi_info_f2c(info); + return static_cast(Info::f2c(info)); } MPI_Fint PMPI_Info_c2f(MPI_Info info){ - return smpi_info_c2f(info); + return info->c2f(); } int PMPI_Keyval_create(MPI_Copy_function* copy_fn, MPI_Delete_function* delete_fn, int* keyval, void* extra_state) { @@ -2841,7 +2871,7 @@ int PMPI_Type_get_attr (MPI_Datatype type, int type_keyval, void *attribute_val, if (type==MPI_DATATYPE_NULL) return MPI_ERR_TYPE; else - return smpi_type_attr_get(type, type_keyval, attribute_val, flag); + return type->attr_get(type_keyval, attribute_val, flag); } int PMPI_Type_set_attr (MPI_Datatype type, int type_keyval, void *attribute_val) @@ -2849,7 +2879,7 @@ int PMPI_Type_set_attr (MPI_Datatype type, int type_keyval, void *attribute_val) if (type==MPI_DATATYPE_NULL) return MPI_ERR_TYPE; else - return smpi_type_attr_put(type, type_keyval, attribute_val); + return type->attr_put(type_keyval, attribute_val); } int PMPI_Type_delete_attr (MPI_Datatype type, int type_keyval) @@ -2857,44 +2887,37 @@ int PMPI_Type_delete_attr (MPI_Datatype type, int type_keyval) if (type==MPI_DATATYPE_NULL) return MPI_ERR_TYPE; else - return smpi_type_attr_delete(type, type_keyval); + return type->attr_delete(type_keyval); } int PMPI_Type_create_keyval(MPI_Type_copy_attr_function* copy_fn, MPI_Type_delete_attr_function* delete_fn, int* keyval, void* extra_state) { - return smpi_type_keyval_create(copy_fn, delete_fn, keyval, extra_state); + return Datatype::keyval_create(copy_fn, delete_fn, keyval, extra_state); } int PMPI_Type_free_keyval(int* keyval) { - return smpi_type_keyval_free(keyval); + return Datatype::keyval_free(keyval); } int PMPI_Info_create( MPI_Info *info){ if (info == nullptr) return MPI_ERR_ARG; - *info = xbt_new(s_smpi_mpi_info_t, 1); - (*info)->info_dict= xbt_dict_new_homogeneous(xbt_free_f); - (*info)->refcount=1; + *info = new Info(); return MPI_SUCCESS; } int PMPI_Info_set( MPI_Info info, char *key, char *value){ if (info == nullptr || key == nullptr || value == nullptr) return MPI_ERR_ARG; - - xbt_dict_set(info->info_dict, key, xbt_strdup(value), nullptr); + info->set(key, value); return MPI_SUCCESS; } int PMPI_Info_free( MPI_Info *info){ if (info == nullptr || *info==nullptr) return MPI_ERR_ARG; - (*info)->refcount--; - if((*info)->refcount==0){ - xbt_dict_free(&((*info)->info_dict)); - xbt_free(*info); - } + Info::unref(*info); *info=MPI_INFO_NULL; return MPI_SUCCESS; } @@ -2905,109 +2928,70 @@ int PMPI_Info_get(MPI_Info info,char *key,int valuelen, char *value, int *flag){ return MPI_ERR_ARG; if (value == nullptr) return MPI_ERR_INFO_VALUE; - char* tmpvalue=static_cast(xbt_dict_get_or_null(info->info_dict, key)); - if(tmpvalue){ - memset(value, 0, valuelen); - memcpy(value,tmpvalue, (strlen(tmpvalue) + 1 < static_cast(valuelen)) ? strlen(tmpvalue) + 1 : valuelen); - *flag=true; - } - return MPI_SUCCESS; + return info->get(key, valuelen, value, flag); } int PMPI_Info_dup(MPI_Info info, MPI_Info *newinfo){ if (info == nullptr || newinfo==nullptr) return MPI_ERR_ARG; - *newinfo = xbt_new(s_smpi_mpi_info_t, 1); - (*newinfo)->info_dict= xbt_dict_new_homogeneous(xbt_free_f); - (*newinfo)->refcount=1; - xbt_dict_cursor_t cursor = nullptr; - char* key; - void* data; - xbt_dict_foreach(info->info_dict,cursor,key,data){ - xbt_dict_set((*newinfo)->info_dict, key, xbt_strdup(static_cast(data)), nullptr); - } + *newinfo = new Info(info); return MPI_SUCCESS; } int PMPI_Info_delete(MPI_Info info, char *key){ if (info == nullptr || key==nullptr) return MPI_ERR_ARG; - try { - xbt_dict_remove(info->info_dict, key); - } - catch(xbt_ex& e){ - return MPI_ERR_INFO_NOKEY; - } - return MPI_SUCCESS; + return info->remove(key); } int PMPI_Info_get_nkeys( MPI_Info info, int *nkeys){ if (info == nullptr || nkeys==nullptr) return MPI_ERR_ARG; - *nkeys=xbt_dict_size(info->info_dict); - return MPI_SUCCESS; + return info->get_nkeys(nkeys); } int PMPI_Info_get_nthkey( MPI_Info info, int n, char *key){ if (info == nullptr || key==nullptr || n<0 || n> MPI_MAX_INFO_KEY) return MPI_ERR_ARG; - - xbt_dict_cursor_t cursor = nullptr; - char *keyn; - void* data; - int num=0; - xbt_dict_foreach(info->info_dict,cursor,keyn,data){ - if(num==n){ - strncpy(key,keyn,strlen(keyn)+1); - xbt_dict_cursor_free(&cursor); - return MPI_SUCCESS; - } - num++; - } - return MPI_ERR_ARG; + return info->get_nthkey(n, key); } int PMPI_Info_get_valuelen( MPI_Info info, char *key, int *valuelen, int *flag){ *flag=false; if (info == nullptr || key == nullptr || valuelen==nullptr) return MPI_ERR_ARG; - char* tmpvalue=(char*)xbt_dict_get_or_null(info->info_dict, key); - if(tmpvalue){ - *valuelen=strlen(tmpvalue); - *flag=true; - } - return MPI_SUCCESS; + return info->get_valuelen(key, valuelen, flag); } int PMPI_Unpack(void* inbuf, int incount, int* position, void* outbuf, int outcount, MPI_Datatype type, MPI_Comm comm) { if(incount<0 || outcount < 0 || inbuf==nullptr || outbuf==nullptr) return MPI_ERR_ARG; - if(!is_datatype_valid(type)) + if(!type->is_valid()) return MPI_ERR_TYPE; if(comm==MPI_COMM_NULL) return MPI_ERR_COMM; - return smpi_mpi_unpack(inbuf, incount, position, outbuf,outcount,type, comm); + return type->unpack(inbuf, incount, position, outbuf,outcount, comm); } int PMPI_Pack(void* inbuf, int incount, MPI_Datatype type, void* outbuf, int outcount, int* position, MPI_Comm comm) { if(incount<0 || outcount < 0|| inbuf==nullptr || outbuf==nullptr) return MPI_ERR_ARG; - if(!is_datatype_valid(type)) + if(!type->is_valid()) return MPI_ERR_TYPE; if(comm==MPI_COMM_NULL) return MPI_ERR_COMM; - return smpi_mpi_pack(inbuf, incount, type, outbuf,outcount,position, comm); + return type->pack(inbuf, incount, outbuf,outcount,position, comm); } int PMPI_Pack_size(int incount, MPI_Datatype datatype, MPI_Comm comm, int* size) { if(incount<0) return MPI_ERR_ARG; - if(!is_datatype_valid(datatype)) + if(!datatype->is_valid()) return MPI_ERR_TYPE; if(comm==MPI_COMM_NULL) return MPI_ERR_COMM; - *size=incount*smpi_datatype_size(datatype); + *size=incount*datatype->size(); return MPI_SUCCESS; }