X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/d656f9465e7b1c36319f86eeafdcec58fe9551a4..efa1f86e31adca3c57e9d0135b2f6ebdbabb0878:/src/smpi/colls/bcast/bcast-SMP-binary.cpp diff --git a/src/smpi/colls/bcast/bcast-SMP-binary.cpp b/src/smpi/colls/bcast/bcast-SMP-binary.cpp index bcec2292a4..1690c72817 100644 --- a/src/smpi/colls/bcast/bcast-SMP-binary.cpp +++ b/src/smpi/colls/bcast/bcast-SMP-binary.cpp @@ -1,4 +1,4 @@ -/* Copyright (c) 2013-2017. The SimGrid Team. +/* Copyright (c) 2013-2019. The SimGrid Team. * All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it @@ -9,15 +9,13 @@ int bcast_SMP_binary_segment_byte = 8192; namespace simgrid{ namespace smpi{ -int Coll_bcast_SMP_binary::bcast(void *buf, int count, - MPI_Datatype datatype, int root, - MPI_Comm comm) +int bcast__SMP_binary(void *buf, int count, + MPI_Datatype datatype, int root, + MPI_Comm comm) { int tag = COLL_TAG_BCAST; MPI_Status status; MPI_Request request; - MPI_Request *request_array; - MPI_Status *status_array; int rank, size; int i; MPI_Aint extent; @@ -33,8 +31,7 @@ int Coll_bcast_SMP_binary::bcast(void *buf, int count, host_num_core = comm->get_intra_comm()->size(); }else{ //implementation buggy in this case - return Coll_bcast_mpich::bcast( buf , count, datatype, - root, comm); + return bcast__mpich(buf , count, datatype, root, comm); } int segment = bcast_SMP_binary_segment_byte / extent; @@ -123,10 +120,8 @@ int Coll_bcast_SMP_binary::bcast(void *buf, int count, // pipeline bcast else { - request_array = - (MPI_Request *) xbt_malloc((size + pipe_length) * sizeof(MPI_Request)); - status_array = - (MPI_Status *) xbt_malloc((size + pipe_length) * sizeof(MPI_Status)); + MPI_Request* request_array = new MPI_Request[size + pipe_length]; + MPI_Status* status_array = new MPI_Status[size + pipe_length]; // case ROOT-of-each-SMP if (rank % host_num_core == 0) { @@ -215,15 +210,14 @@ int Coll_bcast_SMP_binary::bcast(void *buf, int count, } } - free(request_array); - free(status_array); + delete[] request_array; + delete[] status_array; } // when count is not divisible by block size, use default BCAST for the remainder if ((remainder != 0) && (count > segment)) { XBT_WARN("MPI_bcast_SMP_binary use default MPI_bcast."); - Colls::bcast((char *) buf + (pipe_length * increment), remainder, datatype, - root, comm); + colls::bcast((char*)buf + (pipe_length * increment), remainder, datatype, root, comm); } return 1;