X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/ce9cbf0e2aea0198cb08a735a3ad36c6471f5468..4d02714ee138a3bd9b02e0064b7a2aa26407e9e8:/src/bindings/java/jmsg_task.cpp diff --git a/src/bindings/java/jmsg_task.cpp b/src/bindings/java/jmsg_task.cpp index f0da73932b..1983b13579 100644 --- a/src/bindings/java/jmsg_task.cpp +++ b/src/bindings/java/jmsg_task.cpp @@ -1,21 +1,21 @@ /* Functions related to the java task instances. */ -/* Copyright (c) 2007-2017. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2007-2019. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ -#include +#include "simgrid/Exception.hpp" +#include "simgrid/s4u/Host.hpp" +#include "src/kernel/context/Context.hpp" -#include "jmsg.h" +#include "jmsg.hpp" #include "jmsg_host.h" -#include "jmsg_task.h" #include "jmsg_process.h" -#include "jxbt_utilities.h" - -XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(jmsg); +#include "jmsg_task.h" +#include "jxbt_utilities.hpp" -SG_BEGIN_DECL() +XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(java); static jmethodID jtask_method_Comm_constructor; @@ -57,127 +57,81 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_nativeInit(JNIEnv *env, jclass JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_create(JNIEnv * env, jobject jtask, jstring jname, jdouble jflopsAmount, jdouble jbytesAmount) { - msg_task_t task; /* the native task to create */ const char *name = nullptr; /* the name of the task */ - if (jflopsAmount < 0) { - jxbt_throw_illegal(env, bprintf("Task flopsAmount (%f) cannot be negative", static_cast(jflopsAmount))); - return; - } - - if (jbytesAmount < 0) { - jxbt_throw_illegal(env, bprintf("Task bytesAmount (%f) cannot be negative", static_cast(jbytesAmount))); - return; - } - - if (jname) { - /* get the C string from the java string */ + if (jname) name = env->GetStringUTFChars(jname, 0); - } - - /* create the task */ - task = MSG_task_create(name, static_cast(jflopsAmount), static_cast(jbytesAmount), nullptr); + msg_task_t task = MSG_task_create(name, static_cast(jflopsAmount), static_cast(jbytesAmount), jtask); if (jname) env->ReleaseStringUTFChars(jname, name); - /* sets the task name */ - env->SetObjectField(jtask, jtask_field_Task_name, jname); + /* bind & store the task */ jtask_bind(jtask, task, env); - MSG_task_set_data(task, jtask); } JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_parallelCreate(JNIEnv * env, jobject jtask, jstring jname, jobjectArray jhosts, jdoubleArray jcomputeDurations_arg, jdoubleArray jmessageSizes_arg) { - msg_task_t task; /* the native parallel task to create */ - const char *name; /* the name of the task */ - int host_count; - msg_host_t *hosts; - double *computeDurations; - double *messageSizes; - jdouble *jcomputeDurations; - jdouble *jmessageSizes; - jobject jhost; - int index; - - if (!jcomputeDurations_arg) { - jxbt_throw_null(env, xbt_strdup("Parallel task flops amounts cannot be null")); - return; - } - - if (!jmessageSizes_arg) { - jxbt_throw_null(env, xbt_strdup("Parallel task bytes amounts cannot be null")); - return; - } - - if (!jname) { - jxbt_throw_null(env, xbt_strdup("Parallel task name cannot be null")); - return; - } - - host_count = static_cast(env->GetArrayLength(jhosts)); + int host_count = static_cast(env->GetArrayLength(jhosts)); - hosts = xbt_new0(msg_host_t, host_count); - computeDurations = xbt_new0(double, host_count); - messageSizes = xbt_new0(double, host_count * host_count); - - jcomputeDurations = env->GetDoubleArrayElements(jcomputeDurations_arg, 0); - jmessageSizes = env->GetDoubleArrayElements(jmessageSizes_arg, 0); - - for (index = 0; index < host_count; index++) { - jhost = env->GetObjectArrayElement(jhosts, index); + jdouble* jcomputeDurations = env->GetDoubleArrayElements(jcomputeDurations_arg, 0); + msg_host_t* hosts = new msg_host_t[host_count]; + double* computeDurations = new double[host_count]; + for (int index = 0; index < host_count; index++) { + jobject jhost = env->GetObjectArrayElement(jhosts, index); hosts[index] = jhost_get_native(env, jhost); computeDurations[index] = jcomputeDurations[index]; } - for (index = 0; index < host_count * host_count; index++) { + env->ReleaseDoubleArrayElements(jcomputeDurations_arg, jcomputeDurations, 0); + + jdouble* jmessageSizes = env->GetDoubleArrayElements(jmessageSizes_arg, 0); + double* messageSizes = new double[host_count * host_count]; + for (int index = 0; index < host_count * host_count; index++) { messageSizes[index] = jmessageSizes[index]; } - - env->ReleaseDoubleArrayElements(jcomputeDurations_arg, jcomputeDurations, 0); env->ReleaseDoubleArrayElements(jmessageSizes_arg, jmessageSizes, 0); /* get the C string from the java string */ - name = env->GetStringUTFChars(jname, 0); - - task = MSG_parallel_task_create(name, host_count, hosts, computeDurations, messageSizes, nullptr); - + const char* name = env->GetStringUTFChars(jname, 0); + msg_task_t task = MSG_parallel_task_create(name, host_count, hosts, computeDurations, messageSizes, jtask); env->ReleaseStringUTFChars(jname, name); - /* sets the task name */ - env->SetObjectField(jtask, jtask_field_Task_name, jname); + /* associate the java task object and the native task */ jtask_bind(jtask, task, env); - MSG_task_set_data(task, (void *) jtask); - - if (!MSG_task_get_data(task)) - jxbt_throw_jni(env, "global ref allocation failed"); + delete[] hosts; + delete[] computeDurations; + delete[] messageSizes; } JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_cancel(JNIEnv * env, jobject jtask) { msg_task_t ptask = jtask_to_native(jtask, env); - if (!ptask) { + if (not ptask) { jxbt_throw_notbound(env, "task", jtask); return; } msg_error_t rv = MSG_task_cancel(ptask); - jxbt_check_res("MSG_task_cancel()", rv, MSG_OK, bprintf("unexpected error , please report this bug")); + jxbt_check_res("MSG_task_cancel()", rv, MSG_OK, "unexpected error , please report this bug"); } JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_execute(JNIEnv * env, jobject jtask) { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } msg_error_t rv; - rv = MSG_task_execute(task); + if (not simgrid::ForcefulKillException::try_n_catch([&rv, &task]() { rv = MSG_task_execute(task); })) { + jxbt_throw_by_name(env, "org/simgrid/msg/ProcessKilledError", "Process killed"); + } + if (env->ExceptionOccurred()) return; if (rv != MSG_OK) { @@ -189,7 +143,7 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setBound(JNIEnv * env, jobject { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } @@ -199,7 +153,7 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setBound(JNIEnv * env, jobject JNIEXPORT jstring JNICALL Java_org_simgrid_msg_Task_getName(JNIEnv * env, jobject jtask) { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return nullptr; } @@ -212,7 +166,7 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_getSender(JNIEnv * env, jobj msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return nullptr; } @@ -229,7 +183,7 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_getSource(JNIEnv * env, jobj msg_host_t host; msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return nullptr; } @@ -238,7 +192,7 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_getSource(JNIEnv * env, jobj if (host == nullptr) { return nullptr; } - if (!host->extension(JAVA_HOST_LEVEL)) { + if (not host->extension(JAVA_HOST_LEVEL)) { jxbt_throw_jni(env, "MSG_task_get_source() failed"); return nullptr; } @@ -250,17 +204,17 @@ JNIEXPORT jdouble JNICALL Java_org_simgrid_msg_Task_getFlopsAmount(JNIEnv * env, { msg_task_t ptask = jtask_to_native(jtask, env); - if (!ptask) { + if (not ptask) { jxbt_throw_notbound(env, "task", jtask); return -1; } - return (jdouble) MSG_task_get_flops_amount(ptask); + return (jdouble)MSG_task_get_flops_amount(ptask); } JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setName(JNIEnv *env, jobject jtask, jobject jname) { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } @@ -276,7 +230,7 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setPriority(JNIEnv * env, jobje { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } @@ -287,7 +241,7 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setFlopsAmount (JNIEnv *env, jo { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } @@ -298,7 +252,7 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setBytesAmount (JNIEnv *env, jo { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } @@ -306,74 +260,43 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setBytesAmount (JNIEnv *env, jo MSG_task_set_bytes_amount(task, static_cast(dataSize)); } -JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_send(JNIEnv * env,jobject jtask, jstring jalias, jdouble jtimeout) -{ - msg_error_t rv; - const char *alias = env->GetStringUTFChars(jalias, 0); - - msg_task_t task = jtask_to_native(jtask, env); - - if (!task) { - env->ReleaseStringUTFChars(jalias, alias); - jxbt_throw_notbound(env, "task", jtask); - return; - } - - /* Pass a global ref to the Jtask into the Ctask so that the receiver can use it */ - MSG_task_set_data(task, (void *) env->NewGlobalRef(jtask)); - rv = MSG_task_send_with_timeout(task, alias, static_cast(jtimeout)); - env->ReleaseStringUTFChars(jalias, alias); - - if (rv != MSG_OK) { - jmsg_throw_status(env, rv); - } -} - JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_sendBounded(JNIEnv * env,jobject jtask, jstring jalias, jdouble jtimeout,jdouble maxrate) { - msg_error_t rv; - const char *alias = env->GetStringUTFChars(jalias, 0); - msg_task_t task = jtask_to_native(jtask, env); - - if (!task) { - env->ReleaseStringUTFChars(jalias, alias); + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } - /* Pass a global ref to the Jtask into the Ctask so that the receiver can use it */ + /* Add a global ref into the Ctask so that the receiver can use it */ MSG_task_set_data(task, (void *) env->NewGlobalRef(jtask)); - rv = MSG_task_send_with_timeout_bounded(task, alias, static_cast(jtimeout), static_cast(maxrate)); + + const char* alias = env->GetStringUTFChars(jalias, 0); + msg_error_t res = + MSG_task_send_with_timeout_bounded(task, alias, static_cast(jtimeout), static_cast(maxrate)); env->ReleaseStringUTFChars(jalias, alias); - if (rv != MSG_OK) { - jmsg_throw_status(env, rv); - } + if (res != MSG_OK) + jmsg_throw_status(env, res); } -JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_receive(JNIEnv * env, jclass cls, jstring jalias, jdouble jtimeout, - jobject jhost) +JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_receive(JNIEnv* env, jclass cls, jstring jalias, jdouble jtimeout) { msg_task_t task = nullptr; - msg_host_t host = nullptr; - - if (jhost) { - host = jhost_get_native(env, jhost); - - if (!host) { - jxbt_throw_notbound(env, "host", jhost); - return nullptr; - } - } const char *alias = env->GetStringUTFChars(jalias, 0); - msg_error_t rv = MSG_task_receive_ext(&task, alias, (double) jtimeout, host); + msg_error_t rv; + if (not simgrid::ForcefulKillException::try_n_catch([&rv, &task, &alias, &jtimeout]() { + rv = MSG_task_receive_ext(&task, alias, (double)jtimeout, /*host*/ nullptr); + })) { + jxbt_throw_by_name(env, "org/simgrid/msg/ProcessKilledError", "Process killed"); + } + env->ReleaseStringUTFChars(jalias, alias); if (env->ExceptionOccurred()) return nullptr; if (rv != MSG_OK) { - jmsg_throw_status(env,rv); + jmsg_throw_status(env, rv); return nullptr; } jobject jtask_global = (jobject) MSG_task_get_data(task); @@ -383,23 +306,20 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_receive(JNIEnv * env, jclass env->DeleteGlobalRef(jtask_global); MSG_task_set_data(task, nullptr); - env->ReleaseStringUTFChars(jalias, alias); - return (jobject) jtask_local; } JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_irecv(JNIEnv * env, jclass cls, jstring jmailbox) { jclass comm_class = env->FindClass("org/simgrid/msg/Comm"); - if (!comm_class) + if (not comm_class) return nullptr; //pointer to store the task object pointer. - msg_task_t *task = xbt_new(msg_task_t,1); - *task = nullptr; + msg_task_t* task = new msg_task_t(nullptr); /* There should be a cache here */ jobject jcomm = env->NewObject(comm_class, jtask_method_Comm_constructor); - if (!jcomm) { + if (not jcomm) { jxbt_throw_jni(env, "Can't create a Comm object."); return nullptr; } @@ -415,43 +335,29 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_irecv(JNIEnv * env, jclass c return jcomm; } -JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_receiveBounded(JNIEnv * env, jclass cls, jstring jalias, - jdouble jtimeout, jobject jhost, jdouble rate) +JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_receiveBounded(JNIEnv* env, jclass cls, jstring jalias, + jdouble jtimeout, jdouble rate) { - msg_error_t rv; - msg_task_t *task = xbt_new(msg_task_t,1); - *task = nullptr; - - msg_host_t host = nullptr; - - if (jhost) { - host = jhost_get_native(env, jhost); - - if (!host) { - jxbt_throw_notbound(env, "host", jhost); - return nullptr; - } - } + msg_task_t task = nullptr; const char *alias = env->GetStringUTFChars(jalias, 0); - rv = MSG_task_receive_ext_bounded(task, alias, static_cast(jtimeout), host, static_cast(rate)); + msg_error_t res = MSG_task_receive_ext_bounded(&task, alias, static_cast(jtimeout), /*host*/ nullptr, + static_cast(rate)); if (env->ExceptionOccurred()) return nullptr; - if (rv != MSG_OK) { - jmsg_throw_status(env,rv); + if (res != MSG_OK) { + jmsg_throw_status(env, res); return nullptr; } - jobject jtask_global = (jobject) MSG_task_get_data(*task); + jobject jtask_global = (jobject)MSG_task_get_data(task); /* Convert the global ref into a local ref so that the JVM can free the stuff */ jobject jtask_local = env->NewLocalRef(jtask_global); env->DeleteGlobalRef(jtask_global); - MSG_task_set_data(*task, nullptr); + MSG_task_set_data(task, nullptr); env->ReleaseStringUTFChars(jalias, alias); - xbt_free(task); - return (jobject) jtask_local; } @@ -459,14 +365,14 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_irecvBounded(JNIEnv * env, j jdouble rate) { jclass comm_class = env->FindClass("org/simgrid/msg/Comm"); - if (!comm_class) + if (not comm_class) return nullptr; // pointer to store the task object pointer. - msg_task_t* task = xbt_new0(msg_task_t, 1); + msg_task_t* task = new msg_task_t(nullptr); jobject jcomm = env->NewObject(comm_class, jtask_method_Comm_constructor); - if (!jcomm) { + if (not jcomm) { jxbt_throw_jni(env, "Can't create a Comm object."); return nullptr; } @@ -488,14 +394,15 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_isend(JNIEnv *env, jobject j jclass comm_class = env->FindClass("org/simgrid/msg/Comm"); - if (!comm_class) return nullptr; + if (not comm_class) + return nullptr; jobject jcomm = env->NewObject(comm_class, jtask_method_Comm_constructor); const char* mailbox = env->GetStringUTFChars(jmailbox, 0); msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { env->ReleaseStringUTFChars(jmailbox, mailbox); env->DeleteLocalRef(jcomm); jxbt_throw_notbound(env, "task", jtask); @@ -523,7 +430,7 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_isendBounded(JNIEnv *env, jo const char *mailbox; jclass comm_class = env->FindClass("org/simgrid/msg/Comm"); - if (!comm_class) + if (not comm_class) return nullptr; jcomm = env->NewObject(comm_class, jtask_method_Comm_constructor); @@ -531,7 +438,7 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_isendBounded(JNIEnv *env, jo task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { env->ReleaseStringUTFChars(jmailbox, mailbox); env->DeleteLocalRef(jcomm); jxbt_throw_notbound(env, "task", jtask); @@ -554,7 +461,7 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_nativeFinalize(JNIEnv * env, jo { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } @@ -564,13 +471,17 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_nativeFinalize(JNIEnv * env, jo static void msg_task_cancel_on_failed_dsend(void*t) { msg_task_t task = (msg_task_t) t; - JNIEnv *env =get_current_thread_env(); - jobject jtask_global = (jobject) MSG_task_get_data(task); - - /* Destroy the global ref so that the JVM can free the stuff */ - env->DeleteGlobalRef(jtask_global); + JNIEnv* env = get_current_thread_env(); + if (env) { + jobject jtask_global = (jobject)MSG_task_get_data(task); + /* Destroy the global ref so that the JVM can free the stuff */ + env->DeleteGlobalRef(jtask_global); + /* Don't free the C data here, to avoid a race condition with the GC also sometimes doing so. + * A rare memleak is seen as preferable to a rare "free(): invalid pointer" failure that + * proves really hard to debug. + */ + } MSG_task_set_data(task, nullptr); - MSG_task_destroy(task); } JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_dsend(JNIEnv * env, jobject jtask, jstring jalias) @@ -579,7 +490,7 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_dsend(JNIEnv * env, jobject jta msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { env->ReleaseStringUTFChars(jalias, alias); jxbt_throw_notbound(env, "task", jtask); return; @@ -599,7 +510,7 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_dsendBounded(JNIEnv * env, jobj msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { env->ReleaseStringUTFChars(jalias, alias); jxbt_throw_notbound(env, "task", jtask); return; @@ -629,5 +540,3 @@ JNIEXPORT jint JNICALL Java_org_simgrid_msg_Task_listenFrom(JNIEnv * env, jclass return (jint) rv; } - -SG_END_DECL()