X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/c42000db0f347a26ac1645d830ac949194ec4da0..4e0b0a957106c8c55b7aa24f118ed5862e98064d:/src/gras/DataDesc/ddt_exchange.c diff --git a/src/gras/DataDesc/ddt_exchange.c b/src/gras/DataDesc/ddt_exchange.c index 4bd36ed966..09d56c148a 100644 --- a/src/gras/DataDesc/ddt_exchange.c +++ b/src/gras/DataDesc/ddt_exchange.c @@ -11,38 +11,38 @@ #include "gras/DataDesc/datadesc_private.h" #include "gras/Transport/transport_interface.h" /* gras_trp_chunk_send/recv */ -GRAS_LOG_NEW_DEFAULT_SUBCATEGORY(ddt_exchange,datadesc, +XBT_LOG_NEW_DEFAULT_SUBCATEGORY(ddt_exchange,datadesc, "Sending data over the network"); const char *gras_datadesc_cat_names[9] = { "undefined", "scalar", "struct", "union", "ref", "array", "ignored", "invalid"}; -static gras_datadesc_type_t *int_type = NULL; -static gras_datadesc_type_t *pointer_type = NULL; -static _GRAS_INLINE gras_error_t gras_dd_send_int(gras_socket_t *sock, int i); -static _GRAS_INLINE gras_error_t gras_dd_recv_int(gras_socket_t *sock, int r_arch, int *i); +static gras_datadesc_type_t int_type = NULL; +static gras_datadesc_type_t pointer_type = NULL; +static _XBT_INLINE xbt_error_t gras_dd_send_int(gras_socket_t sock, int i); +static _XBT_INLINE xbt_error_t gras_dd_recv_int(gras_socket_t sock, int r_arch, int *i); -static _GRAS_INLINE gras_error_t -gras_dd_alloc_ref(gras_dict_t *refs, long int size, +static _XBT_INLINE xbt_error_t +gras_dd_alloc_ref(xbt_dict_t refs, long int size, char **r_ref, long int r_len, char **l_ref, int detect_cycle); -static _GRAS_INLINE int +static _XBT_INLINE int gras_dd_is_r_null(char **r_ptr, long int length); -static gras_error_t -gras_datadesc_send_rec(gras_socket_t *sock, - gras_cbps_t *state, - gras_dict_t *refs, - gras_datadesc_type_t *type, +static xbt_error_t +gras_datadesc_send_rec(gras_socket_t sock, + gras_cbps_t state, + xbt_dict_t refs, + gras_datadesc_type_t type, char *data, int detect_cycle); -static gras_error_t -gras_datadesc_recv_rec(gras_socket_t *sock, - gras_cbps_t *state, - gras_dict_t *refs, - gras_datadesc_type_t *type, +static xbt_error_t +gras_datadesc_recv_rec(gras_socket_t sock, + gras_cbps_t state, + xbt_dict_t refs, + gras_datadesc_type_t type, int r_arch, char **r_data, long int r_lgr, @@ -51,25 +51,25 @@ gras_datadesc_recv_rec(gras_socket_t *sock, int detect_cycle); -static _GRAS_INLINE gras_error_t -gras_dd_send_int(gras_socket_t *sock,int i) { +static _XBT_INLINE xbt_error_t +gras_dd_send_int(gras_socket_t sock,int i) { if (!int_type) { int_type = gras_datadesc_by_name("int"); - gras_assert(int_type); + xbt_assert(int_type); } DEBUG1("send_int(%d)",i); return gras_trp_chunk_send(sock, (char*)&i, int_type->size[GRAS_THISARCH]); } -static _GRAS_INLINE gras_error_t -gras_dd_recv_int(gras_socket_t *sock, int r_arch, int *i) { - gras_error_t errcode; +static _XBT_INLINE xbt_error_t +gras_dd_recv_int(gras_socket_t sock, int r_arch, int *i) { + xbt_error_t errcode; if (!int_type) { int_type = gras_datadesc_by_name("int"); - gras_assert(int_type); + xbt_assert(int_type); } if (int_type->size[GRAS_THISARCH] >= int_type->size[r_arch]) { @@ -77,12 +77,12 @@ gras_dd_recv_int(gras_socket_t *sock, int r_arch, int *i) { if (r_arch != GRAS_THISARCH) TRY(gras_dd_convert_elm(int_type,1,r_arch, i,i)); } else { - void *ptr = gras_malloc(int_type->size[r_arch]); + void *ptr = xbt_malloc(int_type->size[r_arch]); TRY(gras_trp_chunk_recv(sock, (char*)ptr, int_type->size[r_arch])); if (r_arch != GRAS_THISARCH) TRY(gras_dd_convert_elm(int_type,1,r_arch, ptr,i)); - gras_free(ptr); + xbt_free(ptr); } DEBUG1("recv_int(%d)",*i); @@ -94,7 +94,7 @@ gras_dd_recv_int(gras_socket_t *sock, int r_arch, int *i) { * of 'length' bytes set to 0. * FIXME: Check in configure? */ -static _GRAS_INLINE int +static _XBT_INLINE int gras_dd_is_r_null(char **r_ptr, long int length) { int i; @@ -107,8 +107,8 @@ gras_dd_is_r_null(char **r_ptr, long int length) { return 1; } -static _GRAS_INLINE gras_error_t -gras_dd_alloc_ref(gras_dict_t *refs, +static _XBT_INLINE xbt_error_t +gras_dd_alloc_ref(xbt_dict_t refs, long int size, char **r_ref, long int r_len, /* pointer_type->size[r_arch] */ @@ -116,8 +116,8 @@ gras_dd_alloc_ref(gras_dict_t *refs, int detect_cycle) { char *l_data = NULL; - gras_assert1(size>0,"Cannot allocate %ld bytes!", size); - l_data = gras_malloc((size_t)size); + xbt_assert1(size>0,"Cannot allocate %ld bytes!", size); + l_data = xbt_malloc((size_t)size); *l_ref = l_data; DEBUG2("l_data=%p, &l_data=%p",(void*)l_data,(void*)&l_data); @@ -125,15 +125,15 @@ gras_dd_alloc_ref(gras_dict_t *refs, DEBUG3("alloc_ref: r_ref=%p; *r_ref=%p, r_len=%ld", (void*)r_ref, (void*)(r_ref?*r_ref:NULL), r_len); if (detect_cycle && r_ref && !gras_dd_is_r_null( r_ref, r_len)) { - gras_error_t errcode; - void *ptr = gras_malloc(sizeof(void *)); + void *ptr = xbt_malloc(sizeof(void *)); + CRITICAL0("detect_cycle"); memcpy(ptr,l_ref, sizeof(void *)); DEBUG2("Insert %p under %p",*(void**)ptr, *(void**)r_ref); if (detect_cycle) - gras_dict_set_ext(refs,(const char *) r_ref, r_len, ptr, gras_free); + xbt_dict_set_ext(refs,(const char *) r_ref, r_len, ptr, xbt_free_fct); } return no_error; } @@ -146,11 +146,11 @@ gras_dd_alloc_ref(gras_dict_t *refs, * This comparison does not take the set headers into account (name and ID), * but only the payload (actual type description). */ -int gras_datadesc_type_cmp(const gras_datadesc_type_t *d1, - const gras_datadesc_type_t *d2) { +int gras_datadesc_type_cmp(const gras_datadesc_type_t d1, + const gras_datadesc_type_t d2) { int ret,cpt; - gras_dd_cat_field_t *field1,*field2; - gras_datadesc_type_t *field_desc_1,*field_desc_2; + gras_dd_cat_field_t field1,field2; + gras_datadesc_type_t field_desc_1,field_desc_2; if (d1 == d2) return 0; /* easy optimization */ @@ -216,19 +216,19 @@ int gras_datadesc_type_cmp(const gras_datadesc_type_t *d1, break; case e_gras_datadesc_type_cat_struct: - if (gras_dynar_length(d1->category.struct_data.fields) != - gras_dynar_length(d2->category.struct_data.fields)) { + if (xbt_dynar_length(d1->category.struct_data.fields) != + xbt_dynar_length(d2->category.struct_data.fields)) { DEBUG4("ddt_cmp: %s (having %lu fields) != %s (having %lu fields)", - d1->name, gras_dynar_length(d1->category.struct_data.fields), - d2->name, gras_dynar_length(d2->category.struct_data.fields)); + d1->name, xbt_dynar_length(d1->category.struct_data.fields), + d2->name, xbt_dynar_length(d2->category.struct_data.fields)); - return gras_dynar_length(d1->category.struct_data.fields) > - gras_dynar_length(d2->category.struct_data.fields) ? + return xbt_dynar_length(d1->category.struct_data.fields) > + xbt_dynar_length(d2->category.struct_data.fields) ? 1 : -1; } - gras_dynar_foreach(d1->category.struct_data.fields, cpt, field1) { + xbt_dynar_foreach(d1->category.struct_data.fields, cpt, field1) { - gras_dynar_get(d2->category.struct_data.fields, cpt, &field2); + field2 = xbt_dynar_get_as(d2->category.struct_data.fields, cpt, gras_dd_cat_field_t); field_desc_1 = field1->type; field_desc_2 = field2->type; ret = gras_datadesc_type_cmp(field_desc_1,field_desc_2); @@ -246,15 +246,15 @@ int gras_datadesc_type_cmp(const gras_datadesc_type_t *d1, if (d1->category.union_data.selector != d2->category.union_data.selector) return 1; /* ISO C forbids ordered comparisons of pointers to functions */ - if (gras_dynar_length(d1->category.union_data.fields) != - gras_dynar_length(d2->category.union_data.fields)) - return gras_dynar_length(d1->category.union_data.fields) > - gras_dynar_length(d2->category.union_data.fields) ? + if (xbt_dynar_length(d1->category.union_data.fields) != + xbt_dynar_length(d2->category.union_data.fields)) + return xbt_dynar_length(d1->category.union_data.fields) > + xbt_dynar_length(d2->category.union_data.fields) ? 1 : -1; - gras_dynar_foreach(d1->category.union_data.fields, cpt, field1) { + xbt_dynar_foreach(d1->category.union_data.fields, cpt, field1) { - gras_dynar_get(d2->category.union_data.fields, cpt, field2); + field2 = xbt_dynar_get_as(d2->category.union_data.fields, cpt, gras_dd_cat_field_t); field_desc_1 = field1->type; field_desc_2 = field2->type; ret = gras_datadesc_type_cmp(field_desc_1,field_desc_2); @@ -302,23 +302,23 @@ int gras_datadesc_type_cmp(const gras_datadesc_type_t *d1, * to a new location, and store a pointer to it in dst. * */ -gras_error_t gras_datadesc_cpy(gras_datadesc_type_t *type, +xbt_error_t gras_datadesc_cpy(gras_datadesc_type_t type, void *src, void **dst) { RAISE_UNIMPLEMENTED; } -static gras_error_t -gras_datadesc_send_rec(gras_socket_t *sock, - gras_cbps_t *state, - gras_dict_t *refs, - gras_datadesc_type_t *type, +static xbt_error_t +gras_datadesc_send_rec(gras_socket_t sock, + gras_cbps_t state, + xbt_dict_t refs, + gras_datadesc_type_t type, char *data, int detect_cycle) { - gras_error_t errcode; - int cpt; - gras_datadesc_type_t *sub_type; /* type on which we recurse */ + xbt_error_t errcode; + int cpt; + gras_datadesc_type_t sub_type; /* type on which we recurse */ VERB2("Send a %s (%s)", type->name, gras_datadesc_cat_names[type->category_code]); @@ -333,16 +333,16 @@ gras_datadesc_send_rec(gras_socket_t *sock, break; case e_gras_datadesc_type_cat_struct: { - gras_dd_cat_struct_t struct_data; - gras_dd_cat_field_t *field; - char *field_data; + gras_dd_cat_struct_t struct_data; + gras_dd_cat_field_t field; + char *field_data; struct_data = type->category.struct_data; - gras_assert1(struct_data.closed, + xbt_assert1(struct_data.closed, "Please call gras_datadesc_declare_struct_close on %s before sending it", type->name); VERB1(">> Send all fields of the structure %s",type->name); - gras_dynar_foreach(struct_data.fields, cpt, field) { + xbt_dynar_foreach(struct_data.fields, cpt, field) { field_data = data; field_data += field->offset[GRAS_THISARCH]; @@ -363,31 +363,31 @@ gras_datadesc_send_rec(gras_socket_t *sock, } case e_gras_datadesc_type_cat_union: { - gras_dd_cat_union_t union_data; - gras_dd_cat_field_t *field=NULL; - int field_num; + gras_dd_cat_union_t union_data; + gras_dd_cat_field_t field=NULL; + int field_num; union_data = type->category.union_data; - gras_assert1(union_data.closed, + xbt_assert1(union_data.closed, "Please call gras_datadesc_declare_union_close on %s before sending it", type->name); /* retrieve the field number */ field_num = union_data.selector(state, data); - gras_assert1(field_num > 0, + xbt_assert1(field_num > 0, "union field selector of %s gave a negative value", type->name); - gras_assert3(field_num < gras_dynar_length(union_data.fields), + xbt_assert3(field_num < xbt_dynar_length(union_data.fields), "union field selector of %s returned %d but there is only %lu fields", - type->name, field_num, gras_dynar_length(union_data.fields)); + type->name, field_num, xbt_dynar_length(union_data.fields)); /* Send the field number */ TRY(gras_dd_send_int(sock, field_num)); /* Send the content */ - gras_dynar_get(union_data.fields, field_num, field); + field = xbt_dynar_get_as(union_data.fields, field_num, gras_dd_cat_field_t); sub_type = field->type; if (field->pre) @@ -419,7 +419,7 @@ gras_datadesc_send_rec(gras_socket_t *sock, /* Send the actual value of the pointer for cycle handling */ if (!pointer_type) { pointer_type = gras_datadesc_by_name("data pointer"); - gras_assert(pointer_type); + xbt_assert(pointer_type); } TRY(gras_trp_chunk_send(sock, (char*)data, @@ -431,12 +431,12 @@ gras_datadesc_send_rec(gras_socket_t *sock, break; } errcode = detect_cycle - ? gras_dict_get_ext(refs,(char*)ref, sizeof(void*), &dummy) + ? xbt_dict_get_ext(refs,(char*)ref, sizeof(void*), &dummy) : mismatch_error; if (errcode == mismatch_error) { VERB1("Sending data referenced at %p", (void*)*ref); if (detect_cycle) - gras_dict_set_ext(refs, (char*)ref, sizeof(void*), ref, NULL); + xbt_dict_set_ext(refs, (char*)ref, sizeof(void*), ref, NULL); TRY(gras_datadesc_send_rec(sock,state,refs, sub_type, *ref, detect_cycle || sub_type->cycle)); } else if (errcode == no_error) { @@ -460,7 +460,7 @@ gras_datadesc_send_rec(gras_socket_t *sock, count = array_data.fixed_size; if (count == 0) { count = array_data.dynamic_size(state,data); - gras_assert1(count >=0, + xbt_assert1(count >=0, "Invalid (negative) array size for type %s",type->name); TRY(gras_dd_send_int(sock, count)); } @@ -472,6 +472,15 @@ gras_datadesc_send_rec(gras_socket_t *sock, VERB1("Array of %ld scalars, send it in one shot",count); TRY(gras_trp_chunk_send(sock, data, sub_type->aligned_size[GRAS_THISARCH] * count)); + } else if (sub_type->category_code == e_gras_datadesc_type_cat_array && + sub_type->category.array_data.fixed_size > 0 && + sub_type->category.array_data.type->category_code == e_gras_datadesc_type_cat_scalar) { + + VERB1("Array of %ld fixed array of scalars, send it in one shot",count); + TRY(gras_trp_chunk_send(sock, data, + sub_type->category.array_data.type->aligned_size[GRAS_THISARCH] + * count * sub_type->category.array_data.fixed_size)); + } else { for (cpt=0; cptcycle)); @@ -482,7 +491,7 @@ gras_datadesc_send_rec(gras_socket_t *sock, } default: - gras_assert0(0, "Invalid type"); + xbt_assert0(0, "Invalid type"); } return no_error; @@ -494,20 +503,20 @@ gras_datadesc_send_rec(gras_socket_t *sock, * Copy the data pointed by src and described by type to the socket * */ -gras_error_t gras_datadesc_send(gras_socket_t *sock, - gras_datadesc_type_t *type, +xbt_error_t gras_datadesc_send(gras_socket_t sock, + gras_datadesc_type_t type, void *src) { - gras_error_t errcode; - gras_cbps_t *state = NULL; - gras_dict_t *refs; /* all references already sent */ + xbt_error_t errcode; + gras_cbps_t state; + xbt_dict_t refs; /* all references already sent */ - refs = gras_dict_new(); + refs = xbt_dict_new(); state = gras_cbps_new(); - + errcode = gras_datadesc_send_rec(sock,state,refs,type,(char*)src, type->cycle); - gras_dict_free(&refs); + xbt_dict_free(&refs); gras_cbps_free(&state); return errcode; @@ -525,11 +534,11 @@ gras_error_t gras_datadesc_send(gras_socket_t *sock, * Having this size passed as an argument of the recursive function is a crude * hack, but I was told that working code is sometimes better than neat one ;) */ -gras_error_t -gras_datadesc_recv_rec(gras_socket_t *sock, - gras_cbps_t *state, - gras_dict_t *refs, - gras_datadesc_type_t *type, +xbt_error_t +gras_datadesc_recv_rec(gras_socket_t sock, + gras_cbps_t state, + xbt_dict_t refs, + gras_datadesc_type_t type, int r_arch, char **r_data, long int r_lgr, @@ -537,12 +546,12 @@ gras_datadesc_recv_rec(gras_socket_t *sock, int subsize, int detect_cycle) { - gras_error_t errcode; - int cpt; - gras_datadesc_type_t *sub_type; + xbt_error_t errcode; + int cpt; + gras_datadesc_type_t sub_type; VERB2("Recv a %s @%p", type->name, (void*)l_data); - gras_assert(l_data); + xbt_assert(l_data); switch (type->category_code) { case e_gras_datadesc_type_cat_scalar: @@ -551,26 +560,26 @@ gras_datadesc_recv_rec(gras_socket_t *sock, if (r_arch != GRAS_THISARCH) TRY(gras_dd_convert_elm(type,1,r_arch, l_data,l_data)); } else { - void *ptr = gras_malloc(type->size[r_arch]); + void *ptr = xbt_malloc(type->size[r_arch]); TRY(gras_trp_chunk_recv(sock, (char*)ptr, type->size[r_arch])); if (r_arch != GRAS_THISARCH) TRY(gras_dd_convert_elm(type,1,r_arch, ptr,l_data)); - gras_free(ptr); + xbt_free(ptr); } break; case e_gras_datadesc_type_cat_struct: { - gras_dd_cat_struct_t struct_data; - gras_dd_cat_field_t *field; + gras_dd_cat_struct_t struct_data; + gras_dd_cat_field_t field; struct_data = type->category.struct_data; - gras_assert1(struct_data.closed, + xbt_assert1(struct_data.closed, "Please call gras_datadesc_declare_struct_close on %s before receiving it", type->name); VERB1(">> Receive all fields of the structure %s",type->name); - gras_dynar_foreach(struct_data.fields, cpt, field) { + xbt_dynar_foreach(struct_data.fields, cpt, field) { char *field_data = l_data + field->offset[GRAS_THISARCH]; sub_type = field->type; @@ -586,13 +595,13 @@ gras_datadesc_recv_rec(gras_socket_t *sock, } case e_gras_datadesc_type_cat_union: { - gras_dd_cat_union_t union_data; - gras_dd_cat_field_t *field=NULL; - int field_num; + gras_dd_cat_union_t union_data; + gras_dd_cat_field_t field=NULL; + int field_num; union_data = type->category.union_data; - gras_assert1(union_data.closed, + xbt_assert1(union_data.closed, "Please call gras_datadesc_declare_union_close on %s before receiving it", type->name); /* retrieve the field number */ @@ -600,13 +609,13 @@ gras_datadesc_recv_rec(gras_socket_t *sock, if (field_num < 0) RAISE1(mismatch_error, "Received union field for %s is negative", type->name); - if (field_num < gras_dynar_length(union_data.fields)) + if (field_num < xbt_dynar_length(union_data.fields)) RAISE3(mismatch_error, "Received union field for %s is %d but there is only %lu fields", - type->name, field_num, gras_dynar_length(union_data.fields)); + type->name, field_num, xbt_dynar_length(union_data.fields)); /* Recv the content */ - gras_dynar_get(union_data.fields, field_num, field); + field = xbt_dynar_get_as(union_data.fields, field_num, gras_dd_cat_field_t); sub_type = field->type; TRY(gras_datadesc_recv_rec(sock,state,refs, sub_type, @@ -634,10 +643,10 @@ gras_datadesc_recv_rec(gras_socket_t *sock, /* Get the actual value of the pointer for cycle handling */ if (!pointer_type) { pointer_type = gras_datadesc_by_name("data pointer"); - gras_assert(pointer_type); + xbt_assert(pointer_type); } - r_ref = gras_malloc(pointer_type->size[r_arch]); + r_ref = xbt_malloc(pointer_type->size[r_arch]); TRY(gras_trp_chunk_recv(sock, (char*)r_ref, pointer_type->size[r_arch])); @@ -647,12 +656,12 @@ gras_datadesc_recv_rec(gras_socket_t *sock, VERB1("Not receiving data remotely referenced @%p since it's NULL", *(void **)r_ref); *(void**)l_data = NULL; - gras_free(r_ref); + xbt_free(r_ref); break; } errcode = detect_cycle - ? gras_dict_get_ext(refs, + ? xbt_dict_get_ext(refs, (char*)r_ref, pointer_type->size[r_arch], (void**)&l_ref) : mismatch_error; @@ -667,7 +676,7 @@ gras_datadesc_recv_rec(gras_socket_t *sock, /* Damn. Reference to a dynamic array. Allocating the size for it is more complicated */ gras_dd_cat_array_t array_data = sub_type->category.array_data; - gras_datadesc_type_t *subsub_type; + gras_datadesc_type_t subsub_type; subsubcount = array_data.fixed_size; if (subsubcount == 0) @@ -705,7 +714,7 @@ gras_datadesc_recv_rec(gras_socket_t *sock, } else { return errcode; } - gras_free(r_ref); + xbt_free(r_ref); break; } @@ -737,14 +746,40 @@ gras_datadesc_recv_rec(gras_socket_t *sock, if (r_arch != GRAS_THISARCH) TRY(gras_dd_convert_elm(sub_type,count,r_arch, l_data,l_data)); } else { - ptr = gras_malloc(sub_type->aligned_size[r_arch] * count); + ptr = xbt_malloc(sub_type->aligned_size[r_arch] * count); TRY(gras_trp_chunk_recv(sock, (char*)ptr, sub_type->size[r_arch] * count)); if (r_arch != GRAS_THISARCH) TRY(gras_dd_convert_elm(sub_type,count,r_arch, ptr,l_data)); - gras_free(ptr); + xbt_free(ptr); } + } else if (sub_type->category_code == e_gras_datadesc_type_cat_array && + sub_type->category.array_data.fixed_size > 0 && + sub_type->category.array_data.type->category_code == e_gras_datadesc_type_cat_scalar) { + gras_datadesc_type_t subsub_type; + array_data = sub_type->category.array_data; + subsub_type = array_data.type; + + VERB1("Array of %d fixed array of scalars, get it in one shot",count); + if (subsub_type->aligned_size[GRAS_THISARCH] >= + subsub_type->aligned_size[r_arch]) { + TRY(gras_trp_chunk_recv(sock, (char*)l_data, + subsub_type->aligned_size[r_arch] * count * + array_data.fixed_size)); + if (r_arch != GRAS_THISARCH) + TRY(gras_dd_convert_elm(subsub_type,count*array_data.fixed_size,r_arch, l_data,l_data)); + } else { + ptr = xbt_malloc(subsub_type->aligned_size[r_arch] * count*array_data.fixed_size); + + TRY(gras_trp_chunk_recv(sock, (char*)ptr, + subsub_type->size[r_arch] * count*array_data.fixed_size)); + if (r_arch != GRAS_THISARCH) + TRY(gras_dd_convert_elm(subsub_type,count*array_data.fixed_size,r_arch, ptr,l_data)); + xbt_free(ptr); + } + + } else { /* not scalar content, get it recursively (may contain pointers) */ elm_size = sub_type->aligned_size[GRAS_THISARCH]; @@ -762,7 +797,7 @@ gras_datadesc_recv_rec(gras_socket_t *sock, } default: - gras_assert0(0, "Invalid type"); + xbt_assert0(0, "Invalid type"); } if (type->recv) @@ -778,17 +813,17 @@ gras_datadesc_recv_rec(gras_socket_t *sock, * and store a pointer to it in @dst * */ -gras_error_t -gras_datadesc_recv(gras_socket_t *sock, - gras_datadesc_type_t *type, - int r_arch, - void *dst) { +xbt_error_t +gras_datadesc_recv(gras_socket_t sock, + gras_datadesc_type_t type, + int r_arch, + void *dst) { - gras_error_t errcode; - gras_cbps_t *state = NULL; /* callback persistent state */ - gras_dict_t *refs; /* all references already sent */ + xbt_error_t errcode; + gras_cbps_t state; /* callback persistent state */ + xbt_dict_t refs; /* all references already sent */ - refs = gras_dict_new(); + refs = xbt_dict_new(); state = gras_cbps_new(); errcode = gras_datadesc_recv_rec(sock, state, refs, type, @@ -796,7 +831,7 @@ gras_datadesc_recv(gras_socket_t *sock, (char *) dst,-1, type->cycle); - gras_dict_free(&refs); + xbt_dict_free(&refs); gras_cbps_free(&state); return errcode;