X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/bdef81fa4e3566ce31b435deb98fea7b8fe70e6e..c73bbc06caa1eb2ca3965708222a1655c4c14644:/src/mc/checker/CommunicationDeterminismChecker.cpp diff --git a/src/mc/checker/CommunicationDeterminismChecker.cpp b/src/mc/checker/CommunicationDeterminismChecker.cpp index 864566c7a7..3bdf2a4805 100644 --- a/src/mc/checker/CommunicationDeterminismChecker.cpp +++ b/src/mc/checker/CommunicationDeterminismChecker.cpp @@ -1,5 +1,4 @@ -/* Copyright (c) 2008-2015. The SimGrid Team. - * All rights reserved. */ +/* Copyright (c) 2008-2017. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ @@ -11,23 +10,23 @@ #include #include -#include "src/mc/mc_state.h" -#include "src/mc/mc_comm_pattern.h" -#include "src/mc/mc_request.h" -#include "src/mc/mc_safety.h" +#include "src/mc/Transition.hpp" +#include "src/mc/VisitedState.hpp" +#include "src/mc/checker/CommunicationDeterminismChecker.hpp" +#include "src/mc/mc_exit.h" #include "src/mc/mc_private.h" #include "src/mc/mc_record.h" +#include "src/mc/mc_request.h" +#include "src/mc/mc_safety.h" #include "src/mc/mc_smx.h" -#include "src/mc/Client.hpp" -#include "src/mc/checker/CommunicationDeterminismChecker.hpp" -#include "src/mc/mc_exit.h" -#include "src/mc/VisitedState.hpp" -#include "src/mc/Transition.hpp" +#include "src/mc/mc_state.h" +#include "src/mc/remote/Client.hpp" + +#include "src/smpi/smpi_request.hpp" using simgrid::mc::remote; -XBT_LOG_NEW_DEFAULT_SUBCATEGORY(mc_comm_determinism, mc, - "Logging specific to MC communication determinism detection"); +XBT_LOG_NEW_DEFAULT_SUBCATEGORY(mc_comm_determinism, mc, "Logging specific to MC communication determinism detection"); /********** Global variables **********/ @@ -36,7 +35,8 @@ xbt_dynar_t incomplete_communications_pattern; /********** Static functions ***********/ -static e_mc_comm_pattern_difference_t compare_comm_pattern(simgrid::mc::PatternCommunication* comm1, simgrid::mc::PatternCommunication* comm2) +static e_mc_comm_pattern_difference_t compare_comm_pattern(simgrid::mc::PatternCommunication* comm1, + simgrid::mc::PatternCommunication* comm2) { if(comm1->type != comm2->type) return TYPE_DIFF; @@ -55,8 +55,11 @@ static e_mc_comm_pattern_difference_t compare_comm_pattern(simgrid::mc::PatternC return NONE_DIFF; } -static char* print_determinism_result(e_mc_comm_pattern_difference_t diff, int process, simgrid::mc::PatternCommunication* comm, unsigned int cursor) { - char *type, *res; +static char* print_determinism_result(e_mc_comm_pattern_difference_t diff, int process, + simgrid::mc::PatternCommunication* comm, unsigned int cursor) +{ + char* type; + char* res; if (comm->type == simgrid::mc::PatternCommunicationType::send) type = bprintf("The send communications pattern of the process %d is different!", process - 1); @@ -93,9 +96,8 @@ static char* print_determinism_result(e_mc_comm_pattern_difference_t diff, int p return res; } -static void update_comm_pattern( - simgrid::mc::PatternCommunication* comm_pattern, - simgrid::mc::RemotePtr comm_addr) +static void update_comm_pattern(simgrid::mc::PatternCommunication* comm_pattern, + simgrid::mc::RemotePtr comm_addr) { // HACK, type punning simgrid::mc::Remote temp_comm; @@ -110,27 +112,24 @@ static void update_comm_pattern( comm_pattern->dst_host = MC_smx_actor_get_host_name(dst_proc); if (comm_pattern->data.size() == 0 && comm->src_buff != nullptr) { size_t buff_size; - mc_model_checker->process().read( - &buff_size, remote(comm->dst_buff_size)); + mc_model_checker->process().read(&buff_size, remote(comm->dst_buff_size)); comm_pattern->data.resize(buff_size); - mc_model_checker->process().read_bytes( - comm_pattern->data.data(), comm_pattern->data.size(), - remote(comm->src_buff)); + mc_model_checker->process().read_bytes(comm_pattern->data.data(), comm_pattern->data.size(), + remote(comm->src_buff)); } } namespace simgrid { namespace mc { -void CommunicationDeterminismChecker::deterministic_comm_pattern( - int process, simgrid::mc::PatternCommunication* comm, int backtracking) +void CommunicationDeterminismChecker::deterministic_comm_pattern(int process, simgrid::mc::PatternCommunication* comm, + int backtracking) { simgrid::mc::PatternCommunicationList* list = xbt_dynar_get_as(initial_communications_pattern, process, simgrid::mc::PatternCommunicationList*); if(!backtracking){ - e_mc_comm_pattern_difference_t diff = - compare_comm_pattern(list->list[list->index_comm].get(), comm); + e_mc_comm_pattern_difference_t diff = compare_comm_pattern(list->list[list->index_comm].get(), comm); if (diff != NONE_DIFF) { if (comm->type == simgrid::mc::PatternCommunicationType::send) { @@ -173,19 +172,17 @@ void CommunicationDeterminismChecker::deterministic_comm_pattern( /********** Non Static functions ***********/ -void CommunicationDeterminismChecker::get_comm_pattern(xbt_dynar_t list, smx_simcall_t request, e_mc_call_type_t call_type, int backtracking) +void CommunicationDeterminismChecker::get_comm_pattern(xbt_dynar_t list, smx_simcall_t request, + e_mc_call_type_t call_type, int backtracking) { const smx_actor_t issuer = MC_smx_simcall_get_issuer(request); - simgrid::mc::PatternCommunicationList* initial_pattern = xbt_dynar_get_as( - initial_communications_pattern, issuer->pid, simgrid::mc::PatternCommunicationList*); - xbt_dynar_t incomplete_pattern = xbt_dynar_get_as( - incomplete_communications_pattern, issuer->pid, xbt_dynar_t); + simgrid::mc::PatternCommunicationList* initial_pattern = + xbt_dynar_get_as(initial_communications_pattern, issuer->pid, simgrid::mc::PatternCommunicationList*); + xbt_dynar_t incomplete_pattern = xbt_dynar_get_as(incomplete_communications_pattern, issuer->pid, xbt_dynar_t); std::unique_ptr pattern = - std::unique_ptr( - new simgrid::mc::PatternCommunication()); - pattern->index = - initial_pattern->index_comm + xbt_dynar_length(incomplete_pattern); + std::unique_ptr(new simgrid::mc::PatternCommunication()); + pattern->index = initial_pattern->index_comm + xbt_dynar_length(incomplete_pattern); if (call_type == MC_CALL_TYPE_SEND) { /* Create comm pattern */ @@ -193,41 +190,35 @@ void CommunicationDeterminismChecker::get_comm_pattern(xbt_dynar_t list, smx_sim pattern->comm_addr = simcall_comm_isend__get__result(request); simgrid::mc::Remote temp_synchro; - mc_model_checker->process().read(temp_synchro, remote( - static_cast(pattern->comm_addr))); - simgrid::kernel::activity::Comm* synchro = - static_cast(temp_synchro.getBuffer()); + mc_model_checker->process().read(temp_synchro, + remote(static_cast(pattern->comm_addr))); + simgrid::kernel::activity::Comm* synchro = static_cast(temp_synchro.getBuffer()); char* remote_name = mc_model_checker->process().read( - (std::uint64_t)(synchro->mbox ? &synchro->mbox->name : &synchro->mbox_cpy->name)); + (std::uint64_t)(synchro->mbox ? &synchro->mbox->name_ : &synchro->mbox_cpy->name_)); pattern->rdv = mc_model_checker->process().read_string(remote_name); pattern->src_proc = mc_model_checker->process().resolveActor(simgrid::mc::remote(synchro->src_proc))->pid; pattern->src_host = MC_smx_actor_get_host_name(issuer); - struct s_smpi_mpi_request mpi_request = - mc_model_checker->process().read( - (std::uint64_t) simcall_comm_isend__get__data(request)); - pattern->tag = mpi_request.tag; + simgrid::smpi::Request mpi_request = + mc_model_checker->process().read((std::uint64_t)simcall_comm_isend__get__data(request)); + pattern->tag = mpi_request.tag(); - if (synchro->src_buff != nullptr){ + if (synchro->src_buff != nullptr) { pattern->data.resize(synchro->src_buff_size); - mc_model_checker->process().read_bytes( - pattern->data.data(), pattern->data.size(), - remote(synchro->src_buff)); + mc_model_checker->process().read_bytes(pattern->data.data(), pattern->data.size(), remote(synchro->src_buff)); } - if(mpi_request.detached){ + if(mpi_request.detached()){ if (!this->initial_communications_pattern_done) { /* Store comm pattern */ - simgrid::mc::PatternCommunicationList* list = xbt_dynar_get_as( - initial_communications_pattern, pattern->src_proc, - simgrid::mc::PatternCommunicationList*); + simgrid::mc::PatternCommunicationList* list = + xbt_dynar_get_as(initial_communications_pattern, pattern->src_proc, simgrid::mc::PatternCommunicationList*); list->list.push_back(std::move(pattern)); } else { /* Evaluate comm determinism */ this->deterministic_comm_pattern(pattern->src_proc, pattern.get(), backtracking); - xbt_dynar_get_as( - initial_communications_pattern, pattern->src_proc, simgrid::mc::PatternCommunicationList* - )->index_comm++; + xbt_dynar_get_as(initial_communications_pattern, pattern->src_proc, simgrid::mc::PatternCommunicationList*) + ->index_comm++; } return; } @@ -235,37 +226,33 @@ void CommunicationDeterminismChecker::get_comm_pattern(xbt_dynar_t list, smx_sim pattern->type = simgrid::mc::PatternCommunicationType::receive; pattern->comm_addr = simcall_comm_irecv__get__result(request); - struct s_smpi_mpi_request mpi_request; - mc_model_checker->process().read( - &mpi_request, remote((struct s_smpi_mpi_request*)simcall_comm_irecv__get__data(request))); - pattern->tag = mpi_request.tag; + simgrid::smpi::Request mpi_request; + mc_model_checker->process().read(&mpi_request, + remote((simgrid::smpi::Request*)simcall_comm_irecv__get__data(request))); + pattern->tag = mpi_request.tag(); simgrid::mc::Remote temp_comm; - mc_model_checker->process().read(temp_comm, remote( - static_cast(pattern->comm_addr))); + mc_model_checker->process().read(temp_comm, + remote(static_cast(pattern->comm_addr))); simgrid::kernel::activity::Comm* comm = temp_comm.getBuffer(); char* remote_name; - mc_model_checker->process().read(&remote_name, - remote(comm->mbox ? &comm->mbox->name : &comm->mbox_cpy->name)); + mc_model_checker->process().read(&remote_name, remote(comm->mbox ? &comm->mbox->name_ : &comm->mbox_cpy->name_)); pattern->rdv = mc_model_checker->process().read_string(remote_name); pattern->dst_proc = mc_model_checker->process().resolveActor(simgrid::mc::remote(comm->dst_proc))->pid; pattern->dst_host = MC_smx_actor_get_host_name(issuer); } else xbt_die("Unexpected call_type %i", (int) call_type); - XBT_DEBUG("Insert incomplete comm pattern %p for process %lu", - pattern.get(), issuer->pid); - xbt_dynar_t dynar = - xbt_dynar_get_as(incomplete_communications_pattern, issuer->pid, xbt_dynar_t); + XBT_DEBUG("Insert incomplete comm pattern %p for process %lu", pattern.get(), issuer->pid); + xbt_dynar_t dynar = xbt_dynar_get_as(incomplete_communications_pattern, issuer->pid, xbt_dynar_t); simgrid::mc::PatternCommunication* pattern2 = pattern.release(); xbt_dynar_push(dynar, &pattern2); } - void CommunicationDeterminismChecker::complete_comm_pattern( - xbt_dynar_t list, simgrid::mc::RemotePtr comm_addr, - unsigned int issuer, int backtracking) + xbt_dynar_t list, simgrid::mc::RemotePtr comm_addr, unsigned int issuer, + int backtracking) { simgrid::mc::PatternCommunication* current_comm_pattern; unsigned int cursor = 0; @@ -278,9 +265,7 @@ void CommunicationDeterminismChecker::complete_comm_pattern( update_comm_pattern(current_comm_pattern, comm_addr); completed = 1; simgrid::mc::PatternCommunication* temp; - xbt_dynar_remove_at( - xbt_dynar_get_as(incomplete_communications_pattern, issuer, xbt_dynar_t), - cursor, &temp); + xbt_dynar_remove_at(xbt_dynar_get_as(incomplete_communications_pattern, issuer, xbt_dynar_t), cursor, &temp); comm_pattern = std::unique_ptr(temp); XBT_DEBUG("Remove incomplete comm pattern for process %u at cursor %u", issuer, cursor); break; @@ -289,8 +274,8 @@ void CommunicationDeterminismChecker::complete_comm_pattern( if(!completed) xbt_die("Corresponding communication not found!"); - simgrid::mc::PatternCommunicationList* pattern = xbt_dynar_get_as( - initial_communications_pattern, issuer, simgrid::mc::PatternCommunicationList*); + simgrid::mc::PatternCommunicationList* pattern = + xbt_dynar_get_as(initial_communications_pattern, issuer, simgrid::mc::PatternCommunicationList*); if (!this->initial_communications_pattern_done) /* Store comm pattern */ @@ -302,16 +287,11 @@ void CommunicationDeterminismChecker::complete_comm_pattern( } } -CommunicationDeterminismChecker::CommunicationDeterminismChecker(Session& session) - : Checker(session) +CommunicationDeterminismChecker::CommunicationDeterminismChecker(Session& session) : Checker(session) { - } -CommunicationDeterminismChecker::~CommunicationDeterminismChecker() -{ - -} +CommunicationDeterminismChecker::~CommunicationDeterminismChecker() = default; RecordTrace CommunicationDeterminismChecker::getRecordTrace() // override { @@ -327,8 +307,8 @@ std::vector CommunicationDeterminismChecker::getTextualTrace() // o for (auto const& state : stack_) { smx_simcall_t req = &state->executed_req; if (req) - trace.push_back(simgrid::mc::request_to_string( - req, state->transition.argument, simgrid::mc::RequestType::executed)); + trace.push_back( + simgrid::mc::request_to_string(req, state->transition.argument, simgrid::mc::RequestType::executed)); } return trace; } @@ -336,16 +316,12 @@ std::vector CommunicationDeterminismChecker::getTextualTrace() // o void CommunicationDeterminismChecker::logState() // override { Checker::logState(); - if (_sg_mc_comms_determinism && - !this->recv_deterministic && - this->send_deterministic) { + if (_sg_mc_comms_determinism && !this->recv_deterministic && this->send_deterministic) { XBT_INFO("******************************************************"); XBT_INFO("**** Only-send-deterministic communication pattern ****"); XBT_INFO("******************************************************"); XBT_INFO("%s", this->recv_diff); - } else if(_sg_mc_comms_determinism && - !this->send_deterministic && - this->recv_deterministic) { + } else if (_sg_mc_comms_determinism && !this->send_deterministic && this->recv_deterministic) { XBT_INFO("******************************************************"); XBT_INFO("**** Only-recv-deterministic communication pattern ****"); XBT_INFO("******************************************************"); @@ -356,26 +332,23 @@ void CommunicationDeterminismChecker::logState() // override XBT_INFO("Executed transitions = %lu", mc_model_checker->executed_transitions); XBT_INFO("Send-deterministic : %s", !this->send_deterministic ? "No" : "Yes"); if (_sg_mc_comms_determinism) - XBT_INFO("Recv-deterministic : %s", - !this->recv_deterministic ? "No" : "Yes"); + XBT_INFO("Recv-deterministic : %s", !this->recv_deterministic ? "No" : "Yes"); } void CommunicationDeterminismChecker::prepare() { - - int i; const int maxpid = MC_smx_get_maxpid(); // Create initial_communications_pattern elements: initial_communications_pattern = simgrid::xbt::newDeleteDynar(); - for (i=0; i < maxpid; i++){ + for (int i = 0; i < maxpid; i++) { simgrid::mc::PatternCommunicationList* process_list_pattern = new simgrid::mc::PatternCommunicationList(); xbt_dynar_insert_at(initial_communications_pattern, i, &process_list_pattern); } // Create incomplete_communications_pattern elements: incomplete_communications_pattern = xbt_dynar_new(sizeof(xbt_dynar_t), xbt_dynar_free_voidp); - for (i=0; i < maxpid; i++){ + for (int i = 0; i < maxpid; i++) { xbt_dynar_t process_pattern = xbt_dynar_new(sizeof(simgrid::mc::PatternCommunication*), nullptr); xbt_dynar_insert_at(incomplete_communications_pattern, i, &process_pattern); } @@ -393,8 +366,7 @@ void CommunicationDeterminismChecker::prepare() stack_.push_back(std::move(initial_state)); } -static inline -bool all_communications_are_finished() +static inline bool all_communications_are_finished() { for (size_t current_actor = 1; current_actor < MC_smx_get_maxpid(); current_actor++) { xbt_dynar_t pattern = xbt_dynar_get_as(incomplete_communications_pattern, current_actor, xbt_dynar_t); @@ -409,13 +381,11 @@ bool all_communications_are_finished() void CommunicationDeterminismChecker::restoreState() { /* Intermediate backtracking */ - { - simgrid::mc::State* state = stack_.back().get(); - if (state->system_state) { - simgrid::mc::restore_snapshot(state->system_state); - MC_restore_communications_pattern(state); - return; - } + simgrid::mc::State* state = stack_.back().get(); + if (state->system_state) { + simgrid::mc::restore_snapshot(state->system_state); + MC_restore_communications_pattern(state); + return; } /* Restore the initial state */ @@ -457,33 +427,28 @@ void CommunicationDeterminismChecker::restoreState() } } -int CommunicationDeterminismChecker::main(void) +void CommunicationDeterminismChecker::main(void) { std::unique_ptr visited_state = nullptr; smx_simcall_t req = nullptr; while (!stack_.empty()) { - /* Get current state */ simgrid::mc::State* state = stack_.back().get(); XBT_DEBUG("**************************************************"); - XBT_DEBUG("Exploration depth = %zi (state = %d, interleaved processes = %zd)", - stack_.size(), state->num, + XBT_DEBUG("Exploration depth = %zi (state = %d, interleaved processes = %zd)", stack_.size(), state->num, state->interleaveSize()); /* Update statistics */ mc_model_checker->visited_states++; - if (stack_.size() <= (std::size_t) _sg_mc_max_depth - && (req = MC_state_get_request(state)) != nullptr - && (visited_state == nullptr)) { + if (stack_.size() <= (std::size_t)_sg_mc_max_depth && (req = MC_state_get_request(state)) != nullptr && + (visited_state == nullptr)) { int req_num = state->transition.argument; - XBT_DEBUG("Execute: %s", - simgrid::mc::request_to_string( - req, req_num, simgrid::mc::RequestType::simix).c_str()); + XBT_DEBUG("Execute: %s", simgrid::mc::request_to_string(req, req_num, simgrid::mc::RequestType::simix).c_str()); std::string req_str; if (dot_output != nullptr) @@ -512,16 +477,14 @@ int CommunicationDeterminismChecker::main(void) std::unique_ptr next_state = std::unique_ptr(new simgrid::mc::State(++expandedStatesCount_)); - /* If comm determinism verification, we cannot stop the exploration if - some communications are not finished (at least, data are transferred). - These communications are incomplete and they cannot be analyzed and - compared with the initial pattern. */ - bool compare_snapshots = all_communications_are_finished() - && this->initial_communications_pattern_done; + /* If comm determinism verification, we cannot stop the exploration if some communications are not finished (at + * least, data are transferred). These communications are incomplete and they cannot be analyzed and compared + * with the initial pattern. */ + bool compare_snapshots = all_communications_are_finished() && this->initial_communications_pattern_done; - if (_sg_mc_visited == 0 - || (visited_state = visitedStates_.addVisitedState( - expandedStatesCount_, next_state.get(), compare_snapshots)) == nullptr) { + if (_sg_mc_max_visited_states == 0 || + (visited_state = visitedStates_.addVisitedState(expandedStatesCount_, next_state.get(), compare_snapshots)) == + nullptr) { /* Get enabled actors and insert them in the interleave set of the next state */ for (auto& actor : mc_model_checker->process().actors()) @@ -533,8 +496,8 @@ int CommunicationDeterminismChecker::main(void) state->num, next_state->num, req_str.c_str()); } else if (dot_output != nullptr) - fprintf(dot_output, "\"%d\" -> \"%d\" [%s];\n", - state->num, visited_state->other_num == -1 ? visited_state->num : visited_state->other_num, req_str.c_str()); + fprintf(dot_output, "\"%d\" -> \"%d\" [%s];\n", state->num, + visited_state->original_num == -1 ? visited_state->num : visited_state->original_num, req_str.c_str()); stack_.push_back(std::move(next_state)); @@ -543,17 +506,16 @@ int CommunicationDeterminismChecker::main(void) if (stack_.size() > (std::size_t) _sg_mc_max_depth) XBT_WARN("/!\\ Max depth reached ! /!\\ "); else if (visited_state != nullptr) - XBT_DEBUG("State already visited (equal to state %d), exploration stopped on this path.", visited_state->other_num == -1 ? visited_state->num : visited_state->other_num); + XBT_DEBUG("State already visited (equal to state %d), exploration stopped on this path.", + visited_state->original_num == -1 ? visited_state->num : visited_state->original_num); else - XBT_DEBUG("There are no more processes to interleave. (depth %zi)", - stack_.size()); + XBT_DEBUG("There are no more processes to interleave. (depth %zi)", stack_.size()); if (!this->initial_communications_pattern_done) this->initial_communications_pattern_done = 1; /* Trash the current state, no longer needed */ - XBT_DEBUG("Delete state %d at depth %zi", - state->num, stack_.size()); + XBT_DEBUG("Delete state %d at depth %zi", state->num, stack_.size()); stack_.pop_back(); visited_state = nullptr; @@ -561,52 +523,40 @@ int CommunicationDeterminismChecker::main(void) /* Check for deadlocks */ if (mc_model_checker->checkDeadlock()) { MC_show_deadlock(); - return SIMGRID_MC_EXIT_DEADLOCK; + throw new simgrid::mc::DeadlockError(); } while (!stack_.empty()) { std::unique_ptr state = std::move(stack_.back()); stack_.pop_back(); - if (state->interleaveSize() - && stack_.size() < (std::size_t) _sg_mc_max_depth) { + if (state->interleaveSize() && stack_.size() < (std::size_t)_sg_mc_max_depth) { /* We found a back-tracking point, let's loop */ - XBT_DEBUG("Back-tracking to state %d at depth %zi", - state->num, stack_.size() + 1); + XBT_DEBUG("Back-tracking to state %d at depth %zi", state->num, stack_.size() + 1); stack_.push_back(std::move(state)); this->restoreState(); - XBT_DEBUG("Back-tracking to state %d at depth %zi done", - stack_.back()->num, stack_.size()); + XBT_DEBUG("Back-tracking to state %d at depth %zi done", stack_.back()->num, stack_.size()); break; } else { - XBT_DEBUG("Delete state %d at depth %zi", - state->num, stack_.size() + 1); + XBT_DEBUG("Delete state %d at depth %zi", state->num, stack_.size() + 1); } } } } simgrid::mc::session->logState(); - return SIMGRID_MC_EXIT_SUCCESS; } -int CommunicationDeterminismChecker::run() +void CommunicationDeterminismChecker::run() { XBT_INFO("Check communication determinism"); simgrid::mc::session->initialize(); this->prepare(); - this->initial_communications_pattern_done = 0; - this->recv_deterministic = 1; - this->send_deterministic = 1; - this->recv_diff = nullptr; - this->send_diff = nullptr; - - int res = this->main(); - return res; + this->main(); } Checker* createCommunicationDeterminismChecker(Session& session)