X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/bd6274487954af16de90c357090e2d698d886cd1..f3507930c130404d05f982cf9fe960fb95f7eb4b:/src/xbt/dict.c?ds=sidebyside diff --git a/src/xbt/dict.c b/src/xbt/dict.c index c28171f432..378bdbf9ac 100644 --- a/src/xbt/dict.c +++ b/src/xbt/dict.c @@ -8,14 +8,23 @@ * under the terms of the license (GNU LGPL) which comes with this package. */ #include +#include #include "xbt/ex.h" #include "xbt/log.h" +#include "xbt/mallocator.h" +#include "xbt_modinter.h" #include "dict_private.h" XBT_LOG_NEW_DEFAULT_SUBCATEGORY(xbt_dict,xbt, "Dictionaries provide the same functionnalities than hash tables"); /*####[ Private prototypes ]#################################################*/ +static xbt_mallocator_t dict_mallocator = NULL; +static void* dict_mallocator_new_f(void); +static void dict_mallocator_free_f(void* dict); +static void dict_mallocator_reset_f(void* dict); + + /*####[ Code ]###############################################################*/ /** @@ -36,14 +45,23 @@ xbt_dict_t xbt_dict_new(void) { * \see xbt_dict_new(), xbt_dict_free() */ xbt_dict_t xbt_dict_new_ext(int hashsize) { - int i; - xbt_dict_t dict = xbt_new0(s_xbt_dict_t, 1); + xbt_dict_t dict; + + if (dict_mallocator == NULL) { + /* first run */ + dict_mallocator = xbt_mallocator_new(256, + dict_mallocator_new_f, + dict_mallocator_free_f, + dict_mallocator_reset_f); + dict_elm_mallocator = xbt_mallocator_new(256, + dict_elm_mallocator_new_f, + dict_elm_mallocator_free_f, + dict_elm_mallocator_reset_f); + } + + dict = xbt_mallocator_get(dict_mallocator); dict->table_size = hashsize; dict->table = xbt_new0(xbt_dictelm_t, dict->table_size); - - for (i = 0; i < hashsize; i++) { - dict->table[i] = NULL; - } dict->count = 0; return dict; @@ -58,17 +76,22 @@ xbt_dict_t xbt_dict_new_ext(int hashsize) { void xbt_dict_free(xbt_dict_t *dict) { int i; xbt_dictelm_t current, previous; + int table_size; + xbt_dictelm_t *table; + if (dict != NULL && *dict != NULL) { - for (i = 0; i < (*dict)->table_size; i++) { - current = (*dict)->table[i]; + table_size = (*dict)->table_size; + table = (*dict)->table; + for (i = 0; i < table_size; i++) { + current = table[i]; while (current != NULL) { previous = current; current = current->next; xbt_dictelm_free(previous); } } - xbt_free((*dict)->table); - xbt_free(*dict); + xbt_free(table); + xbt_mallocator_release(dict_mallocator, *dict); *dict = NULL; } } @@ -105,12 +128,25 @@ void xbt_dict_hashsize_set(xbt_dict_t dict, int hashsize) { /** * Returns the hash code of a string. */ -unsigned int xbt_dict_hash(const char *str) { +static unsigned int xbt_dict_hash_ext(const char *str, int str_len) { /* fast implementation of djb2 algorithm */ unsigned int hash = 5381; int c; - while ((c = *str++)) { + while (str_len--) { + c = *str++; + hash = ((hash << 5) + hash) + c; /* hash * 33 + c */ + } + + return hash; +} + +static unsigned int xbt_dict_hash(const char *str) { + /* fast implementation of djb2 algorithm */ + unsigned int hash = 5381; + int c; + + while ( (c = *str++) ) { hash = ((hash << 5) + hash) + c; /* hash * 33 + c */ } @@ -129,15 +165,17 @@ unsigned int xbt_dict_hash(const char *str) { * Set the \a data in the structure under the \a key, which can be any kind * of data, as long as its length is provided in \a key_len. */ -void xbt_dict_set_ext(xbt_dict_t dict, +void xbt_dict_set_ext(xbt_dict_t dict, const char *key, int key_len, void *data, - void_f_pvoid_t *free_ctn) { - xbt_assert(dict); + void_f_pvoid_t free_ctn) { - unsigned int hash_code = xbt_dict_hash(key) % dict->table_size; + unsigned int hash_code; xbt_dictelm_t current, previous = NULL; + xbt_assert(dict); + + hash_code = xbt_dict_hash_ext(key,key_len) % dict->table_size; current = dict->table[hash_code]; while (current != NULL && @@ -179,10 +217,10 @@ void xbt_dict_set_ext(xbt_dict_t dict, * set the \a data in the structure under the \a key, which is a * null terminated string. */ -void xbt_dict_set(xbt_dict_t dict, +void xbt_dict_set(xbt_dict_t dict, const char *key, void *data, - void_f_pvoid_t *free_ctn) { + void_f_pvoid_t free_ctn) { xbt_assert(dict); @@ -202,11 +240,15 @@ void xbt_dict_set(xbt_dict_t dict, void *xbt_dict_get_ext(xbt_dict_t dict, const char *key, int key_len) { - xbt_assert(dict); - unsigned int hash_code = xbt_dict_hash(key) % dict->table_size; + + unsigned int hash_code; xbt_dictelm_t current; + xbt_assert(dict); + + hash_code = xbt_dict_hash_ext(key,key_len) % dict->table_size; + current = dict->table[hash_code]; while (current != NULL && (key_len != current->key_len || strncmp(key, current->key, key_len))) { @@ -233,11 +275,15 @@ void *xbt_dict_get_ext(xbt_dict_t dict, */ void *xbt_dict_get(xbt_dict_t dict, const char *key) { - xbt_assert(dict); - unsigned int hash_code = xbt_dict_hash(key) % dict->table_size; + + unsigned int hash_code ; xbt_dictelm_t current; + xbt_assert(dict); + + hash_code = xbt_dict_hash(key) % dict->table_size; + current = dict->table[hash_code]; while (current != NULL && (strcmp(key, current->key))) { current = current->next; @@ -255,17 +301,22 @@ void *xbt_dict_get(xbt_dict_t dict, */ void *xbt_dict_get_or_null(xbt_dict_t dict, const char *key) { - xbt_ex_t e; - void *result = NULL; - TRY { - result = xbt_dict_get(dict, key); - } CATCH(e) { - if (e.category != not_found_error) - RETHROW; - xbt_ex_free(e); - result = NULL; + unsigned int hash_code ; + xbt_dictelm_t current; + + xbt_assert(dict); + + hash_code = xbt_dict_hash(key) % dict->table_size; + + current = dict->table[hash_code]; + while (current != NULL && (strcmp(key, current->key))) { + current = current->next; } - return result; + + if (current == NULL) + return NULL; + + return current->content; } @@ -281,11 +332,15 @@ void *xbt_dict_get_or_null(xbt_dict_t dict, void xbt_dict_remove_ext(xbt_dict_t dict, const char *key, int key_len) { - xbt_assert(dict); - unsigned int hash_code = xbt_dict_hash(key) % dict->table_size; + + unsigned int hash_code ; xbt_dictelm_t current, previous = NULL; + xbt_assert(dict); + + hash_code = xbt_dict_hash_ext(key,key_len) % dict->table_size; + current = dict->table[hash_code]; while (current != NULL && (key_len != current->key_len || strncmp(key, current->key, key_len))) { @@ -329,10 +384,16 @@ void xbt_dict_remove(xbt_dict_t dict, * \param dict the dict */ void xbt_dict_reset(xbt_dict_t dict) { - xbt_assert(dict); + int i; xbt_dictelm_t current, previous = NULL; + + xbt_assert(dict); + + if (dict->count == 0) + return; + for (i = 0; i < dict->table_size; i++) { current = dict->table[i]; while (current != NULL) { @@ -360,9 +421,13 @@ int xbt_dict_length(xbt_dict_t dict) { * Add an already mallocated element to a dictionary. */ void xbt_dict_add_element(xbt_dict_t dict, xbt_dictelm_t element) { - xbt_assert(dict); - int hashcode = xbt_dict_hash(element->key) % dict->table_size; + + int hashcode; + + xbt_assert(dict); + + hashcode = xbt_dict_hash_ext(element->key,element->key_len) % dict->table_size; element->next = dict->table[hashcode]; dict->table[hashcode] = element; } @@ -378,7 +443,7 @@ void xbt_dict_add_element(xbt_dict_t dict, xbt_dictelm_t element) { */ void xbt_dict_dump(xbt_dict_t dict, - void_f_pvoid_t *output) { + void_f_pvoid_t output) { int i; xbt_dictelm_t element; printf("Dict %p:\n", dict); @@ -388,7 +453,7 @@ void xbt_dict_dump(xbt_dict_t dict, while (element != NULL) { printf("%s -> ", element->key); if (output != NULL) { - output(element->content); + (*output)(element->content); } printf("\n"); element = element->next; @@ -397,6 +462,33 @@ void xbt_dict_dump(xbt_dict_t dict, } } +/** + * Destroy the dict mallocators. + * This is an internal XBT function called by xbt_exit(). + */ +void xbt_dict_exit(void) { + if (dict_mallocator != NULL) { + xbt_mallocator_free(dict_mallocator); + dict_mallocator = NULL; + xbt_mallocator_free(dict_elm_mallocator); + dict_elm_mallocator = NULL; + } +} + +static void* dict_mallocator_new_f(void) { + return xbt_new(s_xbt_dict_t, 1); +} + +static void dict_mallocator_free_f(void* dict) { + xbt_free(dict); +} + +static void dict_mallocator_reset_f(void* dict) { + /* nothing to do because all fields are + * initialized in xbt_dict_new + */ +} + #ifdef SIMGRID_TEST #include "xbt.h" #include "xbt/ex.h" @@ -411,11 +503,10 @@ static void print_str(void *str) { printf("%s",(char*)PRINTF_STR(str)); } -static void debuged_add(xbt_dict_t head,const char*key) -{ - char *data=xbt_strdup(key); +static void debuged_add_ext(xbt_dict_t head,const char*key,const char*data_to_fill) { + char *data=xbt_strdup(data_to_fill); - xbt_test_log1("Add %s",PRINTF_STR(key)); + xbt_test_log2("Add %s under %s",PRINTF_STR(data_to_fill),PRINTF_STR(key)); xbt_dict_set(head,key,data,&free); if (XBT_LOG_ISENABLED(xbt_dict,xbt_log_priority_debug)) { @@ -423,6 +514,9 @@ static void debuged_add(xbt_dict_t head,const char*key) fflush(stdout); } } +static void debuged_add(xbt_dict_t head,const char*key) { + debuged_add_ext(head,key,key); +} static void fill(xbt_dict_t *head) { xbt_test_add0("Fill in the dictionnary"); @@ -439,14 +533,21 @@ static void fill(xbt_dict_t *head) { debuged_add(*head,"123457"); } -static void search(xbt_dict_t head,const char*key) { - void *data; + +static void search_ext(xbt_dict_t head,const char*key, const char *data) { + void *found; xbt_test_add1("Search %s",key); - data=xbt_dict_get(head,key); - xbt_test_log1("Found %s",(char *)data); + found=xbt_dict_get(head,key); + xbt_test_log1("Found %s",(char *)found); if (data) - xbt_test_assert0(!strcmp((char*)data,key),"Key and data do not match"); + xbt_test_assert1(found,"data do not match expectations: found NULL while searching for %s",data); + if (found) + xbt_test_assert2(!strcmp((char*)data,found),"data do not match expectations: found %s while searching for %s", (char*)found, data); +} + +static void search(xbt_dict_t head,const char*key) { + search_ext(head,key,key); } static void debuged_remove(xbt_dict_t head,const char*key) { @@ -470,18 +571,21 @@ static void traverse(xbt_dict_t head) { } static void search_not_found(xbt_dict_t head, const char *data) { + int ok=0; xbt_ex_t e; xbt_test_add1("Search %s (expected not to be found)",data); TRY { - data = xbt_dict_get(head,"Can't be found"); + data = xbt_dict_get(head, data); THROW1(unknown_error,0,"Found something which shouldn't be there (%s)",data); } CATCH(e) { if (e.category != not_found_error) xbt_test_exception(e); xbt_ex_free(e); + ok=1; } + xbt_test_assert0(ok,"Exception not raised"); } static void count(xbt_dict_t dict, int length) { @@ -495,12 +599,28 @@ char *data; XBT_TEST_UNIT("basic",test_dict_basic,"Basic usage: change, retrieve, traverse"){ - xbt_test_add0("Traversal the empty dictionnary"); + xbt_test_add0("Traversal the null dictionnary"); + traverse(head); + + xbt_test_add0("Traversal and search the empty dictionnary"); + head = xbt_dict_new(); traverse(head); + TRY { + debuged_remove(head,"12346"); + } CATCH(e) { + if (e.category != not_found_error) + xbt_test_exception(e); + xbt_ex_free(e); + } + xbt_dict_free(&head); xbt_test_add0("Traverse the full dictionnary"); fill(&head); count(head, 7); + + debuged_add_ext(head,"toto","tutu"); + search_ext(head,"toto","tutu"); + debuged_remove(head,"toto"); search(head,"12a"); traverse(head); @@ -622,7 +742,7 @@ XBT_TEST_UNIT("nulldata",test_dict_nulldata,"NULL data management"){ xbt_test_add0("Store NULL under 'null'"); xbt_dict_set(head,"null",NULL,NULL); - search(head,"null"); + search_ext(head,"null",NULL); xbt_test_add0("Check whether I see it while traversing..."); { @@ -668,7 +788,7 @@ XBT_TEST_UNIT("crash",test_dict_crash,"Crash test"){ for (i=0;i<10;i++) { head=xbt_dict_new(); - // if (i%10) printf("."); else printf("%d",i/10); fflush(stdout); + /* if (i%10) printf("."); else printf("%d",i/10); fflush(stdout); */ nb=0; for (j=0;j<1000;j++) { key=xbt_malloc(SIZEOFKEY); @@ -691,7 +811,7 @@ XBT_TEST_UNIT("crash",test_dict_crash,"Crash test"){ head=xbt_dict_new(); xbt_test_add1("Fill %d elements, with keys being the number of element",NB_ELM); for (j=0;j