X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/bd568bd51e676d804576f658d2b3ecc1c0330bbb..3fc07005abb54bbceec067c73455b50f96e5d908:/src/surf/xml/surfxml_sax_cb.cpp diff --git a/src/surf/xml/surfxml_sax_cb.cpp b/src/surf/xml/surfxml_sax_cb.cpp index 9ba84302f7..d42e4297b3 100644 --- a/src/surf/xml/surfxml_sax_cb.cpp +++ b/src/surf/xml/surfxml_sax_cb.cpp @@ -20,16 +20,15 @@ #include "src/surf/xml/platf_private.hpp" -XBT_LOG_NEW_DEFAULT_SUBCATEGORY(surf_parse, surf, - "Logging specific to the SURF parsing module"); +XBT_LOG_NEW_DEFAULT_SUBCATEGORY(surf_parse, surf, "Logging specific to the SURF parsing module"); #undef CLEANUP int ETag_surfxml_include_state(void); #include "simgrid_dtd.c" -char* surf_parsed_filename = NULL; // to locate parse error messages +char* surf_parsed_filename = nullptr; // to locate parse error messages -xbt_dynar_t parsed_link_list = NULL; /* temporary store of current list link of a route */ +xbt_dynar_t parsed_link_list = nullptr; /* temporary store of current list link of a route */ /* * Helping functions */ @@ -87,8 +86,7 @@ struct unit_scale { double scale; }; -/* Note: field `unit' for the last element of parameter `units' should be - * NULL. */ +/* Note: field `unit' for the last element of parameter `units' should be nullptr. */ static double surf_parse_get_value_with_unit(const char *string, const struct unit_scale *units, const char *entity_kind, const char *name, const char *error_msg, const char *default_unit) @@ -109,9 +107,9 @@ static double surf_parse_get_value_with_unit(const char *string, const struct un XBT_WARN("Deprecated unit-less value '%s' for %s %s. %s",string, entity_kind, name, error_msg); ptr = (char*)default_unit; } - for (i = 0; units[i].unit != NULL && strcmp(ptr, units[i].unit) != 0; i++) { + for (i = 0; units[i].unit != nullptr && strcmp(ptr, units[i].unit) != 0; i++) { } - if (units[i].unit != NULL) + if (units[i].unit != nullptr) res *= units[i].scale; else surf_parse_error("unknown unit: %s", ptr); @@ -130,7 +128,7 @@ double surf_parse_get_time(const char *string, const char *entity_kind, const ch { "us", 1e-6 }, { "ns", 1e-9 }, { "ps", 1e-12 }, - { NULL, 0 } + { nullptr, 0 } }; return surf_parse_get_value_with_unit(string, units, entity_kind, name, "Append 's' to your time to get seconds", "s"); @@ -157,7 +155,7 @@ double surf_parse_get_size(const char *string, const char *entity_kind, const ch { "Mb", 0.125 * 1e6 }, { "kb", 0.125 * 1e3 }, { "b", 0.125 }, - { NULL, 0 } + { nullptr, 0 } }; return surf_parse_get_value_with_unit(string, units, entity_kind, name, "Append 'B' to get bytes (or 'b' for bits but 1B = 8b).", "B"); @@ -184,7 +182,7 @@ double surf_parse_get_bandwidth(const char *string, const char *entity_kind, con { "Mbps", 0.125 * 1e6 }, { "kbps", 0.125 * 1e3 }, { "bps", 0.125 }, - { NULL, 0 } + { nullptr, 0 } }; return surf_parse_get_value_with_unit(string, units, entity_kind, name, "Append 'Bps' to get bytes per second (or 'bps' for bits but 1Bps = 8bps)", "Bps"); @@ -211,7 +209,7 @@ double surf_parse_get_speed(const char *string, const char *entity_kind, const c { "kf", 1e3 }, { "flops", 1.0 }, { "f", 1.0 }, - { NULL, 0 } + { nullptr, 0 } }; return surf_parse_get_value_with_unit(string, units, entity_kind, name, "Append 'f' or 'flops' to your speed to get flop per second", "f"); @@ -225,9 +223,9 @@ double surf_parse_get_speed(const char *string, const char *entity_kind, const c /* make sure these symbols are defined as strong ones in this file so that the linker can resolve them */ /* The default current property receiver. Setup in the corresponding opening callbacks. */ -xbt_dict_t current_property_set = NULL; -xbt_dict_t current_model_property_set = NULL; -xbt_dict_t as_current_property_set = NULL; +xbt_dict_t current_property_set = nullptr; +xbt_dict_t current_model_property_set = nullptr; +xbt_dict_t as_current_property_set = nullptr; int AS_TAG = 0; char* as_name_tab[1024]; void* as_dict_tab[1024]; @@ -235,10 +233,10 @@ int as_prop_nb = 0; /* dictionary of random generator data */ -xbt_dict_t random_data_list = NULL; +xbt_dict_t random_data_list = nullptr; YY_BUFFER_STATE surf_input_buffer; -FILE *surf_file_to_parse = NULL; +FILE *surf_file_to_parse = nullptr; /* * Stuff relative to storage @@ -247,11 +245,11 @@ void STag_surfxml_storage(void) { AS_TAG = 0; XBT_DEBUG("STag_surfxml_storage"); - xbt_assert(current_property_set == NULL, "Someone forgot to reset the property set to NULL in its closing tag (or XML malformed)"); + xbt_assert(current_property_set == nullptr, "Someone forgot to reset the property set to nullptr in its closing tag (or XML malformed)"); } void ETag_surfxml_storage(void) { - s_sg_platf_storage_cbarg_t storage = SG_PLATF_STORAGE_INITIALIZER; + s_sg_platf_storage_cbarg_t storage; memset(&storage,0,sizeof(storage)); storage.id = A_surfxml_storage_id; @@ -261,18 +259,18 @@ void ETag_surfxml_storage(void) storage.properties = current_property_set; storage.attach = A_surfxml_storage_attach; sg_platf_new_storage(&storage); - current_property_set = NULL; + current_property_set = nullptr; } void STag_surfxml_storage___type(void) { AS_TAG = 0; XBT_DEBUG("STag_surfxml_storage___type"); - xbt_assert(current_property_set == NULL, "Someone forgot to reset the property set to NULL in its closing tag (or XML malformed)"); - xbt_assert(current_model_property_set == NULL, "Someone forgot to reset the model property set to NULL in its closing tag (or XML malformed)"); + xbt_assert(current_property_set == nullptr, "Someone forgot to reset the property set to nullptr in its closing tag (or XML malformed)"); + xbt_assert(current_model_property_set == nullptr, "Someone forgot to reset the model property set to nullptr in its closing tag (or XML malformed)"); } void ETag_surfxml_storage___type(void) { - s_sg_platf_storage_type_cbarg_t storage_type = SG_PLATF_STORAGE_TYPE_INITIALIZER; + s_sg_platf_storage_type_cbarg_t storage_type; memset(&storage_type,0,sizeof(storage_type)); storage_type.content = A_surfxml_storage___type_content; @@ -284,21 +282,8 @@ void ETag_surfxml_storage___type(void) storage_type.size = surf_parse_get_size(A_surfxml_storage___type_size, "size of storage type", storage_type.id); sg_platf_new_storage_type(&storage_type); - current_property_set = NULL; - current_model_property_set = NULL; -} -void STag_surfxml_mstorage(void) -{ - XBT_DEBUG("STag_surfxml_mstorage"); -} -void ETag_surfxml_mstorage(void) -{ - s_sg_platf_mstorage_cbarg_t mstorage = SG_PLATF_MSTORAGE_INITIALIZER; - memset(&mstorage,0,sizeof(mstorage)); - - mstorage.name = A_surfxml_mstorage_name; - mstorage.type_id = A_surfxml_mstorage_typeId; - sg_platf_new_mstorage(&mstorage); + current_property_set = nullptr; + current_model_property_set = nullptr; } void STag_surfxml_mount(void) { @@ -306,7 +291,7 @@ void STag_surfxml_mount(void) } void ETag_surfxml_mount(void) { - s_sg_platf_mount_cbarg_t mount = SG_PLATF_MOUNT_INITIALIZER; + s_sg_platf_mount_cbarg_t mount; memset(&mount,0,sizeof(mount)); mount.name = A_surfxml_mount_name; @@ -317,9 +302,9 @@ void ETag_surfxml_mount(void) /* * Stuff relative to the tag */ -static xbt_dynar_t surf_input_buffer_stack = NULL; -static xbt_dynar_t surf_file_to_parse_stack = NULL; -static xbt_dynar_t surf_parsed_filename_stack = NULL; +static xbt_dynar_t surf_input_buffer_stack = nullptr; +static xbt_dynar_t surf_file_to_parse_stack = nullptr; +static xbt_dynar_t surf_parsed_filename_stack = nullptr; void STag_surfxml_include(void) { @@ -337,7 +322,7 @@ void STag_surfxml_include(void) surf_input_buffer = surf_parse__create_buffer(surf_file_to_parse, YY_BUF_SIZE); surf_parse_push_buffer_state(surf_input_buffer); - fflush(NULL); + fflush(nullptr); } void ETag_surfxml_include(void) { @@ -358,7 +343,7 @@ void ETag_surfxml_include(void) { */ int ETag_surfxml_include_state(void) { - fflush(NULL); + fflush(nullptr); XBT_DEBUG("ETag_surfxml_include_state '%s'",A_surfxml_include_file); if(xbt_dynar_is_empty(surf_input_buffer_stack)) // nope, that's a true premature EOF. Let the parser die verbosely. @@ -420,12 +405,12 @@ void ETag_surfxml_platform(void){ void STag_surfxml_host(void){ AS_TAG = 0; - xbt_assert(current_property_set == NULL, "Someone forgot to reset the property set to NULL in its closing tag (or XML malformed)"); + xbt_assert(current_property_set == nullptr, "Someone forgot to reset the property set to nullptr in its closing tag (or XML malformed)"); } void STag_surfxml_prop(void) { - if(AS_TAG){ + if(AS_TAG){ // We need a stack here to retrieve the most recently opened AS if (!as_current_property_set){ xbt_assert(as_prop_nb < 1024, "Number of AS property reach the limit!!!"); as_current_property_set = xbt_dict_new_homogeneous(xbt_free_f); // Maybe, it should raise an error @@ -435,7 +420,7 @@ void STag_surfxml_prop(void) as_prop_nb++; } XBT_DEBUG("add prop %s=%s into current AS property set", A_surfxml_prop_id, A_surfxml_prop_value); - xbt_dict_set(as_current_property_set, A_surfxml_prop_id, xbt_strdup(A_surfxml_prop_value), NULL); + xbt_dict_set(as_current_property_set, A_surfxml_prop_id, xbt_strdup(A_surfxml_prop_value), nullptr); } else{ if (!current_property_set) @@ -446,9 +431,9 @@ void STag_surfxml_prop(void) } void ETag_surfxml_host(void) { - s_sg_platf_host_cbarg_t host = SG_PLATF_HOST_INITIALIZER; - char* buf; + s_sg_platf_host_cbarg_t host; memset(&host,0,sizeof(host)); + char* buf; host.properties = current_property_set; @@ -457,22 +442,19 @@ void ETag_surfxml_host(void) { buf = A_surfxml_host_speed; XBT_DEBUG("Buffer: %s", buf); - host.speed_peak = xbt_dynar_new(sizeof(double), NULL); - if (strchr(buf, ',') == NULL){ + host.speed_per_pstate = xbt_dynar_new(sizeof(double), nullptr); + if (strchr(buf, ',') == nullptr){ double speed = surf_parse_get_speed(A_surfxml_host_speed,"speed of host", host.id); - xbt_dynar_push_as(host.speed_peak,double, speed); + xbt_dynar_push_as(host.speed_per_pstate,double, speed); } else { xbt_dynar_t pstate_list = xbt_str_split(buf, ","); unsigned int i; - for (i = 0; i < xbt_dynar_length(pstate_list); i++) { - double speed; - char* speed_str; - - xbt_dynar_get_cpy(pstate_list, i, &speed_str); - xbt_str_trim(speed_str, NULL); - speed = surf_parse_get_speed(speed_str,"speed of host", host.id); - xbt_dynar_push_as(host.speed_peak, double, speed); + char* speed_str; + xbt_dynar_foreach(pstate_list, i, speed_str) { + xbt_str_trim(speed_str, nullptr); + double speed = surf_parse_get_speed(speed_str,"speed of host", host.id); + xbt_dynar_push_as(host.speed_per_pstate, double, speed); XBT_DEBUG("Speed value: %f", speed); } xbt_dynar_free(&pstate_list); @@ -480,19 +462,19 @@ void ETag_surfxml_host(void) { XBT_DEBUG("pstate: %s", A_surfxml_host_pstate); host.core_amount = surf_parse_get_int(A_surfxml_host_core); - host.speed_trace = tmgr_trace_new_from_file(A_surfxml_host_availability___file); - host.state_trace = tmgr_trace_new_from_file(A_surfxml_host_state___file); + host.speed_trace = A_surfxml_host_availability___file[0] ? tmgr_trace_new_from_file(A_surfxml_host_availability___file) : nullptr; + host.state_trace = A_surfxml_host_state___file[0] ? tmgr_trace_new_from_file(A_surfxml_host_state___file) : nullptr; host.pstate = surf_parse_get_int(A_surfxml_host_pstate); host.coord = A_surfxml_host_coordinates; sg_platf_new_host(&host); - xbt_dynar_free(&host.speed_peak); - current_property_set = NULL; + xbt_dynar_free(&host.speed_per_pstate); + current_property_set = nullptr; } void STag_surfxml_host___link(void){ XBT_DEBUG("Create a Host_link for %s",A_surfxml_host___link_id); - s_sg_platf_host_link_cbarg_t host_link = SG_PLATF_HOST_LINK_INITIALIZER; + s_sg_platf_host_link_cbarg_t host_link; memset(&host_link,0,sizeof(host_link)); host_link.id = A_surfxml_host___link_id; @@ -502,7 +484,7 @@ void STag_surfxml_host___link(void){ } void STag_surfxml_router(void){ - s_sg_platf_router_cbarg_t router = SG_PLATF_ROUTER_INITIALIZER; + s_sg_platf_router_cbarg_t router; memset(&router, 0, sizeof(router)); router.id = A_surfxml_router_id; @@ -512,7 +494,7 @@ void STag_surfxml_router(void){ } void ETag_surfxml_cluster(void){ - s_sg_platf_cluster_cbarg_t cluster = SG_PLATF_CLUSTER_INITIALIZER; + s_sg_platf_cluster_cbarg_t cluster; memset(&cluster,0,sizeof(cluster)); cluster.properties = as_current_property_set; @@ -545,6 +527,9 @@ void ETag_surfxml_cluster(void){ case A_surfxml_cluster_topology_FAT___TREE: cluster.topology = SURF_CLUSTER_FAT_TREE; break; + case A_surfxml_cluster_topology_DRAGONFLY: + cluster.topology= SURF_CLUSTER_DRAGONFLY ; + break; default: surf_parse_error("Invalid cluster topology for cluster %s", cluster.id); @@ -581,21 +566,19 @@ void ETag_surfxml_cluster(void){ break; } - cluster.availability_trace = A_surfxml_cluster_availability___file; - cluster.state_trace = A_surfxml_cluster_state___file; sg_platf_new_cluster(&cluster); - current_property_set = NULL; + current_property_set = nullptr; } void STag_surfxml_cluster(void){ parse_after_config(); - xbt_assert(current_property_set == NULL, "Someone forgot to reset the property set to NULL in its closing tag (or XML malformed)"); + xbt_assert(current_property_set == nullptr, "Someone forgot to reset the property set to nullptr in its closing tag (or XML malformed)"); } void STag_surfxml_cabinet(void){ parse_after_config(); - s_sg_platf_cabinet_cbarg_t cabinet = SG_PLATF_CABINET_INITIALIZER; + s_sg_platf_cabinet_cbarg_t cabinet; memset(&cabinet,0,sizeof(cabinet)); cabinet.id = A_surfxml_cabinet_id; cabinet.prefix = A_surfxml_cabinet_prefix; @@ -610,7 +593,7 @@ void STag_surfxml_cabinet(void){ void STag_surfxml_peer(void){ parse_after_config(); - s_sg_platf_peer_cbarg_t peer = SG_PLATF_PEER_INITIALIZER; + s_sg_platf_peer_cbarg_t peer; memset(&peer,0,sizeof(peer)); peer.id = A_surfxml_peer_id; peer.speed = surf_parse_get_speed(A_surfxml_peer_speed, "speed of peer", peer.id); @@ -618,28 +601,28 @@ void STag_surfxml_peer(void){ peer.bw_out = surf_parse_get_bandwidth(A_surfxml_peer_bw___out, "bw_out of peer", peer.id); peer.lat = surf_parse_get_time(A_surfxml_peer_lat, "lat of peer", peer.id); peer.coord = A_surfxml_peer_coordinates; - peer.availability_trace = tmgr_trace_new_from_file(A_surfxml_peer_availability___file); - peer.state_trace = tmgr_trace_new_from_file(A_surfxml_peer_state___file); + peer.availability_trace = A_surfxml_peer_availability___file[0] ? tmgr_trace_new_from_file(A_surfxml_peer_availability___file) : nullptr; + peer.state_trace = A_surfxml_peer_state___file[0] ? tmgr_trace_new_from_file(A_surfxml_peer_state___file) : nullptr; sg_platf_new_peer(&peer); } void STag_surfxml_link(void){ AS_TAG = 0; - xbt_assert(current_property_set == NULL, "Someone forgot to reset the property set to NULL in its closing tag (or XML malformed)"); + xbt_assert(current_property_set == nullptr, "Someone forgot to reset the property set to nullptr in its closing tag (or XML malformed)"); } void ETag_surfxml_link(void){ - s_sg_platf_link_cbarg_t link = SG_PLATF_LINK_INITIALIZER; + s_sg_platf_link_cbarg_t link; memset(&link,0,sizeof(link)); link.properties = current_property_set; link.id = A_surfxml_link_id; link.bandwidth = surf_parse_get_bandwidth(A_surfxml_link_bandwidth, "bandwidth of link", link.id); - link.bandwidth_trace = tmgr_trace_new_from_file(A_surfxml_link_bandwidth___file); + link.bandwidth_trace = A_surfxml_link_bandwidth___file[0] ? tmgr_trace_new_from_file(A_surfxml_link_bandwidth___file) : nullptr; link.latency = surf_parse_get_time(A_surfxml_link_latency, "latency of link", link.id); - link.latency_trace = tmgr_trace_new_from_file(A_surfxml_link_latency___file); - link.state_trace = tmgr_trace_new_from_file(A_surfxml_link_state___file); + link.latency_trace = A_surfxml_link_latency___file[0] ? tmgr_trace_new_from_file(A_surfxml_link_latency___file) : nullptr; + link.state_trace = A_surfxml_link_state___file[0] ? tmgr_trace_new_from_file(A_surfxml_link_state___file):nullptr; switch (A_surfxml_link_sharing___policy) { case A_surfxml_link_sharing___policy_SHARED: @@ -658,7 +641,7 @@ void ETag_surfxml_link(void){ sg_platf_new_link(&link); - current_property_set = NULL; + current_property_set = nullptr; } void STag_surfxml_link___ctn(void){ @@ -683,11 +666,10 @@ void STag_surfxml_link___ctn(void){ } void ETag_surfxml_backbone(void){ - s_sg_platf_link_cbarg_t link = SG_PLATF_LINK_INITIALIZER; + s_sg_platf_link_cbarg_t link; memset(&link,0,sizeof(link)); - link.properties = NULL; - + link.properties = nullptr; link.id = A_surfxml_backbone_id; link.bandwidth = surf_parse_get_bandwidth(A_surfxml_backbone_bandwidth, "bandwidth of backbone", link.id); link.latency = surf_parse_get_time(A_surfxml_backbone_latency, "latency of backbone", link.id); @@ -745,11 +727,13 @@ void ETag_surfxml_route(void){ s_sg_platf_route_cbarg_t route; memset(&route,0,sizeof(route)); - route.src = A_surfxml_route_src; - route.dst = A_surfxml_route_dst; - route.gw_src = NULL; - route.gw_dst = NULL; + + route.src = sg_netcard_by_name_or_null(A_surfxml_route_src); // tested to not be NULL in start tag + route.dst = sg_netcard_by_name_or_null(A_surfxml_route_dst); // tested to not be NULL in start tag + route.gw_src = nullptr; + route.gw_dst = nullptr; route.link_list = new std::vector(); + route.symmetrical = (A_surfxml_route_symmetrical == A_surfxml_route_symmetrical_YES); unsigned int cpt; char *link_name; @@ -758,37 +742,20 @@ void ETag_surfxml_route(void){ route.link_list->push_back(link); } - - switch (A_surfxml_route_symmetrical) { - case AU_surfxml_route_symmetrical: - case A_surfxml_route_symmetrical_YES: - route.symmetrical = TRUE; - break; - case A_surfxml_route_symmetrical_NO: - route.symmetrical = FALSE;; - break; - } - sg_platf_new_route(&route); - parsed_link_list = NULL; + delete route.link_list; + xbt_dynar_free(&parsed_link_list); } void ETag_surfxml_ASroute(void){ s_sg_platf_route_cbarg_t ASroute; memset(&ASroute,0,sizeof(ASroute)); - ASroute.src = A_surfxml_ASroute_src; - ASroute.dst = A_surfxml_ASroute_dst; - - ASroute.gw_src = sg_netcard_by_name_or_null(A_surfxml_ASroute_gw___src); - ASroute.gw_dst = sg_netcard_by_name_or_null(A_surfxml_ASroute_gw___dst); + ASroute.src = sg_netcard_by_name_or_null(A_surfxml_ASroute_src); // tested to not be NULL in start tag + ASroute.dst = sg_netcard_by_name_or_null(A_surfxml_ASroute_dst); // tested to not be NULL in start tag - if (A_surfxml_ASroute_gw___src && !ASroute.gw_src) - surf_parse_error("gw_src=\"%s\" not found for ASroute from \"%s\" to \"%s\"", - A_surfxml_ASroute_gw___src, ASroute.src, ASroute.dst); - if (A_surfxml_ASroute_gw___dst && !ASroute.gw_dst) - surf_parse_error("gw_dst=\"%s\" not found for ASroute from \"%s\" to \"%s\"", - A_surfxml_ASroute_gw___dst, ASroute.src, ASroute.dst); + ASroute.gw_src = sg_netcard_by_name_or_null(A_surfxml_ASroute_gw___src); // tested to not be NULL in start tag + ASroute.gw_dst = sg_netcard_by_name_or_null(A_surfxml_ASroute_gw___dst); // tested to not be NULL in start tag ASroute.link_list = new std::vector(); @@ -798,30 +765,31 @@ void ETag_surfxml_ASroute(void){ simgrid::surf::Link *link = Link::byName(link_name); ASroute.link_list->push_back(link); } + xbt_dynar_free(&parsed_link_list); switch (A_surfxml_ASroute_symmetrical) { case AU_surfxml_ASroute_symmetrical: case A_surfxml_ASroute_symmetrical_YES: - ASroute.symmetrical = TRUE; + ASroute.symmetrical = true; break; case A_surfxml_ASroute_symmetrical_NO: - ASroute.symmetrical = FALSE; + ASroute.symmetrical = false; break; } sg_platf_new_route(&ASroute); - parsed_link_list = NULL; + delete ASroute.link_list; } void ETag_surfxml_bypassRoute(void){ s_sg_platf_route_cbarg_t route; memset(&route,0,sizeof(route)); - route.src = A_surfxml_bypassRoute_src; - route.dst = A_surfxml_bypassRoute_dst; - route.gw_src = NULL; - route.gw_dst = NULL; - route.symmetrical = FALSE; + route.src = sg_netcard_by_name_or_null(A_surfxml_bypassRoute_src); // tested to not be NULL in start tag + route.dst = sg_netcard_by_name_or_null(A_surfxml_bypassRoute_dst); // tested to not be NULL in start tag + route.gw_src = nullptr; + route.gw_dst = nullptr; + route.symmetrical = false; route.link_list = new std::vector(); unsigned int cpt; @@ -839,9 +807,9 @@ void ETag_surfxml_bypassASroute(void){ s_sg_platf_route_cbarg_t ASroute; memset(&ASroute,0,sizeof(ASroute)); - ASroute.src = A_surfxml_bypassASroute_src; - ASroute.dst = A_surfxml_bypassASroute_dst; - ASroute.link_list = new std::vector(); + ASroute.src = sg_netcard_by_name_or_null(A_surfxml_bypassASroute_src); + ASroute.dst = sg_netcard_by_name_or_null(A_surfxml_bypassASroute_dst); + ASroute.link_list = new std::vector(); unsigned int cpt; char *link_name; xbt_dynar_foreach(parsed_link_list, cpt, link_name) { @@ -849,7 +817,7 @@ void ETag_surfxml_bypassASroute(void){ ASroute.link_list->push_back(link); } xbt_dynar_free(&parsed_link_list); - ASroute.symmetrical = FALSE; + ASroute.symmetrical = false; ASroute.gw_src = sg_netcard_by_name_or_null(A_surfxml_bypassASroute_gw___src); ASroute.gw_dst = sg_netcard_by_name_or_null(A_surfxml_bypassASroute_gw___dst); @@ -858,7 +826,7 @@ void ETag_surfxml_bypassASroute(void){ } void ETag_surfxml_trace(void){ - s_sg_platf_trace_cbarg_t trace = SG_PLATF_TRACE_INITIALIZER; + s_sg_platf_trace_cbarg_t trace; memset(&trace,0,sizeof(trace)); trace.id = A_surfxml_trace_id; @@ -871,7 +839,7 @@ void ETag_surfxml_trace(void){ void STag_surfxml_trace___connect(void){ parse_after_config(); - s_sg_platf_trace_connect_cbarg_t trace_connect = SG_PLATF_TRACE_CONNECT_INITIALIZER; + s_sg_platf_trace_connect_cbarg_t trace_connect; memset(&trace_connect,0,sizeof(trace_connect)); trace_connect.element = A_surfxml_trace___connect_element; @@ -901,11 +869,9 @@ void STag_surfxml_trace___connect(void){ void STag_surfxml_AS(void){ parse_after_config(); AS_TAG = 1; - s_sg_platf_AS_cbarg_t AS = SG_PLATF_AS_INITIALIZER; - AS.id = A_surfxml_AS_id; - AS.routing = (int)A_surfxml_AS_routing; + s_sg_platf_AS_cbarg_t AS = { A_surfxml_AS_id, (int)A_surfxml_AS_routing}; - as_current_property_set = NULL; + as_current_property_set = nullptr; sg_platf_new_AS_begin(&AS); } @@ -915,32 +881,29 @@ void ETag_surfxml_AS(void){ xbt_dict_t dict = (xbt_dict_t) as_dict_tab[as_prop_nb-1]; as_prop_nb--; XBT_DEBUG("POP prop %p for AS '%s'",dict,name); - xbt_lib_set(as_router_lib, - name, - ROUTING_PROP_ASR_LEVEL, - dict); + xbt_lib_set(as_router_lib, name, ROUTING_PROP_ASR_LEVEL, dict); xbt_free(name); } - sg_platf_new_AS_end(); + sg_platf_new_AS_seal(); } void STag_surfxml_config(void){ AS_TAG = 0; - xbt_assert(current_property_set == NULL, "Someone forgot to reset the property set to NULL in its closing tag (or XML malformed)"); + xbt_assert(current_property_set == nullptr, "Someone forgot to reset the property set to nullptr in its closing tag (or XML malformed)"); XBT_DEBUG("START configuration name = %s",A_surfxml_config_id); if (_sg_cfg_init_status == 2) { surf_parse_error("All tags must be given before any platform elements (such as , , , , etc)."); } } void ETag_surfxml_config(void){ - xbt_dict_cursor_t cursor = NULL; + xbt_dict_cursor_t cursor = nullptr; char *key; char *elem; char *cfg; xbt_dict_foreach(current_property_set, cursor, key, elem) { cfg = bprintf("%s:%s",key,elem); - if(xbt_cfg_is_default_value(_sg_cfg_set, key)) - xbt_cfg_set_parse(_sg_cfg_set, cfg); + if(xbt_cfg_is_default_value(key)) + xbt_cfg_set_parse(cfg); else XBT_INFO("The custom configuration '%s' is already defined by user!",key); free(cfg); @@ -948,7 +911,7 @@ void ETag_surfxml_config(void){ XBT_DEBUG("End configuration name = %s",A_surfxml_config_id); xbt_dict_free(¤t_property_set); - current_property_set = NULL; + current_property_set = nullptr; } static int argc; @@ -959,11 +922,11 @@ void STag_surfxml_process(void){ argc = 1; argv = xbt_new(char *, 1); argv[0] = xbt_strdup(A_surfxml_process_function); - xbt_assert(current_property_set == NULL, "Someone forgot to reset the property set to NULL in its closing tag (or XML malformed)"); + xbt_assert(current_property_set == nullptr, "Someone forgot to reset the property set to nullptr in its closing tag (or XML malformed)"); } void ETag_surfxml_process(void){ - s_sg_platf_process_cbarg_t process = SG_PLATF_PROCESS_INITIALIZER; + s_sg_platf_process_cbarg_t process; memset(&process,0,sizeof(process)); process.argc = argc; @@ -985,7 +948,13 @@ void ETag_surfxml_process(void){ } sg_platf_new_process(&process); - current_property_set = NULL; + + for (int i = 0; i != argc; ++i) + xbt_free(argv[i]); + xbt_free(argv); + argv = nullptr; + + current_property_set = nullptr; } void STag_surfxml_argument(void){ @@ -998,12 +967,9 @@ void STag_surfxml_model___prop(void){ if (!current_model_property_set) current_model_property_set = xbt_dict_new_homogeneous(xbt_free_f); - xbt_dict_set(current_model_property_set, A_surfxml_model___prop_id, xbt_strdup(A_surfxml_model___prop_value), NULL); + xbt_dict_set(current_model_property_set, A_surfxml_model___prop_id, xbt_strdup(A_surfxml_model___prop_value), nullptr); } -void STag_surfxml_gpu(void) {} -void ETag_surfxml_gpu(void) {} - /* nothing to do in those functions */ void ETag_surfxml_prop(void){} void STag_surfxml_random(void){} @@ -1023,21 +989,12 @@ void ETag_surfxml_model___prop(void){} void surf_parse_open(const char *file) { - static int warned = 0; /* warn only once */ - if (!file) { - if (!warned) { - XBT_WARN - ("Bypassing the XML parser since surf_parse_open received a NULL pointer. " - "If it is not what you want, go fix your code."); - warned = 1; - } - return; - } + xbt_assert(file, "Cannot parse the nullptr file. Bypassing the parser is strongly deprecated nowadays."); if (!surf_input_buffer_stack) - surf_input_buffer_stack = xbt_dynar_new(sizeof(YY_BUFFER_STATE), NULL); + surf_input_buffer_stack = xbt_dynar_new(sizeof(YY_BUFFER_STATE), nullptr); if (!surf_file_to_parse_stack) - surf_file_to_parse_stack = xbt_dynar_new(sizeof(FILE *), NULL); + surf_file_to_parse_stack = xbt_dynar_new(sizeof(FILE *), nullptr); if (!surf_parsed_filename_stack) surf_parsed_filename_stack = xbt_dynar_new(sizeof(char *), &xbt_free_ref); @@ -1059,18 +1016,18 @@ void surf_parse_close(void) xbt_dynar_free(&surf_file_to_parse_stack); xbt_dynar_free(&surf_parsed_filename_stack); if (surf_parsed_filename) { - char *dir = NULL; + char *dir = nullptr; xbt_dynar_pop(surf_path, &dir); free(dir); } free(surf_parsed_filename); - surf_parsed_filename = NULL; + surf_parsed_filename = nullptr; if (surf_file_to_parse) { surf_parse__delete_buffer(surf_input_buffer); fclose(surf_file_to_parse); - surf_file_to_parse = NULL; //Must be reset for Bypass + surf_file_to_parse = nullptr; //Must be reset for Bypass } }