X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/b1dfbcb15b4a2b87a06482ebaebd9f1951af3d43..a8c24434f1950151325aff16e98b10e62ff33f99:/doc/msg-tuto-src/masterworker0.c

diff --git a/doc/msg-tuto-src/masterworker0.c b/doc/msg-tuto-src/masterworker0.c
index 918a59711e..e20b2eba06 100644
--- a/doc/msg-tuto-src/masterworker0.c
+++ b/doc/msg-tuto-src/masterworker0.c
@@ -1,10 +1,9 @@
-/* Copyright (c) 2007-2010, 2013-2015. The SimGrid Team.
- * All rights reserved.                                                     */
+/* Copyright (c) 2007-2017. The SimGrid Team. All rights reserved.          */
 
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
 
-#include "simgrid/msg.h"            /* Yeah! If you want to use msg, you need to include simgrid/msg.h */
+#include "simgrid/msg.h"
 
 XBT_LOG_NEW_DEFAULT_CATEGORY(msg_test, "Messages specific for this msg example");
 
@@ -13,41 +12,32 @@ XBT_LOG_NEW_DEFAULT_CATEGORY(msg_test, "Messages specific for this msg example")
 /** Master expects 3+ arguments given in the XML deployment file: */
 static int master(int argc, char *argv[])
 {
-  int workers_count = 0;
-  msg_host_t *workers = NULL;
-  msg_task_t *todo = NULL;
-
-  int i;
-
   long number_of_tasks = xbt_str_parse_int(argv[1], "Invalid amount of tasks: %s");    /** - Number of tasks      */
   double comp_size = xbt_str_parse_double(argv[2], "Invalid computational size: %s");  /** - Task compute cost    */
   double comm_size = xbt_str_parse_double(argv[3], "Invalid communication size: %s");  /** - Task communication size */
 
-  {                             /*  Task creation */
-    char sprintf_buffer[64];
-
-    todo = xbt_new0(msg_task_t, number_of_tasks);
+  /* Create the tasks in advance */
+  msg_task_t* todo = xbt_new0(msg_task_t, number_of_tasks);
 
-    for (i = 0; i < number_of_tasks; i++) {
-      sprintf(sprintf_buffer, "Task_%d", i);
-      todo[i] =  MSG_task_create(sprintf_buffer, task_comp_size, task_comm_size, NULL);
-    }
+  for (int i = 0; i < number_of_tasks; i++) {
+    char sprintf_buffer[64];
+    sprintf(sprintf_buffer, "Task_%d", i);
+    todo[i] = MSG_task_create(sprintf_buffer, comp_size, comm_size, NULL);
   }
 
-  {                             /* Process organization */
-    workers_count = argc - 4;
-    workers = xbt_new0(msg_host_t, workers_count);
+  /* Get the info about the worker processes from my parameters */
+  int workers_count   = argc - 4;
+  msg_host_t* workers = xbt_new0(msg_host_t, workers_count);
 
-    for (i = 4; i < argc; i++) {
-      workers[i - 4] = MSG_get_host_by_name(argv[i]);
-      xbt_assert(workers[i - 4] != NULL, "Unknown host %s. Stopping Now! ", argv[i]);
-    }
+  for (int i = 4; i < argc; i++) {
+    workers[i - 4] = MSG_get_host_by_name(argv[i]);
+    xbt_assert(workers[i - 4] != NULL, "Unknown host %s. Stopping Now! ", argv[i]);
   }
-
   XBT_INFO("Got %d workers and %ld tasks to process", workers_count, number_of_tasks);
 
-  for (i = 0; i < number_of_tasks; i++) {
-    XBT_INFO("Sending \"%s\" to \"%s\"", todo[i]->name, MSG_host_get_name(workers[i % workers_count]));
+  /* Dispatch the tasks */
+  for (int i = 0; i < number_of_tasks; i++) {
+    XBT_INFO("Sending '%s' to '%s'", todo[i]->name, MSG_host_get_name(workers[i % workers_count]));
     if (MSG_host_self() == workers[i % workers_count]) {
       XBT_INFO("Hey ! It's me ! :)");
     }
@@ -57,7 +47,7 @@ static int master(int argc, char *argv[])
   }
 
   XBT_INFO("All tasks have been dispatched. Let's tell everybody the computation is over.");
-  for (i = 0; i < workers_count; i++) {
+  for (int i = 0; i < workers_count; i++) {
     msg_task_t finalize = MSG_task_create("finalize", 0, 0, FINALIZE);
     MSG_task_send(finalize, MSG_host_get_name(workers[i]));
   }
@@ -66,18 +56,17 @@ static int master(int argc, char *argv[])
   free(workers);
   free(todo);
   return 0;
-}                               /* end_of_master */
+}
 
 /** Worker expects a single argument given in the XML deployment file: */
 static int worker(int argc, char *argv[])
 {
-  msg_task_t task = NULL;
-  XBT_ATTRIB_UNUSED int res;
   while (1) {
-    res = MSG_task_receive(&(task),MSG_host_get_name(MSG_host_self()));
+    msg_task_t task = NULL;
+    int res         = MSG_task_receive(&(task), MSG_host_get_name(MSG_host_self()));
     xbt_assert(res == MSG_OK, "MSG_task_receive failed");
 
-    XBT_INFO("Received \"%s\"", MSG_task_get_name(task));
+    XBT_INFO("Received '%s'", MSG_task_get_name(task));
     if (!strcmp(MSG_task_get_name(task), "finalize")) {
       MSG_task_destroy(task);
       break;
@@ -85,9 +74,8 @@ static int worker(int argc, char *argv[])
 
     XBT_INFO("Processing \"%s\"", MSG_task_get_name(task));
     MSG_task_execute(task);
-    XBT_INFO("\"%s\" done", MSG_task_get_name(task));
+    XBT_INFO("'%s' done", MSG_task_get_name(task));
     MSG_task_destroy(task);
-    task = NULL;
   }
   XBT_INFO("I'm done. See you!");
   return 0;
@@ -96,20 +84,21 @@ static int worker(int argc, char *argv[])
 /** Main function */
 int main(int argc, char *argv[])
 {
-  msg_error_t res = MSG_OK;
 
   MSG_init(&argc, argv);
   xbt_assert(argc > 2, "Usage: %s platform_file deployment_file\n"
              "\tExample: %s msg_platform.xml msg_deployment.xml\n", argv[0], argv[0]);
-  {                             /*  Simulation setting */
-    MSG_create_environment(argv[1]);
-  }
-  {                             /*   Application deployment */
-    MSG_function_register("master", master);
-    MSG_function_register("worker", worker);
-    MSG_launch_application(argv[2]);
-  }
-  res = MSG_main();
+
+  /*  Create a simulated platform */
+  MSG_create_environment(argv[1]);
+
+  /*   Application deployment */
+  MSG_function_register("master", master);
+  MSG_function_register("worker", worker);
+  MSG_launch_application(argv[2]);
+
+  /* Run the simulation */
+  msg_error_t res = MSG_main();
 
   XBT_INFO("Simulation time %g", MSG_get_clock());
   return (res != MSG_OK);