X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/a9361ff5f9057e93ed0bbdfac0eab6e5ba8aeab8..6a5dd57f29dc1312869e80dfd4869c47d0b9e2eb:/src/simdag/sd_global.cpp

diff --git a/src/simdag/sd_global.cpp b/src/simdag/sd_global.cpp
index 38a5852596..b0f93dbfe1 100644
--- a/src/simdag/sd_global.cpp
+++ b/src/simdag/sd_global.cpp
@@ -4,11 +4,12 @@
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
 
-#include "simgrid/sg_config.h"
+#include "simdag_private.hpp"
 #include "simgrid/host.h"
-#include "src/surf/surf_interface.hpp"
 #include "simgrid/s4u/engine.hpp"
-#include "simdag_private.hpp"
+#include "simgrid/sg_config.h"
+#include "src/include/instr/instr_interface.h"
+#include "src/surf/surf_interface.hpp"
 
 XBT_LOG_NEW_CATEGORY(sd, "Logging specific to SimDag");
 XBT_LOG_NEW_DEFAULT_SUBCATEGORY(sd_kernel, sd, "Logging specific to SimDag (kernel)");
@@ -55,7 +56,7 @@ std::set<SD_task_t>* simulate(double how_long){
       total_time += elapsed_time;
 
     /* let's see which tasks are done */
-    for (auto model : *all_existing_models) {
+    for (const auto& model : *all_existing_models) {
       surf_action_t action = surf_model_extract_done_action_set(model);
       while (action != nullptr) {
         SD_task_t task = static_cast<SD_task_t>(action->getData());
@@ -67,7 +68,7 @@ std::set<SD_task_t>* simulate(double how_long){
           sd_global->return_set->insert(task);
 
         /* remove the dependencies after this task */
-        for (auto succ : *task->successors) {
+        for (const auto& succ : *task->successors) {
           succ->predecessors->erase(task);
           succ->inputs->erase(task);
           XBT_DEBUG("Release dependency on %s: %zu remain(s). Becomes schedulable if %zu=0", SD_task_get_name(succ),
@@ -84,7 +85,7 @@ std::set<SD_task_t>* simulate(double how_long){
         }
         task->successors->clear();
 
-        for (auto output : *task->outputs) {
+        for (const auto& output : *task->outputs) {
           output->start_time = task->finish_time;
           output->predecessors->erase(task);
           if (SD_task_get_state(output) == SD_SCHEDULED)
@@ -119,7 +120,7 @@ std::set<SD_task_t>* simulate(double how_long){
 
   if (!sd_global->watch_point_reached && how_long < 0 && !sd_global->initial_tasks->empty()) {
     XBT_WARN("Simulation is finished but %zu tasks are still not done", sd_global->initial_tasks->size());
-    for (auto t : *sd_global->initial_tasks)
+    for (const auto& t : *sd_global->initial_tasks)
       XBT_WARN("%s is in %s state", SD_task_get_name(t), __get_state_name(SD_task_get_state(t)));
   }
 
@@ -227,7 +228,7 @@ void SD_create_environment(const char *platform_file)
 xbt_dynar_t SD_simulate(double how_long) {
   std::set<SD_task_t> *changed_tasks = simgrid::sd::simulate(how_long);
   xbt_dynar_t changed_tasks_dynar = xbt_dynar_new(sizeof(SD_task_t), nullptr);
-  for (auto task: *changed_tasks)
+  for (const auto& task : *changed_tasks)
     xbt_dynar_push(changed_tasks_dynar, &task);
   return changed_tasks_dynar;
 }
@@ -244,6 +245,7 @@ double SD_get_clock() {
  */
 void SD_exit()
 {
+  TRACE_end();
 #if HAVE_JEDULE
   jedule_sd_exit();
 #endif