X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/a5c5765ba9e8336b55101d248a8f43fbf9cd0c0c..21a680050fb52ee9a91716b5fe8aca4ca96e16e5:/src/xbt/backtrace_linux.cpp diff --git a/src/xbt/backtrace_linux.cpp b/src/xbt/backtrace_linux.cpp index 80cd509da3..7cde5e37c2 100644 --- a/src/xbt/backtrace_linux.cpp +++ b/src/xbt/backtrace_linux.cpp @@ -1,12 +1,13 @@ /* backtrace_linux - backtrace displaying on linux platform */ /* This file is included by ex.cpp on need (have execinfo.h, popen & addrline)*/ -/* Copyright (c) 2008-2016. The SimGrid Team. - * All rights reserved. */ +/* Copyright (c) 2008-2017. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ +#include +#include #include #include #include @@ -21,12 +22,10 @@ #include #include #include "xbt/ex.h" -#include "src/xbt/ex_interface.h" #include "xbt/log.h" -#include "xbt/str.h" #include "xbt/module.h" /* xbt_binary_name */ #include "src/xbt_modinter.h" /* backtrace initialization headers */ -#if HAVE_MC +#if SIMGRID_HAVE_MC #define UNW_LOCAL_ONLY #include #endif @@ -34,25 +33,16 @@ extern char **environ; /* the environment, as specified by the opengroup */ -/* Module creation/destruction: nothing to do on linux */ -void xbt_backtrace_preinit(void) -{ -} - -void xbt_backtrace_postexit(void) -{ -} - #include struct trace_arg { - void **array; - int cnt, size; + void** array; + int cnt; + int size; }; -static _Unwind_Reason_Code -backtrace_helper (struct _Unwind_Context *ctx, void *a) +static _Unwind_Reason_Code backtrace_helper(_Unwind_Context* ctx, void* a) { - struct trace_arg *arg = (struct trace_arg *) a; + trace_arg* arg = static_cast(a); /* We are first called with address in the __backtrace function. Skip it. */ @@ -71,14 +61,14 @@ backtrace_helper (struct _Unwind_Context *ctx, void *a) /** @brief reimplementation of glibc backtrace based directly on gcc library, without implicit malloc * - * See http://webloria.loria.fr/~quinson/blog/2012/0208/system_programming_fun_in_SimGrid/ + * See http://people.irisa.fr/Martin.Quinson/blog/2012/0208/system_programming_fun_in_SimGrid/ * for the motivation behind this function * */ int xbt_backtrace_no_malloc(void **array, int size) { int i = 0; for(i=0; i < size; i++) - array[i] = NULL; + array[i] = nullptr; struct trace_arg arg; arg .array = array; @@ -88,9 +78,9 @@ int xbt_backtrace_no_malloc(void **array, int size) { if (size >= 1) _Unwind_Backtrace(backtrace_helper, &arg); - /* _Unwind_Backtrace on IA-64 seems to put NULL address above + /* _Unwind_Backtrace on IA-64 seems to put nullptr address above _start. Fix it up here. */ - if (arg.cnt > 1 && arg.array[arg.cnt - 1] == NULL) + if (arg.cnt > 1 && arg.array[arg.cnt - 1] == nullptr) --arg.cnt; return arg.cnt != -1 ? arg.cnt : 0; } @@ -167,7 +157,7 @@ std::vector resolveBacktrace( if (binary_name.empty()) { for (std::size_t i = 0; i < count; i++) result.push_back(simgrid::xbt::string_printf("%p", loc[i])); - return std::move(result); + return result; } // Create the system command for add2line: @@ -176,7 +166,7 @@ std::vector resolveBacktrace( std::vector addrs(count); for (std::size_t i = 0; i < count; i++) { /* retrieve this address */ - XBT_DEBUG("Retrieving address number %zd from '%s'", i, backtrace_syms[i]); + XBT_DEBUG("Retrieving address number %zu from '%s'", i, backtrace_syms[i]); char buff[256]; snprintf(buff, 256, "%s", strchr(backtrace_syms[i], '[') + 1); char* p = strchr(buff, ']'); @@ -185,7 +175,7 @@ std::vector resolveBacktrace( addrs[i] = buff; else addrs[i] = "0x0"; - XBT_DEBUG("Set up a new address: %zd, '%s'", i, addrs[i].c_str()); + XBT_DEBUG("Set up a new address: %zu, '%s'", i, addrs[i].c_str()); /* Add it to the command line args */ stream << addrs[i] << ' '; } @@ -196,24 +186,25 @@ std::vector resolveBacktrace( XBT_VERB("Fire a first command: '%s'", cmd.c_str()); FILE* pipe = popen(cmd.c_str(), "r"); - if (!pipe) { + if (not pipe) { xbt_die("Cannot fork addr2line to display the backtrace"); } /* To read the output of addr2line */ - char line_func[1024], line_pos[1024]; + char line_func[1024]; + char line_pos[1024]; for (std::size_t i = 0; i < count; i++) { - XBT_DEBUG("Looking for symbol %zd, addr = '%s'", i, addrs[i].c_str()); + XBT_DEBUG("Looking for symbol %zu, addr = '%s'", i, addrs[i].c_str()); if (fgets(line_func, 1024, pipe)) { line_func[strlen(line_func) - 1] = '\0'; } else { - XBT_VERB("Cannot run fgets to look for symbol %zd, addr %s", i, addrs[i].c_str()); + XBT_VERB("Cannot run fgets to look for symbol %zu, addr %s", i, addrs[i].c_str()); strncpy(line_func, "???",3); } if (fgets(line_pos, 1024, pipe)) { line_pos[strlen(line_pos) - 1] = '\0'; } else { - XBT_VERB("Cannot run fgets to look for symbol %zd, addr %s", i, addrs[i].c_str()); + XBT_VERB("Cannot run fgets to look for symbol %zu, addr %s", i, addrs[i].c_str()); strncpy(line_pos, backtrace_syms[i],1024); } @@ -227,26 +218,28 @@ std::vector resolveBacktrace( /* Damn. The symbol is in a dynamic library. Let's get wild */ char maps_buff[512]; - long int offset = 0; - char *p, *p2; + unsigned long int offset = 0; + char* p; int found = 0; /* let's look for the offset of this library in our addressing space */ - char* maps_name = bprintf("/proc/%d/maps", (int) getpid()); - FILE* maps = fopen(maps_name, "r"); - - long int addr = strtol(addrs[i].c_str(), &p, 16); + std::string maps_name = std::string("/proc/") + std::to_string(getpid()) + "/maps"; + FILE* maps = fopen(maps_name.c_str(), "r"); + if (maps == nullptr) { + XBT_CRITICAL("fopen(\"%s\") failed: %s", maps_name.c_str(), strerror(errno)); + continue; + } + unsigned long int addr = strtoul(addrs[i].c_str(), &p, 16); if (*p != '\0') { - XBT_CRITICAL("Cannot parse backtrace address '%s' (addr=%#lx)", - addrs[i].c_str(), addr); + XBT_CRITICAL("Cannot parse backtrace address '%s' (addr=%#lx)", addrs[i].c_str(), addr); } - XBT_DEBUG("addr=%s (as string) =%#lx (as number)", - addrs[i].c_str(), addr); + XBT_DEBUG("addr=%s (as string) =%#lx (as number)", addrs[i].c_str(), addr); - while (!found) { - long int first, last; + while (not found) { + unsigned long int first; + unsigned long int last; - if (fgets(maps_buff, 512, maps) == NULL) + if (fgets(maps_buff, 512, maps) == nullptr) break; if (i == 0) { maps_buff[strlen(maps_buff) - 1] = '\0'; @@ -265,10 +258,9 @@ std::vector resolveBacktrace( } } fclose(maps); - free(maps_name); addrs[i].clear(); - if (!found) { + if (not found) { XBT_VERB("Problem while reading the maps file. Following backtrace will be mangled."); XBT_DEBUG("No dynamic. Static symbol: %s", backtrace_syms[i]); result.push_back(simgrid::xbt::string_printf("?? (%s)", backtrace_syms[i])); @@ -289,7 +281,7 @@ std::vector resolveBacktrace( free(p); snprintf(line_func,3, "??"); } else { - p2 = strrchr(p, '('); + char* p2 = strrchr(p, '('); if (p2) *p2 = '\0'; p2 = strrchr(p, ' '); @@ -297,27 +289,26 @@ std::vector resolveBacktrace( *p2 = '\0'; /* Here we go, fire an addr2line up */ - char* subcmd = bprintf("%s -f -e %s %s", ADDR2LINE, p, addrs[i].c_str()); + std::string subcmd = std::string(ADDR2LINE) + " -f -e " + p + " " + addrs[i]; free(p); - XBT_VERB("Fire a new command: '%s'", subcmd); - FILE* subpipe = popen(subcmd, "r"); - if (!subpipe) { + XBT_VERB("Fire a new command: '%s'", subcmd.c_str()); + FILE* subpipe = popen(subcmd.c_str(), "r"); + if (not subpipe) { xbt_die("Cannot fork addr2line to display the backtrace"); } if (fgets(line_func, 1024, subpipe)) { line_func[strlen(line_func) - 1] = '\0'; } else { - XBT_VERB("Cannot read result of subcommand %s", subcmd); + XBT_VERB("Cannot read result of subcommand %s", subcmd.c_str()); strncpy(line_func, "???",3); } if (fgets(line_pos, 1024, subpipe)) { line_pos[strlen(line_pos) - 1] = '\0'; } else { - XBT_VERB("Cannot read result of subcommand %s", subcmd); + XBT_VERB("Cannot read result of subcommand %s", subcmd.c_str()); strncpy(line_pos, backtrace_syms[i],1024); } pclose(subpipe); - free(subcmd); } /* check whether the trick worked */ @@ -336,9 +327,9 @@ std::vector resolveBacktrace( addrs[i].clear(); /* Mask the bottom of the stack */ - if (!strncmp("main", line_func, strlen("main")) || - !strncmp("xbt_thread_context_wrapper", line_func, strlen("xbt_thread_context_wrapper")) - || !strncmp("smx_ctx_sysv_wrapper", line_func, strlen("smx_ctx_sysv_wrapper"))) + if (not strncmp("main", line_func, strlen("main")) || + not strncmp("xbt_thread_context_wrapper", line_func, strlen("xbt_thread_context_wrapper")) || + not strncmp("smx_ctx_sysv_wrapper", line_func, strlen("smx_ctx_sysv_wrapper"))) break; } pclose(pipe); @@ -349,13 +340,10 @@ std::vector resolveBacktrace( } } -#if HAVE_MC +#if SIMGRID_HAVE_MC int xbt_libunwind_backtrace(void** bt, int size){ - int i = 0; - for(i=0; i < size; i++) - bt[i] = NULL; - - i=0; + for (int i = 0; i < size; i++) + bt[i] = nullptr; unw_cursor_t c; unw_context_t uc; @@ -363,14 +351,13 @@ int xbt_libunwind_backtrace(void** bt, int size){ unw_getcontext (&uc); unw_init_local (&c, &uc); - unw_word_t ip; - unw_step(&c); - while(unw_step(&c) >= 0 && i < size){ + int i; + for (i = 0; unw_step(&c) >= 0 && i < size; i++) { + unw_word_t ip; unw_get_reg(&c, UNW_REG_IP, &ip); bt[i] = (void*)(long)ip; - i++; } return i;