X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/9e3bd4e25dac71e594a6e47ee77ccacd51da1a7c..fd2865e1ce63170aba3f6d6dcfe6b007c52e8cba:/src/kernel/activity/ExecImpl.cpp diff --git a/src/kernel/activity/ExecImpl.cpp b/src/kernel/activity/ExecImpl.cpp index 9860471563..6cecccf6cf 100644 --- a/src/kernel/activity/ExecImpl.cpp +++ b/src/kernel/activity/ExecImpl.cpp @@ -20,8 +20,8 @@ simgrid::kernel::activity::ExecImpl::ExecImpl(const char* name, resource::Action : host_(host) { if (name) - this->name = name; - this->state = SIMIX_RUNNING; + this->name_ = name; + this->state_ = SIMIX_RUNNING; surf_action_ = surf_action; surf_action_->set_data(this); @@ -73,7 +73,8 @@ double simgrid::kernel::activity::ExecImpl::get_remaining() double simgrid::kernel::activity::ExecImpl::get_remaining_ratio() { - if (host_ == nullptr) // parallel task: their remain is already between 0 and 1 (see comment in ExecImpl::remains()) + if (host_ == + nullptr) // parallel task: their remain is already between 0 and 1 (see comment in ExecImpl::get_remaining()) return surf_action_->get_remains(); else // Actually compute the ratio for sequential tasks return surf_action_->get_remains() / surf_action_->get_cost(); @@ -95,14 +96,14 @@ void simgrid::kernel::activity::ExecImpl::post() if (host_ && host_->isOff()) { /* FIXME: handle resource failure for parallel tasks too */ /* If the host running the synchro failed, notice it. This way, the asking * process can be killed if it runs on that host itself */ - state = SIMIX_FAILED; + state_ = SIMIX_FAILED; } else if (surf_action_ && surf_action_->get_state() == simgrid::kernel::resource::Action::State::failed) { /* If the host running the synchro didn't fail, then the synchro was canceled */ - state = SIMIX_CANCELED; + state_ = SIMIX_CANCELED; } else if (timeout_detector_ && timeout_detector_->get_state() == simgrid::kernel::resource::Action::State::done) { - state = SIMIX_TIMEOUT; + state_ = SIMIX_TIMEOUT; } else { - state = SIMIX_DONE; + state_ = SIMIX_DONE; } if (surf_action_) { @@ -116,7 +117,7 @@ void simgrid::kernel::activity::ExecImpl::post() onCompletion(this); /* If there are simcalls associated with the synchro, then answer them */ - if (not simcalls.empty()) + if (not simcalls_.empty()) SIMIX_execution_finish(this); } @@ -125,19 +126,19 @@ simgrid::kernel::activity::ExecImpl::migrate(simgrid::s4u::Host* to) { if (not MC_is_active() && not MC_record_replay_is_active()) { - simgrid::kernel::resource::Action* oldAction = this->surf_action_; - simgrid::kernel::resource::Action* newAction = to->pimpl_cpu->execution_start(oldAction->get_cost()); - newAction->set_remains(oldAction->get_remains()); - newAction->set_data(this); - newAction->set_priority(oldAction->get_priority()); + simgrid::kernel::resource::Action* old_action = this->surf_action_; + simgrid::kernel::resource::Action* new_action = to->pimpl_cpu->execution_start(old_action->get_cost()); + new_action->set_remains(old_action->get_remains()); + new_action->set_data(this); + new_action->set_priority(old_action->get_priority()); // FIXME: the user-defined bound seem to not be kept by LMM, that seem to overwrite it for the multi-core modeling. // I hope that the user did not provide any. - oldAction->set_data(nullptr); - oldAction->cancel(); - oldAction->unref(); - this->surf_action_ = newAction; + old_action->set_data(nullptr); + old_action->cancel(); + old_action->unref(); + this->surf_action_ = new_action; } onMigration(this, to);