X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/9d0bdd2e04d23fbcc1db6e7e525cf79979c4643b..5dbc98300c37e0f099f41320240acabbafe84f03:/src/xbt/config.cpp?ds=sidebyside diff --git a/src/xbt/config.cpp b/src/xbt/config.cpp index 7578fbdfa5..b2d004c2c8 100644 --- a/src/xbt/config.cpp +++ b/src/xbt/config.cpp @@ -37,9 +37,33 @@ void increment(e_xbt_cfgelm_type_t& type) } -/* xbt_cfgelm_t: the typedef corresponding to a config variable. */ +static const char *xbt_cfgelm_type_name[xbt_cfgelm_type_count] = { + "int", "double", "string", "boolean", "any" +}; + +const struct xbt_boolean_couple xbt_cfgelm_boolean_values[] = { + { "yes", "no"}, + { "on", "off"}, + {"true", "false"}, + { "1", "0"}, + { NULL, NULL} +}; + +namespace simgrid { +namespace config { + struct ConfigurationElement ; + class Config; +} +} + +/* Retrieve the variable we'll modify */ +static simgrid::config::ConfigurationElement* xbt_cfgelm_get(xbt_cfg_t cfg, const char *name, e_xbt_cfgelm_type_t type); -typedef struct s_xbt_cfgelm_t { +namespace simgrid { +namespace config { + +// A configuration variable: +struct ConfigurationElement { /* Description */ std::string desc; @@ -53,110 +77,140 @@ typedef struct s_xbt_cfgelm_t { /* Advanced callback (for xbt_cfgelm_string only) */ std::function callback; - /* actual content (could be an union or something) */ - xbt_dynar_t content = nullptr; + union { + int int_content; + double double_content; + char* string_content; + bool boolean_content; + }; - ~s_xbt_cfgelm_t() + ~ConfigurationElement() { XBT_DEBUG("Frees cfgelm %p", this); - if (this->type != xbt_cfgelm_alias) - xbt_dynar_free(&(this->content)); + switch(this->type) { + case xbt_cfgelm_int: + case xbt_cfgelm_double: + case xbt_cfgelm_boolean: + break; + case xbt_cfgelm_string: + free(string_content); + break; + default: + xbt_die("Unexpected config type"); + } } -} s_xbt_cfgelm_t, *xbt_cfgelm_t; +}; -static const char *xbt_cfgelm_type_name[xbt_cfgelm_type_count] = { "int", "double", "string", "boolean", "any", "outofbound" }; +class Config { + // name -> ConfigElement: + xbt_dict_t options; + // alias -> xbt_dict_elm_t from options: + xbt_dict_t aliases; -const struct xbt_boolean_couple xbt_cfgelm_boolean_values[] = { - { "yes", "no"}, - { "on", "off"}, - {"true", "false"}, - { "1", "0"}, - { NULL, NULL} +public: + Config(); + ~Config(); + + // No copy: + Config(Config const&) = delete; + Config& operator=(Config const&) = delete; + + xbt_dictelm_t getElement(const char* name); + ConfigurationElement* operator[](const char* name); + void alias(const char* realname, const char* aliasname); + + simgrid::config::ConfigurationElement* registerOption( + const char *name, const char *desc, e_xbt_cfgelm_type_t type, + xbt_cfg_cb_t cb_set); + + // Debug: + void dump(const char *name, const char *indent); + void showAliases(); + void help(); }; /* Internal stuff used in cache to free a variable */ static void xbt_cfgelm_free(void *data) { if (data) - delete (xbt_cfgelm_t) data; + delete (simgrid::config::ConfigurationElement*) data; } -/* Retrieve the variable we'll modify */ -static xbt_cfgelm_t xbt_cfgelm_get(xbt_cfg_t cfg, const char *name, e_xbt_cfgelm_type_t type); +Config::Config() : + options(xbt_dict_new_homogeneous(xbt_cfgelm_free)), + aliases(xbt_dict_new_homogeneous(NULL)) +{} -/*----[ Memory management ]-----------------------------------------------*/ -/** @brief Constructor - * - * Initialise a config set - */ -xbt_cfg_t xbt_cfg_new(void) +Config::~Config() { - return (xbt_cfg_t) xbt_dict_new_homogeneous(&xbt_cfgelm_free); + XBT_DEBUG("Frees cfg set %p", this); + xbt_dict_free(&this->options); + xbt_dict_free(&this->aliases); } -/** @brief Destructor */ -void xbt_cfg_free(xbt_cfg_t * cfg) +inline +xbt_dictelm_t Config::getElement(const char* name) +{ + // We are interested in the options dictelm: + xbt_dictelm_t res = xbt_dict_get_elm_or_null(options, name); + if (res) + return res; + // The aliases dict stores pointers to the options dictelm: + res = (xbt_dictelm_t) xbt_dict_get_or_null(aliases, name); + if (res) + XBT_INFO("Option %s has been renamed to %s. Consider switching.", name, res->key); + return res; +} + +inline +ConfigurationElement* Config::operator[](const char* name) +{ + xbt_dictelm_t elm = getElement(name); + if (elm) + return (ConfigurationElement*) elm->content; + else + return nullptr; +} + +void Config::alias(const char* realname, const char* aliasname) { - XBT_DEBUG("Frees cfg set %p", cfg); - xbt_dict_free((xbt_dict_t *) cfg); + xbt_assert(this->getElement(aliasname) == nullptr, "Alias '%s' already.", aliasname); + xbt_dictelm_t element = this->getElement(realname); + xbt_assert(element, "Cannot define an alias to the non-existing option '%s'.", realname); + xbt_dict_set(this->aliases, aliasname, element, NULL); } /** @brief Dump a config set for debuging purpose * * @param name The name to give to this config set * @param indent what to write at the beginning of each line (right number of spaces) - * @param cfg the config set */ -void xbt_cfg_dump(const char *name, const char *indent, xbt_cfg_t cfg) +void Config::dump(const char *name, const char *indent) { - xbt_dict_t dict = (xbt_dict_t) cfg; + xbt_dict_t dict = this->options; xbt_dict_cursor_t cursor = NULL; - xbt_cfgelm_t variable = NULL; + simgrid::config::ConfigurationElement* variable = NULL; char *key = NULL; - int i; - int size; - int ival; - char *sval; - double dval; if (name) printf("%s>> Dumping of the config set '%s':\n", indent, name); xbt_dict_foreach(dict, cursor, key, variable) { - printf("%s %s:", indent, key); - - size = xbt_dynar_length(variable->content); - printf ("%s. Actual size=%d. postset=%p\n", - xbt_cfgelm_type_name[variable->type], size, variable->cb_set); - + const char* type_name = xbt_cfgelm_type_name[variable->type]; switch (variable->type) { case xbt_cfgelm_int: - for (i = 0; i < size; i++) { - ival = xbt_dynar_get_as(variable->content, i, int); - printf("%s %d\n", indent, ival); - } + printf("%s %s: ()%s) %i", indent, key, type_name, variable->int_content); break; case xbt_cfgelm_double: - for (i = 0; i < size; i++) { - dval = xbt_dynar_get_as(variable->content, i, double); - printf("%s %f\n", indent, dval); - } + printf("%s %s: ()%s) %f", indent, key, type_name, variable->double_content); break; case xbt_cfgelm_string: - for (i = 0; i < size; i++) { - sval = xbt_dynar_get_as(variable->content, i, char *); - printf("%s %s\n", indent, sval); - } + printf("%s %s: ()%s) %s", indent, key, type_name, variable->string_content); break; case xbt_cfgelm_boolean: - for (i = 0; i < size; i++) { - ival = xbt_dynar_get_as(variable->content, i, int); - printf("%s %d\n", indent, ival); - } - break; - case xbt_cfgelm_alias: - /* no content */ + printf("%s %s: ()%s) %s", indent, key, type_name, + variable->boolean_content ? "true" : "false"); break; default: printf("%s Invalid type!!\n", indent); @@ -171,95 +225,167 @@ void xbt_cfg_dump(const char *name, const char *indent, xbt_cfg_t cfg) xbt_dict_cursor_free(&cursor); } -/*----[ Registering stuff ]-----------------------------------------------*/ -/** @brief Register an element within a config set - * - * @param cfg the config set - * @param name the name of the config element - * @param desc a description for this item (used by xbt_cfg_help()) - * @param type the type of the config element - * @param cb_set callback function called when a value is set - */ -static void xbt_cfg_register( - xbt_cfg_t * cfg, const char *name, const char *desc, e_xbt_cfgelm_type_t type, - xbt_cfg_cb_t cb_set, - std::function callback = std::function()) +simgrid::config::ConfigurationElement* Config::registerOption( + const char *name, const char *desc, e_xbt_cfgelm_type_t type, xbt_cfg_cb_t cb_set) { - if (*cfg == NULL) - *cfg = xbt_cfg_new(); xbt_assert(type >= xbt_cfgelm_int && type <= xbt_cfgelm_boolean, "type of %s not valid (%d should be between %d and %d)", name, (int)type, xbt_cfgelm_int, xbt_cfgelm_boolean); - xbt_cfgelm_t res = (xbt_cfgelm_t) xbt_dict_get_or_null((xbt_dict_t) * cfg, name); + simgrid::config::ConfigurationElement* res = (simgrid::config::ConfigurationElement*) xbt_dict_get_or_null(this->options, name); xbt_assert(NULL == res, "Refusing to register the config element '%s' twice.", name); - res = new s_xbt_cfgelm_t(); + res = new simgrid::config::ConfigurationElement(); XBT_DEBUG("Register cfg elm %s (%s) (%s (=%d) @%p in set %p)", - name, desc, xbt_cfgelm_type_name[type], (int)type, res, *cfg); + name, desc, xbt_cfgelm_type_name[type], (int)type, res, this); res->type = type; + res->cb_set = cb_set; if (desc) res->desc = desc; - res->cb_set = cb_set; - res->callback = std::move(callback); + // Set a default default value: switch (type) { case xbt_cfgelm_int: - res->content = xbt_dynar_new(sizeof(int), NULL); + res->int_content = 0; break; case xbt_cfgelm_double: - res->content = xbt_dynar_new(sizeof(double), NULL); + res->double_content = 0.0; break; case xbt_cfgelm_string: - res->content = xbt_dynar_new(sizeof(char *), xbt_free_ref); + res->string_content = nullptr; break; case xbt_cfgelm_boolean: - res->content = xbt_dynar_new(sizeof(int), NULL); + res->boolean_content = false; break; default: XBT_ERROR("%d is an invalid type code", (int)type); break; } - xbt_dict_set((xbt_dict_t) * cfg, name, res, NULL); + xbt_dict_set(this->options, name, res, NULL); + return res; +} + +/** @brief Displays the declared aliases and their description */ +void Config::showAliases() +{ + xbt_dict_cursor_t dict_cursor; + unsigned int dynar_cursor; + xbt_dictelm_t dictel; + char *name; + xbt_dynar_t names = xbt_dynar_new(sizeof(char *), NULL); + + xbt_dict_foreach(this->aliases, dict_cursor, name, dictel) + xbt_dynar_push(names, &name); + xbt_dynar_sort_strings(names); + + xbt_dynar_foreach(names, dynar_cursor, name) { + simgrid::config::ConfigurationElement* variable = (*this)[name]; + if (variable) + printf(" %s: %s\n", name, variable->desc.c_str()); + } +} + +/** @brief Displays the declared options and their description */ +void Config::help() +{ + xbt_dict_cursor_t dict_cursor; + unsigned int dynar_cursor; + simgrid::config::ConfigurationElement* variable; + char *name; + xbt_dynar_t names = xbt_dynar_new(sizeof(char *), NULL); + + xbt_dict_foreach(this->options, dict_cursor, name, variable) + xbt_dynar_push(names, &name); + xbt_dynar_sort_strings(names); + + xbt_dynar_foreach(names, dynar_cursor, name) { + variable = (simgrid::config::ConfigurationElement*) xbt_dict_get(this->options, name); + + printf(" %s: %s\n", name, variable->desc.c_str()); + printf(" Type: %s; ", xbt_cfgelm_type_name[variable->type]); + printf("Current value: "); + + switch (variable->type) { + case xbt_cfgelm_int: + printf("%d\n", variable->int_content); + break; + case xbt_cfgelm_double: + printf("%f\n", variable->double_content); + break; + case xbt_cfgelm_string: + printf("'%s'\n", variable->string_content); + break; + case xbt_cfgelm_boolean: + printf("'%s'\n", variable->boolean_content ? "true" : "false"); + break; + default: + printf("Invalid type!!\n"); + break; + } + + } + xbt_dynar_free(&names); +} + +} +} + +// C bindings: + +/** @brief Constructor */ +xbt_cfg_t xbt_cfg_new(void) { return new simgrid::config::Config(); } +/** @brief Destructor */ +void xbt_cfg_free(xbt_cfg_t * cfg) { delete *cfg; } + +void xbt_cfg_dump(const char *name, const char *indent, xbt_cfg_t cfg) +{ + cfg->dump(name, indent); } -void xbt_cfg_register_double(const char *name, double default_value,xbt_cfg_cb_t cb_set, const char *desc){ - xbt_cfg_register(&simgrid_config,name,desc,xbt_cfgelm_double,cb_set); +/*----[ Registering stuff ]-----------------------------------------------*/ +/** @brief Register an element within a config set + * + * @param cfg the config set + * @param name the name of the config element + * @param desc a description for this item (used by xbt_cfg_help()) + * @param type the type of the config element + * @param cb_set callback function called when a value is set + */ +static simgrid::config::ConfigurationElement* xbt_cfg_register( + xbt_cfg_t * cfg, const char *name, const char *desc, e_xbt_cfgelm_type_t type, xbt_cfg_cb_t cb_set) +{ + if (*cfg == NULL) + *cfg = xbt_cfg_new(); + return (*cfg)->registerOption(name, desc, type, cb_set); +} + +void xbt_cfg_register_double(const char *name, double default_value,xbt_cfg_cb_t cb_set, const char *desc) +{ + xbt_cfg_register(&simgrid_config, name, desc, xbt_cfgelm_double, cb_set); xbt_cfg_setdefault_double(name, default_value); } -void xbt_cfg_register_int(const char *name, int default_value,xbt_cfg_cb_t cb_set, const char *desc) { - xbt_cfg_register(&simgrid_config,name,desc,xbt_cfgelm_int,cb_set); +void xbt_cfg_register_int(const char *name, int default_value,xbt_cfg_cb_t cb_set, const char *desc) +{ + xbt_cfg_register(&simgrid_config, name, desc, xbt_cfgelm_int, cb_set); xbt_cfg_setdefault_int(name, default_value); } -void xbt_cfg_register_string(const char *name, const char *default_value, xbt_cfg_cb_t cb_set, const char *desc){ +void xbt_cfg_register_string(const char *name, const char *default_value, xbt_cfg_cb_t cb_set, const char *desc) +{ xbt_cfg_register(&simgrid_config,name,desc,xbt_cfgelm_string,cb_set); xbt_cfg_setdefault_string(name, default_value); } -void xbt_cfg_register_boolean(const char *name, const char*default_value,xbt_cfg_cb_t cb_set, const char *desc){ +void xbt_cfg_register_boolean(const char *name, const char*default_value,xbt_cfg_cb_t cb_set, const char *desc) +{ xbt_cfg_register(&simgrid_config,name,desc,xbt_cfgelm_boolean,cb_set); xbt_cfg_setdefault_boolean(name, default_value); } -void xbt_cfg_register_alias(const char *newname, const char *oldname) +void xbt_cfg_register_alias(const char *realname, const char *aliasname) { if (simgrid_config == NULL) simgrid_config = xbt_cfg_new(); - - xbt_cfgelm_t res = (xbt_cfgelm_t) xbt_dict_get_or_null((xbt_dict_t) simgrid_config, oldname); - xbt_assert(NULL == res, "Refusing to register the option '%s' twice.", oldname); - - res = (xbt_cfgelm_t) xbt_dict_get_or_null((xbt_dict_t) simgrid_config, newname); - xbt_assert(res, "Cannot define an alias to the non-existing option '%s'.", newname); - - res = new s_xbt_cfgelm_t(); - XBT_DEBUG("Register cfg alias %s -> %s)",oldname,newname); - - res->desc = bprintf("Deprecated alias for %s",newname); - res->type = xbt_cfgelm_alias; - res->content = (xbt_dynar_t)newname; - - xbt_dict_set((xbt_dict_t) simgrid_config, oldname, res, NULL); + simgrid_config->alias(realname, aliasname); } /** @@ -295,94 +421,12 @@ void xbt_cfg_register_str(xbt_cfg_t * cfg, const char *entry) free(entrycpy); /* strdup'ed by dict mechanism, but cannot be const */ } -/** @brief Displays the declared aliases and their description */ -void xbt_cfg_aliases(void) -{ - xbt_dict_cursor_t dict_cursor; - unsigned int dynar_cursor; - xbt_cfgelm_t variable; - char *name; - xbt_dynar_t names = xbt_dynar_new(sizeof(char *), NULL); - - xbt_dict_foreach((xbt_dict_t )simgrid_config, dict_cursor, name, variable) - xbt_dynar_push(names, &name); - xbt_dynar_sort_strings(names); - - xbt_dynar_foreach(names, dynar_cursor, name) { - variable = (xbt_cfgelm_t) xbt_dict_get((xbt_dict_t )simgrid_config, name); - - if (variable->type == xbt_cfgelm_alias) - printf(" %s: %s\n", name, variable->desc.c_str()); - } -} - -/** @brief Displays the declared options and their description */ -void xbt_cfg_help(void) -{ - xbt_dict_cursor_t dict_cursor; - unsigned int dynar_cursor; - xbt_cfgelm_t variable; - char *name; - xbt_dynar_t names = xbt_dynar_new(sizeof(char *), NULL); - - xbt_dict_foreach((xbt_dict_t )simgrid_config, dict_cursor, name, variable) - xbt_dynar_push(names, &name); - xbt_dynar_sort_strings(names); - - xbt_dynar_foreach(names, dynar_cursor, name) { - int size; - variable = (xbt_cfgelm_t) xbt_dict_get((xbt_dict_t )simgrid_config, name); - if (variable->type == xbt_cfgelm_alias) - continue; - - printf(" %s: %s\n", name, variable->desc.c_str()); - printf(" Type: %s; ", xbt_cfgelm_type_name[variable->type]); - size = xbt_dynar_length(variable->content); - printf("Current value: "); - - if (size != 1) - printf(size == 0 ? "n/a\n" : "{ "); - for (int i = 0; i < size; i++) { - const char *sep = (size == 1 ? "\n" : (i < size - 1 ? ", " : " }\n")); +void xbt_cfg_aliases(void) { simgrid_config->showAliases(); } +void xbt_cfg_help(void) { simgrid_config->help(); } - switch (variable->type) { - case xbt_cfgelm_int: - printf("%d%s", xbt_dynar_get_as(variable->content, i, int), sep); - break; - case xbt_cfgelm_double: - printf("%f%s", xbt_dynar_get_as(variable->content, i, double), sep); - break; - case xbt_cfgelm_string: - printf("'%s'%s", xbt_dynar_get_as(variable->content, i, char *), sep); - break; - case xbt_cfgelm_boolean: { - int b = xbt_dynar_get_as(variable->content, i, int); - const char *bs = b ? xbt_cfgelm_boolean_values[0].true_val: xbt_cfgelm_boolean_values[0].false_val; - if (b == 0 || b == 1) - printf("'%s'%s", bs, sep); - else - printf("'%s/%d'%s", bs, b, sep); - break; - } - default: - printf("Invalid type!!%s", sep); - break; - } - } - } - xbt_dynar_free(&names); -} - -static xbt_cfgelm_t xbt_cfgelm_get(xbt_cfg_t cfg, const char *name, e_xbt_cfgelm_type_t type) +static simgrid::config::ConfigurationElement* xbt_cfgelm_get(xbt_cfg_t cfg, const char *name, e_xbt_cfgelm_type_t type) { - xbt_cfgelm_t res = (xbt_cfgelm_t) xbt_dict_get_or_null((xbt_dict_t) cfg, name); - - // The user used the old name. Switch to the new one after a short warning - while (res && res->type == xbt_cfgelm_alias) { - const char* newname = (const char *)res->content; - XBT_INFO("Option %s has been renamed to %s. Consider switching.", name, newname); - res = xbt_cfgelm_get(cfg, newname, type); - } + simgrid::config::ConfigurationElement* res = (*cfg)[name]; if (!res) { xbt_cfg_help(); @@ -405,12 +449,9 @@ static xbt_cfgelm_t xbt_cfgelm_get(xbt_cfg_t cfg, const char *name, e_xbt_cfgelm */ e_xbt_cfgelm_type_t xbt_cfg_get_type(xbt_cfg_t cfg, const char *name) { - xbt_cfgelm_t variable = NULL; - - variable = (xbt_cfgelm_t) xbt_dict_get_or_null((xbt_dict_t) cfg, name); + simgrid::config::ConfigurationElement* variable = (*cfg)[name]; if (!variable) THROWF(not_found_error, 0, "Can't get the type of '%s' since this variable does not exist", name); - XBT_DEBUG("type in variable = %d", (int)variable->type); return variable->type; } @@ -557,32 +598,16 @@ void xbt_cfg_set_parse(const char *options) * @return the first char after the parsed value in val */ -void *xbt_cfg_set_as_string(const char *key, const char *value) { - xbt_ex_t e; +void *xbt_cfg_set_as_string(const char *key, const char *value) +{ + simgrid::config::ConfigurationElement* variable = (*simgrid_config)[key]; + if (variable == nullptr) + THROWF(not_found_error, 0, "No registered variable corresponding to '%s'.", key); char *ret; - volatile xbt_cfgelm_t variable = NULL; int i; double d; - TRY { - while (variable == NULL) { - variable = (xbt_cfgelm_t) xbt_dict_get((xbt_dict_t) simgrid_config, key); - if (variable->type == xbt_cfgelm_alias) { - const char *newname = (const char*)variable->content; - XBT_INFO("Note: configuration '%s' is deprecated. Please use '%s' instead.", key, newname); - key = newname; - variable = NULL; - } - } - } CATCH(e) { - if (e.category == not_found_error) { - xbt_ex_free(e); - THROWF(not_found_error, 0, "No registered variable corresponding to '%s'.", key); - } - RETHROW; - } - switch (variable->type) { case xbt_cfgelm_string: xbt_cfg_set_string(key, value); /* throws */ @@ -619,7 +644,7 @@ void *xbt_cfg_set_as_string(const char *key, const char *value) { */ void xbt_cfg_setdefault_int(const char *name, int val) { - xbt_cfgelm_t variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_int); + simgrid::config::ConfigurationElement* variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_int); if (variable->isdefault){ xbt_cfg_set_int(name, val); @@ -635,7 +660,7 @@ void xbt_cfg_setdefault_int(const char *name, int val) */ void xbt_cfg_setdefault_double(const char *name, double val) { - xbt_cfgelm_t variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_double); + simgrid::config::ConfigurationElement* variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_double); if (variable->isdefault) { xbt_cfg_set_double(name, val); @@ -651,7 +676,7 @@ void xbt_cfg_setdefault_double(const char *name, double val) */ void xbt_cfg_setdefault_string(const char *name, const char *val) { - xbt_cfgelm_t variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_string); + simgrid::config::ConfigurationElement* variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_string); if (variable->isdefault){ xbt_cfg_set_string(name, val); @@ -667,7 +692,7 @@ void xbt_cfg_setdefault_string(const char *name, const char *val) */ void xbt_cfg_setdefault_boolean(const char *name, const char *val) { - xbt_cfgelm_t variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_boolean); + simgrid::config::ConfigurationElement* variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_boolean); if (variable->isdefault){ xbt_cfg_set_boolean(name, val); @@ -684,10 +709,8 @@ void xbt_cfg_setdefault_boolean(const char *name, const char *val) */ void xbt_cfg_set_int(const char *name, int val) { - xbt_cfgelm_t variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_int); - - xbt_dynar_set(variable->content, 0, &val); - + simgrid::config::ConfigurationElement* variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_int); + variable->int_content = val; if (variable->cb_set) variable->cb_set(name); variable->isdefault = false; @@ -700,10 +723,8 @@ void xbt_cfg_set_int(const char *name, int val) */ void xbt_cfg_set_double(const char *name, double val) { - xbt_cfgelm_t variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_double); - - xbt_dynar_set(variable->content, 0, &val); - + simgrid::config::ConfigurationElement* variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_double); + variable->double_content = val; if (variable->cb_set) variable->cb_set(name); variable->isdefault = false; @@ -718,18 +739,12 @@ void xbt_cfg_set_double(const char *name, double val) */ void xbt_cfg_set_string(const char *name, const char *val) { - char *newval = xbt_strdup(val); - xbt_cfgelm_t variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_string); - - if (!xbt_dynar_is_empty(variable->content)) { - char *sval = xbt_dynar_get_as(variable->content, 0, char *); - free(sval); - } - - xbt_dynar_set(variable->content, 0, &newval); - + simgrid::config::ConfigurationElement* variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_string); + free(variable->string_content); + variable->string_content = xbt_strdup(val); if (variable->cb_set) variable->cb_set(name); + variable->isdefault = false; if (variable->callback) { try { @@ -745,8 +760,6 @@ void xbt_cfg_set_string(const char *name, const char *val) xbt_die("Error for flag %s=%s", val, name); } } - - variable->isdefault = false; } /** @brief Set or add a boolean value to \a name within \a cfg @@ -757,7 +770,7 @@ void xbt_cfg_set_string(const char *name, const char *val) void xbt_cfg_set_boolean(const char *name, const char *val) { int bval=-1; - xbt_cfgelm_t variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_boolean); + simgrid::config::ConfigurationElement* variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_boolean); for (int i = 0; xbt_cfgelm_boolean_values[i].true_val != NULL; i++) { if (strcmp(val, xbt_cfgelm_boolean_values[i].true_val) == 0){ @@ -770,8 +783,7 @@ void xbt_cfg_set_boolean(const char *name, const char *val) } } xbt_assert(bval != -1, "Value of option '%s' not valid. Should be a boolean (yes,no,on,off,true,false,0,1)", val); - xbt_dynar_set(variable->content, 0, &bval); - + variable->boolean_content = bval; if (variable->cb_set) variable->cb_set(name); variable->isdefault = false; @@ -781,7 +793,7 @@ void xbt_cfg_set_boolean(const char *name, const char *val) /* Say if the value is the default value */ int xbt_cfg_is_default_value(const char *name) { - xbt_cfgelm_t variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_any); + simgrid::config::ConfigurationElement* variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_any); return variable->isdefault; } @@ -791,18 +803,11 @@ int xbt_cfg_is_default_value(const char *name) * @param name the name of the variable * * Returns the first value from the config set under the given name. - * If there is more than one value, it will issue a warning. Consider using xbt_cfg_get_dynar() instead. */ int xbt_cfg_get_int(const char *name) { - xbt_cfgelm_t variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_int); - - if (xbt_dynar_length(variable->content) > 1) { - XBT_WARN("You asked for the first value of the config element '%s', but there is %lu values", - name, xbt_dynar_length(variable->content)); - } - - return xbt_dynar_get_as(variable->content, 0, int); + simgrid::config::ConfigurationElement* variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_int); + return variable->int_content; } /** @brief Retrieve a double value of a variable (get a warning if not uniq) @@ -811,18 +816,11 @@ int xbt_cfg_get_int(const char *name) * @param name the name of the variable * * Returns the first value from the config set under the given name. - * If there is more than one value, it will issue a warning. Consider using xbt_cfg_get_dynar() instead. */ double xbt_cfg_get_double(const char *name) { - xbt_cfgelm_t variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_double); - - if (xbt_dynar_length(variable->content) > 1) { - XBT_WARN ("You asked for the first value of the config element '%s', but there is %lu values\n", - name, xbt_dynar_length(variable->content)); - } - - return xbt_dynar_get_as(variable->content, 0, double); + simgrid::config::ConfigurationElement* variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_double); + return variable->double_content; } /** @brief Retrieve a string value of a variable (get a warning if not uniq) @@ -831,23 +829,15 @@ double xbt_cfg_get_double(const char *name) * @param name the name of the variable * * Returns the first value from the config set under the given name. - * If there is more than one value, it will issue a warning. Consider using - * xbt_cfg_get_dynar() instead. Returns NULL if there is no value. + * If there is more than one value, it will issue a warning. + * Returns NULL if there is no value. * * \warning the returned value is the actual content of the config set */ char *xbt_cfg_get_string(const char *name) { - xbt_cfgelm_t variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_string); - - if (xbt_dynar_length(variable->content) > 1) { - XBT_WARN("You asked for the first value of the config element '%s', but there is %lu values\n", - name, xbt_dynar_length(variable->content)); - } else if (xbt_dynar_is_empty(variable->content)) { - return NULL; - } - - return xbt_dynar_get_as(variable->content, 0, char *); + simgrid::config::ConfigurationElement* variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_string); + return variable->string_content; } /** @brief Retrieve a boolean value of a variable (get a warning if not uniq) @@ -856,18 +846,12 @@ char *xbt_cfg_get_string(const char *name) * @param name the name of the variable * * Returns the first value from the config set under the given name. - * If there is more than one value, it will issue a warning. Consider using xbt_cfg_get_dynar() instead. + * If there is more than one value, it will issue a warning. */ int xbt_cfg_get_boolean(const char *name) { - xbt_cfgelm_t variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_boolean); - - if (xbt_dynar_length(variable->content) > 1) { - XBT_WARN("You asked for the first value of the config element '%s', but there is %lu values", - name, xbt_dynar_length(variable->content)); - } - - return xbt_dynar_get_as(variable->content, 0, int); + simgrid::config::ConfigurationElement* variable = xbt_cfgelm_get(simgrid_config, name, xbt_cfgelm_boolean); + return variable->boolean_content; } namespace simgrid { @@ -920,8 +904,9 @@ long int parseLong(const char* value) void declareFlag(const char* name, const char* description, std::function callback) { - xbt_cfg_register(&simgrid_config, name, description, xbt_cfgelm_string, NULL, - std::move(callback)); + simgrid::config::ConfigurationElement* e = xbt_cfg_register( + &simgrid_config, name, description, xbt_cfgelm_string, NULL); + e->callback = std::move(callback); } }