X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/9982cd9fee0903300e2323bc196a5262f4e5b969..5198991bb329c947bd497b66b2d837959ce20ee6:/src/surf/plugins/host_dvfs.cpp diff --git a/src/surf/plugins/host_dvfs.cpp b/src/surf/plugins/host_dvfs.cpp index 251f05ff0d..7ffaa7ca32 100644 --- a/src/surf/plugins/host_dvfs.cpp +++ b/src/surf/plugins/host_dvfs.cpp @@ -40,6 +40,7 @@ public: double sampling_rate; explicit Governor(simgrid::s4u::Host* ptr) : host(ptr) { init(); } + virtual ~Governor() = default; void init() { @@ -52,7 +53,8 @@ public: } } - virtual void update() {} + virtual void update() = 0; + virtual std::string getName() = 0; double samplingRate() { return sampling_rate; } }; @@ -60,14 +62,16 @@ class Performance : public Governor { public: explicit Performance(simgrid::s4u::Host* ptr) : Governor(ptr) {} - void update() { host->setPstate(0); } + void update() override { host->setPstate(0); } + std::string getName() override { return "Performance"; } }; class Powersave : public Governor { public: explicit Powersave(simgrid::s4u::Host* ptr) : Governor(ptr) {} - void update() { host->setPstate(host->getPstatesCount() - 1); } + void update() override { host->setPstate(host->getPstatesCount() - 1); } + std::string getName() override { return "Powersave"; } }; class OnDemand : public Governor { @@ -76,13 +80,15 @@ class OnDemand : public Governor { public: explicit OnDemand(simgrid::s4u::Host* ptr) : Governor(ptr) {} - void update() + std::string getName() override { return "OnDemand"; } + void update() override { double load = sg_host_get_current_load(host); - if (load > freq_up_threshold) { + // FIXME I don't like that we multiply with the getCoreCount() just here... + if (load*host->getCoreCount() > freq_up_threshold) { host->setPstate(0); /* Run at max. performance! */ - XBT_INFO("Changed to pstate %f", 0.0); + XBT_INFO("Load: %f > threshold: %f --> changed to pstate %i", load * host->getCoreCount(), freq_up_threshold, 0); } else { /* The actual implementation uses a formula here: (See Kernel file cpufreq_ondemand.c:158) * @@ -92,9 +98,10 @@ public: * lowest_pstate - load*pstatesCount() */ int max_pstate = host->getPstatesCount() - 1; + int new_pstate = max_pstate - load * max_pstate; + host->setPstate(new_pstate); - host->setPstate(max_pstate - load * max_pstate); - XBT_INFO("Changed to pstate %f -- check: %i", max_pstate - load * max_pstate, host->getPstate()); + XBT_DEBUG("Load: %f --> changed to pstate %i", load*host->getCoreCount(), new_pstate); } } }; @@ -106,34 +113,32 @@ class Conservative : public Governor { public: explicit Conservative(simgrid::s4u::Host* ptr) : Governor(ptr) {} - void update() + virtual std::string getName() override { return "Conservative"; } + virtual void update() override { - double load = sg_host_get_current_load(host); + double load = sg_host_get_current_load(host)*host->getCoreCount(); int pstate = host->getPstate(); if (load > freq_up_threshold) { if (pstate != 0) { host->setPstate(pstate - 1); - XBT_INFO("Increasing performance to pstate %d", pstate - 1); + XBT_INFO("Load: %f > threshold: %f -> increasing performance to pstate %d", load, freq_up_threshold, pstate - 1); } else { - XBT_DEBUG("Cannot speed up even more, already in slowest pstate %d", pstate); + XBT_DEBUG("Load: %f > threshold: %f -> but cannot speed up even more, already in highest pstate %d", load, freq_up_threshold, pstate); } - } - - if (load < freq_down_threshold) { + } else if (load < freq_down_threshold) { int max_pstate = host->getPstatesCount() - 1; if (pstate != max_pstate) { // Are we in the slowest pstate already? host->setPstate(pstate + 1); - XBT_INFO("Slowing down to pstate %d", pstate + 1); + XBT_INFO("Load: %f < threshold: %f -> slowing down to pstate %d", load, freq_down_threshold, pstate + 1); } else { - XBT_DEBUG("Cannot slow down even more, already in slowest pstate %d", pstate); + XBT_DEBUG("Load: %f < threshold: %f -> cannot slow down even more, already in slowest pstate %d", load, freq_down_threshold, pstate); } } } }; -} class HostDvfs { public: @@ -150,8 +155,9 @@ HostDvfs::HostDvfs(simgrid::s4u::Host* ptr) {} HostDvfs::~HostDvfs() = default; } } +} -using simgrid::plugin::HostDvfs; +using simgrid::plugin::dvfs::HostDvfs; /* **************************** events callback *************************** */ static void on_host_added(simgrid::s4u::Host& host) @@ -180,18 +186,34 @@ static void on_host_added(simgrid::s4u::Host& host) boost::algorithm::to_lower(dvfs_governor); } - simgrid::plugin::dvfs::Governor governor(daemonProc->getHost()); - if (dvfs_governor == "conservative") { - governor = simgrid::plugin::dvfs::Conservative(daemonProc->getHost()); - } + auto governor = [&dvfs_governor, &daemonProc]() { + if (dvfs_governor == "conservative") { + return std::unique_ptr( + new simgrid::plugin::dvfs::Conservative(daemonProc->getHost())); + } else if (dvfs_governor == "ondemand") { + return std::unique_ptr( + new simgrid::plugin::dvfs::OnDemand(daemonProc->getHost())); + } else if (dvfs_governor == "performance") { + return std::unique_ptr( + new simgrid::plugin::dvfs::Performance(daemonProc->getHost())); + } else if (dvfs_governor == "powersave") { + return std::unique_ptr( + new simgrid::plugin::dvfs::Powersave(daemonProc->getHost())); + } else { + XBT_CRITICAL("No governor specified for host %s, falling back to Performance", + daemonProc->getHost()->getCname()); + return std::unique_ptr( + new simgrid::plugin::dvfs::Performance(daemonProc->getHost())); + } + }(); while (1) { // Sleep *before* updating; important for startup (i.e., t = 0). // In the beginning, we want to go with the pstates specified in the platform file // (so we sleep first) - simgrid::s4u::this_actor::sleep_for(governor.samplingRate()); - governor.update(); - XBT_INFO("Governor just updated!"); + simgrid::s4u::this_actor::sleep_for(governor->samplingRate()); + governor->update(); + XBT_DEBUG("Governor (%s) just updated!", governor->getName().c_str()); } XBT_WARN("I should have never reached this point: daemons should be killed when all regular processes are done");