X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/9335baa2b23f940577448a84168eb0b50d3dd966..efa1f86e31adca3c57e9d0135b2f6ebdbabb0878:/src/smpi/colls/bcast/bcast-NTSL-Isend.cpp diff --git a/src/smpi/colls/bcast/bcast-NTSL-Isend.cpp b/src/smpi/colls/bcast/bcast-NTSL-Isend.cpp index 464bb5c6a5..535b208d57 100644 --- a/src/smpi/colls/bcast/bcast-NTSL-Isend.cpp +++ b/src/smpi/colls/bcast/bcast-NTSL-Isend.cpp @@ -1,28 +1,24 @@ -/* Copyright (c) 2013-2017. The SimGrid Team. +/* Copyright (c) 2013-2019. The SimGrid Team. * All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ -#include "../colls_private.h" +#include "../colls_private.hpp" static int bcast_NTSL_segment_size_in_byte = 8192; -/* Non-topology-specific pipelined linear-bcast function +/* Non-topology-specific pipelined linear-bcast function 0->1, 1->2 ,2->3, ....., ->last node : in a pipeline fashion */ namespace simgrid{ namespace smpi{ -int Coll_bcast_NTSL_Isend::bcast(void *buf, int count, MPI_Datatype datatype, - int root, MPI_Comm comm) +int bcast__NTSL_Isend(void *buf, int count, MPI_Datatype datatype, + int root, MPI_Comm comm) { int tag = COLL_TAG_BCAST; MPI_Status status; MPI_Request request; - MPI_Request *send_request_array; - MPI_Request *recv_request_array; - MPI_Status *send_status_array; - MPI_Status *recv_status_array; int rank, size; int i; MPI_Aint extent; @@ -37,14 +33,14 @@ int Coll_bcast_NTSL_Isend::bcast(void *buf, int count, MPI_Datatype datatype, /* segment is segment size in number of elements (not bytes) */ int segment = bcast_NTSL_segment_size_in_byte / extent; - segment = segment == 0 ? 1 :segment; + segment = segment == 0 ? 1 :segment; /* pipeline length */ int pipe_length = count / segment; /* use for buffer offset for sending and receiving data = segment size in byte */ int increment = segment * extent; - /* if the input size is not divisible by segment size => + /* if the input size is not divisible by segment size => the small remainder will be done with native implementation */ int remainder = count % segment; @@ -76,14 +72,10 @@ int Coll_bcast_NTSL_Isend::bcast(void *buf, int count, MPI_Datatype datatype, /* pipeline bcast */ else { - send_request_array = - (MPI_Request *) xbt_malloc((size + pipe_length) * sizeof(MPI_Request)); - recv_request_array = - (MPI_Request *) xbt_malloc((size + pipe_length) * sizeof(MPI_Request)); - send_status_array = - (MPI_Status *) xbt_malloc((size + pipe_length) * sizeof(MPI_Status)); - recv_status_array = - (MPI_Status *) xbt_malloc((size + pipe_length) * sizeof(MPI_Status)); + MPI_Request* send_request_array = new MPI_Request[size + pipe_length]; + MPI_Request* recv_request_array = new MPI_Request[size + pipe_length]; + MPI_Status* send_status_array = new MPI_Status[size + pipe_length]; + MPI_Status* recv_status_array = new MPI_Status[size + pipe_length]; /* root send data */ if (rank == 0) { @@ -117,17 +109,16 @@ int Coll_bcast_NTSL_Isend::bcast(void *buf, int count, MPI_Datatype datatype, Request::waitall((pipe_length), send_request_array, send_status_array); } - free(send_request_array); - free(recv_request_array); - free(send_status_array); - free(recv_status_array); + delete[] send_request_array; + delete[] recv_request_array; + delete[] send_status_array; + delete[] recv_status_array; } /* end pipeline */ /* when count is not divisible by block size, use default BCAST for the remainder */ if ((remainder != 0) && (count > segment)) { - XBT_WARN("MPI_bcast_NTSL_Isend_nb use default MPI_bcast."); - Colls::bcast((char *) buf + (pipe_length * increment), remainder, datatype, - root, comm); + XBT_WARN("MPI_bcast_NTSL_Isend_nb use default MPI_bcast."); + colls::bcast((char*)buf + (pipe_length * increment), remainder, datatype, root, comm); } return MPI_SUCCESS;