X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/8a80f216e1cf65ffea72f3ac1fe7de5b33170b1e..6c70be774ea7f214c9945645ddcb11bbdb5ef33a:/src/gras/Msg/gras_msg_exchange.c diff --git a/src/gras/Msg/gras_msg_exchange.c b/src/gras/Msg/gras_msg_exchange.c index 5a7b9cfa76..ba36513fef 100644 --- a/src/gras/Msg/gras_msg_exchange.c +++ b/src/gras/Msg/gras_msg_exchange.c @@ -12,7 +12,6 @@ #include "xbt/ex_interface.h" #include "gras/Msg/msg_private.h" #include "gras/Virtu/virtu_interface.h" -#include "gras/Transport/transport_interface.h" /* gras_select */ XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(gras_msg); @@ -49,7 +48,7 @@ gras_msg_wait_ext_(double timeout, double start, now; gras_msg_procdata_t pd= (gras_msg_procdata_t)gras_libdata_by_id(gras_msg_libdata_id); - int cpt; + unsigned int cpt; xbt_assert0(msg_got,"msg_got is an output parameter"); @@ -92,8 +91,7 @@ gras_msg_wait_ext_(double timeout, memset(&msg,sizeof(msg),0); TRY { - msg.expe = gras_trp_select(timeout ? timeout - now + start : 0); - gras_msg_recv(msg.expe, &msg); + xbt_queue_shift_timed(pd->msg_received,&msg,timeout ? timeout - now + start : 0); } CATCH(e) { if (e.category == system_error && !strncmp("Socket closed by remote side",e.msg, @@ -280,7 +278,8 @@ gras_msg_handleall(double period) { RETHROW0("Error while waiting for messages: %s"); xbt_ex_free(e); } - } while (now - begin < period); + /* Epsilon to avoid numerical stability issues were the waited interval is so small that the global clock cannot notice the increment */ + } while (period - now + begin > 0); } /** @brief Handle an incomming message or timer (or wait up to \a timeOut seconds) @@ -297,7 +296,7 @@ gras_msg_handle(double timeOut) { double untiltimer; - int cpt; + unsigned int cpt; int volatile ran_ok; s_gras_msg_t msg; @@ -332,28 +331,15 @@ gras_msg_handle(double timeOut) { xbt_dynar_shift(pd->msg_queue,&msg); } else { TRY { - msg.expe = gras_trp_select(timeOut); + xbt_queue_shift_timed(pd->msg_received,&msg,timeOut); +// msg.expe = gras_trp_select(timeOut); } CATCH(e) { if (e.category != timeout_error) RETHROW; + DEBUG0("Damn. Timeout while getting a message from the queue"); xbt_ex_free(e); timeouted = 1; } - - if (!timeouted) { - TRY { - /* FIXME: if not the right kind, queue it and recall ourself or goto >:-) */ - gras_msg_recv(msg.expe, &msg); - DEBUG1("Received a msg from the socket kind:%s", - e_gras_msg_kind_names[msg.kind]); - - } CATCH(e) { - RETHROW4("Error while receiving a message on select()ed socket %p to [%s]%s:%d: %s", - msg.expe, - gras_socket_peer_proc(msg.expe),gras_socket_peer_name(msg.expe), - gras_socket_peer_port(msg.expe)); - } - } } if (timeouted) { @@ -456,7 +442,7 @@ gras_msg_handle(double timeOut) { "AND IN SIMGRID (process wasn't killed by an assert)",msg.type->name); if (!ran_ok) THROW1(mismatch_error,0, - "Message '%s' refused by all registered callbacks", msg.type->name); + "Message '%s' refused by all registered callbacks (maybe your callback misses a 'return 0' at the end)", msg.type->name); /* FIXME: gras_datadesc_free not implemented => leaking the payload */ break;