X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/89feb425bdeb4351ac0e27a38d9a9b3463fff433..2aaf66237295992a6fb4b0873b26075bd3a7f44a:/src/surf/sg_platf.cpp?ds=sidebyside diff --git a/src/surf/sg_platf.cpp b/src/surf/sg_platf.cpp index 0ded0be000..08386317d9 100644 --- a/src/surf/sg_platf.cpp +++ b/src/surf/sg_platf.cpp @@ -22,7 +22,6 @@ #include "src/kernel/EngineImpl.hpp" #include "src/kernel/resource/DiskImpl.hpp" #include "src/kernel/resource/profile/Profile.hpp" -#include "src/simix/smx_private.hpp" #include "src/surf/HostImpl.hpp" #include "src/surf/xml/platf_private.hpp" @@ -96,7 +95,7 @@ void sg_platf_new_peer(const simgrid::kernel::routing::PeerCreationArgs* args) auto* zone = dynamic_cast(current_routing); xbt_assert(zone, " tag can only be used in Vivaldi netzones."); - const auto* peer = zone->create_host(args->id, std::vector{args->speed}) + const auto* peer = zone->create_host(args->id, {args->speed}) ->set_state_profile(args->state_trace) ->set_speed_profile(args->speed_trace) ->set_coordinates(args->coord) @@ -109,7 +108,7 @@ void sg_platf_new_peer(const simgrid::kernel::routing::PeerCreationArgs* args) simgrid::kernel::routing::NetPoint* sg_platf_new_router(const std::string& name, const std::string& coords) { auto* netpoint = current_routing->create_router(name)->set_coordinates(coords); - XBT_DEBUG("Router '%s' has the id %u", netpoint->get_cname(), netpoint->id()); + XBT_DEBUG("Router '%s' has the id %lu", netpoint->get_cname(), netpoint->id()); return netpoint; } @@ -130,7 +129,8 @@ void sg_platf_new_link(const simgrid::kernel::routing::LinkCreationArgs* args) if (args->policy == simgrid::s4u::Link::SharingPolicy::SPLITDUPLEX) { link = current_routing->create_split_duplex_link(args->id, args->bandwidths); } else { - link = current_routing->create_link(args->id, args->bandwidths)->set_sharing_policy(args->policy); + link = current_routing->create_link(args->id, args->bandwidths); + link->get_impl()->set_sharing_policy(args->policy, {}); } sg_platf_set_link_properties(link, args); link->seal(); @@ -150,10 +150,10 @@ void sg_platf_new_disk(const simgrid::kernel::routing::DiskCreationArgs* disk) /** @brief Auxiliary function to create hosts */ static std::pair sg_platf_cluster_create_host(const simgrid::kernel::routing::ClusterCreationArgs* cluster, simgrid::s4u::NetZone* zone, - const std::vector& /*coord*/, int id) + const std::vector& /*coord*/, unsigned long id) { xbt_assert(static_cast(id) < cluster->radicals.size(), - "Zone(%s): error when creating host number %d in the zone. Insufficient number of radicals available " + "Zone(%s): error when creating host number %lu in the zone. Insufficient number of radicals available " "(total = %zu). Check the 'radical' parameter in XML", cluster->id.c_str(), id, cluster->radicals.size()); @@ -169,11 +169,12 @@ sg_platf_cluster_create_host(const simgrid::kernel::routing::ClusterCreationArgs /** @brief Auxiliary function to create loopback links */ static simgrid::s4u::Link* sg_platf_cluster_create_loopback(const simgrid::kernel::routing::ClusterCreationArgs* cluster, - simgrid::s4u::NetZone* zone, const std::vector& /*coord*/, int id) + simgrid::s4u::NetZone* zone, const std::vector& /*coord*/, + unsigned long id) { xbt_assert(static_cast(id) < cluster->radicals.size(), - "Zone(%s): error when creating loopback for host number %d in the zone. Insufficient number of radicals " - "available " + "Zone(%s): error when creating loopback for host number %lu in the zone. Insufficient number of " + "radicals available " "(total = %zu). Check the 'radical' parameter in XML", cluster->id.c_str(), id, cluster->radicals.size()); @@ -190,7 +191,8 @@ sg_platf_cluster_create_loopback(const simgrid::kernel::routing::ClusterCreation /** @brief Auxiliary function to create limiter links */ static simgrid::s4u::Link* sg_platf_cluster_create_limiter(const simgrid::kernel::routing::ClusterCreationArgs* cluster, simgrid::s4u::NetZone* zone, - const std::vector& /*coord*/, int id) + const std::vector& /*coord*/, + unsigned long id) { std::string link_id = std::string(cluster->id) + "_link_" + std::to_string(id) + "_limiter"; XBT_DEBUG("Cluster: creating limiter link=%s bw=%f", link_id.c_str(), cluster->limiter_link); @@ -263,7 +265,7 @@ static void sg_platf_new_cluster_flat(simgrid::kernel::routing::ClusterCreationA XBT_DEBUG(" ", bb_name.c_str(), cluster->bb_bw, cluster->bb_lat); - backbone = zone->create_link(bb_name, std::vector{cluster->bb_bw}) + backbone = zone->create_link(bb_name, cluster->bb_bw) ->set_sharing_policy(cluster->bb_sharing_policy) ->set_latency(cluster->bb_lat) ->seal(); @@ -288,7 +290,7 @@ static void sg_platf_new_cluster_flat(simgrid::kernel::routing::ClusterCreationA std::string loopback_name = link_id + "_loopback"; XBT_DEBUG("", loopback_name.c_str(), cluster->loopback_bw); - const auto* loopback = zone->create_link(loopback_name, std::vector{cluster->loopback_bw}) + const auto* loopback = zone->create_link(loopback_name, cluster->loopback_bw) ->set_sharing_policy(simgrid::s4u::Link::SharingPolicy::FATPIPE) ->set_latency(cluster->loopback_lat) ->seal(); @@ -303,7 +305,7 @@ static void sg_platf_new_cluster_flat(simgrid::kernel::routing::ClusterCreationA std::string limiter_name = std::string(link_id) + "_limiter"; XBT_DEBUG("", limiter_name.c_str(), cluster->limiter_link); - limiter = zone->create_link(limiter_name, std::vector{cluster->limiter_link})->seal(); + limiter = zone->create_link(limiter_name, cluster->limiter_link)->seal(); } // create link @@ -311,7 +313,7 @@ static void sg_platf_new_cluster_flat(simgrid::kernel::routing::ClusterCreationA if (cluster->sharing_policy == simgrid::s4u::Link::SharingPolicy::SPLITDUPLEX) { link = zone->create_split_duplex_link(link_id, cluster->bw)->set_latency(cluster->lat)->seal(); } else { - link = zone->create_link(link_id, std::vector{cluster->bw})->set_latency(cluster->lat)->seal(); + link = zone->create_link(link_id, cluster->bw)->set_latency(cluster->lat)->seal(); } /* adding routes */ @@ -357,7 +359,7 @@ static void sg_platf_cluster_set_hostlink(simgrid::kernel::routing::StarZone* zo const simgrid::s4u::Link* link_up, const simgrid::s4u::Link* link_down, const simgrid::s4u::Link* backbone) { - XBT_DEBUG("Push Host_link for host '%s' to position %u", netpoint->get_cname(), netpoint->id()); + XBT_DEBUG("Push Host_link for host '%s' to position %lu", netpoint->get_cname(), netpoint->id()); simgrid::s4u::LinkInRoute linkUp{link_up}; simgrid::s4u::LinkInRoute linkDown{link_down}; if (backbone) { @@ -393,12 +395,10 @@ static void sg_platf_build_cabinet(simgrid::kernel::routing::StarZone* zone, { for (int const& radical : args->radicals) { std::string id = args->prefix + std::to_string(radical) + args->suffix; - auto const* host = zone->create_host(id, std::vector{args->speed})->seal(); + auto const* host = zone->create_host(id, {args->speed})->seal(); - const auto* link_up = - zone->create_link("link_" + id + "_UP", std::vector{args->bw})->set_latency(args->lat)->seal(); - const auto* link_down = - zone->create_link("link_" + id + "_DOWN", std::vector{args->bw})->set_latency(args->lat)->seal(); + const auto* link_up = zone->create_link("link_" + id + "_UP", {args->bw})->set_latency(args->lat)->seal(); + const auto* link_down = zone->create_link("link_" + id + "_DOWN", {args->bw})->set_latency(args->lat)->seal(); sg_platf_cluster_set_hostlink(zone, host->get_netpoint(), link_up, link_down, backbone); } @@ -452,13 +452,14 @@ void sg_platf_new_bypass_route(simgrid::kernel::routing::RouteCreationArgs* rout void sg_platf_new_actor(simgrid::kernel::routing::ActorCreationArgs* actor) { + auto* engine = simgrid::s4u::Engine::get_instance(); sg_host_t host = sg_host_by_name(actor->host); if (not host) { // The requested host does not exist. Do a nice message to the user std::string msg = std::string("Cannot create actor '") + actor->function + "': host '" + actor->host + "' does not exist\nExisting hosts: '"; - std::vector list = simgrid::s4u::Engine::get_instance()->get_all_hosts(); + std::vector list = engine->get_all_hosts(); for (auto const& some_host : list) { msg += some_host->get_name(); @@ -471,8 +472,7 @@ void sg_platf_new_actor(simgrid::kernel::routing::ActorCreationArgs* actor) } xbt_die("%s", msg.c_str()); } - const simgrid::kernel::actor::ActorCodeFactory& factory = - simgrid::kernel::EngineImpl::get_instance()->get_function(actor->function); + const simgrid::kernel::actor::ActorCodeFactory& factory = engine->get_impl()->get_function(actor->function); xbt_assert(factory, "Error while creating an actor from the XML file: Function '%s' not registered", actor->function); double start_time = actor->start_time; @@ -523,7 +523,7 @@ void sg_platf_new_actor(simgrid::kernel::routing::ActorCreationArgs* actor) /** * @brief Auxiliary function to build the object NetZoneImpl * - * Builds the objects, setting its father properties and root netzone if needed + * Builds the objects, setting its parent properties and root netzone if needed * @param zone the parameters defining the Zone to build. * @return Pointer to recently created netzone */