X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/848f2365a5b3ecb2966dcb1c39fbb6d99acabc3e..38f246c4c46920a78ea0af8233449f402c178f04:/src/kernel/actor/ActorImpl.cpp diff --git a/src/kernel/actor/ActorImpl.cpp b/src/kernel/actor/ActorImpl.cpp index e7e2b7f496..93549a5e87 100644 --- a/src/kernel/actor/ActorImpl.cpp +++ b/src/kernel/actor/ActorImpl.cpp @@ -3,10 +3,11 @@ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ +#include "simgrid/s4u/Actor.hpp" #include "mc/mc.h" #include "simgrid/Exception.hpp" -#include "simgrid/s4u/Actor.hpp" #include "simgrid/s4u/Exec.hpp" +#include "src/kernel/EngineImpl.hpp" #include "src/kernel/activity/CommImpl.hpp" #include "src/kernel/activity/ExecImpl.hpp" #include "src/kernel/activity/IoImpl.hpp" @@ -14,7 +15,9 @@ #include "src/kernel/activity/SynchroRaw.hpp" #include "src/mc/mc_replay.hpp" #include "src/mc/remote/AppSide.hpp" -#include "src/simix/smx_private.hpp" +#if HAVE_SMPI +#include "src/smpi/include/private.hpp" +#endif #include "src/surf/HostImpl.hpp" #include "src/surf/cpu_interface.hpp" @@ -51,15 +54,7 @@ unsigned long* get_maxpid_addr() } ActorImpl* ActorImpl::by_pid(aid_t pid) { - auto item = simix_global->process_list.find(pid); - if (item != simix_global->process_list.end()) - return item->second; - - // Search the trash - for (auto& a : simix_global->actors_to_destroy) - if (a.get_pid() == pid) - return &a; - return nullptr; // Not found, even in the trash + return EngineImpl::get_instance()->get_actor_by_pid(pid); } ActorImpl* ActorImpl::self() @@ -78,7 +73,7 @@ ActorImpl::ActorImpl(xbt::string name, s4u::Host* host) : host_(host), name_(std ActorImpl::~ActorImpl() { - if (simix_global != nullptr && this != simix_global->maestro_) + if (EngineImpl::has_instance() && not EngineImpl::get_instance()->is_maestro(this)) s4u::Actor::on_destruction(*get_ciface()); } @@ -93,7 +88,7 @@ ActorImpl::~ActorImpl() ActorImplPtr ActorImpl::attach(const std::string& name, void* data, s4u::Host* host) { // This is mostly a copy/paste from create(), it'd be nice to share some code between those two functions. - + auto* engine = EngineImpl::get_instance(); XBT_DEBUG("Attach actor %s on host '%s'", name.c_str(), host->get_cname()); if (not host->is_on()) { @@ -103,20 +98,18 @@ ActorImplPtr ActorImpl::attach(const std::string& name, void* data, s4u::Host* h auto* actor = new ActorImpl(xbt::string(name), host); /* Actor data */ - actor->set_user_data(data); + actor->piface_.set_data(data); actor->code_ = nullptr; XBT_VERB("Create context %s", actor->get_cname()); - xbt_assert(simix_global != nullptr, "simix is not initialized, please call MSG_init first"); - actor->context_.reset(simix_global->context_factory->attach(actor)); + actor->context_.reset(engine->get_context_factory()->attach(actor)); /* Add the actor to it's host actor list */ host->get_impl()->add_actor(actor); /* Now insert it in the global actor list and in the actors to run list */ - simix_global->process_list[actor->get_pid()] = actor; - XBT_DEBUG("Inserting [%p] %s(%s) in the to_run list", actor, actor->get_cname(), host->get_cname()); - simix_global->actors_to_run.push_back(actor); + engine->add_actor(actor->get_pid(), actor); + engine->add_actor_to_run_list_no_check(actor); intrusive_ptr_add_ref(actor); auto* context = dynamic_cast(actor->context_.get()); @@ -145,15 +138,16 @@ void ActorImpl::detach() void ActorImpl::cleanup_from_simix() { - const std::lock_guard lock(simix_global->mutex); - simix_global->process_list.erase(pid_); + auto* engine = EngineImpl::get_instance(); + const std::lock_guard lock(engine->get_mutex()); + engine->remove_actor(pid_); if (host_ && host_actor_list_hook.is_linked()) host_->get_impl()->remove_actor(this); - if (not smx_destroy_list_hook.is_linked()) { + if (not kernel_destroy_list_hook.is_linked()) { #if SIMGRID_HAVE_MC - xbt_dynar_push_as(simix_global->dead_actors_vector, ActorImpl*, this); + engine->add_dead_actor_to_dynar(this); #endif - simix_global->actors_to_destroy.push_back(*this); + engine->add_actor_to_destroy_list(*this); } } @@ -183,7 +177,7 @@ void ActorImpl::cleanup() XBT_DEBUG("%s@%s(%ld) should not run anymore", get_cname(), get_host()->get_cname(), get_pid()); - if (this == simix_global->maestro_) /* Do not cleanup maestro */ + if (EngineImpl::get_instance()->is_maestro(this)) /* Do not cleanup maestro */ return; XBT_DEBUG("Cleanup actor %s (%p), waiting synchro %p", get_cname(), this, waiting_synchro_.get()); @@ -230,7 +224,7 @@ void ActorImpl::exit() activities_.remove(waiting_synchro_); waiting_synchro_ = nullptr; } - for (auto& activity : activities_) + for (auto const& activity : activities_) activity->cancel(); activities_.clear(); @@ -240,7 +234,8 @@ void ActorImpl::exit() void ActorImpl::kill(ActorImpl* actor) const { - xbt_assert(actor != simix_global->maestro_, "Killing maestro is a rather bad idea"); + auto* engine = EngineImpl::get_instance(); + xbt_assert(not engine->is_maestro(actor), "Killing maestro is a rather bad idea"); if (actor->finished_) { XBT_DEBUG("Ignoring request to kill actor %s@%s that is already dead", actor->get_cname(), actor->host_->get_cname()); @@ -254,28 +249,23 @@ void ActorImpl::kill(ActorImpl* actor) const if (actor == this) { XBT_DEBUG("Go on, this is a suicide,"); - } else if (std::find(begin(simix_global->actors_to_run), end(simix_global->actors_to_run), actor) != - end(simix_global->actors_to_run)) { - XBT_DEBUG("Actor %s is already in the to_run list", actor->get_cname()); - } else { - XBT_DEBUG("Inserting %s in the to_run list", actor->get_cname()); - simix_global->actors_to_run.push_back(actor); - } + } else + engine->add_actor_to_run_list(actor); } void ActorImpl::kill_all() const { - for (auto const& kv : simix_global->process_list) + for (auto const& kv : EngineImpl::get_instance()->get_actor_list()) if (kv.second != this) this->kill(kv.second); } void ActorImpl::set_kill_time(double kill_time) { - if (kill_time <= SIMIX_get_clock()) + if (kill_time <= s4u::Engine::get_clock()) return; XBT_DEBUG("Set kill time %f for actor %s@%s", kill_time, get_cname(), host_->get_cname()); - kill_timer_ = simix::Timer::set(kill_time, [this] { + kill_timer_ = timer::Timer::set(kill_time, [this] { this->exit(); kill_timer_ = nullptr; }); @@ -283,7 +273,7 @@ void ActorImpl::set_kill_time(double kill_time) double ActorImpl::get_kill_time() const { - return kill_timer_ ? kill_timer_->date : 0.0; + return kill_timer_ ? kill_timer_->get_date() : 0.0; } void ActorImpl::yield() @@ -319,9 +309,10 @@ void ActorImpl::yield() } } - if (SMPI_switch_data_segment && not finished_) { - SMPI_switch_data_segment(get_iface()); - } +#if HAVE_SMPI + if (not finished_) + smpi_switch_data_segment(get_iface()); +#endif } /** This actor will be terminated automatically when the last non-daemon actor finishes */ @@ -329,27 +320,21 @@ void ActorImpl::daemonize() { if (not daemon_) { daemon_ = true; - simix_global->daemons.push_back(this); + EngineImpl::get_instance()->add_daemon(this); } } void ActorImpl::undaemonize() { if (daemon_) { - auto& vect = simix_global->daemons; - auto it = std::find(vect.begin(), vect.end(), this); - xbt_assert(it != vect.end(), "The dying daemon is not a daemon after all. Please report that bug."); - /* Don't move the whole content since we don't really care about the order */ - - std::swap(*it, vect.back()); - vect.pop_back(); daemon_ = false; + EngineImpl::get_instance()->remove_daemon(this); } } s4u::Actor* ActorImpl::restart() { - xbt_assert(this != simix_global->maestro_, "Restarting maestro is not supported"); + xbt_assert(not EngineImpl::get_instance()->is_maestro(this), "Restarting maestro is not supported"); XBT_DEBUG("Restarting actor %s on %s", get_cname(), host_->get_cname()); @@ -379,7 +364,7 @@ void ActorImpl::suspend() suspended_ = true; /* Suspend the activities associated with this actor. */ - for (auto& activity : activities_) + for (auto const& activity : activities_) activity->suspend(); } @@ -397,10 +382,10 @@ void ActorImpl::resume() suspended_ = false; /* resume the activities that were blocked when suspending the actor. */ - for (auto& activity : activities_) + for (auto const& activity : activities_) activity->resume(); if (not waiting_synchro_) // Reschedule the actor if it was forcefully unscheduled in yield() - simix_global->actors_to_run.push_back(this); + EngineImpl::get_instance()->add_actor_to_run_list_no_check(this); XBT_OUT(); } @@ -443,15 +428,16 @@ void ActorImpl::throw_exception(std::exception_ptr e) void ActorImpl::simcall_answer() { - if (this != simix_global->maestro_) { + auto* engine = EngineImpl::get_instance(); + if (not engine->is_maestro(this)) { XBT_DEBUG("Answer simcall %s issued by %s (%p)", SIMIX_simcall_name(simcall_), get_cname(), this); xbt_assert(simcall_.call_ != simix::Simcall::NONE); simcall_.call_ = simix::Simcall::NONE; + const auto& actors_to_run = engine->get_actors_to_run(); xbt_assert(not XBT_LOG_ISENABLED(simix_process, xbt_log_priority_debug) || - std::find(begin(simix_global->actors_to_run), end(simix_global->actors_to_run), this) == - end(simix_global->actors_to_run), + std::find(begin(actors_to_run), end(actors_to_run), this) == end(actors_to_run), "Actor %p should not exist in actors_to_run!", this); - simix_global->actors_to_run.push_back(this); + engine->add_actor_to_run_list_no_check(this); } } @@ -477,6 +463,7 @@ ActorImplPtr ActorImpl::init(const std::string& name, s4u::Host* host) const ActorImpl* ActorImpl::start(const ActorCode& code) { xbt_assert(code && host_ != nullptr, "Invalid parameters"); + auto* engine = EngineImpl::get_instance(); if (not host_->is_on()) { XBT_WARN("Cannot launch actor '%s' on failed host '%s'", name_.c_str(), host_->get_cname()); @@ -486,17 +473,16 @@ ActorImpl* ActorImpl::start(const ActorCode& code) this->code_ = code; XBT_VERB("Create context %s", get_cname()); - context_.reset(simix_global->context_factory->create_context(ActorCode(code), this)); + context_.reset(engine->get_context_factory()->create_context(ActorCode(code), this)); XBT_DEBUG("Start context '%s'", get_cname()); /* Add the actor to its host's actor list */ host_->get_impl()->add_actor(this); - simix_global->process_list[pid_] = this; + engine->add_actor(pid_, this); /* Now insert it in the global actor list and in the actor to run list */ - XBT_DEBUG("Inserting [%p] %s(%s) in the to_run list", this, get_cname(), host_->get_cname()); - simix_global->actors_to_run.push_back(this); + engine->add_actor_to_run_list_no_check(this); return this; } @@ -513,7 +499,7 @@ ActorImplPtr ActorImpl::create(const std::string& name, const ActorCode& code, v actor = self()->init(xbt::string(name), host); /* actor data */ - actor->set_user_data(data); + actor->piface_.set_data(data); actor->start(code); @@ -522,43 +508,24 @@ ActorImplPtr ActorImpl::create(const std::string& name, const ActorCode& code, v void create_maestro(const std::function& code) { + auto* engine = EngineImpl::get_instance(); /* Create maestro actor and initialize it */ auto* maestro = new ActorImpl(xbt::string(""), /*host*/ nullptr); if (not code) { - maestro->context_.reset(simix_global->context_factory->create_context(ActorCode(), maestro)); + maestro->context_.reset(engine->get_context_factory()->create_context(ActorCode(), maestro)); } else { - maestro->context_.reset(simix_global->context_factory->create_maestro(ActorCode(code), maestro)); + maestro->context_.reset(engine->get_context_factory()->create_maestro(ActorCode(code), maestro)); } - maestro->simcall_.issuer_ = maestro; - simix_global->maestro_ = maestro; + maestro->simcall_.issuer_ = maestro; + engine->set_maestro(maestro); } } // namespace actor } // namespace kernel } // namespace simgrid -int SIMIX_process_count() // XBT_ATTRIB_DEPRECATED_v329 -{ - return simix_global->process_list.size(); -} - -void* SIMIX_process_self_get_data() // XBT_ATTRIB_DEPRECATED_v329 -{ - smx_actor_t self = simgrid::kernel::actor::ActorImpl::self(); - - if (self == nullptr) { - return nullptr; - } - return self->get_user_data(); -} - -void SIMIX_process_self_set_data(void* data) // XBT_ATTRIB_DEPRECATED_v329 -{ - simgrid::kernel::actor::ActorImpl::self()->set_user_data(data); -} - /* needs to be public and without simcall because it is called by exceptions and logging events */ const char* SIMIX_process_self_get_name() @@ -567,19 +534,7 @@ const char* SIMIX_process_self_get_name() } /** @brief Returns the process from PID. */ -smx_actor_t SIMIX_process_from_PID(aid_t pid) +smx_actor_t SIMIX_process_from_PID(aid_t pid) // XBT_ATTRIB_DEPRECATD_v331 { return simgrid::kernel::actor::ActorImpl::by_pid(pid); } - -void SIMIX_process_on_exit(smx_actor_t actor, - const std::function& fun) // XBT_ATTRIB_DEPRECATED_v329 -{ - xbt_assert(actor, "current process not found: are you in maestro context ?"); - actor->on_exit->emplace_back(fun); -} - -void simcall_process_set_data(smx_actor_t process, void* data) // XBT_ATTRIB_DEPRECATED_v329 -{ - simgrid::kernel::actor::simcall([process, data] { process->set_user_data(data); }); -}