X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/817094bccfaafe29059ed2ff71c573699d5909bd..4634214e18b847f6346048fa12179d3d99ae82c9:/include/xbt/Extendable.hpp diff --git a/include/xbt/Extendable.hpp b/include/xbt/Extendable.hpp index 5cf36a9525..0f51c234f2 100644 --- a/include/xbt/Extendable.hpp +++ b/include/xbt/Extendable.hpp @@ -1,4 +1,4 @@ -/* Copyright (c) 2015. The SimGrid Team. +/* Copyright (c) 2015-2018. The SimGrid Team. * All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it @@ -22,7 +22,7 @@ class Extension { static const std::size_t INVALID_ID = std::numeric_limits::max(); std::size_t id_; friend class Extendable; - constexpr Extension(std::size_t id) : id_(id) {} + explicit constexpr Extension(std::size_t id) : id_(id) {} public: explicit constexpr Extension() : id_(INVALID_ID) {} std::size_t id() const { return id_; } @@ -48,7 +48,6 @@ template class Extendable { private: static std::vector deleters_; -protected: std::vector extensions_; public: static size_t extension_create(void (*deleter)(void*)) @@ -65,7 +64,7 @@ public: template static Extension extension_create() { - return extension_create([](void* p){ delete static_cast(p); }); + return Extension(extension_create([](void* p) { delete static_cast(p); })); } Extendable() : extensions_(deleters_.size(), nullptr) {} ~Extendable() @@ -77,7 +76,7 @@ public: * an extension of B might need to have the extension of A around when executing * its cleanup function/destructor. */ for (std::size_t i = extensions_.size(); i > 0; --i) - if (extensions_[i - 1] != nullptr) + if (extensions_[i - 1] != nullptr && deleters_[i - 1] != nullptr) deleters_[i - 1](extensions_[i - 1]); }