X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/7c480b01951b33f03d72ede0a47a45a88bd40b61..13fee991f1cf09401c66b1b2958ad6f24d5f3e74:/src/surf/cpu_interface.cpp diff --git a/src/surf/cpu_interface.cpp b/src/surf/cpu_interface.cpp index bbac0ef94c..6445903e61 100644 --- a/src/surf/cpu_interface.cpp +++ b/src/surf/cpu_interface.cpp @@ -4,8 +4,8 @@ * under the terms of the license (GNU LGPL) which comes with this package. */ #include "cpu_interface.hpp" -#include "src/instr/instr_private.hpp" // TRACE_is_enabled(). FIXME: remove by subscribing tracing to the surf signals -#include +#include "src/surf/surf_interface.hpp" +#include "surf/surf.hpp" XBT_LOG_EXTERNAL_CATEGORY(surf_kernel); XBT_LOG_NEW_DEFAULT_SUBCATEGORY(surf_cpu, surf, "Logging specific to the SURF cpu module"); @@ -22,44 +22,21 @@ namespace surf { void CpuModel::update_actions_state_lazy(double now, double /*delta*/) { - while (not actionHeapIsEmpty() && double_equals(actionHeapTopDate(), now, sg_surf_precision)) { + while (not get_action_heap().empty() && double_equals(get_action_heap().top_date(), now, sg_surf_precision)) { - CpuAction* action = static_cast(actionHeapPop()); + CpuAction* action = static_cast(get_action_heap().pop()); XBT_CDEBUG(surf_kernel, "Something happened to action %p", action); - if (TRACE_is_enabled()) { - Cpu* cpu = static_cast(action->get_variable()->get_constraint(0)->get_id()); - TRACE_surf_host_set_utilization(cpu->getCname(), action->get_category(), action->get_variable()->get_value(), - action->get_last_update(), now - action->get_last_update()); - } - action->finish(kernel::resource::Action::State::done); + action->finish(kernel::resource::Action::State::FINISHED); XBT_CDEBUG(surf_kernel, "Action %p finished", action); } - if (TRACE_is_enabled()) { - //defining the last timestamp that we can safely dump to trace file - //without losing the event ascending order (considering all CPU's) - double smaller = -1; - for (kernel::resource::Action const& action : *get_running_action_set()) { - if (smaller < 0 || action.get_last_update() < smaller) - smaller = action.get_last_update(); - } - if (smaller > 0) { - TRACE_last_timestamp_to_dump = smaller; - } - } } void CpuModel::update_actions_state_full(double now, double delta) { - for (auto it = std::begin(*get_running_action_set()); it != std::end(*get_running_action_set());) { + for (auto it = std::begin(*get_started_action_set()); it != std::end(*get_started_action_set());) { CpuAction& action = static_cast(*it); ++it; // increment iterator here since the following calls to action.finish() may invalidate it - if (TRACE_is_enabled()) { - Cpu* cpu = static_cast(action.get_variable()->get_constraint(0)->get_id()); - TRACE_surf_host_set_utilization(cpu->getCname(), action.get_category(), action.get_variable()->get_value(), - now - delta, delta); - TRACE_last_timestamp_to_dump = now - delta; - } action.update_remains(action.get_variable()->get_value() * delta); @@ -68,7 +45,7 @@ void CpuModel::update_actions_state_full(double now, double delta) if (((action.get_remains_no_update() <= 0) && (action.get_variable()->get_weight() > 0)) || ((action.get_max_duration() != NO_MAX_DURATION) && (action.get_max_duration() <= 0))) { - action.finish(kernel::resource::Action::State::done); + action.finish(kernel::resource::Action::State::FINISHED); } } } @@ -83,14 +60,14 @@ Cpu::Cpu(kernel::resource::Model* model, simgrid::s4u::Host* host, std::vector* speedPerPstate, int core) - : Resource(model, host->getCname(), constraint), coresAmount_(core), host_(host) + : Resource(model, host->get_cname(), constraint), coresAmount_(core), host_(host) { - xbt_assert(core > 0, "Host %s must have at least one core, not 0.", host->getCname()); + xbt_assert(core > 0, "Host %s must have at least one core, not 0.", host->get_cname()); speed_.peak = speedPerPstate->front(); speed_.scale = 1; host->pimpl_cpu = this; - xbt_assert(speed_.scale > 0, "Speed of host %s must be >0", host->getCname()); + xbt_assert(speed_.scale > 0, "Speed of host %s must be >0", host->get_cname()); // Copy the power peak array: for (double const& value : *speedPerPstate) { @@ -110,7 +87,7 @@ void Cpu::setPState(int pstate_index) xbt_assert(pstate_index <= static_cast(speedPerPstate_.size()), "Invalid parameters for CPU %s (pstate %d > length of pstates %d). Please fix your platform file, or your " "call to change the pstate.", - getCname(), pstate_index, static_cast(speedPerPstate_.size())); + get_cname(), pstate_index, static_cast(speedPerPstate_.size())); double new_peak_speed = speedPerPstate_[pstate_index]; pstate_ = pstate_index; @@ -136,15 +113,14 @@ double Cpu::getSpeed(double load) return load * speed_.peak; } -double Cpu::getAvailableSpeed() +double Cpu::get_available_speed() { /* number between 0 and 1 */ return speed_.scale; } void Cpu::onSpeedChange() { - TRACE_surf_host_set_speed(surf_get_clock(), getCname(), coresAmount_ * speed_.scale * speed_.peak); - s4u::Host::onSpeedChange(*host_); + s4u::Host::on_speed_change(*host_); } int Cpu::coreCount() @@ -154,13 +130,13 @@ int Cpu::coreCount() void Cpu::setStateTrace(tmgr_trace_t trace) { - xbt_assert(stateEvent_ == nullptr, "Cannot set a second state trace to Host %s", host_->getCname()); + xbt_assert(stateEvent_ == nullptr, "Cannot set a second state trace to Host %s", host_->get_cname()); stateEvent_ = future_evt_set->add_trace(trace, this); } -void Cpu::setSpeedTrace(tmgr_trace_t trace) +void Cpu::set_speed_trace(tmgr_trace_t trace) { - xbt_assert(speed_.event == nullptr, "Cannot set a second speed trace to Host %s", host_->getCname()); + xbt_assert(speed_.event == nullptr, "Cannot set a second speed trace to Host %s", host_->get_cname()); speed_.event = future_evt_set->add_trace(trace, this); } @@ -172,7 +148,7 @@ void Cpu::setSpeedTrace(tmgr_trace_t trace) void CpuAction::update_remains_lazy(double now) { - xbt_assert(get_state_set() == get_model()->get_running_action_set(), + xbt_assert(get_state_set() == get_model()->get_started_action_set(), "You're updating an action that is not running."); xbt_assert(get_priority() > 0, "You're updating an action that seems suspended."); @@ -183,11 +159,6 @@ void CpuAction::update_remains_lazy(double now) get_last_update()); update_remains(get_last_value() * delta); - if (TRACE_is_enabled()) { - Cpu* cpu = static_cast(get_variable()->get_constraint(0)->get_id()); - TRACE_surf_host_set_utilization(cpu->getCname(), get_category(), get_last_value(), get_last_update(), - now - get_last_update()); - } XBT_CDEBUG(surf_kernel, "Updating action(%p): remains is now %f", this, get_remains_no_update()); }