X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/7bbdf88838ab4ac0694163ff64fa8ed5344f555c..deaf4c6f1cb3026b053ca861fe77313c78385be7:/src/surf/network_constant.cpp

diff --git a/src/surf/network_constant.cpp b/src/surf/network_constant.cpp
index be179760ab..71c87a1c4c 100644
--- a/src/surf/network_constant.cpp
+++ b/src/surf/network_constant.cpp
@@ -1,5 +1,4 @@
-/* Copyright (c) 2013-2015. The SimGrid Team.
- * All rights reserved.                                                     */
+/* Copyright (c) 2013-2018. The SimGrid Team. All rights reserved.          */
 
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
@@ -19,83 +18,77 @@ void surf_network_model_init_Constant()
 }
 
 namespace simgrid {
-  namespace surf {
-  Link* NetworkConstantModel::createLink(const char* name, double bw, double lat, e_surf_link_sharing_policy_t policy)
-  {
+namespace surf {
+LinkImpl* NetworkConstantModel::createLink(const std::string& name, double bw, double lat,
+                                           e_surf_link_sharing_policy_t policy)
+{
 
-    xbt_die("Refusing to create the link %s: there is no link in the Constant network model. "
-            "Please remove any link from your platform (and switch to routing='None')",
-            name);
-    return nullptr;
-    }
+  xbt_die("Refusing to create the link %s: there is no link in the Constant network model. "
+          "Please remove any link from your platform (and switch to routing='None')",
+          name.c_str());
+  return nullptr;
+}
 
-    double NetworkConstantModel::nextOccuringEvent(double /*now*/)
-    {
-      double min = -1.0;
+double NetworkConstantModel::nextOccuringEvent(double /*now*/)
+{
+  double min = -1.0;
+  for (kernel::resource::Action const& action : *getRunningActionSet()) {
+    const NetworkConstantAction& net_action = static_cast<const NetworkConstantAction&>(action);
+    if (net_action.latency_ > 0 && (min < 0 || net_action.latency_ < min))
+      min = net_action.latency_;
+  }
+  return min;
+}
 
-      ActionList *actionSet = getRunningActionSet();
-      for(auto it(actionSet->begin()), itend(actionSet->end()) ; it != itend ; ++it) {
-        NetworkConstantAction *action = static_cast<NetworkConstantAction*>(&*it);
-        if (action->latency_ > 0 && (min < 0 || action->latency_ < min))
-          min = action->latency_;
+void NetworkConstantModel::updateActionsState(double /*now*/, double delta)
+{
+  for (auto it = std::begin(*getRunningActionSet()); it != std::end(*getRunningActionSet());) {
+    NetworkConstantAction& action = static_cast<NetworkConstantAction&>(*it);
+    ++it; // increment iterator here since the following calls to action.finish() may invalidate it
+    if (action.latency_ > 0) {
+      if (action.latency_ > delta) {
+        double_update(&action.latency_, delta, sg_surf_precision);
+      } else {
+        action.latency_ = 0.0;
       }
-
-      return min;
     }
+    action.updateRemains(action.getCost() * delta / action.initialLatency_);
+    if (action.getMaxDuration() != NO_MAX_DURATION)
+      action.updateMaxDuration(delta);
 
-    void NetworkConstantModel::updateActionsState(double /*now*/, double delta)
-    {
-      NetworkConstantAction *action = nullptr;
-      ActionList *actionSet = getRunningActionSet();
-      for(ActionList::iterator it(actionSet->begin()), itNext=it, itend(actionSet->end())
-          ; it != itend ; it=itNext) {
-        ++itNext;
-        action = static_cast<NetworkConstantAction*>(&*it);
-        if (action->latency_ > 0) {
-          if (action->latency_ > delta) {
-            double_update(&(action->latency_), delta, sg_surf_precision);
-          } else {
-            action->latency_ = 0.0;
-          }
-        }
-        action->updateRemains(action->getCost() * delta / action->initialLatency_);
-        if (action->getMaxDuration() != NO_MAX_DURATION)
-          action->updateMaxDuration(delta);
-
-        if (action->getRemainsNoUpdate() <= 0) {
-          action->finish();
-          action->setState(Action::State::done);
-        } else if ((action->getMaxDuration() != NO_MAX_DURATION)
-            && (action->getMaxDuration() <= 0)) {
-          action->finish();
-          action->setState(Action::State::done);
-        }
-      }
+    if ((action.getRemainsNoUpdate() <= 0) ||
+        ((action.getMaxDuration() != NO_MAX_DURATION) && (action.getMaxDuration() <= 0))) {
+      action.finish(kernel::resource::Action::State::done);
     }
+  }
+}
 
-    Action* NetworkConstantModel::communicate(s4u::Host* src, s4u::Host* dst, double size, double rate)
-    {
-      NetworkConstantAction *action = new NetworkConstantAction(this, size, sg_latency_factor);
+kernel::resource::Action* NetworkConstantModel::communicate(s4u::Host* src, s4u::Host* dst, double size, double rate)
+{
+  NetworkConstantAction* action = new NetworkConstantAction(this, size, sg_latency_factor);
 
-      Link::onCommunicate(action, src, dst);
-      return action;
-    }
+  simgrid::s4u::Link::onCommunicate(action, src, dst);
+  return action;
+}
 
-    /**********
-     * Action *
-     **********/
-    NetworkConstantAction::NetworkConstantAction(NetworkConstantModel *model_, double size, double latency)
-    : NetworkAction(model_, size, false)
-    , initialLatency_(latency)
-    {
-      latency_ = latency;
-      if (latency_ <= 0.0) {
-        stateSet_ = getModel()->getDoneActionSet();
-        stateSet_->push_back(*this);
-      }
-    };
+/**********
+ * Action *
+ **********/
+NetworkConstantAction::NetworkConstantAction(NetworkConstantModel* model_, double size, double latency)
+    : NetworkAction(model_, size, false), initialLatency_(latency)
+{
+  latency_ = latency;
+  if (latency_ <= 0.0) {
+    stateSet_ = model_->getDoneActionSet();
+    stateSet_->push_back(*this);
+  }
+};
 
-    NetworkConstantAction::~NetworkConstantAction() {}
+NetworkConstantAction::~NetworkConstantAction() = default;
 
-  }
+void NetworkConstantAction::updateRemainingLazy(double /*now*/)
+{
+  THROW_IMPOSSIBLE;
+}
+}
 }