X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/7aae92e42d677a34e260f2364ba5a33f4d1f6b32..55092bf3f9fe1cccfe72f7ef81fcd51f9a0eb4ca:/src/simix/smx_synchro.cpp diff --git a/src/simix/smx_synchro.cpp b/src/simix/smx_synchro.cpp index 5a4d449efb..81017c1cff 100644 --- a/src/simix/smx_synchro.cpp +++ b/src/simix/smx_synchro.cpp @@ -7,9 +7,10 @@ #include "src/surf/surf_interface.hpp" #include "smx_private.h" -#include "xbt/log.h" +#include +#include -#include "src/simix/SynchroRaw.hpp" +#include "src/kernel/activity/SynchroRaw.hpp" XBT_LOG_NEW_DEFAULT_SUBCATEGORY(simix_synchro, simix, "SIMIX Synchronization (mutex, semaphores and conditions)"); @@ -26,7 +27,7 @@ static smx_synchro_t SIMIX_synchro_wait(sg_host_t smx_host, double timeout) { XBT_IN("(%p, %f)",smx_host,timeout); - simgrid::simix::Raw *sync = new simgrid::simix::Raw(); + simgrid::kernel::activity::Raw *sync = new simgrid::kernel::activity::Raw(); sync->sleep = surf_host_sleep(smx_host, timeout); sync->sleep->setData(sync); XBT_OUT(); @@ -97,11 +98,11 @@ void SIMIX_synchro_finish(smx_synchro_t synchro) namespace simgrid { namespace simix { -Mutex::Mutex() +Mutex::Mutex() : mutex_(this) { XBT_IN("(%p)", this); // Useful to initialize sleeping swag: - simgrid::simix::Process p; + simgrid::simix::ActorImpl p; this->sleeping = xbt_swag_new(xbt_swag_offset(p, synchro_hookup)); XBT_OUT(); } @@ -166,8 +167,8 @@ void Mutex::unlock(smx_process_t issuer) /* If the mutex is not owned by the issuer, that's not good */ if (issuer != this->owner) - THROWF(mismatch_error, 0, "Cannot release that mutex: it was locked by %s (pid:%d), not by you.", - SIMIX_process_get_name(this->owner),SIMIX_process_get_PID(this->owner)); + THROWF(mismatch_error, 0, "Cannot release that mutex: it was locked by %s (pid:%ld), not by you.", + this->owner->name.c_str(),this->owner->pid); if (xbt_swag_size(this->sleeping) > 0) { /*process to wake up */ @@ -187,17 +188,19 @@ void Mutex::unlock(smx_process_t issuer) } } -void SIMIX_mutex_destroy(smx_mutex_t mutex) +/** Increase the refcount for this mutex */ +smx_mutex_t SIMIX_mutex_ref(smx_mutex_t mutex) { if (mutex != nullptr) - intrusive_ptr_release(mutex); + intrusive_ptr_add_ref(mutex); + return mutex; } -XBT_PUBLIC(smx_mutex_t) SIMIX_mutex_dup(smx_mutex_t mutex) +/** Decrease the refcount for this mutex */ +void SIMIX_mutex_unref(smx_mutex_t mutex) { if (mutex != nullptr) - intrusive_ptr_add_ref(mutex); - return mutex; + intrusive_ptr_release(mutex); } smx_mutex_t simcall_HANDLER_mutex_init(smx_simcall_t simcall) @@ -234,10 +237,10 @@ void simcall_HANDLER_mutex_unlock(smx_simcall_t simcall, smx_mutex_t mutex) smx_cond_t SIMIX_cond_init(void) { XBT_IN("()"); - simgrid::simix::Process p; - smx_cond_t cond = xbt_new0(s_smx_cond_t, 1); + simgrid::simix::ActorImpl p; + smx_cond_t cond = new s_smx_cond(); cond->sleeping = xbt_swag_new(xbt_swag_offset(p, synchro_hookup)); - cond->mutex = nullptr; + cond->refcount_ = 1; XBT_OUT(); return cond; } @@ -348,25 +351,40 @@ void SIMIX_cond_broadcast(smx_cond_t cond) XBT_OUT(); } -/** - * \brief Destroys a condition. - * - * Destroys and frees the condition's memory. - * \param cond A condition - */ -void SIMIX_cond_destroy(smx_cond_t cond) +smx_cond_t SIMIX_cond_ref(smx_cond_t cond) +{ + if (cond != nullptr) + intrusive_ptr_add_ref(cond); + return cond; +} + +void SIMIX_cond_unref(smx_cond_t cond) { XBT_IN("(%p)",cond); XBT_DEBUG("Destroy condition %p", cond); - if (cond != nullptr) { + intrusive_ptr_release(cond); + } + XBT_OUT(); +} + + +void intrusive_ptr_add_ref(s_smx_cond_t *cond) +{ + auto previous = (cond->refcount_)++; + xbt_assert(previous != 0); + (void) previous; +} + +void intrusive_ptr_release(s_smx_cond_t *cond) +{ + auto count = --(cond->refcount_); + if (count == 0) { xbt_assert(xbt_swag_size(cond->sleeping) == 0, "Cannot destroy conditional since someone is still using it"); - xbt_swag_free(cond->sleeping); - xbt_free(cond); + delete cond; } - XBT_OUT(); } /******************************** Semaphores **********************************/ @@ -375,7 +393,7 @@ void SIMIX_cond_destroy(smx_cond_t cond) smx_sem_t SIMIX_sem_init(unsigned int value) { XBT_IN("(%u)",value); - simgrid::simix::Process p; + simgrid::simix::ActorImpl p; smx_sem_t sem = xbt_new0(s_smx_sem_t, 1); sem->sleeping = xbt_swag_new(xbt_swag_offset(p, synchro_hookup));