X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/76aa5f3a171581cdc6c36e481fd96201d186cc01..9982cd9fee0903300e2323bc196a5262f4e5b969:/src/surf/plugins/host_dvfs.cpp diff --git a/src/surf/plugins/host_dvfs.cpp b/src/surf/plugins/host_dvfs.cpp index 808bab9c04..251f05ff0d 100644 --- a/src/surf/plugins/host_dvfs.cpp +++ b/src/surf/plugins/host_dvfs.cpp @@ -39,7 +39,7 @@ protected: public: double sampling_rate; - Governor(simgrid::s4u::Host* ptr) : host(ptr) { init(); } + explicit Governor(simgrid::s4u::Host* ptr) : host(ptr) { init(); } void init() { @@ -58,14 +58,14 @@ public: class Performance : public Governor { public: - Performance(simgrid::s4u::Host* ptr) : Governor(ptr) {} + explicit Performance(simgrid::s4u::Host* ptr) : Governor(ptr) {} void update() { host->setPstate(0); } }; class Powersave : public Governor { public: - Powersave(simgrid::s4u::Host* ptr) : Governor(ptr) {} + explicit Powersave(simgrid::s4u::Host* ptr) : Governor(ptr) {} void update() { host->setPstate(host->getPstatesCount() - 1); } }; @@ -74,7 +74,7 @@ class OnDemand : public Governor { double freq_up_threshold = 0.95; public: - OnDemand(simgrid::s4u::Host* ptr) : Governor(ptr) {} + explicit OnDemand(simgrid::s4u::Host* ptr) : Governor(ptr) {} void update() { @@ -86,10 +86,10 @@ public: } else { /* The actual implementation uses a formula here: (See Kernel file cpufreq_ondemand.c:158) * - * freq_next = min_f + load * (max_f - min_f) / 100; + * freq_next = min_f + load * (max_f - min_f) / 100 * * So they assume that frequency increases by 100 MHz. We will just use - * lowest_pstate - load*pstatesCount(); + * lowest_pstate - load*pstatesCount() */ int max_pstate = host->getPstatesCount() - 1; @@ -104,7 +104,7 @@ class Conservative : public Governor { double freq_down_threshold = .2; public: - Conservative(simgrid::s4u::Host* ptr) : Governor(ptr) {} + explicit Conservative(simgrid::s4u::Host* ptr) : Governor(ptr) {} void update() { @@ -204,7 +204,7 @@ static void on_host_added(simgrid::s4u::Host& host) } /* **************************** Public interface *************************** */ -SG_BEGIN_DECL() +extern "C" { /** \ingroup SURF_plugin_load * \brief Initializes the HostDvfs plugin @@ -225,5 +225,4 @@ void sg_host_dvfs_plugin_init() xbt_cfg_register_string("plugin/dvfs/governor", "performance", nullptr, "Which Governor should be used that adapts the CPU frequency?"); } - -SG_END_DECL() +}