X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/7635b2e5c0f40d6fa06fa45d4c638a452aaf7743..dcbbc368228a7623d2f8a53028f6da8f64a5a128:/src/xbt/ex.c

diff --git a/src/xbt/ex.c b/src/xbt/ex.c
index 8ee3c3d334..02e8edcebd 100644
--- a/src/xbt/ex.c
+++ b/src/xbt/ex.c
@@ -52,6 +52,7 @@ void xbt_backtrace_display(void) {
 #endif
 }
 
+
 void xbt_ex_setup_backtrace(xbt_ex_t *e)  {
 #if defined(HAVE_EXECINFO_H) && defined(HAVE_POPEN) && defined(ADDR2LINE)
   int i;
@@ -59,7 +60,7 @@ void xbt_ex_setup_backtrace(xbt_ex_t *e)  {
   char **backtrace = backtrace_symbols (e->bt, e->used);
   
   /* To build the commandline of addr2line */
-  char *cmd = xbt_new(char,strlen(ADDR2LINE)+strlen(xbt_binary_name)+20*e->used);
+  char *cmd = xbt_new(char,strlen(ADDR2LINE)+25+strlen(xbt_binary_name)+32*e->used);
   char *curr=cmd;
   
   /* to extract the addresses from the backtrace */
@@ -72,16 +73,22 @@ void xbt_ex_setup_backtrace(xbt_ex_t *e)  {
 
   /* size (in char) of pointers on this arch */
   int addr_len=0;
-  
+
+  /* Some arches only have stubs of backtrace, no implementation (hppa comes to mind) */
+  if (!e->used)
+     return;
+   
   /* build the commandline */
   curr += sprintf(curr,"%s -f -e %s ",ADDR2LINE,xbt_binary_name);
   for (i=0; i<e->used;i++) {
     /* retrieve this address */
+    DEBUG2("Retrieving address number %d from '%s'", i, backtrace[i]);
     snprintf(buff,256,"%s",strchr(backtrace[i],'[')+1);
     p=strchr(buff,']');
     *p='\0';
-    addrs[i]=bprintf("%s",buff);
-    
+    addrs[i]=bprintf("%s", buff);
+    DEBUG3("Set up a new address: %d, '%s'(%p)", i, addrs[i], addrs[i]);
+     
     /* Add it to the command line args */
     curr+=sprintf(curr,"%s ",addrs[i]);
   }	 
@@ -90,18 +97,22 @@ void xbt_ex_setup_backtrace(xbt_ex_t *e)  {
   /* parse the output and build a new backtrace */
   e->bt_strings = xbt_new(char*,e->used);
   
+  VERB1("Fire a first command: '%s'", cmd);
   pipe = popen(cmd, "r");
   if (!pipe) {
     CRITICAL0("Cannot fork addr2line to display the backtrace");
     abort();
   }
+
   for (i=0; i<e->used; i++) {
+    DEBUG2("Looking for symbol %d, addr = '%s'", i, addrs[i]); 
     fgets(line_func,1024,pipe);
     line_func[strlen(line_func)-1]='\0';
     fgets(line_pos,1024,pipe);
     line_pos[strlen(line_pos)-1]='\0';
 
     if (strcmp("??",line_func)) {
+       DEBUG2("Found static symbol %s() at %s", line_func, line_pos);
       e->bt_strings[i] = bprintf("**   In %s() at %s (static symbol)", line_func,line_pos);
     } else {
       /* Damn. The symbol is in a dynamic library. Let's get wild */
@@ -147,12 +158,16 @@ void xbt_ex_setup_backtrace(xbt_ex_t *e)  {
 	DEBUG4("%#lx %s [%#lx-%#lx]",
 	       addr, found? "in":"out of",first,last);
       }
-      if (!found) 
-	CRITICAL0("Problem while reading the maps file");
-
       fclose(maps);
       free(maps_name);
 
+      if (!found) {
+	VERB0("Problem while reading the maps file. Following backtrace will be mangled.");
+	DEBUG1("No dynamic. Static symbol: %s", backtrace[i]);
+	e->bt_strings[i] = bprintf("**   In ?? (%s)", backtrace[i]);
+	continue;
+      }
+
       /* Ok, Found the offset of the maps line containing the searched symbol. 
 	 We now need to substract this from the address we got from backtrace.
       */
@@ -167,7 +182,7 @@ void xbt_ex_setup_backtrace(xbt_ex_t *e)  {
       p2 = strrchr(p,'(');
       if (p2) *p2= '\0';
       p2 = strrchr(p,' ');
-      if (p2) *p2= '\0';
+      if(p2) *p2= '\0';
       
       /* Here we go, fire an addr2line up */
       subcmd = bprintf("%s -f -e %s %s",ADDR2LINE,p, addrs[i]);
@@ -187,9 +202,11 @@ void xbt_ex_setup_backtrace(xbt_ex_t *e)  {
 
       /* check whether the trick worked */
       if (strcmp("??",line_func)) {
+	DEBUG2("Found dynamic symbol %s() at %s", line_func, line_pos);
 	e->bt_strings[i] = bprintf("**   In %s() at %s (dynamic symbol)", line_func,line_pos);
       } else {
 	/* damn, nothing to do here. Let's print the raw address */
+	DEBUG1("Dynamic symbol not found. Raw address = %s", backtrace[i]);
 	e->bt_strings[i] = bprintf("**   In ?? (%s)", backtrace[i]);
       }
     }
@@ -209,10 +226,11 @@ void xbt_ex_display(xbt_ex_t *e)  {
   if (e->remote)
     bprintf(" on host %s(%ld)",e->host,e->pid);
 
+  CRITICAL1("%s",e->msg);
   fprintf(stderr,
 	  "** SimGrid: UNCAUGHT EXCEPTION received on %s(%ld): category: %s; value: %d\n"
 	  "** %s\n"
-	  "** Thrown by %s()%s",
+	  "** Thrown by %s()%s\n",
 	  gras_os_myname(),gras_os_getpid(),
 	  xbt_ex_catname(e->category), e->value, e->msg,
 	  e->procname,thrower?thrower:" in this process");
@@ -249,8 +267,9 @@ void __xbt_ex_terminate_default(xbt_ex_t *e)  {
 }
 
 /* the externally visible API */
-ex_ctx_cb_t  __xbt_ex_ctx       = &__xbt_ex_ctx_default;
-ex_term_cb_t __xbt_ex_terminate = &__xbt_ex_terminate_default;
+ex_ctx_cb_t XBT_PUBLIC_DATA  __xbt_ex_ctx       = &__xbt_ex_ctx_default;
+ex_term_cb_t XBT_PUBLIC_DATA __xbt_ex_terminate = &__xbt_ex_terminate_default;
+
 
 void xbt_ex_free(xbt_ex_t e) {
   int i;
@@ -268,7 +287,7 @@ void xbt_ex_free(xbt_ex_t e) {
        free((char*)e.bt_strings[i]);
      free((char **)e.bt_strings);
   }
-//  memset(e,0,sizeof(xbt_ex_t));
+  /* memset(e,0,sizeof(xbt_ex_t)); */
 }
 
 /** \brief returns a short name for the given exception category */
@@ -450,9 +469,10 @@ static void bad_example(void) {
   /* end_of_bad_example */
 }
 #endif
-
+typedef struct {char *first;} global_context_t;
+   
 static void good_example(void) {
-  struct {char*first;} *globalcontext;
+  global_context_t *global_context=malloc(sizeof(global_context_t));
   xbt_ex_t ex;
 
   /* GOOD_EXAMPLE */
@@ -462,7 +482,7 @@ static void good_example(void) {
     char * volatile /*03*/ cp3 = NULL /*02*/;
     TRY {
       cp1 = mallocex(SMALLAMOUNT);
-      globalcontext->first = cp1;
+      global_context->first = cp1;
       cp1 = NULL /*05 give away*/;
       cp2 = mallocex(TOOBIG);
       cp3 = mallocex(SMALLAMOUNT);