X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/75d28c977a66ed60c69165faa5968326e8f14c57..f2f6774b105704993c6a0e37597e29904bab314a:/src/smpi/smpi_pmpi.cpp diff --git a/src/smpi/smpi_pmpi.cpp b/src/smpi/smpi_pmpi.cpp index 449032c689..d09c579b55 100644 --- a/src/smpi/smpi_pmpi.cpp +++ b/src/smpi/smpi_pmpi.cpp @@ -4,10 +4,8 @@ * under the terms of the license (GNU LGPL) which comes with this package. */ #include -#include #include "private.h" -#include "smpi_mpi_dt_private.h" XBT_LOG_NEW_DEFAULT_SUBCATEGORY(smpi_pmpi, smpi, "Logging specific to SMPI (pmpi)"); @@ -30,9 +28,9 @@ int PMPI_Init(int *argc, char ***argv) int already_init; MPI_Initialized(&already_init); if(already_init == 0){ - smpi_process_init(argc, argv); - smpi_process_mark_as_initialized(); - int rank = smpi_process_index(); + simgrid::smpi::Process::init(argc, argv); + smpi_process()->mark_as_initialized(); + int rank = smpi_process()->index(); TRACE_smpi_init(rank); TRACE_smpi_computing_init(rank); instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); @@ -50,22 +48,22 @@ int PMPI_Init(int *argc, char ***argv) int PMPI_Finalize() { smpi_bench_end(); - int rank = smpi_process_index(); + int rank = smpi_process()->index(); instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); extra->type = TRACING_FINALIZE; TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - smpi_process_finalize(); + smpi_process()->finalize(); TRACE_smpi_collective_out(rank, -1, __FUNCTION__); - TRACE_smpi_finalize(smpi_process_index()); - smpi_process_destroy(); + TRACE_smpi_finalize(smpi_process()->index()); + smpi_process()->destroy(); return MPI_SUCCESS; } int PMPI_Finalized(int* flag) { - *flag=smpi_process_finalized(); + *flag=smpi_process()!=nullptr ? smpi_process()->finalized() : 0; return MPI_SUCCESS; } @@ -107,7 +105,7 @@ int PMPI_Is_thread_main(int *flag) if (flag == nullptr) { return MPI_ERR_ARG; } else { - *flag = smpi_process_index() == 0; + *flag = smpi_process()->index() == 0; return MPI_SUCCESS; } } @@ -115,7 +113,7 @@ int PMPI_Is_thread_main(int *flag) int PMPI_Abort(MPI_Comm comm, int errorcode) { smpi_bench_end(); - smpi_process_destroy(); + smpi_process()->destroy(); // FIXME: should kill all processes in comm instead simcall_process_kill(SIMIX_process_self()); return MPI_SUCCESS; @@ -153,7 +151,7 @@ int PMPI_Type_free(MPI_Datatype * datatype) if (*datatype == MPI_DATATYPE_NULL) { return MPI_ERR_ARG; } else { - smpi_datatype_unuse(*datatype); + simgrid::smpi::Datatype::unref(*datatype); return MPI_SUCCESS; } } @@ -165,7 +163,7 @@ int PMPI_Type_size(MPI_Datatype datatype, int *size) } else if (size == nullptr) { return MPI_ERR_ARG; } else { - *size = static_cast(smpi_datatype_size(datatype)); + *size = static_cast(datatype->size()); return MPI_SUCCESS; } } @@ -177,7 +175,7 @@ int PMPI_Type_size_x(MPI_Datatype datatype, MPI_Count *size) } else if (size == nullptr) { return MPI_ERR_ARG; } else { - *size = static_cast(smpi_datatype_size(datatype)); + *size = static_cast(datatype->size()); return MPI_SUCCESS; } } @@ -189,7 +187,7 @@ int PMPI_Type_get_extent(MPI_Datatype datatype, MPI_Aint * lb, MPI_Aint * extent } else if (lb == nullptr || extent == nullptr) { return MPI_ERR_ARG; } else { - return smpi_datatype_extent(datatype, lb, extent); + return datatype->extent(lb, extent); } } @@ -205,7 +203,7 @@ int PMPI_Type_extent(MPI_Datatype datatype, MPI_Aint * extent) } else if (extent == nullptr) { return MPI_ERR_ARG; } else { - *extent = smpi_datatype_get_extent(datatype); + *extent = datatype->get_extent(); return MPI_SUCCESS; } } @@ -217,7 +215,7 @@ int PMPI_Type_lb(MPI_Datatype datatype, MPI_Aint * disp) } else if (disp == nullptr) { return MPI_ERR_ARG; } else { - *disp = smpi_datatype_lb(datatype); + *disp = datatype->lb(); return MPI_SUCCESS; } } @@ -229,17 +227,24 @@ int PMPI_Type_ub(MPI_Datatype datatype, MPI_Aint * disp) } else if (disp == nullptr) { return MPI_ERR_ARG; } else { - *disp = smpi_datatype_ub(datatype); + *disp = datatype->ub(); return MPI_SUCCESS; } } int PMPI_Type_dup(MPI_Datatype datatype, MPI_Datatype *newtype){ + int retval = MPI_SUCCESS; if (datatype == MPI_DATATYPE_NULL) { - return MPI_ERR_TYPE; + retval=MPI_ERR_TYPE; } else { - return smpi_datatype_dup(datatype, newtype); + *newtype = new simgrid::smpi::Datatype(datatype, &retval); + //error when duplicating, free the new datatype + if(retval!=MPI_SUCCESS){ + simgrid::smpi::Datatype::unref(*newtype); + *newtype = MPI_DATATYPE_NULL; + } } + return retval; } int PMPI_Op_create(MPI_User_function * function, int commute, MPI_Op * op) @@ -247,7 +252,7 @@ int PMPI_Op_create(MPI_User_function * function, int commute, MPI_Op * op) if (function == nullptr || op == nullptr) { return MPI_ERR_ARG; } else { - *op = new Op(function, (commute!=0)); + *op = new simgrid::smpi::Op(function, (commute!=0)); return MPI_SUCCESS; } } @@ -265,12 +270,24 @@ int PMPI_Op_free(MPI_Op * op) } } +int PMPI_Op_commutative(MPI_Op op, int* commute){ + if (op == MPI_OP_NULL) { + return MPI_ERR_OP; + } else if (commute==nullptr){ + return MPI_ERR_ARG; + } else { + *commute = op->is_commutative(); + return MPI_SUCCESS; + } +} + int PMPI_Group_free(MPI_Group * group) { if (group == nullptr) { return MPI_ERR_ARG; } else { - (*group)->destroy(); + if(*group != MPI_COMM_WORLD->group() && *group != MPI_GROUP_EMPTY) + simgrid::smpi::Group::unref(*group); *group = MPI_GROUP_NULL; return MPI_SUCCESS; } @@ -295,7 +312,7 @@ int PMPI_Group_rank(MPI_Group group, int *rank) } else if (rank == nullptr) { return MPI_ERR_ARG; } else { - *rank = group->rank(smpi_process_index()); + *rank = group->rank(smpi_process()->index()); return MPI_SUCCESS; } } @@ -386,7 +403,7 @@ int PMPI_Group_excl(MPI_Group group, int n, int *ranks, MPI_Group * newgroup) *newgroup = group; if (group != MPI_COMM_WORLD->group() && group != MPI_COMM_SELF->group() && group != MPI_GROUP_EMPTY) - group->use(); + group->ref(); return MPI_SUCCESS; } else if (n == group->size()) { *newgroup = MPI_GROUP_EMPTY; @@ -424,7 +441,7 @@ int PMPI_Group_range_excl(MPI_Group group, int n, int ranges[][3], MPI_Group * n *newgroup = group; if (group != MPI_COMM_WORLD->group() && group != MPI_COMM_SELF->group() && group != MPI_GROUP_EMPTY) - group->use(); + group->ref(); return MPI_SUCCESS; } else { return group->range_excl(n,ranges,newgroup); @@ -477,7 +494,7 @@ int PMPI_Comm_group(MPI_Comm comm, MPI_Group * group) } else { *group = comm->group(); if (*group != MPI_COMM_WORLD->group() && *group != MPI_GROUP_NULL && *group != MPI_GROUP_EMPTY) - (*group)->use(); + (*group)->ref(); return MPI_SUCCESS; } } @@ -520,12 +537,12 @@ int PMPI_Comm_create(MPI_Comm comm, MPI_Group group, MPI_Comm * newcomm) return MPI_ERR_GROUP; } else if (newcomm == nullptr) { return MPI_ERR_ARG; - } else if(group->rank(smpi_process_index())==MPI_UNDEFINED){ + } else if(group->rank(smpi_process()->index())==MPI_UNDEFINED){ *newcomm= MPI_COMM_NULL; return MPI_SUCCESS; }else{ - group->use(); - *newcomm = new Comm(group, nullptr); + group->ref(); + *newcomm = new simgrid::smpi::Comm(group, nullptr); return MPI_SUCCESS; } } @@ -537,7 +554,7 @@ int PMPI_Comm_free(MPI_Comm * comm) } else if (*comm == MPI_COMM_NULL) { return MPI_ERR_COMM; } else { - (*comm)->destroy(); + simgrid::smpi::Comm::destroy(*comm); *comm = MPI_COMM_NULL; return MPI_SUCCESS; } @@ -551,7 +568,7 @@ int PMPI_Comm_disconnect(MPI_Comm * comm) } else if (*comm == MPI_COMM_NULL) { return MPI_ERR_COMM; } else { - (*comm)->destroy(); + simgrid::smpi::Comm::destroy(*comm); *comm = MPI_COMM_NULL; return MPI_SUCCESS; } @@ -601,12 +618,12 @@ int PMPI_Send_init(void *buf, int count, MPI_Datatype datatype, int dst, int tag retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (dst == MPI_PROC_NULL) { retval = MPI_SUCCESS; } else { - *request = Request::send_init(buf, count, datatype, dst, tag, comm); + *request = simgrid::smpi::Request::send_init(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -624,12 +641,12 @@ int PMPI_Recv_init(void *buf, int count, MPI_Datatype datatype, int src, int tag retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (src == MPI_PROC_NULL) { retval = MPI_SUCCESS; } else { - *request = Request::recv_init(buf, count, datatype, src, tag, comm); + *request = simgrid::smpi::Request::recv_init(buf, count, datatype, src, tag, comm); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -647,12 +664,12 @@ int PMPI_Ssend_init(void* buf, int count, MPI_Datatype datatype, int dst, int ta retval = MPI_ERR_ARG; } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (dst == MPI_PROC_NULL) { retval = MPI_SUCCESS; } else { - *request = Request::ssend_init(buf, count, datatype, dst, tag, comm); + *request = simgrid::smpi::Request::ssend_init(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -690,7 +707,7 @@ int PMPI_Startall(int count, MPI_Request * requests) } } if(retval != MPI_ERR_REQUEST) { - Request::startall(count, requests); + simgrid::smpi::Request::startall(count, requests); } } smpi_bench_begin(); @@ -705,7 +722,7 @@ int PMPI_Request_free(MPI_Request * request) if (*request == MPI_REQUEST_NULL) { retval = MPI_ERR_ARG; } else { - Request::unuse(request); + simgrid::smpi::Request::unref(request); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -729,13 +746,13 @@ int PMPI_Irecv(void *buf, int count, MPI_Datatype datatype, int src, int tag, MP retval = MPI_ERR_RANK; } else if ((count < 0) || (buf==nullptr && count > 0)) { retval = MPI_ERR_COUNT; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if(tag<0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int src_traced = comm->group()->index(src); instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); @@ -746,11 +763,11 @@ int PMPI_Irecv(void *buf, int count, MPI_Datatype datatype, int src, int tag, MP extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if(known==0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count*dt_size_send; TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, extra); - *request = Request::irecv(buf, count, datatype, src, tag, comm); + *request = simgrid::smpi::Request::irecv(buf, count, datatype, src, tag, comm); retval = MPI_SUCCESS; TRACE_smpi_ptp_out(rank, src_traced, rank, __FUNCTION__); @@ -779,12 +796,12 @@ int PMPI_Isend(void *buf, int count, MPI_Datatype datatype, int dst, int tag, MP retval = MPI_ERR_RANK; } else if ((count < 0) || (buf==nullptr && count > 0)) { retval = MPI_ERR_COUNT; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if(tag<0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int dst_traced = comm->group()->index(dst); instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); extra->type = TRACING_ISEND; @@ -794,12 +811,12 @@ int PMPI_Isend(void *buf, int count, MPI_Datatype datatype, int dst, int tag, MP extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if(known==0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count*dt_size_send; TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra); - TRACE_smpi_send(rank, rank, dst_traced, tag, count*smpi_datatype_size(datatype)); + TRACE_smpi_send(rank, rank, dst_traced, tag, count*datatype->size()); - *request = Request::isend(buf, count, datatype, dst, tag, comm); + *request = simgrid::smpi::Request::isend(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__); @@ -827,12 +844,12 @@ int PMPI_Issend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, M retval = MPI_ERR_RANK; } else if ((count < 0)|| (buf==nullptr && count > 0)) { retval = MPI_ERR_COUNT; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if(tag<0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int dst_traced = comm->group()->index(dst); instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); extra->type = TRACING_ISSEND; @@ -842,12 +859,12 @@ int PMPI_Issend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, M extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if(known==0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count*dt_size_send; TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra); - TRACE_smpi_send(rank, rank, dst_traced, tag, count*smpi_datatype_size(datatype)); + TRACE_smpi_send(rank, rank, dst_traced, tag, count*datatype->size()); - *request = Request::issend(buf, count, datatype, dst, tag, comm); + *request = simgrid::smpi::Request::issend(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__); @@ -867,19 +884,19 @@ int PMPI_Recv(void *buf, int count, MPI_Datatype datatype, int src, int tag, MPI if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; } else if (src == MPI_PROC_NULL) { - smpi_empty_status(status); + simgrid::smpi::Status::empty(status); status->MPI_SOURCE = MPI_PROC_NULL; retval = MPI_SUCCESS; } else if (src!=MPI_ANY_SOURCE && (src >= comm->group()->size() || src <0)){ retval = MPI_ERR_RANK; } else if ((count < 0) || (buf==nullptr && count > 0)) { retval = MPI_ERR_COUNT; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if(tag<0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int src_traced = comm->group()->index(src); instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); extra->type = TRACING_RECV; @@ -889,11 +906,11 @@ int PMPI_Recv(void *buf, int count, MPI_Datatype datatype, int src, int tag, MPI extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count * dt_size_send; TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, extra); - Request::recv(buf, count, datatype, src, tag, comm, status); + simgrid::smpi::Request::recv(buf, count, datatype, src, tag, comm, status); retval = MPI_SUCCESS; // the src may not have been known at the beginning of the recv (MPI_ANY_SOURCE) @@ -924,12 +941,12 @@ int PMPI_Send(void *buf, int count, MPI_Datatype datatype, int dst, int tag, MPI retval = MPI_ERR_RANK; } else if ((count < 0) || (buf == nullptr && count > 0)) { retval = MPI_ERR_COUNT; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if(tag < 0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int dst_traced = comm->group()->index(dst); instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); extra->type = TRACING_SEND; @@ -939,15 +956,15 @@ int PMPI_Send(void *buf, int count, MPI_Datatype datatype, int dst, int tag, MPI extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) { - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); } extra->send_size = count*dt_size_send; TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra); if (!TRACE_smpi_view_internals()) { - TRACE_smpi_send(rank, rank, dst_traced, tag,count*smpi_datatype_size(datatype)); + TRACE_smpi_send(rank, rank, dst_traced, tag,count*datatype->size()); } - Request::send(buf, count, datatype, dst, tag, comm); + simgrid::smpi::Request::send(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__); @@ -970,12 +987,12 @@ int PMPI_Ssend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, MP retval = MPI_ERR_RANK; } else if ((count < 0) || (buf==nullptr && count > 0)) { retval = MPI_ERR_COUNT; - } else if (!is_datatype_valid(datatype)){ + } else if (!datatype->is_valid()){ retval = MPI_ERR_TYPE; } else if(tag<0 && tag != MPI_ANY_TAG){ retval = MPI_ERR_TAG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int dst_traced = comm->group()->index(dst); instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); extra->type = TRACING_SSEND; @@ -985,13 +1002,13 @@ int PMPI_Ssend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, MP extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if(known == 0) { - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); } extra->send_size = count*dt_size_send; TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, extra); - TRACE_smpi_send(rank, rank, dst_traced, tag,count*smpi_datatype_size(datatype)); + TRACE_smpi_send(rank, rank, dst_traced, tag,count*datatype->size()); - Request::ssend(buf, count, datatype, dst, tag, comm); + simgrid::smpi::Request::ssend(buf, count, datatype, dst, tag, comm); retval = MPI_SUCCESS; TRACE_smpi_ptp_out(rank, rank, dst_traced, __FUNCTION__); @@ -1010,10 +1027,10 @@ int PMPI_Sendrecv(void *sendbuf, int sendcount, MPI_Datatype sendtype, int dst, if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(sendtype) || !is_datatype_valid(recvtype)) { + } else if (!sendtype->is_valid() || !recvtype->is_valid()) { retval = MPI_ERR_TYPE; } else if (src == MPI_PROC_NULL || dst == MPI_PROC_NULL) { - smpi_empty_status(status); + simgrid::smpi::Status::empty(status); status->MPI_SOURCE = MPI_PROC_NULL; retval = MPI_SUCCESS; }else if (dst >= comm->group()->size() || dst <0 || @@ -1026,7 +1043,7 @@ int PMPI_Sendrecv(void *sendbuf, int sendcount, MPI_Datatype sendtype, int dst, retval = MPI_ERR_TAG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int dst_traced = comm->group()->index(dst); int src_traced = comm->group()->index(src); instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); @@ -1037,18 +1054,18 @@ int PMPI_Sendrecv(void *sendbuf, int sendcount, MPI_Datatype sendtype, int dst, extra->datatype1 = encode_datatype(sendtype, &known); int dt_size_send = 1; if(known==0) - dt_size_send = smpi_datatype_size(sendtype); + dt_size_send = sendtype->size(); extra->send_size = sendcount*dt_size_send; extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; if(known==0) - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); extra->recv_size = recvcount*dt_size_recv; TRACE_smpi_ptp_in(rank, src_traced, dst_traced, __FUNCTION__, extra); - TRACE_smpi_send(rank, rank, dst_traced, sendtag,sendcount*smpi_datatype_size(sendtype)); + TRACE_smpi_send(rank, rank, dst_traced, sendtag,sendcount*sendtype->size()); - Request::sendrecv(sendbuf, sendcount, sendtype, dst, sendtag, recvbuf, recvcount, recvtype, src, recvtag, comm, + simgrid::smpi::Request::sendrecv(sendbuf, sendcount, sendtype, dst, sendtag, recvbuf, recvcount, recvtype, src, recvtag, comm, status); retval = MPI_SUCCESS; @@ -1064,16 +1081,16 @@ int PMPI_Sendrecv_replace(void* buf, int count, MPI_Datatype datatype, int dst, MPI_Comm comm, MPI_Status* status) { int retval = 0; - if (!is_datatype_valid(datatype)) { + if (!datatype->is_valid()) { return MPI_ERR_TYPE; } else if (count < 0) { return MPI_ERR_COUNT; } else { - int size = smpi_datatype_get_extent(datatype) * count; + int size = datatype->get_extent() * count; void* recvbuf = xbt_new0(char, size); retval = MPI_Sendrecv(buf, count, datatype, dst, sendtag, recvbuf, count, datatype, src, recvtag, comm, status); if(retval==MPI_SUCCESS){ - smpi_datatype_copy(recvbuf, count, datatype, buf, count, datatype); + simgrid::smpi::Datatype::copy(recvbuf, count, datatype, buf, count, datatype); } xbt_free(recvbuf); @@ -1089,16 +1106,16 @@ int PMPI_Test(MPI_Request * request, int *flag, MPI_Status * status) retval = MPI_ERR_ARG; } else if (*request == MPI_REQUEST_NULL) { *flag= true; - smpi_empty_status(status); + simgrid::smpi::Status::empty(status); retval = MPI_SUCCESS; } else { - int rank = ((*request)->comm() != MPI_COMM_NULL) ? smpi_process_index() : -1; + int rank = ((*request)->comm() != MPI_COMM_NULL) ? smpi_process()->index() : -1; instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); extra->type = TRACING_TEST; TRACE_smpi_testing_in(rank, extra); - *flag = Request::test(request,status); + *flag = simgrid::smpi::Request::test(request,status); TRACE_smpi_testing_out(rank); retval = MPI_SUCCESS; @@ -1115,7 +1132,7 @@ int PMPI_Testany(int count, MPI_Request requests[], int *index, int *flag, MPI_S if (index == nullptr || flag == nullptr) { retval = MPI_ERR_ARG; } else { - *flag = Request::testany(count, requests, index, status); + *flag = simgrid::smpi::Request::testany(count, requests, index, status); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -1130,7 +1147,7 @@ int PMPI_Testall(int count, MPI_Request* requests, int* flag, MPI_Status* status if (flag == nullptr) { retval = MPI_ERR_ARG; } else { - *flag = Request::testall(count, requests, statuses); + *flag = simgrid::smpi::Request::testall(count, requests, statuses); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -1146,11 +1163,11 @@ int PMPI_Probe(int source, int tag, MPI_Comm comm, MPI_Status* status) { } else if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; } else if (source == MPI_PROC_NULL) { - smpi_empty_status(status); + simgrid::smpi::Status::empty(status); status->MPI_SOURCE = MPI_PROC_NULL; retval = MPI_SUCCESS; } else { - Request::probe(source, tag, comm, status); + simgrid::smpi::Request::probe(source, tag, comm, status); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -1167,11 +1184,11 @@ int PMPI_Iprobe(int source, int tag, MPI_Comm comm, int* flag, MPI_Status* statu retval = MPI_ERR_COMM; } else if (source == MPI_PROC_NULL) { *flag=true; - smpi_empty_status(status); + simgrid::smpi::Status::empty(status); status->MPI_SOURCE = MPI_PROC_NULL; retval = MPI_SUCCESS; } else { - Request::iprobe(source, tag, comm, flag, status); + simgrid::smpi::Request::iprobe(source, tag, comm, flag, status); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -1184,7 +1201,7 @@ int PMPI_Wait(MPI_Request * request, MPI_Status * status) smpi_bench_end(); - smpi_empty_status(status); + simgrid::smpi::Status::empty(status); if (request == nullptr) { retval = MPI_ERR_ARG; @@ -1192,7 +1209,7 @@ int PMPI_Wait(MPI_Request * request, MPI_Status * status) retval = MPI_SUCCESS; } else { - int rank = (request!=nullptr && (*request)->comm() != MPI_COMM_NULL) ? smpi_process_index() : -1; + int rank = (request!=nullptr && (*request)->comm() != MPI_COMM_NULL) ? smpi_process()->index() : -1; int src_traced = (*request)->src(); int dst_traced = (*request)->dst(); @@ -1203,7 +1220,7 @@ int PMPI_Wait(MPI_Request * request, MPI_Status * status) extra->type = TRACING_WAIT; TRACE_smpi_ptp_in(rank, src_traced, dst_traced, __FUNCTION__, extra); - Request::wait(request, status); + simgrid::smpi::Request::wait(request, status); retval = MPI_SUCCESS; //the src may not have been known at the beginning of the recv (MPI_ANY_SOURCE) @@ -1245,13 +1262,13 @@ int PMPI_Waitany(int count, MPI_Request requests[], int *index, MPI_Status * sta savedvals[i]=(savedvalstype){req->src(), req->dst(), (req->flags() & RECV), req->tag(), req->comm()}; } } - int rank_traced = smpi_process_index(); + int rank_traced = smpi_process()->index(); instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); extra->type = TRACING_WAITANY; extra->send_size=count; TRACE_smpi_ptp_in(rank_traced, -1, -1, __FUNCTION__,extra); - *index = Request::waitany(count, requests, status); + *index = simgrid::smpi::Request::waitany(count, requests, status); if(*index!=MPI_UNDEFINED){ int src_traced = savedvals[*index].src; @@ -1295,13 +1312,13 @@ int PMPI_Waitall(int count, MPI_Request requests[], MPI_Status status[]) savedvals[i].valid=0; } } - int rank_traced = smpi_process_index(); + int rank_traced = smpi_process()->index(); instr_extra_data extra = xbt_new0(s_instr_extra_data_t,1); extra->type = TRACING_WAITALL; extra->send_size=count; TRACE_smpi_ptp_in(rank_traced, -1, -1, __FUNCTION__,extra); - int retval =Request::waitall(count, requests, status); + int retval = simgrid::smpi::Request::waitall(count, requests, status); for (int i = 0; i < count; i++) { if(savedvals[i].valid){ @@ -1332,7 +1349,7 @@ int PMPI_Waitsome(int incount, MPI_Request requests[], int *outcount, int *indic if (outcount == nullptr) { retval = MPI_ERR_ARG; } else { - *outcount = Request::waitsome(incount, requests, indices, status); + *outcount = simgrid::smpi::Request::waitsome(incount, requests, indices, status); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -1347,7 +1364,7 @@ int PMPI_Testsome(int incount, MPI_Request requests[], int* outcount, int* indic if (outcount == nullptr) { retval = MPI_ERR_ARG; } else { - *outcount = Request::testsome(incount, requests, indices, status); + *outcount = simgrid::smpi::Request::testsome(incount, requests, indices, status); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -1363,10 +1380,10 @@ int PMPI_Bcast(void *buf, int count, MPI_Datatype datatype, int root, MPI_Comm c if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_ARG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int root_traced = comm->group()->index(root); instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); @@ -1376,11 +1393,11 @@ int PMPI_Bcast(void *buf, int count, MPI_Datatype datatype, int root, MPI_Comm c extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count * dt_size_send; TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); if (comm->size() > 1) - mpi_coll_bcast_fun(buf, count, datatype, root, comm); + simgrid::smpi::Colls::bcast(buf, count, datatype, root, comm); retval = MPI_SUCCESS; TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); @@ -1398,12 +1415,16 @@ int PMPI_Barrier(MPI_Comm comm) if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); extra->type = TRACING_BARRIER; TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - mpi_coll_barrier_fun(comm); + simgrid::smpi::Colls::barrier(comm); + + //Barrier can be used to synchronize RMA calls. Finish all requests from comm before. + comm->finish_rma_calls(); + retval = MPI_SUCCESS; TRACE_smpi_collective_out(rank, -1, __FUNCTION__); @@ -1436,7 +1457,7 @@ int PMPI_Gather(void *sendbuf, int sendcount, MPI_Datatype sendtype,void *recvbu sendtmpcount=0; sendtmptype=recvtype; } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int root_traced = comm->group()->index(root); instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); extra->type = TRACING_GATHER; @@ -1445,17 +1466,17 @@ int PMPI_Gather(void *sendbuf, int sendcount, MPI_Datatype sendtype,void *recvbu extra->datatype1 = encode_datatype(sendtmptype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(sendtmptype); + dt_size_send = sendtmptype->size(); extra->send_size = sendtmpcount * dt_size_send; extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; if ((comm->rank() == root) && known == 0) - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); extra->recv_size = recvcount * dt_size_recv; TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); - mpi_coll_gather_fun(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcount, recvtype, root, comm); + simgrid::smpi::Colls::gather(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcount, recvtype, root, comm); retval = MPI_SUCCESS; TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); @@ -1490,7 +1511,7 @@ int PMPI_Gatherv(void *sendbuf, int sendcount, MPI_Datatype sendtype, void *recv sendtmptype=recvtype; } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int root_traced = comm->group()->index(root); int i = 0; int size = comm->size(); @@ -1502,12 +1523,12 @@ int PMPI_Gatherv(void *sendbuf, int sendcount, MPI_Datatype sendtype, void *recv extra->datatype1 = encode_datatype(sendtmptype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(sendtype); + dt_size_send = sendtype->size(); extra->send_size = sendtmpcount * dt_size_send; extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; if (known == 0) - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); if ((comm->rank() == root)) { extra->recvcounts = xbt_new(int, size); for (i = 0; i < size; i++) // copy data to avoid bad free @@ -1515,8 +1536,7 @@ int PMPI_Gatherv(void *sendbuf, int sendcount, MPI_Datatype sendtype, void *recv } TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); - smpi_mpi_gatherv(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcounts, displs, recvtype, root, comm); - retval = MPI_SUCCESS; + retval = simgrid::smpi::Colls::gatherv(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcounts, displs, recvtype, root, comm); TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); } @@ -1541,28 +1561,28 @@ int PMPI_Allgather(void *sendbuf, int sendcount, MPI_Datatype sendtype, retval = MPI_ERR_COUNT; } else { if(sendbuf == MPI_IN_PLACE) { - sendbuf=static_cast(recvbuf)+smpi_datatype_get_extent(recvtype)*recvcount*comm->rank(); + sendbuf=static_cast(recvbuf)+recvtype->get_extent()*recvcount*comm->rank(); sendcount=recvcount; sendtype=recvtype; } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); extra->type = TRACING_ALLGATHER; int known = 0; extra->datatype1 = encode_datatype(sendtype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(sendtype); + dt_size_send = sendtype->size(); extra->send_size = sendcount * dt_size_send; extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; if (known == 0) - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); extra->recv_size = recvcount * dt_size_recv; TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - mpi_coll_allgather_fun(sendbuf, sendcount, sendtype, recvbuf, recvcount, recvtype, comm); + simgrid::smpi::Colls::allgather(sendbuf, sendcount, sendtype, recvbuf, recvcount, recvtype, comm); retval = MPI_SUCCESS; TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } @@ -1588,11 +1608,11 @@ int PMPI_Allgatherv(void *sendbuf, int sendcount, MPI_Datatype sendtype, } else { if(sendbuf == MPI_IN_PLACE) { - sendbuf=static_cast(recvbuf)+smpi_datatype_get_extent(recvtype)*displs[comm->rank()]; + sendbuf=static_cast(recvbuf)+recvtype->get_extent()*displs[comm->rank()]; sendcount=recvcounts[comm->rank()]; sendtype=recvtype; } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int i = 0; int size = comm->size(); instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); @@ -1602,19 +1622,19 @@ int PMPI_Allgatherv(void *sendbuf, int sendcount, MPI_Datatype sendtype, extra->datatype1 = encode_datatype(sendtype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(sendtype); + dt_size_send = sendtype->size(); extra->send_size = sendcount * dt_size_send; extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; if (known == 0) - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); extra->recvcounts = xbt_new(int, size); for (i = 0; i < size; i++) // copy data to avoid bad free extra->recvcounts[i] = recvcounts[i] * dt_size_recv; TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - mpi_coll_allgatherv_fun(sendbuf, sendcount, sendtype, recvbuf, recvcounts, displs, recvtype, comm); + simgrid::smpi::Colls::allgatherv(sendbuf, sendcount, sendtype, recvbuf, recvcounts, displs, recvtype, comm); retval = MPI_SUCCESS; TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } @@ -1632,8 +1652,8 @@ int PMPI_Scatter(void *sendbuf, int sendcount, MPI_Datatype sendtype, if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (((comm->rank() == root) && (!is_datatype_valid(sendtype))) || - ((recvbuf != MPI_IN_PLACE) && (!is_datatype_valid(recvtype)))) { + } else if (((comm->rank() == root) && (!sendtype->is_valid())) || + ((recvbuf != MPI_IN_PLACE) && (!recvtype->is_valid()))) { retval = MPI_ERR_TYPE; } else if ((sendbuf == recvbuf) || ((comm->rank()==root) && sendcount>0 && (sendbuf == nullptr))){ @@ -1644,7 +1664,7 @@ int PMPI_Scatter(void *sendbuf, int sendcount, MPI_Datatype sendtype, recvtype = sendtype; recvcount = sendcount; } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int root_traced = comm->group()->index(root); instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); extra->type = TRACING_SCATTER; @@ -1653,16 +1673,16 @@ int PMPI_Scatter(void *sendbuf, int sendcount, MPI_Datatype sendtype, extra->datatype1 = encode_datatype(sendtype, &known); int dt_size_send = 1; if ((comm->rank() == root) && known == 0) - dt_size_send = smpi_datatype_size(sendtype); + dt_size_send = sendtype->size(); extra->send_size = sendcount * dt_size_send; extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; if (known == 0) - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); extra->recv_size = recvcount * dt_size_recv; TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); - mpi_coll_scatter_fun(sendbuf, sendcount, sendtype, recvbuf, recvcount, recvtype, root, comm); + simgrid::smpi::Colls::scatter(sendbuf, sendcount, sendtype, recvbuf, recvcount, recvtype, root, comm); retval = MPI_SUCCESS; TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); } @@ -1690,7 +1710,7 @@ int PMPI_Scatterv(void *sendbuf, int *sendcounts, int *displs, recvtype = sendtype; recvcount = sendcounts[comm->rank()]; } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int root_traced = comm->group()->index(root); int i = 0; int size = comm->size(); @@ -1702,7 +1722,7 @@ int PMPI_Scatterv(void *sendbuf, int *sendcounts, int *displs, extra->datatype1 = encode_datatype(sendtype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(sendtype); + dt_size_send = sendtype->size(); if ((comm->rank() == root)) { extra->sendcounts = xbt_new(int, size); for (i = 0; i < size; i++) // copy data to avoid bad free @@ -1711,13 +1731,12 @@ int PMPI_Scatterv(void *sendbuf, int *sendcounts, int *displs, extra->datatype2 = encode_datatype(recvtype, &known); int dt_size_recv = 1; if (known == 0) - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); extra->recv_size = recvcount * dt_size_recv; TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); - smpi_mpi_scatterv(sendbuf, sendcounts, displs, sendtype, recvbuf, recvcount, recvtype, root, comm); + retval = simgrid::smpi::Colls::scatterv(sendbuf, sendcounts, displs, sendtype, recvbuf, recvcount, recvtype, root, comm); - retval = MPI_SUCCESS; TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); } @@ -1733,10 +1752,10 @@ int PMPI_Reduce(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype) || op == MPI_OP_NULL) { + } else if (!datatype->is_valid() || op == MPI_OP_NULL) { retval = MPI_ERR_ARG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int root_traced = comm->group()->index(root); instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); extra->type = TRACING_REDUCE; @@ -1744,13 +1763,13 @@ int PMPI_Reduce(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count * dt_size_send; extra->root = root_traced; TRACE_smpi_collective_in(rank, root_traced, __FUNCTION__, extra); - mpi_coll_reduce_fun(sendbuf, recvbuf, count, datatype, op, root, comm); + simgrid::smpi::Colls::reduce(sendbuf, recvbuf, count, datatype, op, root, comm); retval = MPI_SUCCESS; TRACE_smpi_collective_out(rank, root_traced, __FUNCTION__); @@ -1764,10 +1783,10 @@ int PMPI_Reduce_local(void *inbuf, void *inoutbuf, int count, MPI_Datatype datat int retval = 0; smpi_bench_end(); - if (!is_datatype_valid(datatype) || op == MPI_OP_NULL) { + if (!datatype->is_valid() || op == MPI_OP_NULL) { retval = MPI_ERR_ARG; } else { - if(op!=MPI_OP_NULL) op->apply( inbuf, inoutbuf, &count, &datatype); + op->apply(inbuf, inoutbuf, &count, datatype); retval = MPI_SUCCESS; } smpi_bench_begin(); @@ -1782,7 +1801,7 @@ int PMPI_Allreduce(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatyp if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; @@ -1790,22 +1809,22 @@ int PMPI_Allreduce(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatyp char* sendtmpbuf = static_cast(sendbuf); if( sendbuf == MPI_IN_PLACE ) { - sendtmpbuf = static_cast(xbt_malloc(count*smpi_datatype_get_extent(datatype))); - smpi_datatype_copy(recvbuf, count, datatype,sendtmpbuf, count, datatype); + sendtmpbuf = static_cast(xbt_malloc(count*datatype->get_extent())); + simgrid::smpi::Datatype::copy(recvbuf, count, datatype,sendtmpbuf, count, datatype); } - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); extra->type = TRACING_ALLREDUCE; int known = 0; extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count * dt_size_send; TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - mpi_coll_allreduce_fun(sendtmpbuf, recvbuf, count, datatype, op, comm); + simgrid::smpi::Colls::allreduce(sendtmpbuf, recvbuf, count, datatype, op, comm); if( sendbuf == MPI_IN_PLACE ) xbt_free(sendtmpbuf); @@ -1826,26 +1845,25 @@ int PMPI_Scan(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, MP if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); extra->type = TRACING_SCAN; int known = 0; extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count * dt_size_send; TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - smpi_mpi_scan(sendbuf, recvbuf, count, datatype, op, comm); + retval = simgrid::smpi::Colls::scan(sendbuf, recvbuf, count, datatype, op, comm); - retval = MPI_SUCCESS; TRACE_smpi_collective_out(rank, -1, __FUNCTION__); } @@ -1860,29 +1878,29 @@ int PMPI_Exscan(void *sendbuf, void *recvbuf, int count, MPI_Datatype datatype, if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); extra->type = TRACING_EXSCAN; int known = 0; extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = count * dt_size_send; void* sendtmpbuf = sendbuf; if (sendbuf == MPI_IN_PLACE) { - sendtmpbuf = static_cast(xbt_malloc(count * smpi_datatype_size(datatype))); - memcpy(sendtmpbuf, recvbuf, count * smpi_datatype_size(datatype)); + sendtmpbuf = static_cast(xbt_malloc(count * datatype->size())); + memcpy(sendtmpbuf, recvbuf, count * datatype->size()); } TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - smpi_mpi_exscan(sendtmpbuf, recvbuf, count, datatype, op, comm); - retval = MPI_SUCCESS; + retval = simgrid::smpi::Colls::exscan(sendtmpbuf, recvbuf, count, datatype, op, comm); + TRACE_smpi_collective_out(rank, -1, __FUNCTION__); if (sendbuf == MPI_IN_PLACE) xbt_free(sendtmpbuf); @@ -1899,14 +1917,14 @@ int PMPI_Reduce_scatter(void *sendbuf, void *recvbuf, int *recvcounts, MPI_Datat if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; } else if (recvcounts == nullptr) { retval = MPI_ERR_ARG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int i = 0; int size = comm->size(); instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); @@ -1916,7 +1934,7 @@ int PMPI_Reduce_scatter(void *sendbuf, void *recvbuf, int *recvcounts, MPI_Datat extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = 0; extra->recvcounts = xbt_new(int, size); int totalcount = 0; @@ -1926,13 +1944,13 @@ int PMPI_Reduce_scatter(void *sendbuf, void *recvbuf, int *recvcounts, MPI_Datat } void* sendtmpbuf = sendbuf; if (sendbuf == MPI_IN_PLACE) { - sendtmpbuf = static_cast(xbt_malloc(totalcount * smpi_datatype_size(datatype))); - memcpy(sendtmpbuf, recvbuf, totalcount * smpi_datatype_size(datatype)); + sendtmpbuf = static_cast(xbt_malloc(totalcount * datatype->size())); + memcpy(sendtmpbuf, recvbuf, totalcount * datatype->size()); } TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - mpi_coll_reduce_scatter_fun(sendtmpbuf, recvbuf, recvcounts, datatype, op, comm); + simgrid::smpi::Colls::reduce_scatter(sendtmpbuf, recvbuf, recvcounts, datatype, op, comm); retval = MPI_SUCCESS; TRACE_smpi_collective_out(rank, -1, __FUNCTION__); @@ -1952,7 +1970,7 @@ int PMPI_Reduce_scatter_block(void *sendbuf, void *recvbuf, int recvcount, if (comm == MPI_COMM_NULL) { retval = MPI_ERR_COMM; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { retval = MPI_ERR_TYPE; } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; @@ -1961,7 +1979,7 @@ int PMPI_Reduce_scatter_block(void *sendbuf, void *recvbuf, int recvcount, } else { int count = comm->size(); - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); extra->type = TRACING_REDUCE_SCATTER; extra->num_processes = count; @@ -1969,15 +1987,15 @@ int PMPI_Reduce_scatter_block(void *sendbuf, void *recvbuf, int recvcount, extra->datatype1 = encode_datatype(datatype, &known); int dt_size_send = 1; if (known == 0) - dt_size_send = smpi_datatype_size(datatype); + dt_size_send = datatype->size(); extra->send_size = 0; extra->recvcounts = xbt_new(int, count); for (int i = 0; i < count; i++) // copy data to avoid bad free extra->recvcounts[i] = recvcount * dt_size_send; void* sendtmpbuf = sendbuf; if (sendbuf == MPI_IN_PLACE) { - sendtmpbuf = static_cast(xbt_malloc(recvcount * count * smpi_datatype_size(datatype))); - memcpy(sendtmpbuf, recvbuf, recvcount * count * smpi_datatype_size(datatype)); + sendtmpbuf = static_cast(xbt_malloc(recvcount * count * datatype->size())); + memcpy(sendtmpbuf, recvbuf, recvcount * count * datatype->size()); } TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); @@ -1985,7 +2003,7 @@ int PMPI_Reduce_scatter_block(void *sendbuf, void *recvbuf, int recvcount, int* recvcounts = static_cast(xbt_malloc(count * sizeof(int))); for (int i = 0; i < count; i++) recvcounts[i] = recvcount; - mpi_coll_reduce_scatter_fun(sendtmpbuf, recvbuf, recvcounts, datatype, op, comm); + simgrid::smpi::Colls::reduce_scatter(sendtmpbuf, recvbuf, recvcounts, datatype, op, comm); xbt_free(recvcounts); retval = MPI_SUCCESS; @@ -2010,7 +2028,7 @@ int PMPI_Alltoall(void* sendbuf, int sendcount, MPI_Datatype sendtype, void* rec } else if ((sendbuf != MPI_IN_PLACE && sendtype == MPI_DATATYPE_NULL) || recvtype == MPI_DATATYPE_NULL) { retval = MPI_ERR_TYPE; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); extra->type = TRACING_ALLTOALL; @@ -2018,8 +2036,8 @@ int PMPI_Alltoall(void* sendbuf, int sendcount, MPI_Datatype sendtype, void* rec int sendtmpcount = sendcount; MPI_Datatype sendtmptype = sendtype; if (sendbuf == MPI_IN_PLACE) { - sendtmpbuf = static_cast(xbt_malloc(recvcount * comm->size() * smpi_datatype_size(recvtype))); - memcpy(sendtmpbuf, recvbuf, recvcount * comm->size() * smpi_datatype_size(recvtype)); + sendtmpbuf = static_cast(xbt_malloc(recvcount * comm->size() * recvtype->size())); + memcpy(sendtmpbuf, recvbuf, recvcount * comm->size() * recvtype->size()); sendtmpcount = recvcount; sendtmptype = recvtype; } @@ -2027,18 +2045,18 @@ int PMPI_Alltoall(void* sendbuf, int sendcount, MPI_Datatype sendtype, void* rec int known = 0; extra->datatype1 = encode_datatype(sendtmptype, &known); if (known == 0) - extra->send_size = sendtmpcount * smpi_datatype_size(sendtmptype); + extra->send_size = sendtmpcount * sendtmptype->size(); else extra->send_size = sendtmpcount; extra->datatype2 = encode_datatype(recvtype, &known); if (known == 0) - extra->recv_size = recvcount * smpi_datatype_size(recvtype); + extra->recv_size = recvcount * recvtype->size(); else extra->recv_size = recvcount; TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - retval = mpi_coll_alltoall_fun(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcount, recvtype, comm); + retval = simgrid::smpi::Colls::alltoall(sendtmpbuf, sendtmpcount, sendtmptype, recvbuf, recvcount, recvtype, comm); TRACE_smpi_collective_out(rank, -1, __FUNCTION__); @@ -2065,7 +2083,7 @@ int PMPI_Alltoallv(void* sendbuf, int* sendcounts, int* senddisps, MPI_Datatype recvdisps == nullptr) { retval = MPI_ERR_ARG; } else { - int rank = comm != MPI_COMM_NULL ? smpi_process_index() : -1; + int rank = comm != MPI_COMM_NULL ? smpi_process()->index() : -1; int i = 0; int size = comm->size(); instr_extra_data extra = xbt_new0(s_instr_extra_data_t, 1); @@ -2077,7 +2095,7 @@ int PMPI_Alltoallv(void* sendbuf, int* sendcounts, int* senddisps, MPI_Datatype int known = 0; int dt_size_recv = 1; extra->datatype2 = encode_datatype(recvtype, &known); - dt_size_recv = smpi_datatype_size(recvtype); + dt_size_recv = recvtype->size(); void* sendtmpbuf = static_cast(sendbuf); int* sendtmpcounts = sendcounts; @@ -2103,7 +2121,7 @@ int PMPI_Alltoallv(void* sendbuf, int* sendcounts, int* senddisps, MPI_Datatype extra->datatype1 = encode_datatype(sendtmptype, &known); int dt_size_send = 1; - dt_size_send = smpi_datatype_size(sendtmptype); + dt_size_send = sendtmptype->size(); for (i = 0; i < size; i++) { // copy data to avoid bad free extra->send_size += sendtmpcounts[i] * dt_size_send; @@ -2111,7 +2129,7 @@ int PMPI_Alltoallv(void* sendbuf, int* sendcounts, int* senddisps, MPI_Datatype } extra->num_processes = size; TRACE_smpi_collective_in(rank, -1, __FUNCTION__, extra); - retval = mpi_coll_alltoallv_fun(sendtmpbuf, sendtmpcounts, sendtmpdisps, sendtmptype, recvbuf, recvcounts, + retval = simgrid::smpi::Colls::alltoallv(sendtmpbuf, sendtmpcounts, sendtmpdisps, sendtmptype, recvbuf, recvcounts, recvdisps, recvtype, comm); TRACE_smpi_collective_out(rank, -1, __FUNCTION__); @@ -2141,17 +2159,17 @@ int PMPI_Get_count(MPI_Status * status, MPI_Datatype datatype, int *count) { if (status == nullptr || count == nullptr) { return MPI_ERR_ARG; - } else if (!is_datatype_valid(datatype)) { + } else if (!datatype->is_valid()) { return MPI_ERR_TYPE; } else { - size_t size = smpi_datatype_size(datatype); + size_t size = datatype->size(); if (size == 0) { *count = 0; return MPI_SUCCESS; } else if (status->count % size != 0) { return MPI_UNDEFINED; } else { - *count = smpi_mpi_get_count(status, datatype); + *count = simgrid::smpi::Status::get_count(status, datatype); return MPI_SUCCESS; } } @@ -2163,7 +2181,7 @@ int PMPI_Type_contiguous(int count, MPI_Datatype old_type, MPI_Datatype* new_typ } else if (count<0){ return MPI_ERR_COUNT; } else { - return smpi_datatype_contiguous(count, old_type, new_type, 0); + return simgrid::smpi::Datatype::create_contiguous(count, old_type, 0, new_type); } } @@ -2171,7 +2189,7 @@ int PMPI_Type_commit(MPI_Datatype* datatype) { if (datatype == nullptr || *datatype == MPI_DATATYPE_NULL) { return MPI_ERR_TYPE; } else { - smpi_datatype_commit(datatype); + (*datatype)->commit(); return MPI_SUCCESS; } } @@ -2182,7 +2200,7 @@ int PMPI_Type_vector(int count, int blocklen, int stride, MPI_Datatype old_type, } else if (count<0 || blocklen<0){ return MPI_ERR_COUNT; } else { - return smpi_datatype_vector(count, blocklen, stride, old_type, new_type); + return simgrid::smpi::Datatype::create_vector(count, blocklen, stride, old_type, new_type); } } @@ -2192,7 +2210,7 @@ int PMPI_Type_hvector(int count, int blocklen, MPI_Aint stride, MPI_Datatype old } else if (count<0 || blocklen<0){ return MPI_ERR_COUNT; } else { - return smpi_datatype_hvector(count, blocklen, stride, old_type, new_type); + return simgrid::smpi::Datatype::create_hvector(count, blocklen, stride, old_type, new_type); } } @@ -2206,7 +2224,7 @@ int PMPI_Type_indexed(int count, int* blocklens, int* indices, MPI_Datatype old_ } else if (count<0){ return MPI_ERR_COUNT; } else { - return smpi_datatype_indexed(count, blocklens, indices, old_type, new_type); + return simgrid::smpi::Datatype::create_indexed(count, blocklens, indices, old_type, new_type); } } @@ -2216,7 +2234,7 @@ int PMPI_Type_create_indexed(int count, int* blocklens, int* indices, MPI_Dataty } else if (count<0){ return MPI_ERR_COUNT; } else { - return smpi_datatype_indexed(count, blocklens, indices, old_type, new_type); + return simgrid::smpi::Datatype::create_indexed(count, blocklens, indices, old_type, new_type); } } @@ -2231,7 +2249,7 @@ int PMPI_Type_create_indexed_block(int count, int blocklength, int* indices, MPI int* blocklens=static_cast(xbt_malloc(blocklength*count*sizeof(int))); for (int i = 0; i < count; i++) blocklens[i]=blocklength; - int retval = smpi_datatype_indexed(count, blocklens, indices, old_type, new_type); + int retval = simgrid::smpi::Datatype::create_indexed(count, blocklens, indices, old_type, new_type); xbt_free(blocklens); return retval; } @@ -2244,7 +2262,7 @@ int PMPI_Type_hindexed(int count, int* blocklens, MPI_Aint* indices, MPI_Datatyp } else if (count<0){ return MPI_ERR_COUNT; } else { - return smpi_datatype_hindexed(count, blocklens, indices, old_type, new_type); + return simgrid::smpi::Datatype::create_hindexed(count, blocklens, indices, old_type, new_type); } } @@ -2263,7 +2281,7 @@ int PMPI_Type_create_hindexed_block(int count, int blocklength, MPI_Aint* indice int* blocklens=(int*)xbt_malloc(blocklength*count*sizeof(int)); for (int i = 0; i < count; i++) blocklens[i] = blocklength; - int retval = smpi_datatype_hindexed(count, blocklens, indices, old_type, new_type); + int retval = simgrid::smpi::Datatype::create_hindexed(count, blocklens, indices, old_type, new_type); xbt_free(blocklens); return retval; } @@ -2273,7 +2291,7 @@ int PMPI_Type_struct(int count, int* blocklens, MPI_Aint* indices, MPI_Datatype* if (count<0){ return MPI_ERR_COUNT; } else { - return smpi_datatype_struct(count, blocklens, indices, old_types, new_type); + return simgrid::smpi::Datatype::create_struct(count, blocklens, indices, old_types, new_type); } } @@ -2289,7 +2307,7 @@ int PMPI_Error_class(int errorcode, int* errorclass) { } int PMPI_Initialized(int* flag) { - *flag=smpi_process_initialized(); + *flag=(smpi_process()!=nullptr && smpi_process()->initialized()); return MPI_SUCCESS; } @@ -2303,7 +2321,9 @@ int PMPI_Cart_create(MPI_Comm comm_old, int ndims, int* dims, int* periodic, int } else if (ndims < 0 || (ndims > 0 && (dims == nullptr || periodic == nullptr)) || comm_cart == nullptr) { return MPI_ERR_ARG; } else{ - new Cart(comm_old, ndims, dims, periodic, reorder, comm_cart); + simgrid::smpi::Topo_Cart* topo = new simgrid::smpi::Topo_Cart(comm_old, ndims, dims, periodic, reorder, comm_cart); + if(*comm_cart==MPI_COMM_NULL) + delete topo; return MPI_SUCCESS; } } @@ -2315,7 +2335,7 @@ int PMPI_Cart_rank(MPI_Comm comm, int* coords, int* rank) { if (coords == nullptr) { return MPI_ERR_ARG; } - Cart* topo = static_cast(comm->topo()); + MPIR_Cart_Topology topo = static_cast(comm->topo()); if (topo==nullptr) { return MPI_ERR_ARG; } @@ -2329,7 +2349,7 @@ int PMPI_Cart_shift(MPI_Comm comm, int direction, int displ, int* source, int* d if (source == nullptr || dest == nullptr || direction < 0 ) { return MPI_ERR_ARG; } - Cart* topo = static_cast(comm->topo()); + MPIR_Cart_Topology topo = static_cast(comm->topo()); if (topo==nullptr) { return MPI_ERR_ARG; } @@ -2349,7 +2369,7 @@ int PMPI_Cart_coords(MPI_Comm comm, int rank, int maxdims, int* coords) { if(coords == nullptr) { return MPI_ERR_ARG; } - Cart* topo = static_cast(comm->topo()); + MPIR_Cart_Topology topo = static_cast(comm->topo()); if (topo==nullptr) { return MPI_ERR_ARG; } @@ -2363,7 +2383,7 @@ int PMPI_Cart_get(MPI_Comm comm, int maxdims, int* dims, int* periods, int* coor if(maxdims <= 0 || dims == nullptr || periods == nullptr || coords == nullptr) { return MPI_ERR_ARG; } - Cart* topo = static_cast(comm->topo()); + MPIR_Cart_Topology topo = static_cast(comm->topo()); if (topo==nullptr) { return MPI_ERR_ARG; } @@ -2377,7 +2397,7 @@ int PMPI_Cartdim_get(MPI_Comm comm, int* ndims) { if (ndims == nullptr) { return MPI_ERR_ARG; } - Cart* topo = static_cast(comm->topo()); + MPIR_Cart_Topology topo = static_cast(comm->topo()); if (topo==nullptr) { return MPI_ERR_ARG; } @@ -2391,7 +2411,7 @@ int PMPI_Dims_create(int nnodes, int ndims, int* dims) { if (ndims < 1 || nnodes < 1) { return MPI_ERR_DIMS; } - return Dims_create(nnodes, ndims, dims); + return simgrid::smpi::Topo_Cart::Dims_create(nnodes, ndims, dims); } int PMPI_Cart_sub(MPI_Comm comm, int* remain_dims, MPI_Comm* comm_new) { @@ -2401,11 +2421,13 @@ int PMPI_Cart_sub(MPI_Comm comm, int* remain_dims, MPI_Comm* comm_new) { if (comm_new == nullptr) { return MPI_ERR_ARG; } - Cart* topo = static_cast(comm->topo()); + MPIR_Cart_Topology topo = static_cast(comm->topo()); if (topo==nullptr) { return MPI_ERR_ARG; } - Cart* cart = topo->sub(remain_dims, comm_new); + MPIR_Cart_Topology cart = topo->sub(remain_dims, comm_new); + if(*comm_new==MPI_COMM_NULL) + delete cart; if(cart==nullptr) return MPI_ERR_ARG; return MPI_SUCCESS; @@ -2419,10 +2441,9 @@ int PMPI_Type_create_resized(MPI_Datatype oldtype,MPI_Aint lb, MPI_Aint extent, MPI_Aint disps[3] = {lb, 0, lb + extent}; MPI_Datatype types[3] = {MPI_LB, oldtype, MPI_UB}; - s_smpi_mpi_struct_t* subtype = smpi_datatype_struct_create(blocks, disps, 3, types); - smpi_datatype_create(newtype, oldtype->size, lb, lb + extent, sizeof(s_smpi_mpi_struct_t), subtype, DT_FLAG_VECTOR); + *newtype = new simgrid::smpi::Type_Struct(oldtype->size(), lb, lb + extent, DT_FLAG_DERIVED, 3, blocks, disps, types); - (*newtype)->flags &= ~DT_FLAG_COMMITED; + (*newtype)->addflag(~DT_FLAG_COMMITED); return MPI_SUCCESS; } @@ -2434,20 +2455,81 @@ int PMPI_Win_create( void *base, MPI_Aint size, int disp_unit, MPI_Info info, MP }else if ((base == nullptr && size != 0) || disp_unit <= 0 || size < 0 ){ retval= MPI_ERR_OTHER; }else{ - *win = new Win( base, size, disp_unit, info, comm); + *win = new simgrid::smpi::Win( base, size, disp_unit, info, comm); retval = MPI_SUCCESS; } smpi_bench_begin(); return retval; } +int PMPI_Win_allocate( MPI_Aint size, int disp_unit, MPI_Info info, MPI_Comm comm, void *base, MPI_Win *win){ + int retval = 0; + smpi_bench_end(); + if (comm == MPI_COMM_NULL) { + retval= MPI_ERR_COMM; + }else if (disp_unit <= 0 || size < 0 ){ + retval= MPI_ERR_OTHER; + }else{ + void* ptr = xbt_malloc(size); + if(ptr==nullptr) + return MPI_ERR_NO_MEM; + *static_cast(base) = ptr; + *win = new simgrid::smpi::Win( ptr, size, disp_unit, info, comm,1); + retval = MPI_SUCCESS; + } + smpi_bench_begin(); + return retval; +} + +int PMPI_Win_create_dynamic( MPI_Info info, MPI_Comm comm, MPI_Win *win){ + int retval = 0; + smpi_bench_end(); + if (comm == MPI_COMM_NULL) { + retval= MPI_ERR_COMM; + }else{ + *win = new simgrid::smpi::Win(info, comm); + retval = MPI_SUCCESS; + } + smpi_bench_begin(); + return retval; +} + +int PMPI_Win_attach(MPI_Win win, void *base, MPI_Aint size){ + int retval = 0; + smpi_bench_end(); + if(win == MPI_WIN_NULL){ + retval = MPI_ERR_WIN; + } else if ((base == nullptr && size != 0) || size < 0 ){ + retval= MPI_ERR_OTHER; + }else{ + retval = win->attach(base, size); + } + smpi_bench_begin(); + return retval; +} + +int PMPI_Win_detach(MPI_Win win, void *base){ + int retval = 0; + smpi_bench_end(); + if(win == MPI_WIN_NULL){ + retval = MPI_ERR_WIN; + } else if (base == nullptr){ + retval= MPI_ERR_OTHER; + }else{ + retval = win->detach(base); + } + smpi_bench_begin(); + return retval; +} + + int PMPI_Win_free( MPI_Win* win){ int retval = 0; smpi_bench_end(); if (win == nullptr || *win == MPI_WIN_NULL) { retval = MPI_ERR_WIN; }else{ - delete(*win); + delete *win; retval=MPI_SUCCESS; } smpi_bench_begin(); @@ -2478,12 +2560,32 @@ int PMPI_Win_get_name(MPI_Win win, char * name, int* len) } } +int PMPI_Win_get_info(MPI_Win win, MPI_Info* info) +{ + if (win == MPI_WIN_NULL) { + return MPI_ERR_WIN; + } else { + *info = win->info(); + return MPI_SUCCESS; + } +} + +int PMPI_Win_set_info(MPI_Win win, MPI_Info info) +{ + if (win == MPI_WIN_NULL) { + return MPI_ERR_TYPE; + } else { + win->set_info(info); + return MPI_SUCCESS; + } +} + int PMPI_Win_get_group(MPI_Win win, MPI_Group * group){ if (win == MPI_WIN_NULL) { return MPI_ERR_WIN; }else { win->get_group(group); - (*group)->use(); + (*group)->ref(); return MPI_SUCCESS; } } @@ -2494,7 +2596,7 @@ int PMPI_Win_fence( int assert, MPI_Win win){ if (win == MPI_WIN_NULL) { retval = MPI_ERR_WIN; } else { - int rank = smpi_process_index(); + int rank = smpi_process()->index(); TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); retval = win->fence(assert); TRACE_smpi_collective_out(rank, -1, __FUNCTION__); @@ -2513,15 +2615,16 @@ int PMPI_Get( void *origin_addr, int origin_count, MPI_Datatype origin_datatype, retval = MPI_SUCCESS; } else if (target_rank <0){ retval = MPI_ERR_RANK; - } else if (target_disp <0){ + } else if (win->dynamic()==0 && target_disp <0){ + //in case of dynamic window, target_disp can be mistakenly seen as negative, as it is an address retval = MPI_ERR_ARG; } else if ((origin_count < 0 || target_count < 0) || (origin_addr==nullptr && origin_count > 0)){ retval = MPI_ERR_COUNT; - } else if ((!is_datatype_valid(origin_datatype)) || (!is_datatype_valid(target_datatype))) { + } else if ((!origin_datatype->is_valid()) || (!target_datatype->is_valid())) { retval = MPI_ERR_TYPE; } else { - int rank = smpi_process_index(); + int rank = smpi_process()->index(); MPI_Group group; win->get_group(&group); int src_traced = group->index(target_rank); @@ -2546,20 +2649,21 @@ int PMPI_Put( void *origin_addr, int origin_count, MPI_Datatype origin_datatype, retval = MPI_SUCCESS; } else if (target_rank <0){ retval = MPI_ERR_RANK; - } else if (target_disp <0){ + } else if (win->dynamic()==0 && target_disp <0){ + //in case of dynamic window, target_disp can be mistakenly seen as negative, as it is an address retval = MPI_ERR_ARG; } else if ((origin_count < 0 || target_count < 0) || (origin_addr==nullptr && origin_count > 0)){ retval = MPI_ERR_COUNT; - } else if ((!is_datatype_valid(origin_datatype)) || (!is_datatype_valid(target_datatype))) { + } else if ((!origin_datatype->is_valid()) || (!target_datatype->is_valid())) { retval = MPI_ERR_TYPE; } else { - int rank = smpi_process_index(); + int rank = smpi_process()->index(); MPI_Group group; win->get_group(&group); int dst_traced = group->index(target_rank); TRACE_smpi_ptp_in(rank, rank, dst_traced, __FUNCTION__, nullptr); - TRACE_smpi_send(rank, rank, dst_traced, SMPI_RMA_TAG, origin_count*smpi_datatype_size(origin_datatype)); + TRACE_smpi_send(rank, rank, dst_traced, SMPI_RMA_TAG, origin_count*origin_datatype->size()); retval = win->put( origin_addr, origin_count, origin_datatype, target_rank, target_disp, target_count, target_datatype); @@ -2580,18 +2684,19 @@ int PMPI_Accumulate( void *origin_addr, int origin_count, MPI_Datatype origin_da retval = MPI_SUCCESS; } else if (target_rank <0){ retval = MPI_ERR_RANK; - } else if (target_disp <0){ + } else if (win->dynamic()==0 && target_disp <0){ + //in case of dynamic window, target_disp can be mistakenly seen as negative, as it is an address retval = MPI_ERR_ARG; } else if ((origin_count < 0 || target_count < 0) || (origin_addr==nullptr && origin_count > 0)){ retval = MPI_ERR_COUNT; - } else if ((!is_datatype_valid(origin_datatype)) || - (!is_datatype_valid(target_datatype))) { + } else if ((!origin_datatype->is_valid()) || + (!target_datatype->is_valid())) { retval = MPI_ERR_TYPE; } else if (op == MPI_OP_NULL) { retval = MPI_ERR_OP; } else { - int rank = smpi_process_index(); + int rank = smpi_process()->index(); MPI_Group group; win->get_group(&group); int src_traced = group->index(target_rank); @@ -2606,6 +2711,51 @@ int PMPI_Accumulate( void *origin_addr, int origin_count, MPI_Datatype origin_da return retval; } +int PMPI_Get_accumulate(void *origin_addr, int origin_count, MPI_Datatype origin_datatype, void *result_addr, +int result_count, MPI_Datatype result_datatype, int target_rank, MPI_Aint target_disp, int target_count, +MPI_Datatype target_datatype, MPI_Op op, MPI_Win win){ + int retval = 0; + smpi_bench_end(); + if (win == MPI_WIN_NULL) { + retval = MPI_ERR_WIN; + } else if (target_rank == MPI_PROC_NULL) { + retval = MPI_SUCCESS; + } else if (target_rank <0){ + retval = MPI_ERR_RANK; + } else if (win->dynamic()==0 && target_disp <0){ + //in case of dynamic window, target_disp can be mistakenly seen as negative, as it is an address + retval = MPI_ERR_ARG; + } else if ((origin_count < 0 || target_count < 0 || result_count <0) || + (origin_addr==nullptr && origin_count > 0) || + (result_addr==nullptr && result_count > 0)){ + retval = MPI_ERR_COUNT; + } else if ((!origin_datatype->is_valid()) || + (!target_datatype->is_valid())|| + (!result_datatype->is_valid())) { + retval = MPI_ERR_TYPE; + } else if (op == MPI_OP_NULL) { + retval = MPI_ERR_OP; + } else { + int rank = smpi_process()->index(); + MPI_Group group; + win->get_group(&group); + int src_traced = group->index(target_rank); + TRACE_smpi_ptp_in(rank, src_traced, rank, __FUNCTION__, nullptr); + + retval = win->get_accumulate( origin_addr, origin_count, origin_datatype, result_addr, + result_count, result_datatype, target_rank, target_disp, + target_count, target_datatype, op); + + TRACE_smpi_ptp_out(rank, src_traced, rank, __FUNCTION__); + } + smpi_bench_begin(); + return retval; +} + +int PMPI_Fetch_and_op(void *origin_addr, void *result_addr, MPI_Datatype dtype, int target_rank, MPI_Aint target_disp, MPI_Op op, MPI_Win win){ + return PMPI_Get_accumulate(origin_addr, origin_addr==nullptr?0:1, dtype, result_addr, 1, dtype, target_rank, target_disp, 1, dtype, op, win); +} + int PMPI_Win_post(MPI_Group group, int assert, MPI_Win win){ int retval = 0; smpi_bench_end(); @@ -2614,7 +2764,7 @@ int PMPI_Win_post(MPI_Group group, int assert, MPI_Win win){ } else if (group==MPI_GROUP_NULL){ retval = MPI_ERR_GROUP; } else { - int rank = smpi_process_index(); + int rank = smpi_process()->index(); TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); retval = win->post(group,assert); TRACE_smpi_collective_out(rank, -1, __FUNCTION__); @@ -2631,7 +2781,7 @@ int PMPI_Win_start(MPI_Group group, int assert, MPI_Win win){ } else if (group==MPI_GROUP_NULL){ retval = MPI_ERR_GROUP; } else { - int rank = smpi_process_index(); + int rank = smpi_process()->index(); TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); retval = win->start(group,assert); TRACE_smpi_collective_out(rank, -1, __FUNCTION__); @@ -2646,7 +2796,7 @@ int PMPI_Win_complete(MPI_Win win){ if (win == MPI_WIN_NULL) { retval = MPI_ERR_WIN; } else { - int rank = smpi_process_index(); + int rank = smpi_process()->index(); TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); retval = win->complete(); @@ -2663,7 +2813,7 @@ int PMPI_Win_wait(MPI_Win win){ if (win == MPI_WIN_NULL) { retval = MPI_ERR_WIN; } else { - int rank = smpi_process_index(); + int rank = smpi_process()->index(); TRACE_smpi_collective_in(rank, -1, __FUNCTION__, nullptr); retval = win->wait(); @@ -2674,6 +2824,43 @@ int PMPI_Win_wait(MPI_Win win){ return retval; } +int PMPI_Win_lock(int lock_type, int rank, int assert, MPI_Win win){ + int retval = 0; + smpi_bench_end(); + if (win == MPI_WIN_NULL) { + retval = MPI_ERR_WIN; + } else if (lock_type != MPI_LOCK_EXCLUSIVE && + lock_type != MPI_LOCK_SHARED) { + retval = MPI_ERR_LOCKTYPE; + } else if (rank == MPI_PROC_NULL){ + retval = MPI_SUCCESS; + } else { + int myrank = smpi_process()->index(); + TRACE_smpi_collective_in(myrank, -1, __FUNCTION__, nullptr); + retval = win->lock(lock_type,rank,assert); + TRACE_smpi_collective_out(myrank, -1, __FUNCTION__); + } + smpi_bench_begin(); + return retval; +} + +int PMPI_Win_unlock(int rank, MPI_Win win){ + int retval = 0; + smpi_bench_end(); + if (win == MPI_WIN_NULL) { + retval = MPI_ERR_WIN; + } else if (rank == MPI_PROC_NULL){ + retval = MPI_SUCCESS; + } else { + int myrank = smpi_process()->index(); + TRACE_smpi_collective_in(myrank, -1, __FUNCTION__, nullptr); + retval = win->unlock(rank); + TRACE_smpi_collective_out(myrank, -1, __FUNCTION__); + } + smpi_bench_begin(); + return retval; +} + int PMPI_Alloc_mem(MPI_Aint size, MPI_Info info, void *baseptr){ void *ptr = xbt_malloc(size); if(ptr==nullptr) @@ -2696,7 +2883,7 @@ int PMPI_Type_set_name(MPI_Datatype datatype, char * name) } else if (name == nullptr) { return MPI_ERR_ARG; } else { - smpi_datatype_set_name(datatype, name); + datatype->set_name(name); return MPI_SUCCESS; } } @@ -2708,73 +2895,75 @@ int PMPI_Type_get_name(MPI_Datatype datatype, char * name, int* len) } else if (name == nullptr) { return MPI_ERR_ARG; } else { - smpi_datatype_get_name(datatype, name, len); + datatype->get_name(name, len); return MPI_SUCCESS; } } MPI_Datatype PMPI_Type_f2c(MPI_Fint datatype){ - return smpi_type_f2c(datatype); + return static_cast(simgrid::smpi::F2C::f2c(datatype)); } MPI_Fint PMPI_Type_c2f(MPI_Datatype datatype){ - return smpi_type_c2f( datatype); + return datatype->c2f(); } MPI_Group PMPI_Group_f2c(MPI_Fint group){ - return smpi_group_f2c( group); + return simgrid::smpi::Group::f2c(group); } MPI_Fint PMPI_Group_c2f(MPI_Group group){ - return smpi_group_c2f(group); + return group->c2f(); } MPI_Request PMPI_Request_f2c(MPI_Fint request){ - return smpi_request_f2c(request); + return static_cast(simgrid::smpi::Request::f2c(request)); } MPI_Fint PMPI_Request_c2f(MPI_Request request) { - return smpi_request_c2f(request); + return request->c2f(); } MPI_Win PMPI_Win_f2c(MPI_Fint win){ - return smpi_win_f2c(win); + return static_cast(simgrid::smpi::Win::f2c(win)); } MPI_Fint PMPI_Win_c2f(MPI_Win win){ - return smpi_win_c2f(win); + return win->c2f(); } MPI_Op PMPI_Op_f2c(MPI_Fint op){ - return smpi_op_f2c(op); + return static_cast(simgrid::smpi::Op::f2c(op)); } MPI_Fint PMPI_Op_c2f(MPI_Op op){ - return smpi_op_c2f(op); + return op->c2f(); } MPI_Comm PMPI_Comm_f2c(MPI_Fint comm){ - return smpi_comm_f2c(comm); + return static_cast(simgrid::smpi::Comm::f2c(comm)); } MPI_Fint PMPI_Comm_c2f(MPI_Comm comm){ - return smpi_comm_c2f(comm); + return comm->c2f(); } MPI_Info PMPI_Info_f2c(MPI_Fint info){ - return smpi_info_f2c(info); + return static_cast(simgrid::smpi::Info::f2c(info)); } MPI_Fint PMPI_Info_c2f(MPI_Info info){ - return smpi_info_c2f(info); + return info->c2f(); } int PMPI_Keyval_create(MPI_Copy_function* copy_fn, MPI_Delete_function* delete_fn, int* keyval, void* extra_state) { - return smpi_comm_keyval_create(copy_fn, delete_fn, keyval, extra_state); + smpi_copy_fn _copy_fn={copy_fn,nullptr,nullptr}; + smpi_delete_fn _delete_fn={delete_fn,nullptr,nullptr}; + return simgrid::smpi::Keyval::keyval_create(_copy_fn, _delete_fn, keyval, extra_state); } int PMPI_Keyval_free(int* keyval) { - return smpi_comm_keyval_free(keyval); + return simgrid::smpi::Keyval::keyval_free(keyval); } int PMPI_Attr_delete(MPI_Comm comm, int keyval) { @@ -2784,13 +2973,13 @@ int PMPI_Attr_delete(MPI_Comm comm, int keyval) { else if (comm==MPI_COMM_NULL) return MPI_ERR_COMM; else - return comm->attr_delete(keyval); + return comm->attr_delete(keyval); } int PMPI_Attr_get(MPI_Comm comm, int keyval, void* attr_value, int* flag) { static int one = 1; static int zero = 0; - static int tag_ub = 1000000; + static int tag_ub = INT_MAX; static int last_used_code = MPI_ERR_LASTCODE; if (comm==MPI_COMM_NULL){ @@ -2822,7 +3011,7 @@ int PMPI_Attr_get(MPI_Comm comm, int keyval, void* attr_value, int* flag) { *static_cast(attr_value) = &one; return MPI_SUCCESS; default: - return comm->attr_get(keyval, attr_value, flag); + return comm->attr_get(keyval, attr_value, flag); } } @@ -2833,7 +3022,7 @@ int PMPI_Attr_put(MPI_Comm comm, int keyval, void* attr_value) { else if (comm==MPI_COMM_NULL) return MPI_ERR_COMM; else - return comm->attr_put(keyval, attr_value); + return comm->attr_put(keyval, attr_value); } int PMPI_Comm_get_attr (MPI_Comm comm, int comm_keyval, void *attribute_val, int *flag) @@ -2866,7 +3055,7 @@ int PMPI_Type_get_attr (MPI_Datatype type, int type_keyval, void *attribute_val, if (type==MPI_DATATYPE_NULL) return MPI_ERR_TYPE; else - return smpi_type_attr_get(type, type_keyval, attribute_val, flag); + return type->attr_get(type_keyval, attribute_val, flag); } int PMPI_Type_set_attr (MPI_Datatype type, int type_keyval, void *attribute_val) @@ -2874,7 +3063,7 @@ int PMPI_Type_set_attr (MPI_Datatype type, int type_keyval, void *attribute_val) if (type==MPI_DATATYPE_NULL) return MPI_ERR_TYPE; else - return smpi_type_attr_put(type, type_keyval, attribute_val); + return type->attr_put(type_keyval, attribute_val); } int PMPI_Type_delete_attr (MPI_Datatype type, int type_keyval) @@ -2882,44 +3071,96 @@ int PMPI_Type_delete_attr (MPI_Datatype type, int type_keyval) if (type==MPI_DATATYPE_NULL) return MPI_ERR_TYPE; else - return smpi_type_attr_delete(type, type_keyval); + return type->attr_delete(type_keyval); } int PMPI_Type_create_keyval(MPI_Type_copy_attr_function* copy_fn, MPI_Type_delete_attr_function* delete_fn, int* keyval, void* extra_state) { - return smpi_type_keyval_create(copy_fn, delete_fn, keyval, extra_state); + smpi_copy_fn _copy_fn={nullptr,copy_fn,nullptr}; + smpi_delete_fn _delete_fn={nullptr,delete_fn,nullptr}; + return simgrid::smpi::Keyval::keyval_create(_copy_fn, _delete_fn, keyval, extra_state); } int PMPI_Type_free_keyval(int* keyval) { - return smpi_type_keyval_free(keyval); + return simgrid::smpi::Keyval::keyval_free(keyval); +} + +int PMPI_Win_get_attr (MPI_Win win, int keyval, void *attribute_val, int* flag) +{ + static MPI_Aint size; + static int disp_unit; + if (win==MPI_WIN_NULL) + return MPI_ERR_TYPE; + else{ + switch (keyval) { + case MPI_WIN_BASE : + *static_cast(attribute_val) = win->base(); + *flag = 1; + return MPI_SUCCESS; + case MPI_WIN_SIZE : + size = win->size(); + *static_cast(attribute_val) = &size; + *flag = 1; + return MPI_SUCCESS; + case MPI_WIN_DISP_UNIT : + disp_unit=win->disp_unit(); + *static_cast(attribute_val) = &disp_unit; + *flag = 1; + return MPI_SUCCESS; + default: + return win->attr_get(keyval, attribute_val, flag); + } +} + +} + +int PMPI_Win_set_attr (MPI_Win win, int type_keyval, void *attribute_val) +{ + if (win==MPI_WIN_NULL) + return MPI_ERR_TYPE; + else + return win->attr_put(type_keyval, attribute_val); +} + +int PMPI_Win_delete_attr (MPI_Win win, int type_keyval) +{ + if (win==MPI_WIN_NULL) + return MPI_ERR_TYPE; + else + return win->attr_delete(type_keyval); +} + +int PMPI_Win_create_keyval(MPI_Win_copy_attr_function* copy_fn, MPI_Win_delete_attr_function* delete_fn, int* keyval, + void* extra_state) +{ + smpi_copy_fn _copy_fn={nullptr, nullptr, copy_fn}; + smpi_delete_fn _delete_fn={nullptr, nullptr, delete_fn}; + return simgrid::smpi::Keyval::keyval_create(_copy_fn, _delete_fn, keyval, extra_state); +} + +int PMPI_Win_free_keyval(int* keyval) { + return simgrid::smpi::Keyval::keyval_free(keyval); } int PMPI_Info_create( MPI_Info *info){ if (info == nullptr) return MPI_ERR_ARG; - *info = xbt_new(s_smpi_mpi_info_t, 1); - (*info)->info_dict= xbt_dict_new_homogeneous(xbt_free_f); - (*info)->refcount=1; + *info = new simgrid::smpi::Info(); return MPI_SUCCESS; } int PMPI_Info_set( MPI_Info info, char *key, char *value){ if (info == nullptr || key == nullptr || value == nullptr) return MPI_ERR_ARG; - - xbt_dict_set(info->info_dict, key, xbt_strdup(value), nullptr); + info->set(key, value); return MPI_SUCCESS; } int PMPI_Info_free( MPI_Info *info){ if (info == nullptr || *info==nullptr) return MPI_ERR_ARG; - (*info)->refcount--; - if((*info)->refcount==0){ - xbt_dict_free(&((*info)->info_dict)); - xbt_free(*info); - } + simgrid::smpi::Info::unref(*info); *info=MPI_INFO_NULL; return MPI_SUCCESS; } @@ -2930,109 +3171,70 @@ int PMPI_Info_get(MPI_Info info,char *key,int valuelen, char *value, int *flag){ return MPI_ERR_ARG; if (value == nullptr) return MPI_ERR_INFO_VALUE; - char* tmpvalue=static_cast(xbt_dict_get_or_null(info->info_dict, key)); - if(tmpvalue){ - memset(value, 0, valuelen); - memcpy(value,tmpvalue, (strlen(tmpvalue) + 1 < static_cast(valuelen)) ? strlen(tmpvalue) + 1 : valuelen); - *flag=true; - } - return MPI_SUCCESS; + return info->get(key, valuelen, value, flag); } int PMPI_Info_dup(MPI_Info info, MPI_Info *newinfo){ if (info == nullptr || newinfo==nullptr) return MPI_ERR_ARG; - *newinfo = xbt_new(s_smpi_mpi_info_t, 1); - (*newinfo)->info_dict= xbt_dict_new_homogeneous(xbt_free_f); - (*newinfo)->refcount=1; - xbt_dict_cursor_t cursor = nullptr; - char* key; - void* data; - xbt_dict_foreach(info->info_dict,cursor,key,data){ - xbt_dict_set((*newinfo)->info_dict, key, xbt_strdup(static_cast(data)), nullptr); - } + *newinfo = new simgrid::smpi::Info(info); return MPI_SUCCESS; } int PMPI_Info_delete(MPI_Info info, char *key){ if (info == nullptr || key==nullptr) return MPI_ERR_ARG; - try { - xbt_dict_remove(info->info_dict, key); - } - catch(xbt_ex& e){ - return MPI_ERR_INFO_NOKEY; - } - return MPI_SUCCESS; + return info->remove(key); } int PMPI_Info_get_nkeys( MPI_Info info, int *nkeys){ if (info == nullptr || nkeys==nullptr) return MPI_ERR_ARG; - *nkeys=xbt_dict_size(info->info_dict); - return MPI_SUCCESS; + return info->get_nkeys(nkeys); } int PMPI_Info_get_nthkey( MPI_Info info, int n, char *key){ if (info == nullptr || key==nullptr || n<0 || n> MPI_MAX_INFO_KEY) return MPI_ERR_ARG; - - xbt_dict_cursor_t cursor = nullptr; - char *keyn; - void* data; - int num=0; - xbt_dict_foreach(info->info_dict,cursor,keyn,data){ - if(num==n){ - strncpy(key,keyn,strlen(keyn)+1); - xbt_dict_cursor_free(&cursor); - return MPI_SUCCESS; - } - num++; - } - return MPI_ERR_ARG; + return info->get_nthkey(n, key); } int PMPI_Info_get_valuelen( MPI_Info info, char *key, int *valuelen, int *flag){ *flag=false; if (info == nullptr || key == nullptr || valuelen==nullptr) return MPI_ERR_ARG; - char* tmpvalue=(char*)xbt_dict_get_or_null(info->info_dict, key); - if(tmpvalue){ - *valuelen=strlen(tmpvalue); - *flag=true; - } - return MPI_SUCCESS; + return info->get_valuelen(key, valuelen, flag); } int PMPI_Unpack(void* inbuf, int incount, int* position, void* outbuf, int outcount, MPI_Datatype type, MPI_Comm comm) { if(incount<0 || outcount < 0 || inbuf==nullptr || outbuf==nullptr) return MPI_ERR_ARG; - if(!is_datatype_valid(type)) + if(!type->is_valid()) return MPI_ERR_TYPE; if(comm==MPI_COMM_NULL) return MPI_ERR_COMM; - return smpi_mpi_unpack(inbuf, incount, position, outbuf,outcount,type, comm); + return type->unpack(inbuf, incount, position, outbuf,outcount, comm); } int PMPI_Pack(void* inbuf, int incount, MPI_Datatype type, void* outbuf, int outcount, int* position, MPI_Comm comm) { if(incount<0 || outcount < 0|| inbuf==nullptr || outbuf==nullptr) return MPI_ERR_ARG; - if(!is_datatype_valid(type)) + if(!type->is_valid()) return MPI_ERR_TYPE; if(comm==MPI_COMM_NULL) return MPI_ERR_COMM; - return smpi_mpi_pack(inbuf, incount, type, outbuf,outcount,position, comm); + return type->pack(inbuf, incount, outbuf,outcount,position, comm); } int PMPI_Pack_size(int incount, MPI_Datatype datatype, MPI_Comm comm, int* size) { if(incount<0) return MPI_ERR_ARG; - if(!is_datatype_valid(datatype)) + if(!datatype->is_valid()) return MPI_ERR_TYPE; if(comm==MPI_COMM_NULL) return MPI_ERR_COMM; - *size=incount*smpi_datatype_size(datatype); + *size=incount*datatype->size(); return MPI_SUCCESS; }