X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/652e6c763d01ad7924087d541928bd44c795d72d..3ba5d4a966c2ac976b2b1656c52145f70189d108:/src/simix/smx_network.cpp?ds=inline diff --git a/src/simix/smx_network.cpp b/src/simix/smx_network.cpp index 6dc0a8ee72..07f4c3c8e6 100644 --- a/src/simix/smx_network.cpp +++ b/src/simix/smx_network.cpp @@ -26,7 +26,7 @@ XBT_LOG_NEW_DEFAULT_SUBCATEGORY(simix_network, simix, "SIMIX network-related syn static void SIMIX_waitany_remove_simcall_from_actions(smx_simcall_t simcall); static void SIMIX_comm_copy_data(smx_activity_t comm); -static void SIMIX_comm_start(smx_activity_t synchro); +static void SIMIX_comm_start(simgrid::kernel::activity::CommImplPtr synchro); /** * \brief Checks if there is a communication activity queued in a deque matching our needs @@ -52,7 +52,7 @@ _find_matching_comm(boost::circular_buffer_space_optimized* dequ } if (comm->type == type && (match_fun == nullptr || match_fun(this_user_data, other_user_data, comm)) && (not comm->match_fun || comm->match_fun(other_user_data, this_user_data, my_synchro))) { - XBT_DEBUG("Found a matching communication synchro %p", comm); + XBT_DEBUG("Found a matching communication synchro %p", comm.get()); if (remove_matching) deque->erase(it); #if SIMGRID_HAVE_MC @@ -63,7 +63,7 @@ _find_matching_comm(boost::circular_buffer_space_optimized* dequ } XBT_DEBUG("Sorry, communication synchro %p does not match our needs:" " its type is %d but we are looking for a comm of type %d (or maybe the filtering didn't match)", - comm, (int)comm->type, (int)type); + comm.get(), (int)comm->type, (int)type); } XBT_DEBUG("No matching communication synchro found"); return nullptr; @@ -92,7 +92,7 @@ XBT_PRIVATE smx_activity_t simcall_HANDLER_comm_isend(smx_simcall_t simcall, smx void (*copy_data_fun)(smx_activity_t, void*, size_t),// used to copy data if not default one void *data, int detached) { - XBT_DEBUG("send from %p", mbox); + XBT_DEBUG("send from mailbox %p", mbox); /* Prepare a synchro describing us, so that it gets passed to the user-provided filter of other side */ simgrid::kernel::activity::CommImplPtr this_comm = @@ -106,14 +106,14 @@ XBT_PRIVATE smx_activity_t simcall_HANDLER_comm_isend(smx_simcall_t simcall, smx _find_matching_comm(&mbox->comm_queue, SIMIX_COMM_RECEIVE, match_fun, data, this_comm, /*remove_matching*/ true); if (not other_comm) { - other_comm = this_comm; + other_comm = std::move(this_comm); if (mbox->permanent_receiver != nullptr) { //this mailbox is for small messages, which have to be sent right now other_comm->state = SIMIX_READY; other_comm->dst_proc=mbox->permanent_receiver.get(); mbox->done_comm_queue.push_back(other_comm); - XBT_DEBUG("pushing a message into the permanent receive list %p, comm %p", mbox, other_comm); + XBT_DEBUG("pushing a message into the permanent receive list %p, comm %p", mbox, other_comm.get()); }else{ mbox->push(other_comm); @@ -181,7 +181,7 @@ smx_activity_t SIMIX_comm_irecv(smx_actor_t dst_proc, smx_mailbox_t mbox, void * { simgrid::kernel::activity::CommImplPtr this_synchro = simgrid::kernel::activity::CommImplPtr(new simgrid::kernel::activity::CommImpl(SIMIX_COMM_RECEIVE)); - XBT_DEBUG("recv from %p %p. this_synchro=%p", mbox, &mbox->comm_queue, this_synchro); + XBT_DEBUG("recv from mbox %p. this_synchro=%p", mbox, this_synchro.get()); simgrid::kernel::activity::CommImplPtr other_comm; //communication already done, get it inside the list of completed comms @@ -198,7 +198,7 @@ smx_activity_t SIMIX_comm_irecv(smx_actor_t dst_proc, smx_mailbox_t mbox, void * mbox->push(this_synchro); } else { if (other_comm->surf_comm && other_comm->remains() < 1e-12) { - XBT_DEBUG("comm %p has been already sent, and is finished, destroy it",other_comm); + XBT_DEBUG("comm %p has been already sent, and is finished, destroy it", other_comm.get()); other_comm->state = SIMIX_DONE; other_comm->type = SIMIX_COMM_DONE; other_comm->mbox = nullptr; @@ -214,12 +214,12 @@ smx_activity_t SIMIX_comm_irecv(smx_actor_t dst_proc, smx_mailbox_t mbox, void * other_comm = _find_matching_comm(&mbox->comm_queue, SIMIX_COMM_SEND, match_fun, data, this_synchro, /*remove_matching*/ true); - if (not other_comm) { - XBT_DEBUG("Receive pushed first %zu", mbox->comm_queue.size()); + if (other_comm == nullptr) { + XBT_DEBUG("Receive pushed first (%zu comm enqueued so far)", mbox->comm_queue.size()); other_comm = this_synchro; mbox->push(this_synchro); } else { - XBT_DEBUG("Match my %p with the existing %p", this_synchro, other_comm); + XBT_DEBUG("Match my %p with the existing %p", this_synchro.get(), other_comm.get()); other_comm->state = SIMIX_READY; other_comm->type = SIMIX_COMM_READY; @@ -286,7 +286,7 @@ smx_activity_t SIMIX_comm_iprobe(smx_actor_t dst_proc, smx_mailbox_t mbox, int t void simcall_HANDLER_comm_wait(smx_simcall_t simcall, smx_activity_t synchro, double timeout) { /* Associate this simcall to the wait synchro */ - XBT_DEBUG("simcall_HANDLER_comm_wait, %p", synchro); + XBT_DEBUG("simcall_HANDLER_comm_wait, %p", synchro.get()); synchro->simcalls.push_back(simcall); simcall->issuer->waiting_synchro = synchro; @@ -391,14 +391,11 @@ void simcall_HANDLER_comm_testany(smx_simcall_t simcall, simgrid::kernel::activi void simcall_HANDLER_comm_waitany(smx_simcall_t simcall, xbt_dynar_t synchros, double timeout) { - smx_activity_t synchro; - unsigned int cursor = 0; - if (MC_is_active() || MC_record_replay_is_active()){ if (timeout > 0.0) xbt_die("Timeout not implemented for waitany in the model-checker"); int idx = SIMCALL_GET_MC_VALUE(simcall); - synchro = xbt_dynar_get_as(synchros, idx, smx_activity_t); + smx_activity_t synchro = xbt_dynar_get_as(synchros, idx, smx_activity_t); synchro->simcalls.push_back(simcall); simcall_comm_waitany__set__result(simcall, idx); synchro->state = SIMIX_DONE; @@ -416,7 +413,10 @@ void simcall_HANDLER_comm_waitany(smx_simcall_t simcall, xbt_dynar_t synchros, d }); } - xbt_dynar_foreach(synchros, cursor, synchro){ + unsigned int cursor; + simgrid::kernel::activity::ActivityImpl* ptr; + xbt_dynar_foreach(synchros, cursor, ptr){ + smx_activity_t synchro = simgrid::kernel::activity::ActivityImplPtr(ptr); /* associate this simcall to the the synchro */ synchro->simcalls.push_back(simcall); @@ -430,11 +430,13 @@ void simcall_HANDLER_comm_waitany(smx_simcall_t simcall, xbt_dynar_t synchros, d void SIMIX_waitany_remove_simcall_from_actions(smx_simcall_t simcall) { - smx_activity_t synchro; unsigned int cursor = 0; xbt_dynar_t synchros = simcall_comm_waitany__get__comms(simcall); - xbt_dynar_foreach(synchros, cursor, synchro) { + simgrid::kernel::activity::ActivityImpl* ptr; + xbt_dynar_foreach(synchros, cursor, ptr){ + smx_activity_t synchro = simgrid::kernel::activity::ActivityImplPtr(ptr); + // Remove the first occurence of simcall: auto i = boost::range::find(synchro->simcalls, simcall); if (i != synchro->simcalls.end()) @@ -446,22 +448,19 @@ void SIMIX_waitany_remove_simcall_from_actions(smx_simcall_t simcall) * \brief Starts the simulation of a communication synchro. * \param synchro the communication synchro */ -static inline void SIMIX_comm_start(smx_activity_t synchro) +static inline void SIMIX_comm_start(simgrid::kernel::activity::CommImplPtr comm) { - simgrid::kernel::activity::CommImplPtr comm = - boost::static_pointer_cast(synchro); - /* If both the sender and the receiver are already there, start the communication */ - if (synchro->state == SIMIX_READY) { + if (comm->state == SIMIX_READY) { simgrid::s4u::Host* sender = comm->src_proc->host; simgrid::s4u::Host* receiver = comm->dst_proc->host; comm->surf_comm = surf_network_model->communicate(sender, receiver, comm->task_size, comm->rate); - comm->surf_comm->setData(&*synchro); + comm->surf_comm->setData(comm.get()); comm->state = SIMIX_RUNNING; - XBT_DEBUG("Starting communication %p from '%s' to '%s' (surf_action: %p)", synchro, sender->cname(), + XBT_DEBUG("Starting communication %p from '%s' to '%s' (surf_action: %p)", comm.get(), sender->cname(), receiver->cname(), comm->surf_comm); /* If a link is failed, detect it immediately */ @@ -534,7 +533,7 @@ void SIMIX_comm_finish(smx_activity_t synchro) switch (comm->state) { case SIMIX_DONE: - XBT_DEBUG("Communication %p complete!", synchro); + XBT_DEBUG("Communication %p complete!", synchro.get()); SIMIX_comm_copy_data(synchro); break; @@ -565,7 +564,7 @@ void SIMIX_comm_finish(smx_activity_t synchro) case SIMIX_LINK_FAILURE: XBT_DEBUG("Link failure in synchro %p between '%s' and '%s': posting an exception to the issuer: %s (%p) " "detached:%d", - synchro, comm->src_proc ? comm->src_proc->host->cname() : nullptr, + synchro.get(), comm->src_proc ? comm->src_proc->host->cname() : nullptr, comm->dst_proc ? comm->dst_proc->host->cname() : nullptr, simcall->issuer->cname(), simcall->issuer, comm->detached); if (comm->src_proc == simcall->issuer) { @@ -688,7 +687,7 @@ void SIMIX_comm_copy_data(smx_activity_t synchro) if (not comm->src_buff || not comm->dst_buff || comm->copied) return; - XBT_DEBUG("Copying comm %p data from %s (%p) -> %s (%p) (%zu bytes)", comm, + XBT_DEBUG("Copying comm %p data from %s (%p) -> %s (%p) (%zu bytes)", comm.get(), comm->src_proc ? comm->src_proc->host->cname() : "a finished process", comm->src_buff, comm->dst_proc ? comm->dst_proc->host->cname() : "a finished process", comm->dst_buff, buff_size);