X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/605e2d3042cadf11949ae854862dc5553b74dd30..8a70fd6e0cc77910dda2e50a7f8bbb864f26c0b9:/src/simix/smx_network.c diff --git a/src/simix/smx_network.c b/src/simix/smx_network.c index 990a4f54c4..7732d2a5f5 100644 --- a/src/simix/smx_network.c +++ b/src/simix/smx_network.c @@ -19,12 +19,10 @@ static void SIMIX_comm_finish(smx_action_t action); static void SIMIX_waitany_req_remove_from_actions(smx_req_t req); static void SIMIX_comm_copy_data(smx_action_t comm); static smx_action_t SIMIX_comm_new(e_smx_comm_type_t type); -static XBT_INLINE void SIMIX_comm_wait_for_completion(smx_action_t comm, - double timeout); static XBT_INLINE void SIMIX_rdv_push(smx_rdv_t rdv, smx_action_t comm); static XBT_INLINE void SIMIX_rdv_remove(smx_rdv_t rdv, smx_action_t comm); static smx_action_t SIMIX_rdv_get_request(smx_rdv_t rdv, e_smx_comm_type_t type, - int (*match_fun)(void *, void *), void *); + int (*match_fun)(void *, void *), void *); static void SIMIX_rdv_free(void *data); void SIMIX_network_init(void) @@ -221,6 +219,12 @@ void SIMIX_comm_destroy(smx_action_t action) SIMIX_comm_destroy_internal_actions(action); + if (action->comm.detached && action->state != SIMIX_DONE) { + /* the communication has failed and was detached: + * we have to free the buffer */ + ((void_f_pvoid_t) action->comm.src_data)(action->comm.src_buff); + } + xbt_free(action); } @@ -248,7 +252,8 @@ void SIMIX_comm_destroy_internal_actions(smx_action_t action) smx_action_t SIMIX_comm_isend(smx_process_t src_proc, smx_rdv_t rdv, double task_size, double rate, void *src_buff, size_t src_buff_size, - int (*match_fun)(void *, void *), void *data) + int (*match_fun)(void *, void *), void *data, + int detached) { smx_action_t action; @@ -264,6 +269,13 @@ smx_action_t SIMIX_comm_isend(smx_process_t src_proc, smx_rdv_t rdv, action->comm.type = SIMIX_COMM_READY; } + /* If the communication action is detached then decrease the refcount + * by one, so it will be eliminated by the receivers destroy call */ + if (detached) { + action->comm.detached = 1; + action->comm.refcount--; + } + /* Setup the communication request */ action->comm.src_proc = src_proc; action->comm.task_size = task_size; @@ -315,7 +327,7 @@ smx_action_t SIMIX_comm_irecv(smx_process_t dst_proc, smx_rdv_t rdv, return action; } -void SIMIX_pre_comm_wait(smx_req_t req) +void SIMIX_pre_comm_wait(smx_req_t req, int idx) { smx_action_t action = req->comm_wait.comm; double timeout = req->comm_wait.timeout; @@ -326,7 +338,20 @@ void SIMIX_pre_comm_wait(smx_req_t req) req->issuer->waiting_action = action; if (MC_IS_ENABLED){ - action->state = SIMIX_DONE; + if(idx == 0){ + action->state = SIMIX_DONE; + }else{ + /* If we reached this point, the wait request must have a timeout */ + /* Otherwise it shouldn't be enabled and executed by the MC */ + if(timeout == -1) + THROW_IMPOSSIBLE; + + if(action->comm.src_proc == req->issuer) + action->state = SIMIX_SRC_TIMEOUT; + else + action->state = SIMIX_DST_TIMEOUT; + } + SIMIX_comm_finish(action); return; } @@ -349,8 +374,20 @@ void SIMIX_pre_comm_wait(smx_req_t req) void SIMIX_pre_comm_test(smx_req_t req) { smx_action_t action = req->comm_test.comm; - req->comm_test.result = (action->state != SIMIX_WAITING && action->state != SIMIX_RUNNING); + if(MC_IS_ENABLED){ + req->comm_test.result = action->comm.src_proc && action->comm.dst_proc; + if(req->comm_test.result){ + action->state = SIMIX_DONE; + xbt_fifo_push(action->request_list, req); + SIMIX_comm_finish(action); + }else{ + SIMIX_request_answer(req); + } + return; + } + + req->comm_test.result = (action->state != SIMIX_WAITING && action->state != SIMIX_RUNNING); if (req->comm_test.result) { xbt_fifo_push(action->request_list, req); SIMIX_comm_finish(action); @@ -359,7 +396,7 @@ void SIMIX_pre_comm_test(smx_req_t req) } } -void SIMIX_pre_comm_testany(smx_req_t req, unsigned int idx) +void SIMIX_pre_comm_testany(smx_req_t req, int idx) { unsigned int cursor; smx_action_t action; @@ -367,10 +404,11 @@ void SIMIX_pre_comm_testany(smx_req_t req, unsigned int idx) req->comm_testany.result = -1; if (MC_IS_ENABLED){ - if((int)idx == -1){ + if(idx == -1){ SIMIX_request_answer(req); }else{ action = xbt_dynar_get_as(actions, idx, smx_action_t); + req->comm_testany.result = idx; xbt_fifo_push(action->request_list, req); action->state = SIMIX_DONE; SIMIX_comm_finish(action); @@ -389,7 +427,7 @@ void SIMIX_pre_comm_testany(smx_req_t req, unsigned int idx) SIMIX_request_answer(req); } -void SIMIX_pre_comm_waitany(smx_req_t req, unsigned int idx) +void SIMIX_pre_comm_waitany(smx_req_t req, int idx) { smx_action_t action; unsigned int cursor = 0; @@ -470,6 +508,7 @@ static XBT_INLINE void SIMIX_comm_start(smx_action_t action) void SIMIX_comm_finish(smx_action_t action) { + unsigned int destroy_count = 0; smx_req_t req; while ((req = xbt_fifo_shift(action->request_list))) { @@ -568,7 +607,11 @@ void SIMIX_comm_finish(smx_action_t action) req->issuer->waiting_action = NULL; SIMIX_request_answer(req); + destroy_count++; } + + while(destroy_count-- > 0) + SIMIX_comm_destroy(action); } void SIMIX_post_comm(smx_action_t action) @@ -611,7 +654,9 @@ void SIMIX_comm_cancel(smx_action_t action) SIMIX_rdv_remove(action->comm.rdv, action); action->state = SIMIX_FAILED; } else { - surf_workstation_model->action_cancel(action->comm.surf_comm); + /* When running the MC there are no surf actions */ + if(!MC_IS_ENABLED) + surf_workstation_model->action_cancel(action->comm.surf_comm); } }