X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/5b547799240cfe5d60c1c4161e3fc8849095e2ca..040d8fa855d2b6ac9884f68108a09b935570be21:/src/kernel/activity/CommImpl.cpp diff --git a/src/kernel/activity/CommImpl.cpp b/src/kernel/activity/CommImpl.cpp index 1724a85b50..39fe618bb6 100644 --- a/src/kernel/activity/CommImpl.cpp +++ b/src/kernel/activity/CommImpl.cpp @@ -1,22 +1,22 @@ -/* Copyright (c) 2007-2021. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2007-2022. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ +#include +#include +#include +#include + #include "src/kernel/activity/CommImpl.hpp" -#include "simgrid/Exception.hpp" -#include "simgrid/kernel/resource/Action.hpp" -#include "simgrid/kernel/routing/NetPoint.hpp" -#include "simgrid/modelchecker.h" -#include "simgrid/s4u/Host.hpp" #include "src/kernel/activity/MailboxImpl.hpp" #include "src/kernel/context/Context.hpp" +#include "src/kernel/resource/CpuImpl.hpp" +#include "src/kernel/resource/LinkImpl.hpp" +#include "src/kernel/resource/StandardLinkImpl.hpp" #include "src/mc/mc_replay.hpp" -#include "src/surf/cpu_interface.hpp" -#include "src/surf/network_interface.hpp" -#include "src/surf/surf_interface.hpp" -XBT_LOG_NEW_DEFAULT_SUBCATEGORY(simix_network, simix, "SIMIX network-related synchronization"); +XBT_LOG_NEW_DEFAULT_SUBCATEGORY(ker_network, kernel, "Kernel network-related synchronization"); XBT_PRIVATE void simcall_HANDLER_comm_send(smx_simcall_t simcall, smx_actor_t src, smx_mailbox_t mbox, double task_size, double rate, unsigned char* src_buff, size_t src_buff_size, @@ -55,11 +55,11 @@ XBT_PRIVATE simgrid::kernel::activity::ActivityImplPtr simcall_HANDLER_comm_isen if (not other_comm) { other_comm = std::move(this_comm); - if (mbox->permanent_receiver_ != nullptr) { + if (mbox->is_permanent()) { // this mailbox is for small messages, which have to be sent right now - other_comm->state_ = simgrid::kernel::activity::State::READY; - other_comm->dst_actor_ = mbox->permanent_receiver_.get(); - mbox->done_comm_queue_.push_back(other_comm); + other_comm->set_state(simgrid::kernel::activity::State::READY); + other_comm->dst_actor_ = mbox->get_permanent_receiver().get(); + mbox->push_done(other_comm); XBT_DEBUG("pushing a message into the permanent receive list %p, comm %p", mbox, other_comm.get()); } else { @@ -68,7 +68,7 @@ XBT_PRIVATE simgrid::kernel::activity::ActivityImplPtr simcall_HANDLER_comm_isen } else { XBT_DEBUG("Receive already pushed"); - other_comm->state_ = simgrid::kernel::activity::State::READY; + other_comm->set_state(simgrid::kernel::activity::State::READY); } if (detached) { @@ -88,7 +88,7 @@ XBT_PRIVATE simgrid::kernel::activity::ActivityImplPtr simcall_HANDLER_comm_isen other_comm->copy_data_fun = copy_data_fun; if (MC_is_active() || MC_record_replay_is_active()) - other_comm->state_ = simgrid::kernel::activity::State::RUNNING; + other_comm->set_state(simgrid::kernel::activity::State::RUNNING); else other_comm->start(); @@ -119,7 +119,7 @@ simcall_HANDLER_comm_irecv(smx_simcall_t /*simcall*/, smx_actor_t receiver, smx_ simgrid::kernel::activity::CommImplPtr other_comm; // communication already done, get it inside the list of completed comms - if (mbox->permanent_receiver_ != nullptr && not mbox->done_comm_queue_.empty()) { + if (mbox->is_permanent() && mbox->has_some_done_comm()) { XBT_DEBUG("We have a comm that has probably already been received, trying to match it, to skip the communication"); // find a match in the list of already received comms other_comm = mbox->find_matching_comm(simgrid::kernel::activity::CommImpl::Type::SEND, match_fun, data, @@ -134,7 +134,7 @@ simcall_HANDLER_comm_irecv(smx_simcall_t /*simcall*/, smx_actor_t receiver, smx_ } else { if (other_comm->surf_action_ && other_comm->get_remaining() < 1e-12) { XBT_DEBUG("comm %p has been already sent, and is finished, destroy it", other_comm.get()); - other_comm->state_ = simgrid::kernel::activity::State::DONE; + other_comm->set_state(simgrid::kernel::activity::State::DONE); other_comm->set_mailbox(nullptr); } } @@ -150,13 +150,13 @@ simcall_HANDLER_comm_irecv(smx_simcall_t /*simcall*/, smx_actor_t receiver, smx_ /*remove_matching*/ true); if (other_comm == nullptr) { - XBT_DEBUG("Receive pushed first (%zu comm enqueued so far)", mbox->comm_queue_.size()); + XBT_DEBUG("Receive pushed first (%zu comm enqueued so far)", mbox->size()); other_comm = std::move(this_synchro); mbox->push(other_comm); } else { XBT_DEBUG("Match my %p with the existing %p", this_synchro.get(), other_comm.get()); - other_comm->state_ = simgrid::kernel::activity::State::READY; + other_comm->set_state(simgrid::kernel::activity::State::READY); } receiver->activities_.emplace_back(other_comm); } @@ -173,7 +173,7 @@ simcall_HANDLER_comm_irecv(smx_simcall_t /*simcall*/, smx_actor_t receiver, smx_ other_comm->copy_data_fun = copy_data_fun; if (MC_is_active() || MC_record_replay_is_active()) { - other_comm->state_ = simgrid::kernel::activity::State::RUNNING; + other_comm->set_state(simgrid::kernel::activity::State::RUNNING); return other_comm; } other_comm->start(); @@ -206,33 +206,31 @@ void simcall_HANDLER_comm_waitany(smx_simcall_t simcall, simgrid::kernel::activi /******************************************************************************/ /* SIMIX_comm_copy_data callbacks */ /******************************************************************************/ +// XBT_ATTRIB_DEPRECATED_v333 void SIMIX_comm_set_copy_data_callback(void (*callback)(simgrid::kernel::activity::CommImpl*, void*, size_t)) { simgrid::kernel::activity::CommImpl::set_copy_data_callback(callback); } +// XBT_ATTRIB_DEPRECATED_v333 void SIMIX_comm_copy_buffer_callback(simgrid::kernel::activity::CommImpl* comm, void* buff, size_t buff_size) { - XBT_DEBUG("Copy the data over"); - memcpy(comm->dst_buff_, buff, buff_size); - if (comm->detached()) { // if this is a detached send, the source buffer was duplicated by SMPI sender to make the - // original buffer available to the application ASAP - xbt_free(buff); - comm->src_buff_ = nullptr; - } + simgrid::s4u::Comm::copy_buffer_callback(comm, buff, buff_size); } +// XBT_ATTRIB_DEPRECATED_v333 void SIMIX_comm_copy_pointer_callback(simgrid::kernel::activity::CommImpl* comm, void* buff, size_t buff_size) { - xbt_assert((buff_size == sizeof(void*)), "Cannot copy %zu bytes: must be sizeof(void*)", buff_size); - *(void**)(comm->dst_buff_) = buff; + simgrid::s4u::Comm::copy_pointer_callback(comm, buff, buff_size); } namespace simgrid { namespace kernel { namespace activity { +xbt::signal CommImpl::on_start; +xbt::signal CommImpl::on_completion; -void (*CommImpl::copy_data_callback_)(CommImpl*, void*, size_t) = &SIMIX_comm_copy_pointer_callback; +void (*CommImpl::copy_data_callback_)(CommImpl*, void*, size_t) = &s4u::Comm::copy_pointer_callback; void CommImpl::set_copy_data_callback(void (*callback)(CommImpl*, void*, size_t)) { @@ -278,7 +276,7 @@ CommImpl& CommImpl::detach() CommImpl::CommImpl(s4u::Host* from, s4u::Host* to, double bytes) : size_(bytes), detached_(true), from_(from), to_(to) { - state_ = State::READY; + set_state(State::READY); } CommImpl::~CommImpl() @@ -287,7 +285,7 @@ CommImpl::~CommImpl() cleanup_surf(); - if (detached_ && state_ != State::DONE) { + if (detached_ && get_state() != State::DONE) { /* the communication has failed and was detached: * we have to free the buffer */ if (clean_fun) @@ -302,19 +300,20 @@ CommImpl::~CommImpl() CommImpl* CommImpl::start() { /* If both the sender and the receiver are already there, start the communication */ - if (state_ == State::READY) { + if (get_state() == State::READY) { from_ = from_ != nullptr ? from_ : src_actor_->get_host(); to_ = to_ != nullptr ? to_ : dst_actor_->get_host(); - - /* FIXME[donassolo]: getting the network_model from the origin host - * Soon we need to change this function to first get the routes and later - * create the respective surf actions */ + /* Getting the network_model from the origin host + * Valid while we have a single network model, otherwise we would need to change this function to first get the + * routes and later create the respective surf actions */ auto net_model = from_->get_netpoint()->get_englobing_zone()->get_network_model(); surf_action_ = net_model->communicate(from_, to_, size_, rate_); surf_action_->set_activity(this); surf_action_->set_category(get_tracing_category()); - state_ = State::RUNNING; + set_start_time(surf_action_->get_start_time()); + set_state(State::RUNNING); + on_start(*this); XBT_DEBUG("Starting communication %p from '%s' to '%s' (surf_action: %p; state: %s)", this, from_->get_cname(), to_->get_cname(), surf_action_, get_state_str()); @@ -323,7 +322,7 @@ CommImpl* CommImpl::start() if (surf_action_->get_state() == resource::Action::State::FAILED) { XBT_DEBUG("Communication from '%s' to '%s' failed to start because of a link failure", from_->get_cname(), to_->get_cname()); - state_ = State::LINK_FAILURE; + set_state(State::LINK_FAILURE); post(); } else if ((src_actor_ != nullptr && src_actor_->is_suspended()) || @@ -346,6 +345,16 @@ CommImpl* CommImpl::start() return this; } +std::vector CommImpl::get_traversed_links() const +{ + xbt_assert(get_state() != State::WAITING, "You cannot use %s() if your communication is not ready (%s)", __FUNCTION__, + get_state_str()); + std::vector vlinks; + XBT_ATTRIB_UNUSED double res = 0; + from_->route_to(to_, vlinks, &res); + return vlinks; +} + /** @brief Copy the communication data from the sender's buffer to the receiver's one */ void CommImpl::copy_data() { @@ -381,13 +390,13 @@ void CommImpl::copy_data() bool CommImpl::test() { if ((MC_is_active() || MC_record_replay_is_active()) && src_actor_ && dst_actor_) - state_ = State::DONE; + set_state(State::DONE); return ActivityImpl::test(); } void CommImpl::wait_for(actor::ActorImpl* issuer, double timeout) { - XBT_DEBUG("CommImpl::wait_for(%g), %p, state %s", timeout, this, to_c_str(state_)); + XBT_DEBUG("CommImpl::wait_for(%g), %p, state %s", timeout, this, get_state_str()); /* Associate this simcall to the wait synchro */ register_simcall(&issuer->simcall_); @@ -395,13 +404,13 @@ void CommImpl::wait_for(actor::ActorImpl* issuer, double timeout) if (MC_is_active() || MC_record_replay_is_active()) { int idx = issuer->simcall_.mc_value_; if (idx == 0) { - state_ = State::DONE; + set_state(State::DONE); } else { /* If we reached this point, the wait simcall must have a timeout */ /* Otherwise it shouldn't be enabled and executed by the MC */ if (timeout < 0.0) THROW_IMPOSSIBLE; - state_ = (issuer == src_actor_ ? State::SRC_TIMEOUT : State::DST_TIMEOUT); + set_state(issuer == src_actor_ ? State::SRC_TIMEOUT : State::DST_TIMEOUT); } finish(); return; @@ -409,7 +418,7 @@ void CommImpl::wait_for(actor::ActorImpl* issuer, double timeout) /* If the synchro has already finish perform the error handling, */ /* otherwise set up a waiting timeout on the right side */ - if (state_ != State::WAITING && state_ != State::RUNNING) { + if (get_state() != State::WAITING && get_state() != State::RUNNING) { finish(); } else { /* we need a sleep action (even when there is no timeout) to be notified of host failures */ resource::Action* sleep = issuer->get_host()->get_cpu()->sleep(timeout); @@ -445,7 +454,7 @@ void CommImpl::wait_any_for(actor::ActorImpl* issuer, const std::vectorsimcalls_.push_back(&issuer->simcall_); simcall_comm_waitany__set__result(&issuer->simcall_, idx); - comm->state_ = State::DONE; + comm->set_state(State::DONE); comm->finish(); return; } @@ -469,7 +478,7 @@ void CommImpl::wait_any_for(actor::ActorImpl* issuer, const std::vectorsimcalls_.push_back(&issuer->simcall_); /* see if the synchro is already finished */ - if (comm->state_ != State::WAITING && comm->state_ != State::RUNNING) { + if (comm->get_state() != State::WAITING && comm->get_state() != State::RUNNING) { comm->finish(); break; } @@ -495,13 +504,13 @@ void CommImpl::resume() void CommImpl::cancel() { /* if the synchro is a waiting state means that it is still in a mbox so remove from it and delete it */ - if (state_ == State::WAITING) { + if (get_state() == State::WAITING) { if (not detached_) { mbox_->remove(this); - state_ = State::CANCELED; + set_state(State::CANCELED); } } else if (not MC_is_active() /* when running the MC there are no surf actions */ - && not MC_record_replay_is_active() && (state_ == State::READY || state_ == State::RUNNING)) { + && not MC_record_replay_is_active() && (get_state() == State::READY || get_state() == State::RUNNING)) { surf_action_->cancel(); } } @@ -524,19 +533,21 @@ void CommImpl::cleanup_surf() void CommImpl::post() { + on_completion(*this); + /* Update synchro state */ if (src_timeout_ && src_timeout_->get_state() == resource::Action::State::FINISHED) - state_ = State::SRC_TIMEOUT; + set_state(State::SRC_TIMEOUT); else if (dst_timeout_ && dst_timeout_->get_state() == resource::Action::State::FINISHED) - state_ = State::DST_TIMEOUT; + set_state(State::DST_TIMEOUT); else if (src_timeout_ && src_timeout_->get_state() == resource::Action::State::FAILED) - state_ = State::SRC_HOST_FAILURE; + set_state(State::SRC_HOST_FAILURE); else if (dst_timeout_ && dst_timeout_->get_state() == resource::Action::State::FAILED) - state_ = State::DST_HOST_FAILURE; + set_state(State::DST_HOST_FAILURE); else if (surf_action_ && surf_action_->get_state() == resource::Action::State::FAILED) { - state_ = State::LINK_FAILURE; + set_state(State::LINK_FAILURE); } else - state_ = State::DONE; + set_state(State::DONE); XBT_DEBUG("CommImpl::post(): comm %p, state %s, src_proc %p, dst_proc %p, detached: %d", this, get_state_str(), src_actor_.get(), dst_actor_.get(), detached_); @@ -547,16 +558,79 @@ void CommImpl::post() /* Answer all simcalls associated with the synchro */ finish(); } +void CommImpl::set_exception(actor::ActorImpl* issuer) +{ + switch (get_state()) { + case State::FAILED: + issuer->exception_ = std::make_exception_ptr(NetworkFailureException(XBT_THROW_POINT, "Remote peer failed")); + break; + case State::SRC_TIMEOUT: + issuer->exception_ = + std::make_exception_ptr(TimeoutException(XBT_THROW_POINT, "Communication timeouted because of the sender")); + break; + + case State::DST_TIMEOUT: + issuer->exception_ = + std::make_exception_ptr(TimeoutException(XBT_THROW_POINT, "Communication timeouted because of the receiver")); + break; + + case State::SRC_HOST_FAILURE: + if (issuer == src_actor_) + issuer->context_->set_wannadie(); + else { + set_state(State::FAILED); + issuer->exception_ = std::make_exception_ptr(NetworkFailureException(XBT_THROW_POINT, "Remote peer failed")); + } + break; + + case State::DST_HOST_FAILURE: + if (issuer == dst_actor_) + issuer->context_->set_wannadie(); + else { + set_state(State::FAILED); + issuer->exception_ = std::make_exception_ptr(NetworkFailureException(XBT_THROW_POINT, "Remote peer failed")); + } + break; + + case State::LINK_FAILURE: + XBT_DEBUG("Link failure in synchro %p between '%s' and '%s': posting an exception to the issuer: %s (%p) " + "detached:%d", + this, src_actor_ ? src_actor_->get_host()->get_cname() : nullptr, + dst_actor_ ? dst_actor_->get_host()->get_cname() : nullptr, issuer->get_cname(), issuer, detached_); + if (src_actor_ == issuer) { + XBT_DEBUG("I'm source"); + } else if (dst_actor_ == issuer) { + XBT_DEBUG("I'm dest"); + } else { + XBT_DEBUG("I'm neither source nor dest"); + } + set_state(State::FAILED); + issuer->throw_exception(std::make_exception_ptr(NetworkFailureException(XBT_THROW_POINT, "Link failure"))); + break; + + case State::CANCELED: + if (issuer == dst_actor_) + issuer->exception_ = + std::make_exception_ptr(CancelException(XBT_THROW_POINT, "Communication canceled by the sender")); + else + issuer->exception_ = + std::make_exception_ptr(CancelException(XBT_THROW_POINT, "Communication canceled by the receiver")); + break; + + default: + xbt_assert(get_state() == State::DONE, "Internal error in CommImpl::finish(): unexpected synchro state %s", + get_state_str()); + } +} void CommImpl::finish() { - XBT_DEBUG("CommImpl::finish() in state %s", to_c_str(state_)); - + XBT_DEBUG("CommImpl::finish() in state %s", get_state_str()); /* If the synchro is still in a rendez-vous point then remove from it */ if (mbox_) mbox_->remove(this); - if (state_ == State::DONE) + if (get_state() == State::DONE) copy_data(); while (not simcalls_.empty()) { @@ -579,8 +653,8 @@ void CommImpl::finish() simcall->timeout_cb_ = nullptr; } if (not MC_is_active() && not MC_record_replay_is_active()) { - CommImpl** element = std::find(comms, comms + count, this); - ssize_t rank = (element != comms + count) ? element - comms : -1; + auto element = std::find(comms, comms + count, this); + ssize_t rank = (element != comms + count) ? element - comms : -1; simcall_comm_waitany__set__result(simcall, rank); } } @@ -590,63 +664,7 @@ void CommImpl::finish() if (not simcall->issuer_->get_host()->is_on()) { simcall->issuer_->context_->set_wannadie(); } else { - switch (state_) { - case State::SRC_TIMEOUT: - simcall->issuer_->exception_ = std::make_exception_ptr( - TimeoutException(XBT_THROW_POINT, "Communication timeouted because of the sender")); - break; - - case State::DST_TIMEOUT: - simcall->issuer_->exception_ = std::make_exception_ptr( - TimeoutException(XBT_THROW_POINT, "Communication timeouted because of the receiver")); - break; - - case State::SRC_HOST_FAILURE: - if (simcall->issuer_ == src_actor_) - simcall->issuer_->context_->set_wannadie(); - else - simcall->issuer_->exception_ = - std::make_exception_ptr(NetworkFailureException(XBT_THROW_POINT, "Remote peer failed")); - break; - - case State::DST_HOST_FAILURE: - if (simcall->issuer_ == dst_actor_) - simcall->issuer_->context_->set_wannadie(); - else - simcall->issuer_->exception_ = - std::make_exception_ptr(NetworkFailureException(XBT_THROW_POINT, "Remote peer failed")); - break; - - case State::LINK_FAILURE: - XBT_DEBUG("Link failure in synchro %p between '%s' and '%s': posting an exception to the issuer: %s (%p) " - "detached:%d", - this, src_actor_ ? src_actor_->get_host()->get_cname() : nullptr, - dst_actor_ ? dst_actor_->get_host()->get_cname() : nullptr, simcall->issuer_->get_cname(), - simcall->issuer_, detached_); - if (src_actor_ == simcall->issuer_) { - XBT_DEBUG("I'm source"); - } else if (dst_actor_ == simcall->issuer_) { - XBT_DEBUG("I'm dest"); - } else { - XBT_DEBUG("I'm neither source nor dest"); - } - simcall->issuer_->throw_exception( - std::make_exception_ptr(NetworkFailureException(XBT_THROW_POINT, "Link failure"))); - break; - - case State::CANCELED: - if (simcall->issuer_ == dst_actor_) - simcall->issuer_->exception_ = - std::make_exception_ptr(CancelException(XBT_THROW_POINT, "Communication canceled by the sender")); - else - simcall->issuer_->exception_ = - std::make_exception_ptr(CancelException(XBT_THROW_POINT, "Communication canceled by the receiver")); - break; - - default: - xbt_assert(state_ == State::DONE, "Internal error in CommImpl::finish(): unexpected synchro state %s", - to_c_str(state_)); - } + set_exception(simcall->issuer_); simcall->issuer_->simcall_answer(); } /* if there is an exception during a waitany or a testany, indicate the position of the failed communication */ @@ -663,8 +681,8 @@ void CommImpl::finish() comms = simcall_comm_testany__get__comms(simcall); count = simcall_comm_testany__get__count(simcall); } - CommImpl** element = std::find(comms, comms + count, this); - ssize_t rank = (element != comms + count) ? element - comms : -1; + auto element = std::find(comms, comms + count, this); + ssize_t rank = (element != comms + count) ? element - comms : -1; // In order to modify the exception we have to rethrow it: try { std::rethrow_exception(simcall->issuer_->exception_);