X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/4e1a33c02d4d7552d988f33482fabd5383435a72..abf7c33aff8279f498000149d39448946c3297b3:/src/mc/mc_request.c

diff --git a/src/mc/mc_request.c b/src/mc/mc_request.c
index b656a4d2c6..47609e83eb 100644
--- a/src/mc/mc_request.c
+++ b/src/mc/mc_request.c
@@ -4,6 +4,8 @@
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
 
+#include <assert.h>
+
 #include "mc_request.h"
 #include "mc_safety.h"
 #include "mc_private.h"
@@ -62,8 +64,6 @@ int MC_request_depend(smx_simcall_t r1, smx_simcall_t r2)
         SIMCALL_COMM_ISEND ? simcall_comm_isend__get__rdv(r1) :
         simcall_comm_irecv__get__rdv(r1);
 
-    // FIXME, remote access to comm object
-
     if (rdv != synchro2.comm.rdv_cpy
         && simcall_comm_wait__get__timeout(r2) <= 0)
       return FALSE;
@@ -232,18 +232,17 @@ static char *buff_size_to_string(size_t buff_size)
 
 char *MC_request_to_string(smx_simcall_t req, int value)
 {
-  char *type = NULL, *args = NULL, *str = NULL, *p = NULL, *bs = NULL;
-  smx_synchro_t act = NULL;
-  smx_mutex_t mutex = NULL;
-  size_t size = 0;
+  const char* type = NULL;
+  char *args = NULL;
 
   smx_process_t issuer = MC_smx_simcall_get_issuer(req);
 
   switch (req->call) {
-  case SIMCALL_COMM_ISEND:
-    type = xbt_strdup("iSend");
-    p = pointer_to_string(simcall_comm_isend__get__src_buff(req));
-    bs = buff_size_to_string(simcall_comm_isend__get__src_buff_size(req));
+
+  case SIMCALL_COMM_ISEND: {
+    type = "iSend";
+    char* p = pointer_to_string(simcall_comm_isend__get__src_buff(req));
+    char* bs = buff_size_to_string(simcall_comm_isend__get__src_buff_size(req));
     if (issuer->smx_host)
       args =
           bprintf("src=(%lu)%s (%s), buff=%s, size=%s", issuer->pid,
@@ -254,14 +253,23 @@ char *MC_request_to_string(smx_simcall_t req, int value)
       args =
           bprintf("src=(%lu)%s, buff=%s, size=%s", issuer->pid,
                   MC_smx_process_get_name(issuer), p, bs);
+    xbt_free(bs);
+    xbt_free(p);
     break;
-  case SIMCALL_COMM_IRECV:
-    size =
-        simcall_comm_irecv__get__dst_buff_size(req) ?
-        *simcall_comm_irecv__get__dst_buff_size(req) : 0;
-    type = xbt_strdup("iRecv");
-    p = pointer_to_string(simcall_comm_irecv__get__dst_buff(req));
-    bs = buff_size_to_string(size);
+  }
+
+  case SIMCALL_COMM_IRECV: {
+    size_t* remote_size = simcall_comm_irecv__get__dst_buff_size(req);
+
+    // size_t size = size_pointer ? *size_pointer : 0;
+    size_t size = 0;
+    if (remote_size)
+      MC_process_read_simple(&mc_model_checker->process, &size,
+        remote_size, sizeof(size));
+
+    type = "iRecv";
+    char* p = pointer_to_string(simcall_comm_irecv__get__dst_buff(req));
+    char* bs = buff_size_to_string(size);
     if (issuer->smx_host)
       args =
           bprintf("dst=(%lu)%s (%s), buff=%s, size=%s", issuer->pid,
@@ -273,19 +281,28 @@ char *MC_request_to_string(smx_simcall_t req, int value)
           bprintf("dst=(%lu)%s, buff=%s, size=%s", issuer->pid,
                   MC_smx_process_get_name(issuer),
                   p, bs);
+    xbt_free(bs);
+    xbt_free(p);
     break;
-  case SIMCALL_COMM_WAIT:
-    act = simcall_comm_wait__get__comm(req);
+  }
+
+  case SIMCALL_COMM_WAIT: {
+    smx_synchro_t remote_act = simcall_comm_wait__get__comm(req);
+    char* p;
     if (value == -1) {
-      type = xbt_strdup("WaitTimeout");
-      p = pointer_to_string(act);
+      type = "WaitTimeout";
+      p = pointer_to_string(remote_act);
       args = bprintf("comm=%s", p);
     } else {
-      type = xbt_strdup("Wait");
-      p = pointer_to_string(act);
-      // TODO, fix remote access to comm
-      smx_process_t src_proc = MC_smx_resolve_process(act->comm.src_proc);
-      smx_process_t dst_proc = MC_smx_resolve_process(act->comm.dst_proc);
+      type = "Wait";
+      p = pointer_to_string(remote_act);
+
+      s_smx_synchro_t synchro;
+      MC_process_read_simple(&mc_model_checker->process, &synchro,
+        remote_act, sizeof(synchro));
+
+      smx_process_t src_proc = MC_smx_resolve_process(synchro.comm.src_proc);
+      smx_process_t dst_proc = MC_smx_resolve_process(synchro.comm.dst_proc);
       args = bprintf("comm=%s [(%lu)%s (%s)-> (%lu)%s (%s)]", p,
                      src_proc ? src_proc->pid : 0,
                      src_proc ? MC_smx_process_get_host_name(src_proc) : "",
@@ -294,19 +311,27 @@ char *MC_request_to_string(smx_simcall_t req, int value)
                      dst_proc ? MC_smx_process_get_host_name(dst_proc) : "",
                      dst_proc ? MC_smx_process_get_name(dst_proc) : "");
     }
+    xbt_free(p);
     break;
-  case SIMCALL_COMM_TEST:
-    act = simcall_comm_test__get__comm(req);
-    if (act->comm.src_proc == NULL || act->comm.dst_proc == NULL) {
-      type = xbt_strdup("Test FALSE");
-      p = pointer_to_string(act);
+  }
+
+  case SIMCALL_COMM_TEST: {
+    smx_synchro_t remote_act = simcall_comm_test__get__comm(req);
+    s_smx_synchro_t synchro;
+    MC_process_read_simple(&mc_model_checker->process, &synchro,
+      remote_act, sizeof(synchro));
+
+    char* p;
+    if (synchro.comm.src_proc == NULL || synchro.comm.dst_proc == NULL) {
+      type = "Test FALSE";
+      p = pointer_to_string(remote_act);
       args = bprintf("comm=%s", p);
     } else {
-      type = xbt_strdup("Test TRUE");
-      p = pointer_to_string(act);
-      // TODO, get process, get process name
-      smx_process_t src_proc = MC_smx_resolve_process(act->comm.src_proc);
-      smx_process_t dst_proc = MC_smx_resolve_process(act->comm.dst_proc);
+      type = "Test TRUE";
+      p = pointer_to_string(remote_act);
+
+      smx_process_t src_proc = MC_smx_resolve_process(synchro.comm.src_proc);
+      smx_process_t dst_proc = MC_smx_resolve_process(synchro.comm.dst_proc);
       args = bprintf("comm=%s [(%lu)%s (%s) -> (%lu)%s (%s)]", p,
                      src_proc->pid,
                      MC_smx_process_get_name(src_proc),
@@ -315,52 +340,71 @@ char *MC_request_to_string(smx_simcall_t req, int value)
                      MC_smx_process_get_name(dst_proc),
                      MC_smx_process_get_host_name(dst_proc));
     }
+    xbt_free(p);
     break;
+  }
 
-  case SIMCALL_COMM_WAITANY:
-    type = xbt_strdup("WaitAny");
-    if (!xbt_dynar_is_empty(simcall_comm_waitany__get__comms(req))) {
-      p = pointer_to_string(xbt_dynar_get_as
-                            (simcall_comm_waitany__get__comms(req), value,
-                             smx_synchro_t));
-      args =
-          bprintf("comm=%s (%d of %lu)", p, value + 1,
-                  xbt_dynar_length(simcall_comm_waitany__get__comms(req)));
+  case SIMCALL_COMM_WAITANY: {
+    type = "WaitAny";
+    s_xbt_dynar_t comms;
+    MC_process_read_simple(&mc_model_checker->process,
+      &comms,  simcall_comm_waitany__get__comms(req), sizeof(comms));
+    if (!xbt_dynar_is_empty(&comms)) {
+      smx_synchro_t remote_sync;
+      MC_process_read_dynar_element(&mc_model_checker->process,
+        &remote_sync, simcall_comm_waitany__get__comms(req), value);
+      char* p = pointer_to_string(remote_sync);
+      args = bprintf("comm=%s (%d of %lu)",
+        p, value + 1, xbt_dynar_length(&comms));
+      xbt_free(p);
     } else {
       args = bprintf("comm at idx %d", value);
     }
     break;
+  }
 
   case SIMCALL_COMM_TESTANY:
     if (value == -1) {
-      type = xbt_strdup("TestAny FALSE");
+      type = "TestAny FALSE";
       args = xbt_strdup("-");
     } else {
-      type = xbt_strdup("TestAny");
+      type = "TestAny";
       args =
           bprintf("(%d of %lu)", value + 1,
-                  xbt_dynar_length(simcall_comm_testany__get__comms(req)));
+                  MC_process_read_dynar_length(&mc_model_checker->process,
+                    simcall_comm_testany__get__comms(req)));
     }
     break;
 
-  case SIMCALL_MUTEX_LOCK:
-    mutex = simcall_mutex_lock__get__mutex(req);
-    type = xbt_strdup("Mutex LOCK");
-    args = bprintf("locked = %d, owner = %d, sleeping = %d", mutex->locked, mutex->owner != NULL ? (int)mutex->owner->pid : -1, xbt_swag_size(mutex->sleeping));
+  case SIMCALL_MUTEX_LOCK: {
+    type = "Mutex LOCK";
+
+    s_smx_mutex_t mutex;
+    MC_process_read_simple(&mc_model_checker->process, &mutex,
+      simcall_mutex_lock__get__mutex(req), sizeof(mutex));
+    s_xbt_swag_t mutex_sleeping;
+    MC_process_read_simple(&mc_model_checker->process, &mutex_sleeping,
+      mutex.sleeping, sizeof(mutex_sleeping));
+
+    args = bprintf("locked = %d, owner = %d, sleeping = %d",
+      mutex.locked,
+      mutex.owner != NULL ? (int) MC_smx_resolve_process(mutex.owner)->pid : -1,
+      mutex_sleeping.count);
     break;
+  }
 
   case SIMCALL_MC_SNAPSHOT:
-    type = xbt_strdup("MC_SNAPSHOT");
+    type = "MC_SNAPSHOT";
     args = NULL;
     break;
 
   case SIMCALL_MC_COMPARE_SNAPSHOTS:
-    type = xbt_strdup("MC_COMPARE_SNAPSHOTS");
+    type = "MC_COMPARE_SNAPSHOTS";
     args = NULL;
     break;
 
   case SIMCALL_MC_RANDOM:
-    type = xbt_strdup("MC_RANDOM");
+    type = "MC_RANDOM";
     args = bprintf("%d", value);
     break;
 
@@ -368,37 +412,55 @@ char *MC_request_to_string(smx_simcall_t req, int value)
     THROW_UNIMPLEMENTED;
   }
 
+  char* str;
   if (args != NULL) {
-    // FIXME, get process name
     str =
         bprintf("[(%lu)%s (%s)] %s(%s)", issuer->pid,
                 MC_smx_process_get_host_name(issuer),
                 MC_smx_process_get_name(issuer),
                 type, args);
   } else {
-    // FIXME, get process name
     str =
         bprintf("[(%lu)%s (%s)] %s ", issuer->pid,
                 MC_smx_process_get_host_name(issuer),
                 MC_smx_process_get_name(issuer),
                 type);
   }
-
   xbt_free(args);
-  xbt_free(type);
-  xbt_free(p);
-  xbt_free(bs);
   return str;
 }
 
 unsigned int MC_request_testany_fail(smx_simcall_t req)
 {
-  unsigned int cursor;
-  smx_synchro_t action;
-
-  xbt_dynar_foreach(simcall_comm_testany__get__comms(req), cursor, action) {
-    // FIXME, remote access to comm object
-    if (action->comm.src_proc && action->comm.dst_proc)
+  // Remote xbt_dynar_foreach on simcall_comm_testany__get__comms(req).
+
+  // Read the dynar:
+  s_xbt_dynar_t comms;
+  MC_process_read_simple(&mc_model_checker->process,
+    &comms, simcall_comm_testany__get__comms(req), sizeof(comms));
+
+  // Read ther dynar buffer:
+  size_t buffer_size = comms.elmsize * comms.used;
+  char buffer[buffer_size];
+  MC_process_read_simple(&mc_model_checker->process,
+    buffer, comms.data, buffer_size);
+
+  // Iterate over the elements:
+  assert(comms.elmsize == sizeof(smx_synchro_t));
+  unsigned cursor;
+  for (cursor=0; cursor != comms.used; ++cursor) {
+
+    // Get the element:
+    smx_synchro_t remote_action;
+    memcpy(buffer + comms.elmsize * cursor, &remote_action, sizeof(remote_action));
+
+    // Dereference the pointer:
+    s_smx_synchro_t action;
+    MC_process_read_simple(&mc_model_checker->process,
+      &action, remote_action, sizeof(action));
+
+    // Finally so something useful about it:
+    if (action.comm.src_proc && action.comm.dst_proc)
       return FALSE;
   }
 
@@ -407,35 +469,38 @@ unsigned int MC_request_testany_fail(smx_simcall_t req)
 
 int MC_request_is_enabled_by_idx(smx_simcall_t req, unsigned int idx)
 {
-  smx_synchro_t act;
-
-  // FIXME, remote access to comm object
-
+  smx_synchro_t remote_act = NULL;
   switch (req->call) {
 
   case SIMCALL_COMM_WAIT:
     /* FIXME: check also that src and dst processes are not suspended */
-    act = simcall_comm_wait__get__comm(req);
-    return (act->comm.src_proc && act->comm.dst_proc);
+    remote_act = simcall_comm_wait__get__comm(req);
     break;
 
-  case SIMCALL_COMM_WAITANY:
-    act =
-        xbt_dynar_get_as(simcall_comm_waitany__get__comms(req), idx,
-                         smx_synchro_t);
-    return (act->comm.src_proc && act->comm.dst_proc);
+  case SIMCALL_COMM_WAITANY: {
+    smx_synchro_t act;
+    MC_process_read_dynar_element(
+      &mc_model_checker->process, &act, simcall_comm_waitany__get__comms(req),
+      idx);
+    }
     break;
 
-  case SIMCALL_COMM_TESTANY:
-    act =
-        xbt_dynar_get_as(simcall_comm_testany__get__comms(req), idx,
-                         smx_synchro_t);
-    return (act->comm.src_proc && act->comm.dst_proc);
+  case SIMCALL_COMM_TESTANY: {
+    s_smx_synchro_t act;
+    MC_process_read_dynar_element(
+      &mc_model_checker->process, &act, simcall_comm_testany__get__comms(req),
+      idx);
+    }
     break;
 
   default:
     return TRUE;
   }
+
+  s_smx_synchro_t synchro;
+  MC_process_read_simple(&mc_model_checker->process,
+    &synchro, remote_act, sizeof(synchro));
+  return synchro.comm.src_proc && synchro.comm.dst_proc;
 }
 
 int MC_process_is_enabled(smx_process_t process)
@@ -445,8 +510,7 @@ int MC_process_is_enabled(smx_process_t process)
 
 char *MC_request_get_dot_output(smx_simcall_t req, int value)
 {
-  char *str = NULL, *label = NULL;
-  smx_synchro_t act = NULL;
+  char *label = NULL;
 
   const smx_process_t issuer = MC_smx_simcall_get_issuer(req);
 
@@ -469,8 +533,7 @@ char *MC_request_get_dot_output(smx_simcall_t req, int value)
       label = bprintf("[(%lu)] iRecv", issuer->pid);
     break;
 
-  case SIMCALL_COMM_WAIT:
-    act = simcall_comm_wait__get__comm(req);
+  case SIMCALL_COMM_WAIT: {
     if (value == -1) {
       if (issuer->smx_host)
         label =
@@ -479,9 +542,13 @@ char *MC_request_get_dot_output(smx_simcall_t req, int value)
       else
         label = bprintf("[(%lu)] WaitTimeout", issuer->pid);
     } else {
-      // FIXME, remote access to act->comm
-      smx_process_t src_proc = MC_smx_resolve_process(act->comm.src_proc);
-      smx_process_t dst_proc = MC_smx_resolve_process(act->comm.dst_proc);
+      smx_synchro_t remote_act = simcall_comm_wait__get__comm(req);
+      s_smx_synchro_t synchro;
+      MC_process_read_simple(&mc_model_checker->process, &synchro,
+        remote_act, sizeof(synchro));
+
+      smx_process_t src_proc = MC_smx_resolve_process(synchro.comm.src_proc);
+      smx_process_t dst_proc = MC_smx_resolve_process(synchro.comm.dst_proc);
       if (issuer->smx_host)
         label =
             bprintf("[(%lu)%s] Wait [(%lu)->(%lu)]", issuer->pid,
@@ -495,10 +562,14 @@ char *MC_request_get_dot_output(smx_simcall_t req, int value)
                     dst_proc ? dst_proc->pid : 0);
     }
     break;
+  }
 
-  case SIMCALL_COMM_TEST:
-    act = simcall_comm_test__get__comm(req);
-    if (act->comm.src_proc == NULL || act->comm.dst_proc == NULL) {
+  case SIMCALL_COMM_TEST: {
+    smx_synchro_t remote_act = simcall_comm_test__get__comm(req);
+    s_smx_synchro_t synchro;
+    MC_process_read_simple(&mc_model_checker->process, &synchro,
+      remote_act, sizeof(synchro));
+    if (synchro.comm.src_proc == NULL || synchro.comm.dst_proc == NULL) {
       if (issuer->smx_host)
         label =
             bprintf("[(%lu)%s] Test FALSE", issuer->pid,
@@ -514,18 +585,22 @@ char *MC_request_get_dot_output(smx_simcall_t req, int value)
         label = bprintf("[(%lu)] Test TRUE", issuer->pid);
     }
     break;
+  }
 
-  case SIMCALL_COMM_WAITANY:
+  case SIMCALL_COMM_WAITANY: {
+    unsigned long comms_size = MC_process_read_dynar_length(
+      &mc_model_checker->process, simcall_comm_waitany__get__comms(req));
     if (issuer->smx_host)
       label =
           bprintf("[(%lu)%s] WaitAny [%d of %lu]", issuer->pid,
                   MC_smx_process_get_host_name(issuer), value + 1,
-                  xbt_dynar_length(simcall_comm_waitany__get__comms(req)));
+                  comms_size);
     else
       label =
           bprintf("[(%lu)] WaitAny [%d of %lu]", issuer->pid, value + 1,
-                  xbt_dynar_length(simcall_comm_waitany__get__comms(req)));
+                  comms_size);
     break;
+  }
 
   case SIMCALL_COMM_TESTANY:
     if (value == -1) {
@@ -584,7 +659,7 @@ char *MC_request_get_dot_output(smx_simcall_t req, int value)
     THROW_UNIMPLEMENTED;
   }
 
-  str =
+  char* str =
       bprintf("label = \"%s\", color = %s, fontcolor = %s", label,
               colors[issuer->pid - 1], colors[issuer->pid - 1]);
   xbt_free(label);