X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/4d648ebbbe5705878080b9cbf1ca61497323c592..c5d588d76539d285fb67bef1ab477191622b94a9:/src/mc/mc_base.cpp diff --git a/src/mc/mc_base.cpp b/src/mc/mc_base.cpp index d44192625b..eaaf235c84 100644 --- a/src/mc/mc_base.cpp +++ b/src/mc/mc_base.cpp @@ -1,23 +1,23 @@ -/* Copyright (c) 2008-2019. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2008-2021. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ -#include "src/mc/mc_base.h" +#include "src/mc/mc_base.hpp" #include "mc/mc.h" -#include "simgrid/config.h" +#include "src/kernel/EngineImpl.hpp" #include "src/kernel/activity/CommImpl.hpp" #include "src/kernel/activity/MutexImpl.hpp" +#include "src/kernel/actor/SimcallObserver.hpp" #include "src/mc/mc_config.hpp" -#include "src/mc/mc_forward.hpp" #include "src/mc/mc_replay.hpp" -#include "src/simix/smx_private.hpp" -#include +#include "xbt/random.hpp" #if SIMGRID_HAVE_MC #include "src/mc/ModelChecker.hpp" -#include "src/mc/remote/RemoteClient.hpp" +#include "src/mc/Session.hpp" +#include "src/mc/remote/RemoteProcess.hpp" using simgrid::mc::remote; #endif @@ -29,30 +29,38 @@ int MC_random(int min, int max) #if SIMGRID_HAVE_MC xbt_assert(mc_model_checker == nullptr); #endif - /* TODO, if the MC is disabled we do not really need to make a simcall for this :) */ - return simcall_mc_random(min, max); + if (not MC_is_active() && not MC_record_replay_is_active()) { // no need to do a simcall in this case + static simgrid::xbt::random::XbtRandom prng; + return prng.uniform_int(min, max); + } + simgrid::kernel::actor::RandomSimcall observer{simgrid::kernel::actor::ActorImpl::self(), min, max}; + return simgrid::kernel::actor::simcall([&observer] { return observer.get_value(); }, &observer); } namespace simgrid { namespace mc { -void wait_for_requests() +void execute_actors() { + auto* engine = kernel::EngineImpl::get_instance(); #if SIMGRID_HAVE_MC xbt_assert(mc_model_checker == nullptr, "This must be called from the client"); #endif - while (not simix_global->actors_to_run.empty()) { - simix_global->run_all_actors(); - for (smx_actor_t const& process : simix_global->actors_that_ran) { - smx_simcall_t req = &process->simcall; - if (req->call != SIMCALL_NONE && not simgrid::mc::request_is_visible(req)) - SIMIX_simcall_handle(req, 0); + while (engine->has_actors_to_run()) { + engine->run_all_actors(); + for (auto const& actor : engine->get_actors_that_ran()) { + const s_smx_simcall* req = &actor->simcall_; + if (req->call_ != simix::Simcall::NONE && not simgrid::mc::request_is_visible(req)) + actor->simcall_handle(0); } } #if SIMGRID_HAVE_MC - xbt_dynar_reset(simix_global->actors_vector); - for (std::pair const& kv : simix_global->process_list) { - xbt_dynar_push_as(simix_global->actors_vector, smx_actor_t, kv.second); + engine->reset_actor_dynar(); + for (auto const& kv : engine->get_actor_list()) { + auto actor = kv.second; + if (actor->simcall_.observer_ != nullptr) + actor->simcall_.mc_max_consider_ = actor->simcall_.observer_->get_max_consider(); + engine->add_actor_to_dynar(actor); } #endif } @@ -71,24 +79,29 @@ void wait_for_requests() // Called from both MCer and MCed: bool actor_is_enabled(smx_actor_t actor) { +// #del #if SIMGRID_HAVE_MC // If in the MCer, ask the client app since it has all the data if (mc_model_checker != nullptr) { - return mc_model_checker->process().actor_is_enabled(actor->get_pid()); + return simgrid::mc::session_singleton->actor_is_enabled(actor->get_pid()); } #endif +// # // Now, we are in the client app, no need for remote memory reading. - smx_simcall_t req = &actor->simcall; + smx_simcall_t req = &actor->simcall_; + + if (req->observer_ != nullptr) + return req->observer_->is_enabled(); - switch (req->call) { - case SIMCALL_NONE: + using simix::Simcall; + switch (req->call_) { + case Simcall::NONE: return false; - case SIMCALL_COMM_WAIT: { + case Simcall::COMM_WAIT: { /* FIXME: check also that src and dst processes are not suspended */ - simgrid::kernel::activity::CommImpl* act = - static_cast(simcall_comm_wait__getraw__comm(req)); + const kernel::activity::CommImpl* act = simcall_comm_wait__getraw__comm(req); if (act->src_timeout_ || act->dst_timeout_) { /* If it has a timeout it will be always be enabled (regardless of who declared the timeout), @@ -97,47 +110,22 @@ bool actor_is_enabled(smx_actor_t actor) return true; } /* On the other hand if it hasn't a timeout, check if the comm is ready.*/ - else if (act->detached && act->src_actor_ == nullptr && - act->type_ == simgrid::kernel::activity::CommImpl::Type::READY) + else if (act->detached() && act->src_actor_ == nullptr && act->state_ == simgrid::kernel::activity::State::READY) return (act->dst_actor_ != nullptr); return (act->src_actor_ && act->dst_actor_); } - case SIMCALL_COMM_WAITANY: { + case Simcall::COMM_WAITANY: { simgrid::kernel::activity::CommImpl** comms = simcall_comm_waitany__get__comms(req); size_t count = simcall_comm_waitany__get__count(req); for (unsigned int index = 0; index < count; ++index) { - auto* comm = comms[index]; + auto const* comm = comms[index]; if (comm->src_actor_ && comm->dst_actor_) return true; } return false; } - case SIMCALL_MUTEX_LOCK: { - smx_mutex_t mutex = simcall_mutex_lock__get__mutex(req); - - if (mutex->owner_ == nullptr) - return true; - return mutex->owner_->get_pid() == req->issuer->get_pid(); - } - - case SIMCALL_SEM_ACQUIRE: { - static int warned = 0; - if (not warned) - XBT_INFO("Using semaphore in model-checked code is still experimental. Use at your own risk"); - warned = 1; - return true; - } - - case SIMCALL_COND_WAIT: { - static int warned = 0; - if (not warned) - XBT_INFO("Using condition variables in model-checked code is still experimental. Use at your own risk"); - warned = 1; - return true; - } - default: /* The rest of the requests are always enabled */ return true; @@ -147,27 +135,18 @@ bool actor_is_enabled(smx_actor_t actor) /* This is the list of requests that are visible from the checker algorithm. * Any other requests are handled right away on the application side. */ -bool request_is_visible(smx_simcall_t req) +bool request_is_visible(const s_smx_simcall* req) { #if SIMGRID_HAVE_MC xbt_assert(mc_model_checker == nullptr, "This should be called from the client side"); #endif + if (req->observer_ != nullptr) + return req->observer_->is_visible(); - return req->call == SIMCALL_COMM_ISEND || req->call == SIMCALL_COMM_IRECV || req->call == SIMCALL_COMM_WAIT || - req->call == SIMCALL_COMM_WAITANY || req->call == SIMCALL_COMM_TEST || req->call == SIMCALL_COMM_TESTANY || - req->call == SIMCALL_MC_RANDOM || req->call == SIMCALL_MUTEX_LOCK || req->call == SIMCALL_MUTEX_TRYLOCK || - req->call == SIMCALL_MUTEX_UNLOCK; + using simix::Simcall; + return req->call_ == Simcall::COMM_ISEND || req->call_ == Simcall::COMM_IRECV || req->call_ == Simcall::COMM_WAIT || + req->call_ == Simcall::COMM_WAITANY || req->call_ == Simcall::COMM_TEST || req->call_ == Simcall::COMM_TESTANY; } } } - -int simcall_HANDLER_mc_random(smx_simcall_t simcall, int min, int max) -{ - if (not MC_is_active() && MC_record_path.empty()) { - static std::default_random_engine rnd_engine; - std::uniform_int_distribution prng(min, max); - return prng(rnd_engine); - } - return simcall->mc_value; -}