X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/4d44525bee1bd3bbe44647622f9259dec37cadea..510c97d4c651c63ef9851a7e1d9c328f62b5b00b:/src/instr/instr_paje_types.cpp diff --git a/src/instr/instr_paje_types.cpp b/src/instr/instr_paje_types.cpp index 77f7ae99dc..bc9f521d88 100644 --- a/src/instr/instr_paje_types.cpp +++ b/src/instr/instr_paje_types.cpp @@ -4,6 +4,7 @@ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ +#include "simgrid/Exception.hpp" #include "src/instr/instr_private.hpp" XBT_LOG_NEW_DEFAULT_SUBCATEGORY (instr_paje_types, instr, "Paje tracing event system (types)"); @@ -19,10 +20,10 @@ Type::Type(const std::string& name, const std::string& alias, const std::string& : id_(instr_new_paje_id()), name_(name), color_(color), father_(father) { if (name_.empty() || alias.empty()) - THROWF(tracing_error, 0, "can't create a new type with no name or alias"); + throw simgrid::TracingError(XBT_THROW_POINT, "can't create a new type with no name or alias"); if (father != nullptr){ - father->children_.insert({alias, this}); + father->children_[alias].reset(this); XBT_DEBUG("new type %s, child of %s", get_cname(), father->get_cname()); } if (trace_format == simgrid::instr::TraceFormat::Paje) { @@ -30,12 +31,6 @@ Type::Type(const std::string& name, const std::string& alias, const std::string& } } -Type::~Type() -{ - for (auto elm : children_) - delete elm.second; -} - ContainerType::ContainerType(const std::string& name, Type* father) : Type(name, name, "", father) { XBT_DEBUG("ContainerType %s(%lld), child of %s(%lld)", get_cname(), get_id(), father->get_cname(), father->get_id()); @@ -165,17 +160,19 @@ void Type::log_definition(simgrid::instr::Type* source, simgrid::instr::Type* de Type* Type::by_name(const std::string& name) { Type* ret = nullptr; - for (auto elm : children_) { + for (auto const& elm : children_) { if (elm.second->name_ == name) { if (ret != nullptr) { - THROWF (tracing_error, 0, "there are two children types with the same name?"); + throw simgrid::TracingError(XBT_THROW_POINT, "there are two children types with the same name?"); } else { - ret = elm.second; + ret = elm.second.get(); } } } if (ret == nullptr) - THROWF(tracing_error, 2, "type with name (%s) not found in father type (%s)", name.c_str(), get_cname()); + throw simgrid::TracingError( + XBT_THROW_POINT, + simgrid::xbt::string_printf("type with name (%s) not found in father type (%s)", name.c_str(), get_cname())); return ret; } @@ -187,7 +184,7 @@ void ValueType::add_entity_value(const std::string& name) void ValueType::add_entity_value(const std::string& name, const std::string& color) { if (name.empty()) - THROWF(tracing_error, 0, "can't get a value with no name"); + throw simgrid::TracingError(XBT_THROW_POINT, "can't get a value with no name"); auto it = values_.find(name); if (it == values_.end()) { @@ -201,7 +198,9 @@ EntityValue* ValueType::get_entity_value(const std::string& name) { auto ret = values_.find(name); if (ret == values_.end()) { - THROWF(tracing_error, 2, "value with name (%s) not found in father type (%s)", name.c_str(), get_cname()); + throw simgrid::TracingError( + XBT_THROW_POINT, + simgrid::xbt::string_printf("value with name (%s) not found in father type (%s)", name.c_str(), get_cname())); } return &ret->second; } @@ -210,7 +209,8 @@ VariableType* Type::by_name_or_create(const std::string& name, const std::string { auto cont = children_.find(name); std::string mycolor = color.empty() ? "1 1 1" : color; - return cont == children_.end() ? new VariableType(name, mycolor, this) : static_cast(cont->second); + return cont == children_.end() ? new VariableType(name, mycolor, this) + : static_cast(cont->second.get()); } LinkType* Type::by_name_or_create(const std::string& name, Type* source, Type* dest) @@ -224,7 +224,7 @@ LinkType* Type::by_name_or_create(const std::string& name, Type* source, Type* d ret->log_definition(source, dest); return ret; } else - return static_cast(it->second); + return static_cast(it->second.get()); } } }