X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/46448320f12d59d0a5efc015ec51ec6ebba525c6..826fb7bc8e0e6270c5d57edb4ba64e3f303a86ee:/teshsuite/mc/dwarf/dwarf.cpp

diff --git a/teshsuite/mc/dwarf/dwarf.cpp b/teshsuite/mc/dwarf/dwarf.cpp
index 91693d3853..0e08c601f9 100644
--- a/teshsuite/mc/dwarf/dwarf.cpp
+++ b/teshsuite/mc/dwarf/dwarf.cpp
@@ -1,4 +1,4 @@
-/* Copyright (c) 2014-2015. The SimGrid Team.
+/* Copyright (c) 2014-2019. The SimGrid Team.
  * All rights reserved.                                                     */
 
 /* This program is free software; you can redistribute it and/or modify it
@@ -8,23 +8,27 @@
 #undef NDEBUG
 #endif
 
-#include <string.h>
-#include <assert.h>
+#include <cassert>
+#include <cstring>
 
-#include <xbt.h>
 #include <mc/mc.h>
 
 #include "mc/datatypes.h"
-#include "mc/mc_object_info.h"
-#include "mc/mc_private.h"
-
-#include "mc/Process.hpp"
-#include "mc/Type.hpp"
-#include "mc/ObjectInformation.hpp"
-#include "mc/Variable.hpp"
-
-int test_some_array[4][5][6];
-struct some_struct { int first; int second[4][5]; } test_some_struct;
+#include "src/mc/mc_private.hpp"
+
+#include "src/mc/ObjectInformation.hpp"
+#include "src/mc/Type.hpp"
+#include "src/mc/Variable.hpp"
+#include "src/mc/remote/RemoteClient.hpp"
+
+// Test broken with multi-dimensional arrays. See https://sourceware.org/bugzilla/show_bug.cgi?id=22546
+// int test_some_array[4][5][6];
+int test_some_array[4 * 5 * 6];
+struct some_struct {
+  int first;
+  int second[4][5];
+};
+some_struct test_some_struct;
 
 static simgrid::mc::Type* find_type_by_name(simgrid::mc::ObjectInformation* info, const char* name)
 {
@@ -68,35 +72,29 @@ static void test_local_variable(simgrid::mc::ObjectInformation* info, const char
   simgrid::mc::Variable* var = find_local_variable(subprogram, variable);
   assert(var);
 
-  void* frame_base = mc_find_frame_base(subprogram, info, cursor);
-  s_mc_location_t location;
-
-  mc_dwarf_resolve_locations(&location,
-    &var->location_list, info, cursor, frame_base, NULL, -1);
-
-  xbt_assert(mc_get_location_type(&location)==MC_LOCATION_TYPE_ADDRESS,
-    "Unexpected location type for variable %s of %s", variable, function);
-
-  xbt_assert(location.memory_location == address,
-    "Bad resolution of local variable %s of %s", variable, function);
+  void* frame_base = subprogram->frame_base(*cursor);
+  simgrid::dwarf::Location location = simgrid::dwarf::resolve(
+    var->location_list, info, cursor, frame_base, nullptr, -1);
 
+  xbt_assert(location.in_memory(), "Expected the variable %s of function %s to be in memory", variable, function);
+  xbt_assert(location.address() == address, "Bad resolution of local variable %s of %s", variable, function);
 }
 
-static simgrid::mc::Variable* test_global_variable(simgrid::mc::Process* process, simgrid::mc::ObjectInformation* info, const char* name, void* address, long byte_size) {
-
+static simgrid::mc::Variable* test_global_variable(simgrid::mc::RemoteClient& process,
+                                                   simgrid::mc::ObjectInformation* info, const char* name,
+                                                   void* address, long byte_size)
+{
   simgrid::mc::Variable* variable = info->find_variable(name);
   xbt_assert(variable, "Global variable %s was not found", name);
-  xbt_assert(variable->name == name,
-    "Name mismatch for %s", name);
+  xbt_assert(variable->name == name, "Name mismatch for %s", name);
   xbt_assert(variable->global, "Variable %s is not global", name);
-  xbt_assert(variable->address == address,
-      "Address mismatch for %s : %p expected but %p found",
-      name, address, variable->address);
+  xbt_assert(variable->address == address, "Address mismatch for %s : %p expected but %p found", name, address,
+             variable->address);
 
-  auto i = process->binary_info->types.find(variable->type_id);
-  xbt_assert(i != process->binary_info->types.end(), "Missing type for %s", name);
+  auto i = process.binary_info->types.find(variable->type_id);
+  xbt_assert(i != process.binary_info->types.end(), "Missing type for %s", name);
   simgrid::mc::Type* type = &i->second;
-  xbt_assert(type->byte_size = byte_size, "Byte size mismatch for %s", name);
+  xbt_assert(type->byte_size == byte_size, "Byte size mismatch for %s", name);
   return variable;
 }
 
@@ -110,13 +108,13 @@ static simgrid::mc::Member* find_member(simgrid::mc::Type& type, const char* nam
 
 int some_local_variable = 0;
 
-typedef struct foo {int i;} s_foo;
+struct s_foo {
+  int i;
+};
 
-static void test_type_by_name(simgrid::mc::Process* process, s_foo my_foo)
+static void test_type_by_name(simgrid::mc::RemoteClient& process, s_foo /*my_foo*/)
 {
-  assert(
-    process->binary_info->full_types_by_name.find("struct foo") !=
-      process->binary_info->full_types_by_name.end());
+  assert(process.binary_info->full_types_by_name.find("struct s_foo") != process.binary_info->full_types_by_name.end());
 }
 
 int main(int argc, char** argv)
@@ -126,46 +124,41 @@ int main(int argc, char** argv)
   simgrid::mc::Variable* var;
   simgrid::mc::Type* type;
 
-  simgrid::mc::Process p(getpid(), -1);
-  simgrid::mc::Process* process = &p;
+  simgrid::mc::RemoteClient process(getpid(), -1);
+  process.init();
 
-  test_global_variable(process, process->binary_info.get(),
-    "some_local_variable", &some_local_variable, sizeof(int));
+  test_global_variable(process, process.binary_info.get(), "some_local_variable", &some_local_variable, sizeof(int));
 
-  var = test_global_variable(process, process->binary_info.get(),
-    "test_some_array", &test_some_array, sizeof(test_some_array));
-  auto i = process->binary_info->types.find(var->type_id);
-  xbt_assert(i != process->binary_info->types.end(), "Missing type");
+  var = test_global_variable(process, process.binary_info.get(), "test_some_array", &test_some_array,
+                             sizeof(test_some_array));
+  auto i = process.binary_info->types.find(var->type_id);
+  xbt_assert(i != process.binary_info->types.end(), "Missing type");
   type = &i->second;
-  xbt_assert(type->element_count == 6*5*4,
-    "element_count mismatch in test_some_array : %i / %i",
-    type->element_count, 6*5*4);
-
-  var = test_global_variable(process, process->binary_info.get(),
-    "test_some_struct", &test_some_struct, sizeof(test_some_struct));
-  i = process->binary_info->types.find(var->type_id);
-  xbt_assert(i != process->binary_info->types.end(), "Missing type");
+  xbt_assert(type->element_count == 6 * 5 * 4, "element_count mismatch in test_some_array : %i / %i",
+             type->element_count, 6 * 5 * 4);
+
+  var = test_global_variable(process, process.binary_info.get(), "test_some_struct", &test_some_struct,
+                             sizeof(test_some_struct));
+  i = process.binary_info->types.find(var->type_id);
+  xbt_assert(i != process.binary_info->types.end(), "Missing type");
   type = &i->second;
 
   assert(type);
   assert(find_member(*type, "first")->offset() == 0);
-  assert(find_member(*type, "second")->offset()
-      == ((const char*)&test_some_struct.second) - (const char*)&test_some_struct);
+  assert(find_member(*type, "second")->offset() ==
+         ((const char*)&test_some_struct.second) - (const char*)&test_some_struct);
 
   unw_context_t context;
   unw_cursor_t cursor;
   unw_getcontext(&context);
   unw_init_local(&cursor, &context);
 
-  test_local_variable(process->binary_info.get(), "main", "argc", &argc, &cursor);
+  test_local_variable(process.binary_info.get(), "main", "argc", &argc, &cursor);
 
-  {
-    int lexical_block_variable = 50;
-    test_local_variable(process->binary_info.get(), "main",
-      "lexical_block_variable", &lexical_block_variable, &cursor);
-  }
+  int lexical_block_variable = 50;
+  test_local_variable(process.binary_info.get(), "main", "lexical_block_variable", &lexical_block_variable, &cursor);
 
-  s_foo my_foo;
+  s_foo my_foo = {0};
   test_type_by_name(process, my_foo);
 
   _exit(0);