X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/3a8a55f46d501ddbfcdd245206059a336e09448c..57e7dcd49d4873f73dc0337e4f172bd169f77a44:/src/smpi/smpi_base.c

diff --git a/src/smpi/smpi_base.c b/src/smpi/smpi_base.c
index aeed260a91..acf0aac0df 100644
--- a/src/smpi/smpi_base.c
+++ b/src/smpi/smpi_base.c
@@ -19,10 +19,8 @@ XBT_LOG_EXTERNAL_CATEGORY(smpi_receiver);
 XBT_LOG_EXTERNAL_CATEGORY(smpi_sender);
 XBT_LOG_EXTERNAL_CATEGORY(smpi_util);
 
-#define EAGER_LIMIT 65536
-#define RDV_TAG     (-10)
-
-void smpi_process_init(int* argc, char*** argv) {
+void smpi_process_init(int *argc, char ***argv)
+{
   int index;
   smpi_process_data_t data;
   smx_process_t proc;
@@ -40,13 +38,17 @@ void smpi_process_init(int* argc, char*** argv) {
   DEBUG2("<%d> New process in the game: %p", index, proc);
 }
 
-void smpi_process_destroy(void) {
+void smpi_process_destroy(void)
+{
   int index = smpi_process_index();
 
   DEBUG1("<%d> Process left the game", index);
 }
 
-static MPI_Request build_request(void* buf, int count, MPI_Datatype datatype, int src, int dst, int tag, MPI_Comm comm, unsigned flags) {
+static MPI_Request build_request(void *buf, int count,
+                                 MPI_Datatype datatype, int src, int dst,
+                                 int tag, MPI_Comm comm, unsigned flags)
+{
   MPI_Request request;
 
   request = xbt_new(s_smpi_mpi_request_t, 1);
@@ -61,137 +63,167 @@ static MPI_Request build_request(void* buf, int count, MPI_Datatype datatype, in
   request->complete = 0;
   request->match = MPI_REQUEST_NULL;
   request->flags = flags;
-  if(request->size <= EAGER_LIMIT) {
-    request->ack = MPI_REQUEST_NULL;
-  } else {
-    request->ack = xbt_new(s_smpi_mpi_request_t, 1);
-    request->ack->buf = NULL;
-    request->ack->size = 0;
-    request->ack->src = dst;
-    request->ack->dst = src;
-    request->ack->tag = RDV_TAG;
-    request->ack->comm = comm;
-    request->ack->rdv = NULL;
-    request->ack->pair = NULL;
-    request->ack->complete = 0;
-    request->ack->match = MPI_REQUEST_NULL;
-    request->ack->flags = NON_PERSISTENT | ((request->flags & RECV) == RECV ? SEND : RECV);
-    smpi_mpi_start(request->ack);
-  }
+#ifdef HAVE_TRACING
+  request->send = 0;
+  request->recv = 0;
+#endif
   return request;
 }
 
 /* MPI Low level calls */
-MPI_Request smpi_mpi_send_init(void* buf, int count, MPI_Datatype datatype, int dst, int tag, MPI_Comm comm) {
-  MPI_Request request = build_request(buf, count, datatype, smpi_comm_rank(comm), dst, tag, comm, PERSISTENT | SEND);
+MPI_Request smpi_mpi_send_init(void *buf, int count, MPI_Datatype datatype,
+                               int dst, int tag, MPI_Comm comm)
+{
+  MPI_Request request =
+      build_request(buf, count, datatype, smpi_comm_rank(comm), dst, tag,
+                    comm, PERSISTENT | SEND);
 
   return request;
 }
 
-MPI_Request smpi_mpi_recv_init(void* buf, int count, MPI_Datatype datatype, int src, int tag, MPI_Comm comm) {
-  MPI_Request request = build_request(buf, count, datatype, src, smpi_comm_rank(comm), tag, comm, PERSISTENT | RECV);
+MPI_Request smpi_mpi_recv_init(void *buf, int count, MPI_Datatype datatype,
+                               int src, int tag, MPI_Comm comm)
+{
+  MPI_Request request =
+      build_request(buf, count, datatype, src, smpi_comm_rank(comm), tag,
+                    comm, PERSISTENT | RECV);
 
   return request;
 }
 
-void smpi_mpi_start(MPI_Request request) {
-  xbt_assert0(request->complete == 0, "Cannot start a non-finished communication");
-  if(request->size > EAGER_LIMIT) {
-    print_request("RDV ack", request->ack);
-    smpi_mpi_wait(&request->ack, MPI_STATUS_IGNORE);
-  }
-  if((request->flags & RECV) == RECV) {
+void smpi_mpi_start(MPI_Request request)
+{
+  xbt_assert0(request->complete == 0,
+              "Cannot start a non-finished communication");
+  if ((request->flags & RECV) == RECV) {
     smpi_process_post_recv(request);
     print_request("New recv", request);
-    request->pair = SIMIX_network_irecv(request->rdv, request->buf, &request->size);
+    request->pair =
+        SIMIX_network_irecv(request->rdv, request->buf, &request->size);
   } else {
-    smpi_process_post_send(request->comm, request); // FIXME
+    smpi_process_post_send(request->comm, request);     // FIXME
     print_request("New send", request);
-    request->pair = SIMIX_network_isend(request->rdv, request->size, -1.0, request->buf, request->size, NULL);
+    request->pair =
+        SIMIX_network_isend(request->rdv, request->size, -1.0,
+                            request->buf, request->size, NULL);
   }
 }
 
-void smpi_mpi_startall(int count, MPI_Request* requests) {
+void smpi_mpi_startall(int count, MPI_Request * requests)
+{
   int i;
 
-  for(i = 0; i < count; i++) {
+  for (i = 0; i < count; i++) {
     smpi_mpi_start(requests[i]);
   }
 }
 
-void smpi_mpi_request_free(MPI_Request* request) {
+void smpi_mpi_request_free(MPI_Request * request)
+{
   xbt_free(*request);
   *request = MPI_REQUEST_NULL;
 }
 
-MPI_Request smpi_isend_init(void* buf, int count, MPI_Datatype datatype, int dst, int tag, MPI_Comm comm) {
-  MPI_Request request = build_request(buf, count, datatype, smpi_comm_rank(comm), dst, tag, comm, NON_PERSISTENT | SEND);
+MPI_Request smpi_isend_init(void *buf, int count, MPI_Datatype datatype,
+                            int dst, int tag, MPI_Comm comm)
+{
+  MPI_Request request =
+      build_request(buf, count, datatype, smpi_comm_rank(comm), dst, tag,
+                    comm, NON_PERSISTENT | SEND);
 
   return request;
 }
 
-MPI_Request smpi_mpi_isend(void* buf, int count, MPI_Datatype datatype, int dst, int tag, MPI_Comm comm) {
-  MPI_Request request = smpi_isend_init(buf, count, datatype, dst, tag, comm);
+MPI_Request smpi_mpi_isend(void *buf, int count, MPI_Datatype datatype,
+                           int dst, int tag, MPI_Comm comm)
+{
+  MPI_Request request =
+      smpi_isend_init(buf, count, datatype, dst, tag, comm);
 
   smpi_mpi_start(request);
   return request;
 }
 
-MPI_Request smpi_irecv_init(void* buf, int count, MPI_Datatype datatype, int src, int tag, MPI_Comm comm) {
-  MPI_Request request = build_request(buf, count, datatype, src, smpi_comm_rank(comm), tag, comm, NON_PERSISTENT | RECV);
+MPI_Request smpi_irecv_init(void *buf, int count, MPI_Datatype datatype,
+                            int src, int tag, MPI_Comm comm)
+{
+  MPI_Request request =
+      build_request(buf, count, datatype, src, smpi_comm_rank(comm), tag,
+                    comm, NON_PERSISTENT | RECV);
 
   return request;
 }
 
-MPI_Request smpi_mpi_irecv(void* buf, int count, MPI_Datatype datatype, int src, int tag, MPI_Comm comm) {
-  MPI_Request request = smpi_irecv_init(buf, count, datatype, src, tag, comm);
+MPI_Request smpi_mpi_irecv(void *buf, int count, MPI_Datatype datatype,
+                           int src, int tag, MPI_Comm comm)
+{
+  MPI_Request request =
+      smpi_irecv_init(buf, count, datatype, src, tag, comm);
 
   smpi_mpi_start(request);
   return request;
 }
 
-void smpi_mpi_recv(void* buf, int count, MPI_Datatype datatype, int src, int tag, MPI_Comm comm, MPI_Status* status) {
+void smpi_mpi_recv(void *buf, int count, MPI_Datatype datatype, int src,
+                   int tag, MPI_Comm comm, MPI_Status * status)
+{
   MPI_Request request;
 
   request = smpi_mpi_irecv(buf, count, datatype, src, tag, comm);
   smpi_mpi_wait(&request, status);
 }
 
-void smpi_mpi_send(void* buf, int count, MPI_Datatype datatype, int dst, int tag, MPI_Comm comm) {
+void smpi_mpi_send(void *buf, int count, MPI_Datatype datatype, int dst,
+                   int tag, MPI_Comm comm)
+{
   MPI_Request request;
 
   request = smpi_mpi_isend(buf, count, datatype, dst, tag, comm);
   smpi_mpi_wait(&request, MPI_STATUS_IGNORE);
 }
 
-void smpi_mpi_sendrecv(void* sendbuf, int sendcount, MPI_Datatype sendtype, int dst, int sendtag, void* recvbuf, int recvcount, MPI_Datatype recvtype, int src, int recvtag, MPI_Comm comm, MPI_Status* status) {
+void smpi_mpi_sendrecv(void *sendbuf, int sendcount, MPI_Datatype sendtype,
+                       int dst, int sendtag, void *recvbuf, int recvcount,
+                       MPI_Datatype recvtype, int src, int recvtag,
+                       MPI_Comm comm, MPI_Status * status)
+{
   MPI_Request requests[2];
   MPI_Status stats[2];
 
-  requests[0] = smpi_isend_init(sendbuf, sendcount, sendtype, dst, sendtag, comm);
-  requests[1] = smpi_irecv_init(recvbuf, recvcount, recvtype, src, recvtag, comm);
+  requests[0] =
+      smpi_isend_init(sendbuf, sendcount, sendtype, dst, sendtag, comm);
+  requests[1] =
+      smpi_irecv_init(recvbuf, recvcount, recvtype, src, recvtag, comm);
   smpi_mpi_startall(2, requests);
   smpi_mpi_waitall(2, requests, stats);
-  if(status != MPI_STATUS_IGNORE) {
+  if (status != MPI_STATUS_IGNORE) {
     // Copy receive status
     memcpy(status, &stats[1], sizeof(MPI_Status));
   }
 }
 
-static void finish_wait(MPI_Request* request, MPI_Status* status) {
-  if(status != MPI_STATUS_IGNORE) {
+int smpi_mpi_get_count(MPI_Status * status, MPI_Datatype datatype)
+{
+  return status->count / smpi_datatype_size(datatype);
+}
+
+static void finish_wait(MPI_Request * request, MPI_Status * status)
+{
+  if (status != MPI_STATUS_IGNORE) {
     status->MPI_SOURCE = (*request)->src;
     status->MPI_TAG = (*request)->tag;
     status->MPI_ERROR = MPI_SUCCESS;
+    status->count = SIMIX_communication_get_dst_buf_size((*request)->pair);
   }
+  SIMIX_communication_destroy((*request)->pair);
   print_request("finishing wait", *request);
-  if((*request)->complete == 1) {
+  if ((*request)->complete == 1) {
     SIMIX_rdv_destroy((*request)->rdv);
   } else {
     (*request)->match->complete = 1;
     (*request)->match->match = MPI_REQUEST_NULL;
   }
-  if(((*request)->flags & NON_PERSISTENT) == NON_PERSISTENT) {
+  if (((*request)->flags & NON_PERSISTENT) == NON_PERSISTENT) {
     smpi_mpi_request_free(request);
   } else {
     (*request)->rdv = NULL;
@@ -199,25 +231,26 @@ static void finish_wait(MPI_Request* request, MPI_Status* status) {
   }
 }
 
-int smpi_mpi_test(MPI_Request* request, MPI_Status* status) {
+int smpi_mpi_test(MPI_Request * request, MPI_Status * status)
+{
   int flag = (*request)->complete;
 
-  if(flag) {
-    SIMIX_communication_destroy((*request)->pair);
-    finish_wait(request, status);
+  if (flag) {
+    smpi_mpi_wait(request, status);
   }
   return flag;
 }
 
-int smpi_mpi_testany(int count, MPI_Request requests[], int* index, MPI_Status* status) {
+int smpi_mpi_testany(int count, MPI_Request requests[], int *index,
+                     MPI_Status * status)
+{
   int i, flag;
 
   *index = MPI_UNDEFINED;
   flag = 0;
-  for(i = 0; i < count; i++) {
-    if(requests[i] != MPI_REQUEST_NULL && requests[i]->complete) {
-      SIMIX_communication_destroy(requests[i]->pair);
-      finish_wait(&requests[i], status);
+  for (i = 0; i < count; i++) {
+    if (requests[i] != MPI_REQUEST_NULL && requests[i]->complete) {
+      smpi_mpi_wait(&requests[i], status);
       *index = i;
       flag = 1;
       break;
@@ -226,70 +259,68 @@ int smpi_mpi_testany(int count, MPI_Request requests[], int* index, MPI_Status*
   return flag;
 }
 
-void smpi_mpi_wait(MPI_Request* request, MPI_Status* status) {
+void smpi_mpi_wait(MPI_Request * request, MPI_Status * status)
+{
   print_request("wait", *request);
-  // data is null if receiver waits before sender enters the rdv
-  if((*request)->complete) {
-    SIMIX_communication_destroy((*request)->pair);
-  } else {
-    SIMIX_network_wait((*request)->pair, -1.0);
-  }
+  SIMIX_network_wait((*request)->pair, -1.0);
   finish_wait(request, status);
 }
 
-int smpi_mpi_waitany(int count, MPI_Request requests[], MPI_Status* status) {
+int smpi_mpi_waitany(int count, MPI_Request requests[],
+                     MPI_Status * status)
+{
   xbt_dynar_t comms;
   int i, size, index;
-  int* map;
+  int *map;
 
   index = MPI_UNDEFINED;
-  if(count > 0) {
+  if (count > 0) {
     // First check for already completed requests
-    for(i = 0; i < count; i++) {
-      if(requests[i] != MPI_REQUEST_NULL && requests[i]->complete) {
+    for (i = 0; i < count; i++) {
+      if (requests[i] != MPI_REQUEST_NULL && requests[i]->complete) {
         index = i;
-        SIMIX_communication_destroy(requests[index]->pair); // always succeeds (but cleans the simix layer)
+        smpi_mpi_wait(&requests[index], status);
         break;
       }
     }
-    if(index == MPI_UNDEFINED) {
+    if (index == MPI_UNDEFINED) {
       // Otherwise, wait for a request to complete
       comms = xbt_dynar_new(sizeof(smx_comm_t), NULL);
       map = xbt_new(int, count);
       size = 0;
       DEBUG0("Wait for one of");
-      for(i = 0; i < count; i++) {
-        if(requests[i] != MPI_REQUEST_NULL && requests[i]->complete == 0) {
+      for (i = 0; i < count; i++) {
+        if (requests[i] != MPI_REQUEST_NULL && requests[i]->complete == 0) {
           print_request("   ", requests[i]);
           xbt_dynar_push(comms, &requests[i]->pair);
           map[size] = i;
           size++;
         }
       }
-      if(size > 0) {
+      if (size > 0) {
         index = SIMIX_network_waitany(comms);
         index = map[index];
+        finish_wait(&requests[index], status);
       }
       xbt_free(map);
       xbt_dynar_free(&comms);
     }
-    if(index != MPI_UNDEFINED) {
-      finish_wait(&requests[index], status);
-    }
   }
   return index;
 }
 
-void smpi_mpi_waitall(int count, MPI_Request requests[],  MPI_Status status[]) {
+void smpi_mpi_waitall(int count, MPI_Request requests[],
+                      MPI_Status status[])
+{
   int index;
   MPI_Status stat;
 
-  while(count > 0) {
+  while (count > 0) {
     index = smpi_mpi_waitany(count, requests, &stat);
-    if(index == MPI_UNDEFINED) {
+    if (index == MPI_UNDEFINED) {
       break;
     }
-    if(status != MPI_STATUS_IGNORE) {
+    if (status != MPI_STATUS_IGNORE) {
       memcpy(&status[index], &stat, sizeof(stat));
     }
     // FIXME: check this -v
@@ -300,14 +331,17 @@ void smpi_mpi_waitall(int count, MPI_Request requests[],  MPI_Status status[]) {
   }
 }
 
-int smpi_mpi_waitsome(int incount, MPI_Request requests[], int* indices, MPI_Status status[]) {
+int smpi_mpi_waitsome(int incount, MPI_Request requests[], int *indices,
+                      MPI_Status status[])
+{
   int i, count;
 
   count = 0;
-  for(i = 0; i < incount; i++) {
-    if(requests[i] != MPI_REQUEST_NULL && requests[i]->complete) {
-      SIMIX_communication_destroy(requests[i]->pair);
-      finish_wait(&requests[i], status != MPI_STATUS_IGNORE ? &status[i] : MPI_STATUS_IGNORE);
+  for (i = 0; i < incount; i++) {
+    if (requests[i] != MPI_REQUEST_NULL && requests[i]->complete) {
+      smpi_mpi_wait(&requests[i],
+                    status !=
+                    MPI_STATUS_IGNORE ? &status[i] : MPI_STATUS_IGNORE);
       indices[count] = i;
       count++;
     }
@@ -315,37 +349,47 @@ int smpi_mpi_waitsome(int incount, MPI_Request requests[], int* indices, MPI_Sta
   return count;
 }
 
-void smpi_mpi_bcast(void* buf, int count, MPI_Datatype datatype, int root, MPI_Comm comm) {
+void smpi_mpi_bcast(void *buf, int count, MPI_Datatype datatype, int root,
+                    MPI_Comm comm)
+{
   // arity=2: a binary tree, arity=4 seem to be a good setting (see P2P-MPI))
   nary_tree_bcast(buf, count, datatype, root, comm, 4);
 }
 
-void smpi_mpi_barrier(MPI_Comm comm) {
+void smpi_mpi_barrier(MPI_Comm comm)
+{
   // arity=2: a binary tree, arity=4 seem to be a good setting (see P2P-MPI))
   nary_tree_barrier(comm, 4);
 }
 
-void smpi_mpi_gather(void* sendbuf, int sendcount, MPI_Datatype sendtype, void* recvbuf, int recvcount, MPI_Datatype recvtype, int root, MPI_Comm comm) {
+void smpi_mpi_gather(void *sendbuf, int sendcount, MPI_Datatype sendtype,
+                     void *recvbuf, int recvcount, MPI_Datatype recvtype,
+                     int root, MPI_Comm comm)
+{
   int system_tag = 666;
   int rank, size, src, index, sendsize, recvsize;
-  MPI_Request* requests;
+  MPI_Request *requests;
 
   rank = smpi_comm_rank(comm);
   size = smpi_comm_size(comm);
-  if(rank != root) {
+  if (rank != root) {
     // Send buffer to root
     smpi_mpi_send(sendbuf, sendcount, sendtype, root, system_tag, comm);
   } else {
     sendsize = smpi_datatype_size(sendtype);
     recvsize = smpi_datatype_size(recvtype);
     // Local copy from root
-    memcpy(&((char*)recvbuf)[root * recvcount * recvsize], sendbuf, sendcount * sendsize * sizeof(char));
+    memcpy(&((char *) recvbuf)[root * recvcount * recvsize], sendbuf,
+           sendcount * sendsize * sizeof(char));
     // Receive buffers from senders
     requests = xbt_new(MPI_Request, size - 1);
     index = 0;
-    for(src = 0; src < size; src++) {
-      if(src != root) {
-        requests[index] = smpi_irecv_init(&((char*)recvbuf)[src * recvcount * recvsize], recvcount, recvtype, src, system_tag, comm);
+    for (src = 0; src < size; src++) {
+      if (src != root) {
+        requests[index] = smpi_irecv_init(&((char *) recvbuf)
+                                          [src * recvcount * recvsize],
+                                          recvcount, recvtype, src,
+                                          system_tag, comm);
         index++;
       }
     }
@@ -356,26 +400,33 @@ void smpi_mpi_gather(void* sendbuf, int sendcount, MPI_Datatype sendtype, void*
   }
 }
 
-void smpi_mpi_gatherv(void* sendbuf, int sendcount, MPI_Datatype sendtype, void* recvbuf, int* recvcounts, int* displs, MPI_Datatype recvtype, int root, MPI_Comm comm) {
+void smpi_mpi_gatherv(void *sendbuf, int sendcount, MPI_Datatype sendtype,
+                      void *recvbuf, int *recvcounts, int *displs,
+                      MPI_Datatype recvtype, int root, MPI_Comm comm)
+{
   int system_tag = 666;
   int rank, size, src, index, sendsize;
-  MPI_Request* requests;
+  MPI_Request *requests;
 
   rank = smpi_comm_rank(comm);
   size = smpi_comm_size(comm);
-  if(rank != root) {
+  if (rank != root) {
     // Send buffer to root
     smpi_mpi_send(sendbuf, sendcount, sendtype, root, system_tag, comm);
   } else {
     sendsize = smpi_datatype_size(sendtype);
     // Local copy from root
-    memcpy(&((char*)recvbuf)[displs[root]], sendbuf, sendcount * sendsize * sizeof(char));
+    memcpy(&((char *) recvbuf)[displs[root]], sendbuf,
+           sendcount * sendsize * sizeof(char));
     // Receive buffers from senders
     requests = xbt_new(MPI_Request, size - 1);
     index = 0;
-    for(src = 0; src < size; src++) {
-      if(src != root) {
-        requests[index] = smpi_irecv_init(&((char*)recvbuf)[displs[src]], recvcounts[src], recvtype, src, system_tag, comm);
+    for (src = 0; src < size; src++) {
+      if (src != root) {
+        requests[index] =
+            smpi_irecv_init(&((char *) recvbuf)[displs[src]],
+                            recvcounts[src], recvtype, src, system_tag,
+                            comm);
         index++;
       }
     }
@@ -386,25 +437,35 @@ void smpi_mpi_gatherv(void* sendbuf, int sendcount, MPI_Datatype sendtype, void*
   }
 }
 
-void smpi_mpi_allgather(void* sendbuf, int sendcount, MPI_Datatype sendtype, void* recvbuf, int recvcount, MPI_Datatype recvtype, MPI_Comm comm) {
+void smpi_mpi_allgather(void *sendbuf, int sendcount,
+                        MPI_Datatype sendtype, void *recvbuf,
+                        int recvcount, MPI_Datatype recvtype,
+                        MPI_Comm comm)
+{
   int system_tag = 666;
   int rank, size, other, index, sendsize, recvsize;
-  MPI_Request* requests;
+  MPI_Request *requests;
 
   rank = smpi_comm_rank(comm);
   size = smpi_comm_size(comm);
   sendsize = smpi_datatype_size(sendtype);
   recvsize = smpi_datatype_size(recvtype);
   // Local copy from self
-  memcpy(&((char*)recvbuf)[rank * recvcount * recvsize], sendbuf, sendcount * sendsize * sizeof(char));
+  memcpy(&((char *) recvbuf)[rank * recvcount * recvsize], sendbuf,
+         sendcount * sendsize * sizeof(char));
   // Send/Recv buffers to/from others;
   requests = xbt_new(MPI_Request, 2 * (size - 1));
   index = 0;
-  for(other = 0; other < size; other++) {
-    if(other != rank) {
-      requests[index] = smpi_isend_init(sendbuf, sendcount, sendtype, other, system_tag, comm);
+  for (other = 0; other < size; other++) {
+    if (other != rank) {
+      requests[index] =
+          smpi_isend_init(sendbuf, sendcount, sendtype, other, system_tag,
+                          comm);
       index++;
-      requests[index] = smpi_irecv_init(&((char*)recvbuf)[other * recvcount * recvsize], recvcount, recvtype, other, system_tag, comm);
+      requests[index] = smpi_irecv_init(&((char *) recvbuf)
+                                        [other * recvcount * recvsize],
+                                        recvcount, recvtype, other,
+                                        system_tag, comm);
       index++;
     }
   }
@@ -414,25 +475,35 @@ void smpi_mpi_allgather(void* sendbuf, int sendcount, MPI_Datatype sendtype, voi
   xbt_free(requests);
 }
 
-void smpi_mpi_allgatherv(void* sendbuf, int sendcount, MPI_Datatype sendtype, void* recvbuf, int* recvcounts, int* displs, MPI_Datatype recvtype, MPI_Comm comm) {
+void smpi_mpi_allgatherv(void *sendbuf, int sendcount,
+                         MPI_Datatype sendtype, void *recvbuf,
+                         int *recvcounts, int *displs,
+                         MPI_Datatype recvtype, MPI_Comm comm)
+{
   int system_tag = 666;
   int rank, size, other, index, sendsize, recvsize;
-  MPI_Request* requests;
+  MPI_Request *requests;
 
   rank = smpi_comm_rank(comm);
   size = smpi_comm_size(comm);
   sendsize = smpi_datatype_size(sendtype);
   recvsize = smpi_datatype_size(recvtype);
   // Local copy from self
-  memcpy(&((char*)recvbuf)[displs[rank]], sendbuf, sendcount * sendsize * sizeof(char));
+  memcpy(&((char *) recvbuf)[displs[rank]], sendbuf,
+         sendcount * sendsize * sizeof(char));
   // Send buffers to others;
   requests = xbt_new(MPI_Request, 2 * (size - 1));
   index = 0;
-  for(other = 0; other < size; other++) {
-    if(other != rank) {
-      requests[index] = smpi_isend_init(sendbuf, sendcount, sendtype, other, system_tag, comm);
+  for (other = 0; other < size; other++) {
+    if (other != rank) {
+      requests[index] =
+          smpi_isend_init(sendbuf, sendcount, sendtype, other, system_tag,
+                          comm);
       index++;
-      requests[index] = smpi_irecv_init(&((char*)recvbuf)[displs[other]], recvcounts[other], recvtype, other, system_tag, comm);
+      requests[index] =
+          smpi_irecv_init(&((char *) recvbuf)[displs[other]],
+                          recvcounts[other], recvtype, other, system_tag,
+                          comm);
       index++;
     }
   }
@@ -442,27 +513,35 @@ void smpi_mpi_allgatherv(void* sendbuf, int sendcount, MPI_Datatype sendtype, vo
   xbt_free(requests);
 }
 
-void smpi_mpi_scatter(void* sendbuf, int sendcount, MPI_Datatype sendtype, void* recvbuf, int recvcount, MPI_Datatype recvtype, int root, MPI_Comm comm) {
+void smpi_mpi_scatter(void *sendbuf, int sendcount, MPI_Datatype sendtype,
+                      void *recvbuf, int recvcount, MPI_Datatype recvtype,
+                      int root, MPI_Comm comm)
+{
   int system_tag = 666;
   int rank, size, dst, index, sendsize, recvsize;
-  MPI_Request* requests;
+  MPI_Request *requests;
 
   rank = smpi_comm_rank(comm);
   size = smpi_comm_size(comm);
-  if(rank != root) {
+  if (rank != root) {
     // Recv buffer from root
-    smpi_mpi_recv(recvbuf, recvcount, recvtype, root, system_tag, comm, MPI_STATUS_IGNORE);
+    smpi_mpi_recv(recvbuf, recvcount, recvtype, root, system_tag, comm,
+                  MPI_STATUS_IGNORE);
   } else {
     sendsize = smpi_datatype_size(sendtype);
     recvsize = smpi_datatype_size(recvtype);
     // Local copy from root
-    memcpy(recvbuf, &((char*)sendbuf)[root * sendcount * sendsize], recvcount * recvsize * sizeof(char));
+    memcpy(recvbuf, &((char *) sendbuf)[root * sendcount * sendsize],
+           recvcount * recvsize * sizeof(char));
     // Send buffers to receivers
     requests = xbt_new(MPI_Request, size - 1);
     index = 0;
-    for(dst = 0; dst < size; dst++) {
-      if(dst != root) {
-        requests[index] = smpi_isend_init(&((char*)sendbuf)[dst * sendcount * sendsize], sendcount, sendtype, dst, system_tag, comm);
+    for (dst = 0; dst < size; dst++) {
+      if (dst != root) {
+        requests[index] = smpi_isend_init(&((char *) sendbuf)
+                                          [dst * sendcount * sendsize],
+                                          sendcount, sendtype, dst,
+                                          system_tag, comm);
         index++;
       }
     }
@@ -473,27 +552,35 @@ void smpi_mpi_scatter(void* sendbuf, int sendcount, MPI_Datatype sendtype, void*
   }
 }
 
-void smpi_mpi_scatterv(void* sendbuf, int* sendcounts, int* displs, MPI_Datatype sendtype, void* recvbuf, int recvcount, MPI_Datatype recvtype, int root, MPI_Comm comm) {
+void smpi_mpi_scatterv(void *sendbuf, int *sendcounts, int *displs,
+                       MPI_Datatype sendtype, void *recvbuf, int recvcount,
+                       MPI_Datatype recvtype, int root, MPI_Comm comm)
+{
   int system_tag = 666;
   int rank, size, dst, index, sendsize, recvsize;
-  MPI_Request* requests;
+  MPI_Request *requests;
 
   rank = smpi_comm_rank(comm);
   size = smpi_comm_size(comm);
-  if(rank != root) {
+  if (rank != root) {
     // Recv buffer from root
-    smpi_mpi_recv(recvbuf, recvcount, recvtype, root, system_tag, comm, MPI_STATUS_IGNORE);
+    smpi_mpi_recv(recvbuf, recvcount, recvtype, root, system_tag, comm,
+                  MPI_STATUS_IGNORE);
   } else {
     sendsize = smpi_datatype_size(sendtype);
     recvsize = smpi_datatype_size(recvtype);
     // Local copy from root
-    memcpy(recvbuf, &((char*)sendbuf)[displs[root]], recvcount * recvsize * sizeof(char));
+    memcpy(recvbuf, &((char *) sendbuf)[displs[root]],
+           recvcount * recvsize * sizeof(char));
     // Send buffers to receivers
     requests = xbt_new(MPI_Request, size - 1);
     index = 0;
-    for(dst = 0; dst < size; dst++) {
-      if(dst != root) {
-        requests[index] = smpi_isend_init(&((char*)sendbuf)[displs[dst]], sendcounts[dst], sendtype, dst, system_tag, comm);
+    for (dst = 0; dst < size; dst++) {
+      if (dst != root) {
+        requests[index] =
+            smpi_isend_init(&((char *) sendbuf)[displs[dst]],
+                            sendcounts[dst], sendtype, dst, system_tag,
+                            comm);
         index++;
       }
     }
@@ -504,15 +591,18 @@ void smpi_mpi_scatterv(void* sendbuf, int* sendcounts, int* displs, MPI_Datatype
   }
 }
 
-void smpi_mpi_reduce(void* sendbuf, void* recvbuf, int count, MPI_Datatype datatype, MPI_Op op, int root, MPI_Comm comm) {
+void smpi_mpi_reduce(void *sendbuf, void *recvbuf, int count,
+                     MPI_Datatype datatype, MPI_Op op, int root,
+                     MPI_Comm comm)
+{
   int system_tag = 666;
   int rank, size, src, index, datasize;
-  MPI_Request* requests;
-  void** tmpbufs;
+  MPI_Request *requests;
+  void **tmpbufs;
 
   rank = smpi_comm_rank(comm);
   size = smpi_comm_size(comm);
-  if(rank != root) {
+  if (rank != root) {
     // Send buffer to root
     smpi_mpi_send(sendbuf, count, datatype, root, system_tag, comm);
   } else {
@@ -522,25 +612,27 @@ void smpi_mpi_reduce(void* sendbuf, void* recvbuf, int count, MPI_Datatype datat
     // Receive buffers from senders
     //TODO: make a MPI_barrier here ?
     requests = xbt_new(MPI_Request, size - 1);
-    tmpbufs = xbt_new(void*, size - 1);
+    tmpbufs = xbt_new(void *, size - 1);
     index = 0;
-    for(src = 0; src < size; src++) {
-      if(src != root) {
+    for (src = 0; src < size; src++) {
+      if (src != root) {
         tmpbufs[index] = xbt_malloc(count * datasize);
-        requests[index] = smpi_irecv_init(tmpbufs[index], count, datatype, src, system_tag, comm);
+        requests[index] =
+            smpi_irecv_init(tmpbufs[index], count, datatype, src,
+                            system_tag, comm);
         index++;
       }
     }
     // Wait for completion of irecv's.
     smpi_mpi_startall(size - 1, requests);
-    for(src = 0; src < size - 1; src++) {
+    for (src = 0; src < size - 1; src++) {
       index = smpi_mpi_waitany(size - 1, requests, MPI_STATUS_IGNORE);
-      if(index == MPI_UNDEFINED) {
+      if (index == MPI_UNDEFINED) {
         break;
       }
       smpi_op_apply(op, tmpbufs[index], recvbuf, &count, &datatype);
     }
-    for(index = 0; index < size - 1; index++) {
+    for (index = 0; index < size - 1; index++) {
       xbt_free(tmpbufs[index]);
     }
     xbt_free(tmpbufs);
@@ -548,7 +640,9 @@ void smpi_mpi_reduce(void* sendbuf, void* recvbuf, int count, MPI_Datatype datat
   }
 }
 
-void smpi_mpi_allreduce(void* sendbuf, void* recvbuf, int count, MPI_Datatype datatype, MPI_Op op, MPI_Comm comm) {
+void smpi_mpi_allreduce(void *sendbuf, void *recvbuf, int count,
+                        MPI_Datatype datatype, MPI_Op op, MPI_Comm comm)
+{
   smpi_mpi_reduce(sendbuf, recvbuf, count, datatype, op, 0, comm);
   smpi_mpi_bcast(recvbuf, count, datatype, 0, comm);
 
@@ -597,12 +691,14 @@ FIXME: buggy implementation
 */
 }
 
-void smpi_mpi_scan(void* sendbuf, void* recvbuf, int count, MPI_Datatype datatype, MPI_Op op, MPI_Comm comm) {
+void smpi_mpi_scan(void *sendbuf, void *recvbuf, int count,
+                   MPI_Datatype datatype, MPI_Op op, MPI_Comm comm)
+{
   int system_tag = 666;
   int rank, size, other, index, datasize;
   int total;
-  MPI_Request* requests;
-  void** tmpbufs;
+  MPI_Request *requests;
+  void **tmpbufs;
 
   rank = smpi_comm_rank(comm);
   size = smpi_comm_size(comm);
@@ -612,30 +708,33 @@ void smpi_mpi_scan(void* sendbuf, void* recvbuf, int count, MPI_Datatype datatyp
   // Send/Recv buffers to/from others;
   total = rank + (size - (rank + 1));
   requests = xbt_new(MPI_Request, total);
-  tmpbufs = xbt_new(void*, rank);
+  tmpbufs = xbt_new(void *, rank);
   index = 0;
-  for(other = 0; other < rank; other++) {
+  for (other = 0; other < rank; other++) {
     tmpbufs[index] = xbt_malloc(count * datasize);
-    requests[index] = smpi_irecv_init(tmpbufs[index], count, datatype, other, system_tag, comm);
+    requests[index] =
+        smpi_irecv_init(tmpbufs[index], count, datatype, other, system_tag,
+                        comm);
     index++;
   }
-  for(other = rank + 1; other < size; other++) {
-    requests[index] = smpi_isend_init(sendbuf, count, datatype, other, system_tag, comm);
+  for (other = rank + 1; other < size; other++) {
+    requests[index] =
+        smpi_isend_init(sendbuf, count, datatype, other, system_tag, comm);
     index++;
   }
   // Wait for completion of all comms.
   smpi_mpi_startall(size - 1, requests);
-  for(other = 0; other < total; other++) {
+  for (other = 0; other < total; other++) {
     index = smpi_mpi_waitany(size - 1, requests, MPI_STATUS_IGNORE);
-    if(index == MPI_UNDEFINED) {
+    if (index == MPI_UNDEFINED) {
       break;
     }
-    if(index < rank) {
+    if (index < rank) {
       // #Request is below rank: it's a irecv
       smpi_op_apply(op, tmpbufs[index], recvbuf, &count, &datatype);
     }
   }
-  for(index = 0; index < size - 1; index++) {
+  for (index = 0; index < size - 1; index++) {
     xbt_free(tmpbufs[index]);
   }
   xbt_free(tmpbufs);