X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/37151c0d4c6efccef4ac99502864f1a7d8fc830b..4aaf8e185dcc8a7c7bde658a4fdd8dafba609c37:/src/smpi/smpi_base.c diff --git a/src/smpi/smpi_base.c b/src/smpi/smpi_base.c index d29b237c67..9ad302a889 100644 --- a/src/smpi/smpi_base.c +++ b/src/smpi/smpi_base.c @@ -9,6 +9,7 @@ #include "mc/mc.h" #include "xbt/replay.h" #include +#include "simix/smx_private.h" #include "surf/surf.h" @@ -70,6 +71,7 @@ static MPI_Request build_request(void *buf, int count, request->comm = comm; request->action = NULL; request->flags = flags; + request->detached = 0; #ifdef HAVE_TRACING request->send = 0; request->recv = 0; @@ -145,7 +147,6 @@ MPI_Request smpi_mpi_recv_init(void *buf, int count, MPI_Datatype datatype, void smpi_mpi_start(MPI_Request request) { smx_rdv_t mailbox; - int detached = 0; xbt_assert(!request->action, "Cannot (re)start a non-finished communication"); @@ -161,10 +162,10 @@ void smpi_mpi_start(MPI_Request request) } else { int receiver = smpi_group_index(smpi_comm_group(request->comm), request->dst); - if(receiver == MPI_UNDEFINED) { - XBT_WARN("Trying to send a message to a wrong rank"); - return; - } +/* if(receiver == MPI_UNDEFINED) {*/ +/* XBT_WARN("Trying to send a message to a wrong rank");*/ +/* return;*/ +/* }*/ print_request("New send", request); if (request->size < xbt_cfg_get_int(_surf_cfg_set, "smpi/async_small_thres")) { // eager mode mailbox = smpi_process_remote_mailbox_small(receiver); @@ -173,11 +174,14 @@ void smpi_mpi_start(MPI_Request request) mailbox = smpi_process_remote_mailbox(receiver); } if (request->size < 64*1024 ) { //(FIXME: this limit should be configurable) - void *oldbuf = request->buf; - detached = 1; - request->buf = malloc(request->size); - if (oldbuf) - memcpy(request->buf,oldbuf,request->size); + void *oldbuf = NULL; + if(request->old_type->has_subtype == 0){ + oldbuf = request->buf; + request->detached = 1; + request->buf = malloc(request->size); + if (oldbuf) + memcpy(request->buf,oldbuf,request->size); + } XBT_DEBUG("Send request %p is detached; buf %p copied into %p",request,oldbuf,request->buf); } @@ -188,7 +192,7 @@ void smpi_mpi_start(MPI_Request request) &smpi_mpi_request_free_voidp, // how to free the userdata if a detached send fails request, // detach if msg size < eager/rdv switch limit - detached); + request->detached); #ifdef HAVE_TRACING /* FIXME: detached sends are not traceable (request->action == NULL) */ @@ -325,9 +329,7 @@ static void finish_wait(MPI_Request * request, MPI_Status * status) if(req->flags & RECV) { subtype->unserialize(req->buf, req->old_buf, req->size/smpi_datatype_size(datatype) , datatype->substruct); } - //FIXME: I am not sure that if the send is detached we have to free - //the sender buffer thus I do it only for the reciever - if(req->flags & RECV) free(req->buf); + if(req->detached == 0) free(req->buf); } if(req->flags & NON_PERSISTENT) { @@ -451,7 +453,7 @@ void smpi_mpi_iprobe(int source, int tag, MPI_Comm comm, int* flag, MPI_Status* if(request->action){ MPI_Request req = (MPI_Request)SIMIX_comm_get_src_data(request->action); - *flag=true; + *flag = 1; if(status != MPI_STATUS_IGNORE) { status->MPI_SOURCE = req->src; status->MPI_TAG = req->tag; @@ -459,7 +461,7 @@ void smpi_mpi_iprobe(int source, int tag, MPI_Comm comm, int* flag, MPI_Status* status->count = req->size; } } - else *flag=false; + else *flag = 0; smpi_mpi_request_free(&request); return; @@ -536,7 +538,7 @@ void smpi_mpi_waitall(int count, MPI_Request requests[], } for(c = 0; c < count; c++) { - if(MC_IS_ENABLED) { + if(MC_is_active()) { smpi_mpi_wait(&requests[c], pstat); index = c; } else {