X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/324f5f6d1ff9d97894561e04693fe4fb76a573d7..c5309c7efaf73d81f7aa8cb7908348d0db5677fe:/src/mc/SafetyChecker.cpp diff --git a/src/mc/SafetyChecker.cpp b/src/mc/SafetyChecker.cpp index ea0b775153..182ff28964 100644 --- a/src/mc/SafetyChecker.cpp +++ b/src/mc/SafetyChecker.cpp @@ -5,9 +5,10 @@ * under the terms of the license (GNU LGPL) which comes with this package. */ #include - #include +#include + #include #include #include @@ -30,47 +31,73 @@ XBT_LOG_NEW_DEFAULT_SUBCATEGORY(mc_safety, mc, "Logging specific to MC safety verification "); +/** Stack (of `simgrid::mc::State*`) representing the current position of the + * the MC in the exploration graph + * + * It is managed by its head (`xbt_fifo_shift` and `xbt_fifo_unshift`). + */ +XBT_PRIVATE static std::list mc_stack; + namespace simgrid { namespace mc { -static int is_exploration_stack_state(mc_state_t current_state){ +static void MC_show_non_termination(void) +{ + XBT_INFO("******************************************"); + XBT_INFO("*** NON-PROGRESSIVE CYCLE DETECTED ***"); + XBT_INFO("******************************************"); + XBT_INFO("Counter-example execution trace:"); + for (auto& s : mc_model_checker->getChecker()->getTextualTrace()) + XBT_INFO("%s", s.c_str()); + MC_print_statistics(mc_stats); +} - xbt_fifo_item_t item; - mc_state_t stack_state; - for(item = xbt_fifo_get_first_item(mc_stack); item != nullptr; item = xbt_fifo_get_next_item(item)) { - stack_state = (mc_state_t) xbt_fifo_get_item_content(item); - if(snapshot_compare(stack_state, current_state) == 0){ - XBT_INFO("Non-progressive cycle : state %d -> state %d", stack_state->num, current_state->num); +static int snapshot_compare(simgrid::mc::State* state1, simgrid::mc::State* state2) +{ + simgrid::mc::Snapshot* s1 = state1->system_state.get(); + simgrid::mc::Snapshot* s2 = state2->system_state.get(); + int num1 = state1->num; + int num2 = state2->num; + return snapshot_compare(num1, s1, num2, s2); +} + +static int is_exploration_stack_state(simgrid::mc::State* current_state) +{ + for (auto i = mc_stack.rbegin(); i != mc_stack.rend(); ++i) + if(snapshot_compare(*i, current_state) == 0){ + XBT_INFO("Non-progressive cycle : state %d -> state %d", (*i)->num, current_state->num); return 1; } - } return 0; } -/** - * \brief Initialize the DPOR exploration algorithm - */ -void SafetyChecker::pre() +RecordTrace SafetyChecker::getRecordTrace() // override { - simgrid::mc::visited_states.clear(); - - mc_state_t initial_state = MC_state_new(); - - XBT_DEBUG("**************************************************"); - XBT_DEBUG("Initial state"); - - /* Wait for requests (schedules processes) */ - mc_model_checker->wait_for_requests(); + RecordTrace res; + for (simgrid::mc::State* state : mc_stack) { + int value = 0; + smx_simcall_t saved_req = MC_state_get_executed_request(state, &value); + const smx_process_t issuer = MC_smx_simcall_get_issuer(saved_req); + const int pid = issuer->pid; + res.push_back(RecordTraceElement(pid, value)); + } + return res; +} - /* Get an enabled process and insert it in the interleave set of the initial state */ - for (auto& p : mc_model_checker->process().simix_processes()) - if (simgrid::mc::process_is_enabled(&p.copy)) { - MC_state_interleave_process(initial_state, &p.copy); - if (reductionMode_ != simgrid::mc::ReductionMode::none) - break; +std::vector SafetyChecker::getTextualTrace() // override +{ + std::vector trace; + for (simgrid::mc::State* state : mc_stack) { + int value; + smx_simcall_t req = MC_state_get_executed_request(state, &value); + if (req) { + char* req_str = simgrid::mc::request_to_string( + req, value, simgrid::mc::RequestType::executed); + trace.push_back(req_str); + xbt_free(req_str); } - - xbt_fifo_unshift(mc_stack, initial_state); + } + return trace; } int SafetyChecker::run() @@ -80,19 +107,20 @@ int SafetyChecker::run() char *req_str = nullptr; int value; smx_simcall_t req = nullptr; - mc_state_t state = nullptr, prev_state = NULL, next_state = NULL; + simgrid::mc::State* prev_state = nullptr; + simgrid::mc::State* next_state = nullptr; xbt_fifo_item_t item = nullptr; std::unique_ptr visited_state = nullptr; - while (xbt_fifo_size(mc_stack) > 0) { + while (!mc_stack.empty()) { /* Get current state */ - state = (mc_state_t)xbt_fifo_get_item_content(xbt_fifo_get_first_item(mc_stack)); + simgrid::mc::State* state = mc_stack.back(); XBT_DEBUG("**************************************************"); XBT_DEBUG - ("Exploration depth=%d (state=%p, num %d)(%u interleave, user_max_depth %d)", - xbt_fifo_size(mc_stack), state, state->num, + ("Exploration depth=%zi (state=%p, num %d)(%u interleave, user_max_depth %d)", + mc_stack.size(), state, state->num, MC_state_interleave_size(state), user_max_depth_reached); /* Update statistics */ @@ -100,7 +128,7 @@ int SafetyChecker::run() /* If there are processes to interleave and the maximum depth has not been reached then perform one step of the exploration algorithm */ - if (xbt_fifo_size(mc_stack) <= _sg_mc_max_depth && !user_max_depth_reached + if (mc_stack.size() <= _sg_mc_max_depth && !user_max_depth_reached && (req = MC_state_get_request(state, &value)) && visited_state == nullptr) { req_str = simgrid::mc::request_to_string(req, value, simgrid::mc::RequestType::simix); @@ -128,7 +156,7 @@ int SafetyChecker::run() return SIMGRID_MC_EXIT_NON_TERMINATION; } - if ((visited_state = simgrid::mc::is_visited_state(next_state)) == nullptr) { + if (_sg_mc_visited == 0 || (visited_state = simgrid::mc::is_visited_state(next_state, true)) == nullptr) { /* Get an enabled process and insert it in the interleave set of the next state */ for (auto& p : mc_model_checker->process().simix_processes()) @@ -144,8 +172,7 @@ int SafetyChecker::run() } else if (dot_output != nullptr) std::fprintf(dot_output, "\"%d\" -> \"%d\" [%s];\n", state->num, visited_state->other_num == -1 ? visited_state->num : visited_state->other_num, req_str); - - xbt_fifo_unshift(mc_stack, next_state); + mc_stack.push_back(next_state); if (dot_output != nullptr) xbt_free(req_str); @@ -155,7 +182,9 @@ int SafetyChecker::run() /* The interleave set is empty or the maximum depth is reached, let's back-track */ } else { - if ((xbt_fifo_size(mc_stack) > _sg_mc_max_depth) || user_max_depth_reached || visited_state != nullptr) { + if (mc_stack.size() > _sg_mc_max_depth + || user_max_depth_reached + || visited_state != nullptr) { if (user_max_depth_reached && visited_state == nullptr) XBT_DEBUG("User max depth reached !"); @@ -165,18 +194,20 @@ int SafetyChecker::run() XBT_DEBUG("State already visited (equal to state %d), exploration stopped on this path.", visited_state->other_num == -1 ? visited_state->num : visited_state->other_num); } else - XBT_DEBUG("There are no more processes to interleave. (depth %d)", xbt_fifo_size(mc_stack) + 1); + XBT_DEBUG("There are no more processes to interleave. (depth %zi)", + mc_stack.size() + 1); /* Trash the current state, no longer needed */ - xbt_fifo_shift(mc_stack); - XBT_DEBUG("Delete state %d at depth %d", state->num, xbt_fifo_size(mc_stack) + 1); + mc_stack.pop_back(); + XBT_DEBUG("Delete state %d at depth %zi", + state->num, mc_stack.size() + 1); MC_state_delete(state, !state->in_visited_states ? 1 : 0); visited_state = nullptr; /* Check for deadlocks */ if (mc_model_checker->checkDeadlock()) { - MC_show_deadlock(nullptr); + MC_show_deadlock(); return SIMGRID_MC_EXIT_DEADLOCK; } @@ -187,14 +218,17 @@ int SafetyChecker::run() executed before it. If it does then add it to the interleave set of the state that executed that previous request. */ - while ((state = (mc_state_t) xbt_fifo_shift(mc_stack))) { + while (!mc_stack.empty()) { + state = mc_stack.back(); + mc_stack.pop_back(); if (reductionMode_ == simgrid::mc::ReductionMode::dpor) { req = MC_state_get_internal_request(state); if (req->call == SIMCALL_MUTEX_LOCK || req->call == SIMCALL_MUTEX_TRYLOCK) xbt_die("Mutex is currently not supported with DPOR, " "use --cfg=model-check/reduction:none"); const smx_process_t issuer = MC_smx_simcall_get_issuer(req); - xbt_fifo_foreach(mc_stack, item, prev_state, mc_state_t) { + for (auto i = mc_stack.rbegin(); i != mc_stack.rend(); ++i) { + simgrid::mc::State* prev_state = *i; if (reductionMode_ != simgrid::mc::ReductionMode::none && simgrid::mc::request_depend(req, MC_state_get_internal_request(prev_state))) { if (XBT_LOG_ISENABLED(mc_safety, xbt_log_priority_debug)) { @@ -234,15 +268,19 @@ int SafetyChecker::run() } } - if (MC_state_interleave_size(state) && xbt_fifo_size(mc_stack) < _sg_mc_max_depth) { + if (MC_state_interleave_size(state) + && mc_stack.size() < _sg_mc_max_depth) { /* We found a back-tracking point, let's loop */ - XBT_DEBUG("Back-tracking to state %d at depth %d", state->num, xbt_fifo_size(mc_stack) + 1); - xbt_fifo_unshift(mc_stack, state); - MC_replay(mc_stack); - XBT_DEBUG("Back-tracking to state %d at depth %d done", state->num, xbt_fifo_size(mc_stack)); + XBT_DEBUG("Back-tracking to state %d at depth %zi", + state->num, mc_stack.size() + 1); + mc_stack.push_back(state); + simgrid::mc::replay(mc_stack); + XBT_DEBUG("Back-tracking to state %d at depth %zi done", + state->num, mc_stack.size()); break; } else { - XBT_DEBUG("Delete state %d at depth %d", state->num, xbt_fifo_size(mc_stack) + 1); + XBT_DEBUG("Delete state %d at depth %zi", + state->num, mc_stack.size() + 1); MC_state_delete(state, !state->in_visited_states ? 1 : 0); } } @@ -251,6 +289,7 @@ int SafetyChecker::run() XBT_INFO("No property violation found."); MC_print_statistics(mc_stats); + initial_global_state = nullptr; return SIMGRID_MC_EXIT_SUCCESS; } @@ -262,8 +301,6 @@ void SafetyChecker::init() else if (reductionMode_ == simgrid::mc::ReductionMode::unset) reductionMode_ = simgrid::mc::ReductionMode::dpor; - _sg_mc_safety = 1; - if (_sg_mc_termination) XBT_INFO("Check non progressive cycles"); else @@ -273,12 +310,30 @@ void SafetyChecker::init() XBT_DEBUG("Starting the safety algorithm"); /* Create exploration stack */ - mc_stack = xbt_fifo_new(); + mc_stack.clear(); + + simgrid::mc::visited_states.clear(); + + simgrid::mc::State* initial_state = MC_state_new(); + + XBT_DEBUG("**************************************************"); + XBT_DEBUG("Initial state"); + + /* Wait for requests (schedules processes) */ + mc_model_checker->wait_for_requests(); + + /* Get an enabled process and insert it in the interleave set of the initial state */ + for (auto& p : mc_model_checker->process().simix_processes()) + if (simgrid::mc::process_is_enabled(&p.copy)) { + MC_state_interleave_process(initial_state, &p.copy); + if (reductionMode_ != simgrid::mc::ReductionMode::none) + break; + } - this->pre(); + mc_stack.push_back(initial_state); /* Save the initial state */ - initial_global_state = xbt_new0(s_mc_global_t, 1); + initial_global_state = std::unique_ptr(new s_mc_global_t()); initial_global_state->snapshot = simgrid::mc::take_snapshot(0); }