X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/31a6e7924c82cf18f981739b2f27f5920b970e73..84f504218e6e541881d121ba0382f132ff1cf135:/src/bindings/java/jmsg_task.cpp diff --git a/src/bindings/java/jmsg_task.cpp b/src/bindings/java/jmsg_task.cpp index b8ebf844fb..d5686e2238 100644 --- a/src/bindings/java/jmsg_task.cpp +++ b/src/bindings/java/jmsg_task.cpp @@ -1,22 +1,21 @@ /* Functions related to the java task instances. */ -/* Copyright (c) 2007-2017. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2007-2022. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ -#include +#include "simgrid/Exception.hpp" +#include "simgrid/s4u/Host.hpp" -#include "jmsg.h" +#include "jmsg.hpp" #include "jmsg_host.h" -#include "jmsg_task.h" #include "jmsg_process.h" -#include "jxbt_utilities.h" +#include "jmsg_task.h" +#include "jxbt_utilities.hpp" XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(java); -SG_BEGIN_DECL() - static jmethodID jtask_method_Comm_constructor; static jfieldID jtask_field_Task_bind; @@ -57,13 +56,8 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_nativeInit(JNIEnv *env, jclass JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_create(JNIEnv * env, jobject jtask, jstring jname, jdouble jflopsAmount, jdouble jbytesAmount) { - const char *name = nullptr; /* the name of the task */ - - if (jname) - name = env->GetStringUTFChars(jname, 0); - msg_task_t task = MSG_task_create(name, static_cast(jflopsAmount), static_cast(jbytesAmount), jtask); - if (jname) - env->ReleaseStringUTFChars(jname, name); + jstring_wrapper task_name(env, jname); + msg_task_t task = MSG_task_create(task_name, jflopsAmount, jbytesAmount, jtask); /* bind & store the task */ jtask_bind(jtask, task, env); @@ -73,11 +67,11 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_parallelCreate(JNIEnv * env, jo jobjectArray jhosts, jdoubleArray jcomputeDurations_arg, jdoubleArray jmessageSizes_arg) { - int host_count = static_cast(env->GetArrayLength(jhosts)); + int host_count = env->GetArrayLength(jhosts); - jdouble* jcomputeDurations = env->GetDoubleArrayElements(jcomputeDurations_arg, 0); - msg_host_t* hosts = xbt_new0(msg_host_t, host_count); - double* computeDurations = xbt_new0(double, host_count); + jdouble* jcomputeDurations = env->GetDoubleArrayElements(jcomputeDurations_arg, nullptr); + auto* hosts = new msg_host_t[host_count]; + auto* computeDurations = new double[host_count]; for (int index = 0; index < host_count; index++) { jobject jhost = env->GetObjectArrayElement(jhosts, index); hosts[index] = jhost_get_native(env, jhost); @@ -85,46 +79,51 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_parallelCreate(JNIEnv * env, jo } env->ReleaseDoubleArrayElements(jcomputeDurations_arg, jcomputeDurations, 0); - jdouble* jmessageSizes = env->GetDoubleArrayElements(jmessageSizes_arg, 0); - double* messageSizes = xbt_new0(double, host_count* host_count); + jdouble* jmessageSizes = env->GetDoubleArrayElements(jmessageSizes_arg, nullptr); + auto* messageSizes = new double[host_count * host_count]; for (int index = 0; index < host_count * host_count; index++) { messageSizes[index] = jmessageSizes[index]; } env->ReleaseDoubleArrayElements(jmessageSizes_arg, jmessageSizes, 0); /* get the C string from the java string */ - const char* name = env->GetStringUTFChars(jname, 0); + jstring_wrapper name(env, jname); msg_task_t task = MSG_parallel_task_create(name, host_count, hosts, computeDurations, messageSizes, jtask); - env->ReleaseStringUTFChars(jname, name); /* associate the java task object and the native task */ jtask_bind(jtask, task, env); + + delete[] hosts; + delete[] computeDurations; + delete[] messageSizes; } JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_cancel(JNIEnv * env, jobject jtask) { msg_task_t ptask = jtask_to_native(jtask, env); - if (!ptask) { + if (not ptask) { jxbt_throw_notbound(env, "task", jtask); return; } msg_error_t rv = MSG_task_cancel(ptask); - - jxbt_check_res("MSG_task_cancel()", rv, MSG_OK, bprintf("unexpected error , please report this bug")); + xbt_assert(rv == MSG_OK, "MSG_task_cancel() unexpectedly failed with error code %d. Please report this bug", rv); } JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_execute(JNIEnv * env, jobject jtask) { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } msg_error_t rv; - rv = MSG_task_execute(task); + if (not simgrid::ForcefulKillException::try_n_catch([&rv, &task]() { rv = MSG_task_execute(task); })) { + jxbt_throw_by_name(env, "org/simgrid/msg/ProcessKilledError", "Process killed"); + } + if (env->ExceptionOccurred()) return; if (rv != MSG_OK) { @@ -136,7 +135,7 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setBound(JNIEnv * env, jobject { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } @@ -144,9 +143,9 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setBound(JNIEnv * env, jobject } JNIEXPORT jstring JNICALL Java_org_simgrid_msg_Task_getName(JNIEnv * env, jobject jtask) { - msg_task_t task = jtask_to_native(jtask, env); + const_msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return nullptr; } @@ -155,16 +154,14 @@ JNIEXPORT jstring JNICALL Java_org_simgrid_msg_Task_getName(JNIEnv * env, jobjec } JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_getSender(JNIEnv * env, jobject jtask) { - msg_process_t process; - - msg_task_t task = jtask_to_native(jtask, env); + const_msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return nullptr; } - process = MSG_task_get_sender(task); + auto const* process = MSG_task_get_sender(task); if (process == nullptr) { return nullptr; } @@ -173,19 +170,18 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_getSender(JNIEnv * env, jobj JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_getSource(JNIEnv * env, jobject jtask) { - msg_host_t host; - msg_task_t task = jtask_to_native(jtask, env); + const_msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return nullptr; } - host = MSG_task_get_source(task); + auto const* host = MSG_task_get_source(task); if (host == nullptr) { return nullptr; } - if (!host->extension(JAVA_HOST_LEVEL)) { + if (not host->extension(JAVA_HOST_LEVEL)) { jxbt_throw_jni(env, "MSG_task_get_source() failed"); return nullptr; } @@ -195,80 +191,76 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_getSource(JNIEnv * env, jobj JNIEXPORT jdouble JNICALL Java_org_simgrid_msg_Task_getFlopsAmount(JNIEnv * env, jobject jtask) { - msg_task_t ptask = jtask_to_native(jtask, env); + const_msg_task_t ptask = jtask_to_native(jtask, env); - if (!ptask) { + if (not ptask) { jxbt_throw_notbound(env, "task", jtask); return -1; } - return (jdouble) MSG_task_get_flops_amount(ptask); + return (jdouble)MSG_task_get_flops_amount(ptask); } JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setName(JNIEnv *env, jobject jtask, jobject jname) { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } - const char *name = env->GetStringUTFChars((jstring) jname, 0); + jstring_wrapper name(env, static_cast(jname)); env->SetObjectField(jtask, jtask_field_Task_name, jname); MSG_task_set_name(task, name); - - env->ReleaseStringUTFChars((jstring) jname, name); } JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setPriority(JNIEnv * env, jobject jtask, jdouble priority) { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } - MSG_task_set_priority(task, static_cast(priority)); + MSG_task_set_priority(task, priority); } JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setFlopsAmount (JNIEnv *env, jobject jtask, jdouble computationAmount) { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } - MSG_task_set_flops_amount(task, static_cast(computationAmount)); + MSG_task_set_flops_amount(task, computationAmount); } JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_setBytesAmount (JNIEnv *env, jobject jtask, jdouble dataSize) { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } env->SetDoubleField(jtask, jtask_field_Task_messageSize, dataSize); - MSG_task_set_bytes_amount(task, static_cast(dataSize)); + MSG_task_set_bytes_amount(task, dataSize); } JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_sendBounded(JNIEnv * env,jobject jtask, jstring jalias, jdouble jtimeout,jdouble maxrate) { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } /* Add a global ref into the Ctask so that the receiver can use it */ - MSG_task_set_data(task, (void *) env->NewGlobalRef(jtask)); + MSG_task_set_data(task, env->NewGlobalRef(jtask)); - const char* alias = env->GetStringUTFChars(jalias, 0); - msg_error_t res = - MSG_task_send_with_timeout_bounded(task, alias, static_cast(jtimeout), static_cast(maxrate)); - env->ReleaseStringUTFChars(jalias, alias); + jstring_wrapper alias(env, jalias); + msg_error_t res = MSG_task_send_with_timeout_bounded(task, alias, jtimeout, maxrate); if (res != MSG_OK) jmsg_throw_status(env, res); @@ -278,16 +270,19 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_receive(JNIEnv* env, jclass { msg_task_t task = nullptr; - const char *alias = env->GetStringUTFChars(jalias, 0); - msg_error_t rv = MSG_task_receive_ext(&task, alias, (double)jtimeout, /*host*/ nullptr); - env->ReleaseStringUTFChars(jalias, alias); + jstring_wrapper alias(env, jalias); + msg_error_t rv; + if (not simgrid::ForcefulKillException::try_n_catch( + [&rv, &task, &alias, &jtimeout]() { rv = MSG_task_receive_with_timeout(&task, alias, (double)jtimeout); })) { + jxbt_throw_by_name(env, "org/simgrid/msg/ProcessKilledError", "Process killed"); + } if (env->ExceptionOccurred()) return nullptr; if (rv != MSG_OK) { - jmsg_throw_status(env,rv); + jmsg_throw_status(env, rv); return nullptr; } - jobject jtask_global = (jobject) MSG_task_get_data(task); + auto jtask_global = (jobject)MSG_task_get_data(task); /* Convert the global ref into a local ref so that the JVM can free the stuff */ jobject jtask_local = env->NewLocalRef(jtask_global); @@ -299,23 +294,21 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_receive(JNIEnv* env, jclass JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_irecv(JNIEnv * env, jclass cls, jstring jmailbox) { jclass comm_class = env->FindClass("org/simgrid/msg/Comm"); - if (!comm_class) + if (not comm_class) return nullptr; //pointer to store the task object pointer. - msg_task_t *task = xbt_new(msg_task_t,1); - *task = nullptr; + auto* task = new msg_task_t(nullptr); /* There should be a cache here */ jobject jcomm = env->NewObject(comm_class, jtask_method_Comm_constructor); - if (!jcomm) { + if (not jcomm) { jxbt_throw_jni(env, "Can't create a Comm object."); return nullptr; } - const char* mailbox = env->GetStringUTFChars(jmailbox, 0); + jstring_wrapper mailbox(env, jmailbox); msg_comm_t comm = MSG_task_irecv(task, mailbox); - env->ReleaseStringUTFChars(jmailbox, mailbox); env->SetLongField(jcomm, jtask_field_Comm_bind, (jlong) (uintptr_t)(comm)); env->SetLongField(jcomm, jtask_field_Comm_taskBind, (jlong) (uintptr_t)(task)); @@ -329,24 +322,21 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_receiveBounded(JNIEnv* env, { msg_task_t task = nullptr; - const char *alias = env->GetStringUTFChars(jalias, 0); - msg_error_t res = MSG_task_receive_ext_bounded(&task, alias, static_cast(jtimeout), /*host*/ nullptr, - static_cast(rate)); + jstring_wrapper alias(env, jalias); + msg_error_t res = MSG_task_receive_with_timeout_bounded(&task, alias, jtimeout, rate); if (env->ExceptionOccurred()) return nullptr; if (res != MSG_OK) { jmsg_throw_status(env, res); return nullptr; } - jobject jtask_global = (jobject)MSG_task_get_data(task); + auto jtask_global = (jobject)MSG_task_get_data(task); /* Convert the global ref into a local ref so that the JVM can free the stuff */ jobject jtask_local = env->NewLocalRef(jtask_global); env->DeleteGlobalRef(jtask_global); MSG_task_set_data(task, nullptr); - env->ReleaseStringUTFChars(jalias, alias); - return (jobject) jtask_local; } @@ -354,21 +344,20 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_irecvBounded(JNIEnv * env, j jdouble rate) { jclass comm_class = env->FindClass("org/simgrid/msg/Comm"); - if (!comm_class) + if (not comm_class) return nullptr; // pointer to store the task object pointer. - msg_task_t* task = xbt_new0(msg_task_t, 1); + auto* task = new msg_task_t(nullptr); jobject jcomm = env->NewObject(comm_class, jtask_method_Comm_constructor); - if (!jcomm) { + if (not jcomm) { jxbt_throw_jni(env, "Can't create a Comm object."); return nullptr; } - const char* mailbox = env->GetStringUTFChars(jmailbox, 0); - msg_comm_t comm = MSG_task_irecv_bounded(task, mailbox, static_cast(rate)); - env->ReleaseStringUTFChars(jmailbox, mailbox); + jstring_wrapper mailbox(env, jmailbox); + msg_comm_t comm = MSG_task_irecv_bounded(task, mailbox, rate); env->SetLongField(jcomm, jtask_field_Comm_bind, (jlong) (uintptr_t)(comm)); env->SetLongField(jcomm, jtask_field_Comm_taskBind, (jlong) (uintptr_t)(task)); @@ -383,29 +372,27 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_isend(JNIEnv *env, jobject j jclass comm_class = env->FindClass("org/simgrid/msg/Comm"); - if (!comm_class) return nullptr; + if (not comm_class) + return nullptr; jobject jcomm = env->NewObject(comm_class, jtask_method_Comm_constructor); - const char* mailbox = env->GetStringUTFChars(jmailbox, 0); + jstring_wrapper mailbox(env, jmailbox); msg_task_t task = jtask_to_native(jtask, env); - if (!task) { - env->ReleaseStringUTFChars(jmailbox, mailbox); + if (not task) { env->DeleteLocalRef(jcomm); jxbt_throw_notbound(env, "task", jtask); return nullptr; } - MSG_task_set_data(task, (void *) env->NewGlobalRef(jtask)); + MSG_task_set_data(task, env->NewGlobalRef(jtask)); comm = MSG_task_isend(task,mailbox); env->SetLongField(jcomm, jtask_field_Comm_bind, (jlong) (uintptr_t)(comm)); env->SetLongField(jcomm, jtask_field_Comm_taskBind, (jlong) (uintptr_t)(nullptr)); env->SetBooleanField(jcomm, jtask_field_Comm_receiving, JNI_FALSE); - env->ReleaseStringUTFChars(jmailbox, mailbox); - return jcomm; } @@ -415,33 +402,29 @@ JNIEXPORT jobject JNICALL Java_org_simgrid_msg_Task_isendBounded(JNIEnv *env, jo msg_task_t task; jobject jcomm; msg_comm_t comm; - const char *mailbox; jclass comm_class = env->FindClass("org/simgrid/msg/Comm"); - if (!comm_class) + if (not comm_class) return nullptr; jcomm = env->NewObject(comm_class, jtask_method_Comm_constructor); - mailbox = env->GetStringUTFChars(jmailbox, 0); + jstring_wrapper mailbox(env, jmailbox); task = jtask_to_native(jtask, env); - if (!task) { - env->ReleaseStringUTFChars(jmailbox, mailbox); + if (not task) { env->DeleteLocalRef(jcomm); jxbt_throw_notbound(env, "task", jtask); return nullptr; } - MSG_task_set_data(task, (void *) env->NewGlobalRef(jtask)); + MSG_task_set_data(task, env->NewGlobalRef(jtask)); comm = MSG_task_isend_bounded(task,mailbox,maxrate); env->SetLongField(jcomm, jtask_field_Comm_bind, (jlong) (uintptr_t)(comm)); env->SetLongField(jcomm, jtask_field_Comm_taskBind, (jlong) (uintptr_t)(nullptr)); env->SetBooleanField(jcomm, jtask_field_Comm_receiving, JNI_FALSE); - env->ReleaseStringUTFChars(jmailbox, mailbox); - return jcomm; } @@ -449,7 +432,7 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_nativeFinalize(JNIEnv * env, jo { msg_task_t task = jtask_to_native(jtask, env); - if (!task) { + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } @@ -458,71 +441,61 @@ JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_nativeFinalize(JNIEnv * env, jo } static void msg_task_cancel_on_failed_dsend(void*t) { - msg_task_t task = (msg_task_t) t; - JNIEnv *env =get_current_thread_env(); - jobject jtask_global = (jobject) MSG_task_get_data(task); - - /* Destroy the global ref so that the JVM can free the stuff */ - env->DeleteGlobalRef(jtask_global); + auto task = (msg_task_t)t; + JNIEnv* env = get_current_thread_env(); + if (env) { + auto jtask_global = (jobject)MSG_task_get_data(task); + /* Destroy the global ref so that the JVM can free the stuff */ + env->DeleteGlobalRef(jtask_global); + /* Don't free the C data here, to avoid a race condition with the GC also sometimes doing so. + * A rare memleak is seen as preferable to a rare "free(): invalid pointer" failure that + * proves really hard to debug. + */ + } MSG_task_set_data(task, nullptr); - MSG_task_destroy(task); } JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_dsend(JNIEnv * env, jobject jtask, jstring jalias) { - const char *alias = env->GetStringUTFChars(jalias, 0); + jstring_wrapper alias(env, jalias); msg_task_t task = jtask_to_native(jtask, env); - if (!task) { - env->ReleaseStringUTFChars(jalias, alias); + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } /* Pass a global ref to the Jtask into the Ctask so that the receiver can use it */ - MSG_task_set_data(task, (void *) env->NewGlobalRef(jtask)); + MSG_task_set_data(task, env->NewGlobalRef(jtask)); MSG_task_dsend(task, alias, msg_task_cancel_on_failed_dsend); - - env->ReleaseStringUTFChars(jalias, alias); } JNIEXPORT void JNICALL Java_org_simgrid_msg_Task_dsendBounded(JNIEnv * env, jobject jtask, jstring jalias, jdouble maxrate) { - const char *alias = env->GetStringUTFChars(jalias, 0); + jstring_wrapper alias(env, jalias); msg_task_t task = jtask_to_native(jtask, env); - if (!task) { - env->ReleaseStringUTFChars(jalias, alias); + if (not task) { jxbt_throw_notbound(env, "task", jtask); return; } /* Pass a global ref to the Jtask into the Ctask so that the receiver can use it */ - MSG_task_set_data(task, (void *) env->NewGlobalRef(jtask)); - MSG_task_dsend_bounded(task, alias, msg_task_cancel_on_failed_dsend,static_cast(maxrate)); - - env->ReleaseStringUTFChars(jalias, alias); + MSG_task_set_data(task, env->NewGlobalRef(jtask)); + MSG_task_dsend_bounded(task, alias, msg_task_cancel_on_failed_dsend, maxrate); } JNIEXPORT jboolean JNICALL Java_org_simgrid_msg_Task_listen(JNIEnv * env, jclass cls, jstring jalias) { - const char *alias = env->GetStringUTFChars(jalias, 0); - int rv = MSG_task_listen(alias); - env->ReleaseStringUTFChars(jalias, alias); - - return (jboolean) rv; + jstring_wrapper alias(env, jalias); + return (jboolean)MSG_task_listen(alias); } JNIEXPORT jint JNICALL Java_org_simgrid_msg_Task_listenFrom(JNIEnv * env, jclass cls, jstring jalias) { - const char *alias = env->GetStringUTFChars(jalias, 0); - int rv = MSG_task_listen_from(alias); - env->ReleaseStringUTFChars(jalias, alias); - - return (jint) rv; + jstring_wrapper alias(env, jalias); + return (jint)MSG_task_listen_from(alias); } - -SG_END_DECL()