X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/2c59c22dfabc4a10eac19ee7d6a6d77a29f06736..88b1e4950f861a4757910503cb770442fc614458:/src/plugins/host_dvfs.cpp diff --git a/src/plugins/host_dvfs.cpp b/src/plugins/host_dvfs.cpp index 483a9c6019..e5a2f47086 100644 --- a/src/plugins/host_dvfs.cpp +++ b/src/plugins/host_dvfs.cpp @@ -6,9 +6,12 @@ #include "simgrid/plugins/dvfs.h" #include "simgrid/plugins/load.h" #include "simgrid/s4u/Engine.hpp" +#include "src/internal_config.h" // HAVE_SMPI #include "src/kernel/activity/ExecImpl.hpp" #include "src/plugins/vm/VirtualMachineImpl.hpp" +#if HAVE_SMPI #include "src/smpi/plugins/ampi/ampi.hpp" +#endif #include #include @@ -77,31 +80,43 @@ class Governor { private: simgrid::s4u::Host* const host_; double sampling_rate_; - int min_pstate; - int max_pstate; + int min_pstate; //< Never use a pstate less than this one + int max_pstate; //< Never use a pstate larger than this one public: - - explicit Governor(simgrid::s4u::Host* ptr) : host_(ptr), min_pstate(cfg_min_pstate), - max_pstate(cfg_max_pstate == max_pstate_not_limited ? host_->get_pstate_count() - 1 : cfg_max_pstate) { - xbt_assert(max_pstate <= host_->get_pstate_count() - 1); - xbt_assert(min_pstate <= max_pstate); - xbt_assert(0 <= min_pstate); + explicit Governor(simgrid::s4u::Host* ptr) + : host_(ptr) + , min_pstate(cfg_min_pstate) + , max_pstate(cfg_max_pstate == max_pstate_not_limited ? host_->get_pstate_count() - 1 : cfg_max_pstate) + { init(); } virtual ~Governor() = default; virtual std::string get_name() const = 0; simgrid::s4u::Host* get_host() const { return host_; } + int get_min_pstate() const { return min_pstate; } + int get_max_pstate() const { return max_pstate; } void init() { const char* local_sampling_rate_config = host_->get_property(cfg_sampling_rate.get_name()); - double global_sampling_rate_config = cfg_sampling_rate; if (local_sampling_rate_config != nullptr) { sampling_rate_ = std::stod(local_sampling_rate_config); } else { - sampling_rate_ = global_sampling_rate_config; + sampling_rate_ = cfg_sampling_rate; + } + const char* local_min_pstate_config = host_->get_property(cfg_min_pstate.get_name()); + if (local_min_pstate_config != nullptr) { + min_pstate = std::stoi(local_min_pstate_config); } + + const char* local_max_pstate_config = host_->get_property(cfg_max_pstate.get_name()); + if (local_max_pstate_config != nullptr) { + max_pstate = std::stod(local_max_pstate_config); + } + xbt_assert(max_pstate <= host_->get_pstate_count() - 1, "Value for max_pstate too large!"); + xbt_assert(min_pstate <= max_pstate, "min_pstate is larger than max_pstate!"); + xbt_assert(0 <= min_pstate, "min_pstate is negative!"); } virtual void update() = 0; @@ -123,7 +138,7 @@ public: explicit Performance(simgrid::s4u::Host* ptr) : Governor(ptr) {} std::string get_name() const override { return "Performance"; } - void update() override { get_host()->set_pstate(min_pstate); } + void update() override { get_host()->set_pstate(get_min_pstate()); } }; /** @@ -141,7 +156,7 @@ public: explicit Powersave(simgrid::s4u::Host* ptr) : Governor(ptr) {} std::string get_name() const override { return "Powersave"; } - void update() override { get_host()->set_pstate(max_pstate); } + void update() override { get_host()->set_pstate(get_max_pstate()); } }; /** @@ -170,8 +185,8 @@ public: sg_host_load_reset(get_host()); // Only consider the period between two calls to this method! if (load > freq_up_threshold_) { - get_host()->set_pstate(min_pstate); /* Run at max. performance! */ - XBT_INFO("Load: %f > threshold: %f --> changed to pstate %i", load, freq_up_threshold_, min_pstate); + get_host()->set_pstate(get_min_pstate()); /* Run at max. performance! */ + XBT_INFO("Load: %f > threshold: %f --> changed to pstate %i", load, freq_up_threshold_, get_min_pstate()); } else { /* The actual implementation uses a formula here: (See Kernel file cpufreq_ondemand.c:158) * @@ -182,13 +197,14 @@ public: */ // Load is now < freq_up_threshold; exclude pstate 0 (the fastest) // because pstate 0 can only be selected if load > freq_up_threshold_ - int new_pstate = max_pstate - load * (max_pstate + 1); + int new_pstate = get_max_pstate() - load * (get_max_pstate() + 1); + if (new_pstate < get_min_pstate()) + new_pstate = get_min_pstate(); get_host()->set_pstate(new_pstate); XBT_DEBUG("Load: %f < threshold: %f --> changed to pstate %i", load, freq_up_threshold_, new_pstate); } } - }; /** @@ -218,7 +234,7 @@ public: sg_host_load_reset(get_host()); // Only consider the period between two calls to this method! if (load > freq_up_threshold_) { - if (pstate != min_pstate) { + if (pstate != get_min_pstate()) { get_host()->set_pstate(pstate - 1); XBT_INFO("Load: %f > threshold: %f -> increasing performance to pstate %d", load, freq_up_threshold_, pstate - 1); @@ -227,7 +243,7 @@ public: freq_up_threshold_, pstate); } } else if (load < freq_down_threshold_) { - if (pstate != max_pstate) { // Are we in the slowest pstate already? + if (pstate != get_max_pstate()) { // Are we in the slowest pstate already? get_host()->set_pstate(pstate + 1); XBT_INFO("Load: %f < threshold: %f -> slowing down to pstate %d", load, freq_down_threshold_, pstate + 1); } else { @@ -252,8 +268,9 @@ private: public: explicit Adagio(simgrid::s4u::Host* ptr) - : Governor(ptr), rates(100, std::vector(host_->get_pstate_count(), 0.0)) + : Governor(ptr), rates(100, std::vector(ptr->get_pstate_count(), 0.0)) { +#if HAVE_SMPI simgrid::smpi::plugin::ampi::on_iteration_in.connect([this](simgrid::s4u::ActorPtr actor) { // Every instance of this class subscribes to this event, so one per host // This means that for any actor, all 'hosts' are normally notified of these @@ -269,6 +286,7 @@ public: task_id = 0; } }); +#endif simgrid::kernel::activity::ExecImpl::on_creation.connect([this](simgrid::kernel::activity::ExecImplPtr activity) { if (activity->host_ == get_host()) pre_task(); @@ -292,21 +310,21 @@ public: void pre_task() { - sg_host_load_reset(host_); - comp_counter = sg_host_get_computed_flops(host_); // Should be 0 because of the reset + sg_host_load_reset(get_host()); + comp_counter = sg_host_get_computed_flops(get_host()); // Should be 0 because of the reset comp_timer = 0; start_time = simgrid::s4u::Engine::get_clock(); if (rates.size() <= task_id) - rates.resize(task_id + 5, std::vector(host_->get_pstate_count(), 0.0)); + rates.resize(task_id + 5, std::vector(get_host()->get_pstate_count(), 0.0)); if (rates[task_id][best_pstate] == 0) best_pstate = 0; - host_->set_pstate(best_pstate); // Load our schedule + get_host()->set_pstate(best_pstate); // Load our schedule XBT_DEBUG("Set pstate to %i", best_pstate); } void post_task() { - double computed_flops = sg_host_get_computed_flops(host_) - comp_counter; + double computed_flops = sg_host_get_computed_flops(get_host()) - comp_counter; double target_time = (simgrid::s4u::Engine::get_clock() - start_time); target_time = target_time * @@ -315,13 +333,12 @@ public: bool is_initialized = rates[task_id][best_pstate] != 0; rates[task_id][best_pstate] = computed_flops / comp_timer; if (not is_initialized) { - for (int i = 1; i < host_->get_pstate_count(); i++) { - rates[task_id][i] = rates[task_id][0] * (host_->get_pstate_speed(i) / host_->get_speed()); + for (int i = 1; i < get_host()->get_pstate_count(); i++) { + rates[task_id][i] = rates[task_id][0] * (get_host()->get_pstate_speed(i) / get_host()->get_speed()); } - is_initialized = true; } - for (int pstate = host_->get_pstate_count() - 1; pstate >= 0; pstate--) { + for (int pstate = get_host()->get_pstate_count() - 1; pstate >= 0; pstate--) { if (computed_flops / rates[task_id][pstate] <= target_time) { // We just found the pstate we want to use! best_pstate = pstate;