X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/2648bf7b99690d4cabbb4c7c9979fcf3d8a17068..996be9435416557e2c1b20cbf462848b475d168d:/src/surf/plugins/host_dvfs.cpp diff --git a/src/surf/plugins/host_dvfs.cpp b/src/surf/plugins/host_dvfs.cpp index 1863fc7fd7..d74cc16caa 100644 --- a/src/surf/plugins/host_dvfs.cpp +++ b/src/surf/plugins/host_dvfs.cpp @@ -1,4 +1,4 @@ -/* Copyright (c) 2010, 2012-2016. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2010, 2012-2018. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ @@ -39,7 +39,7 @@ protected: public: double sampling_rate; - Governor(simgrid::s4u::Host* ptr) : host(ptr) { init(); } + explicit Governor(simgrid::s4u::Host* ptr) : host(ptr) { init(); } void init() { @@ -58,14 +58,14 @@ public: class Performance : public Governor { public: - Performance(simgrid::s4u::Host* ptr) : Governor(ptr) {} + explicit Performance(simgrid::s4u::Host* ptr) : Governor(ptr) {} void update() { host->setPstate(0); } }; class Powersave : public Governor { public: - Powersave(simgrid::s4u::Host* ptr) : Governor(ptr) {} + explicit Powersave(simgrid::s4u::Host* ptr) : Governor(ptr) {} void update() { host->setPstate(host->getPstatesCount() - 1); } }; @@ -74,7 +74,7 @@ class OnDemand : public Governor { double freq_up_threshold = 0.95; public: - OnDemand(simgrid::s4u::Host* ptr) : Governor(ptr) {} + explicit OnDemand(simgrid::s4u::Host* ptr) : Governor(ptr) {} void update() { @@ -104,7 +104,7 @@ class Conservative : public Governor { double freq_down_threshold = .2; public: - Conservative(simgrid::s4u::Host* ptr) : Governor(ptr) {} + explicit Conservative(simgrid::s4u::Host* ptr) : Governor(ptr) {} void update() { @@ -139,18 +139,13 @@ class HostDvfs { public: static simgrid::xbt::Extension EXTENSION_ID; - explicit HostDvfs(simgrid::s4u::Host* ptr); + explicit HostDvfs(simgrid::s4u::Host*); ~HostDvfs(); - -private: - simgrid::s4u::Host* host = nullptr; }; simgrid::xbt::Extension HostDvfs::EXTENSION_ID; -HostDvfs::HostDvfs(simgrid::s4u::Host* ptr) : host(ptr) -{ -} +HostDvfs::HostDvfs(simgrid::s4u::Host* ptr) {} HostDvfs::~HostDvfs() = default; } @@ -164,7 +159,7 @@ static void on_host_added(simgrid::s4u::Host& host) if (dynamic_cast(&host)) // Ignore virtual machines return; - std::string name = "dvfs-daemon-" + host.getName(); + std::string name = std::string("dvfs-daemon-") + host.getCname(); simgrid::s4u::ActorPtr daemon = simgrid::s4u::Actor::createActor(name.c_str(), &host, []() { /** * This lambda function is the function the actor (daemon) will execute @@ -209,7 +204,7 @@ static void on_host_added(simgrid::s4u::Host& host) } /* **************************** Public interface *************************** */ -SG_BEGIN_DECL() +extern "C" { /** \ingroup SURF_plugin_load * \brief Initializes the HostDvfs plugin @@ -230,5 +225,4 @@ void sg_host_dvfs_plugin_init() xbt_cfg_register_string("plugin/dvfs/governor", "performance", nullptr, "Which Governor should be used that adapts the CPU frequency?"); } - -SG_END_DECL() +}