X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/20e80e0441190a30ffdce39c11e8a947fb9d63b5..196327afa332e6c85827da70da72a1aaa178739a:/src/simix/ActorImpl.cpp diff --git a/src/simix/ActorImpl.cpp b/src/simix/ActorImpl.cpp index 96aac00178..f6665e769d 100644 --- a/src/simix/ActorImpl.cpp +++ b/src/simix/ActorImpl.cpp @@ -5,6 +5,8 @@ #include "mc/mc.h" #include "smx_private.hpp" +#include "src/kernel/activity/CommImpl.hpp" +#include "src/kernel/activity/ExecImpl.hpp" #include "src/kernel/activity/IoImpl.hpp" #include "src/kernel/activity/SleepImpl.hpp" #include "src/kernel/activity/SynchroRaw.hpp" @@ -13,6 +15,7 @@ #include "src/simix/smx_host_private.hpp" #include "src/simix/smx_io_private.hpp" #include "src/simix/smx_synchro_private.hpp" +#include "src/surf/HostImpl.hpp" #include "src/surf/cpu_interface.hpp" #include "xbt/ex.hpp" @@ -27,11 +30,11 @@ XBT_LOG_NEW_DEFAULT_SUBCATEGORY(simix_process, simix, "Logging specific to SIMIX unsigned long simix_process_maxpid = 0; /** - * \brief Returns the current agent. + * @brief Returns the current agent. * * This functions returns the currently running SIMIX process. * - * \return The SIMIX process + * @return The SIMIX process */ smx_actor_t SIMIX_process_self() { @@ -41,8 +44,8 @@ smx_actor_t SIMIX_process_self() } /** - * \brief Returns whether a process has pending asynchronous communications. - * \return true if there are asynchronous communications in this process + * @brief Returns whether a process has pending asynchronous communications. + * @return true if there are asynchronous communications in this process */ int SIMIX_process_has_pending_comms(smx_actor_t process) { @@ -50,14 +53,14 @@ int SIMIX_process_has_pending_comms(smx_actor_t process) { } /** - * \brief Moves a process to the list of processes to destroy. + * @brief Moves a process to the list of processes to destroy. */ void SIMIX_process_cleanup(smx_actor_t process) { - XBT_DEBUG("Cleanup process %s (%p), waiting synchro %p", process->name.c_str(), process, + XBT_DEBUG("Cleanup process %s (%p), waiting synchro %p", process->get_cname(), process, process->waiting_synchro.get()); - process->finished = true; + process->finished_ = true; SIMIX_process_on_exit_runall(process); /* Unregister from the kill timer if any */ @@ -66,7 +69,7 @@ void SIMIX_process_cleanup(smx_actor_t process) process->kill_timer = nullptr; } - xbt_os_mutex_acquire(simix_global->mutex); + simix_global->mutex.lock(); /* cancel non-blocking communications */ while (not process->comms.empty()) { @@ -99,18 +102,18 @@ void SIMIX_process_cleanup(smx_actor_t process) } XBT_DEBUG("%p should not be run anymore",process); - simix_global->process_list.erase(process->pid); - if (process->host && process->host_process_list_hook.is_linked()) - simgrid::xbt::intrusive_erase(process->host->extension()->process_list, *process); + simix_global->process_list.erase(process->pid_); + if (process->host_ && process->host_process_list_hook.is_linked()) + simgrid::xbt::intrusive_erase(process->host_->pimpl_->process_list_, *process); if (not process->smx_destroy_list_hook.is_linked()) { #if SIMGRID_HAVE_MC xbt_dynar_push_as(simix_global->dead_actors_vector, smx_actor_t, process); #endif simix_global->process_to_destroy.push_back(*process); } - process->context->iwannadie = 0; + process->context_->iwannadie = 0; - xbt_os_mutex_release(simix_global->mutex); + simix_global->mutex.unlock(); } /** @@ -138,10 +141,10 @@ namespace actor { ActorImpl::~ActorImpl() { - delete this->context; + delete this->context_; } -static int dying_daemon(void* exit_status, void* data) +static void dying_daemon(int /*exit_status*/, void* data) { std::vector* vect = &simix_global->daemons; @@ -151,14 +154,13 @@ static int dying_daemon(void* exit_status, void* data) /* Don't move the whole content since we don't really care about the order */ std::swap(*it, vect->back()); vect->pop_back(); - - return 0; } + /** This process will be terminated automatically when the last non-daemon process finishes */ void ActorImpl::daemonize() { - if (not daemon) { - daemon = true; + if (not daemon_) { + daemon_ = true; simix_global->daemons.push_back(this); SIMIX_process_on_exit(this, dying_daemon, this); } @@ -166,18 +168,10 @@ void ActorImpl::daemonize() simgrid::s4u::Actor* ActorImpl::restart() { - XBT_DEBUG("Restarting process %s on %s", get_cname(), host->get_cname()); + XBT_DEBUG("Restarting process %s on %s", get_cname(), host_->get_cname()); // retrieve the arguments of the old process - // FIXME: Factorize this with SIMIX_host_add_auto_restart_process ? - simgrid::kernel::actor::ProcessArg arg; - arg.name = name; - arg.code = code; - arg.host = host; - arg.kill_time = SIMIX_timer_get_date(kill_timer); - arg.data = userdata; - arg.properties = nullptr; - arg.auto_restart = auto_restart; + simgrid::kernel::actor::ProcessArg arg = ProcessArg(host_, this); // kill the old process SIMIX_process_kill(this, (this == simix_global->maestro_process) ? this : SIMIX_process_self()); @@ -185,22 +179,20 @@ simgrid::s4u::Actor* ActorImpl::restart() // start the new process ActorImpl* actor = simix_global->create_process_function(arg.name.c_str(), std::move(arg.code), arg.data, arg.host, arg.properties.get(), nullptr); - if (arg.kill_time >= 0) - simcall_process_set_kill_time(actor, arg.kill_time); - if (arg.auto_restart) - actor->auto_restart = arg.auto_restart; + simcall_process_set_kill_time(actor, arg.kill_time); + actor->set_auto_restart(arg.auto_restart); return actor->ciface(); } smx_activity_t ActorImpl::suspend(ActorImpl* issuer) { - if (suspended) { - XBT_DEBUG("Actor '%s' is already suspended", name.c_str()); + if (suspended_) { + XBT_DEBUG("Actor '%s' is already suspended", get_cname()); return nullptr; } - suspended = 1; + suspended_ = 1; /* If we are suspending another actor that is waiting on a sync, suspend its synchronization. */ if (this != issuer) { @@ -210,7 +202,7 @@ smx_activity_t ActorImpl::suspend(ActorImpl* issuer) return nullptr; } else { - return SIMIX_execution_start("suspend", 0.0, 1.0, 0.0, this->host); + return SIMIX_execution_start("suspend", 0.0, 1.0, 0.0, this->host_); } } @@ -218,14 +210,14 @@ void ActorImpl::resume() { XBT_IN("process = %p", this); - if (context->iwannadie) { + if (context_->iwannadie) { XBT_VERB("Ignoring request to suspend an actor that is currently dying."); return; } - if (not suspended) + if (not suspended_) return; - suspended = 0; + suspended_ = 0; /* resume the synchronization that was blocking the resumed actor. */ if (waiting_synchro) @@ -236,33 +228,33 @@ void ActorImpl::resume() smx_activity_t ActorImpl::sleep(double duration) { - if (host->is_off()) - THROWF(host_error, 0, "Host %s failed, you cannot sleep there.", host->get_cname()); + if (host_->is_off()) + THROWF(host_error, 0, "Host %s failed, you cannot sleep there.", host_->get_cname()); simgrid::kernel::activity::SleepImpl* synchro = new simgrid::kernel::activity::SleepImpl(); - synchro->host = host; - synchro->surf_sleep = host->pimpl_cpu->sleep(duration); + synchro->host = host_; + synchro->surf_sleep = host_->pimpl_cpu->sleep(duration); synchro->surf_sleep->set_data(synchro); XBT_DEBUG("Create sleep synchronization %p", synchro); return synchro; } -void create_maestro(std::function code) +void create_maestro(simgrid::simix::ActorCode code) { smx_actor_t maestro = nullptr; /* Create maestro process and initialize it */ maestro = new simgrid::kernel::actor::ActorImpl(); - maestro->pid = simix_process_maxpid++; - maestro->name = ""; - maestro->setUserData(nullptr); + maestro->pid_ = simix_process_maxpid++; + maestro->name_ = ""; + maestro->set_user_data(nullptr); if (not code) { - maestro->context = SIMIX_context_new(std::function(), nullptr, maestro); + maestro->context_ = SIMIX_context_new(simgrid::simix::ActorCode(), nullptr, maestro); } else { if (not simix_global) xbt_die("simix is not initialized, please call MSG_init first"); - maestro->context = simix_global->context_factory->create_maestro(code, maestro); + maestro->context_ = simix_global->context_factory->create_maestro(code, maestro); } maestro->simcall.issuer = maestro; @@ -280,22 +272,22 @@ void SIMIX_maestro_create(void (*code)(void*), void* data) } /** - * \brief Internal function to create a process. + * @brief Internal function to create a process. * * This function actually creates the process. * It may be called when a SIMCALL_PROCESS_CREATE simcall occurs, * or directly for SIMIX internal purposes. The sure thing is that it's called from maestro context. * - * \return the process created + * @return the process created */ -smx_actor_t SIMIX_process_create(const char* name, std::function code, void* data, simgrid::s4u::Host* host, - std::map* properties, smx_actor_t parent_process) +smx_actor_t SIMIX_process_create(std::string name, simgrid::simix::ActorCode code, void* data, simgrid::s4u::Host* host, + std::unordered_map* properties, smx_actor_t parent_process) { - XBT_DEBUG("Start process %s on host '%s'", name, host->get_cname()); + XBT_DEBUG("Start process %s on host '%s'", name.c_str(), host->get_cname()); if (host->is_off()) { - XBT_WARN("Cannot launch process '%s' on failed host '%s'", name, host->get_cname()); + XBT_WARN("Cannot launch process '%s' on failed host '%s'", name.c_str(), host->get_cname()); return nullptr; } @@ -303,37 +295,33 @@ smx_actor_t SIMIX_process_create(const char* name, std::function code, v xbt_assert(code && host != nullptr, "Invalid parameters"); /* Process data */ - process->pid = simix_process_maxpid++; - process->name = simgrid::xbt::string(name); - process->host = host; - process->setUserData(data); + process->pid_ = simix_process_maxpid++; + process->name_ = simgrid::xbt::string(name); + process->host_ = host; + process->set_user_data(data); process->simcall.issuer = process; if (parent_process != nullptr) { - process->ppid = parent_process->pid; + process->ppid_ = parent_process->pid_; } process->code = code; - XBT_VERB("Create context %s", process->name.c_str()); - process->context = SIMIX_context_new(std::move(code), simix_global->cleanup_process_function, process); + XBT_VERB("Create context %s", process->get_cname()); + process->context_ = SIMIX_context_new(std::move(code), simix_global->cleanup_process_function, process); /* Add properties */ if (properties != nullptr) for (auto const& kv : *properties) process->set_property(kv.first, kv.second); - /* Make sure that the process is initialized for simix, in case we are called from the Host::onCreation signal */ - if (host->extension() == nullptr) - host->extension_set(new simgrid::simix::Host()); - /* Add the process to its host's process list */ - host->extension()->process_list.push_back(*process); + host->pimpl_->process_list_.push_back(*process); - XBT_DEBUG("Start context '%s'", process->name.c_str()); + XBT_DEBUG("Start context '%s'", process->get_cname()); /* Now insert it in the global process list and in the process to run list */ - simix_global->process_list[process->pid] = process; + simix_global->process_list[process->pid_] = process; XBT_DEBUG("Inserting %s(%s) in the to_run list", process->get_cname(), host->get_cname()); simix_global->process_to_run.push_back(process); intrusive_ptr_add_ref(process); @@ -346,7 +334,7 @@ smx_actor_t SIMIX_process_create(const char* name, std::function code, v } smx_actor_t SIMIX_process_attach(const char* name, void* data, const char* hostname, - std::map* properties, smx_actor_t parent_process) + std::unordered_map* properties, smx_actor_t parent_process) { // This is mostly a copy/paste from SIMIX_process_new(), // it'd be nice to share some code between those two functions. @@ -361,23 +349,23 @@ smx_actor_t SIMIX_process_attach(const char* name, void* data, const char* hostn smx_actor_t process = new simgrid::kernel::actor::ActorImpl(); /* Process data */ - process->pid = simix_process_maxpid++; - process->name = std::string(name); - process->host = host; - process->setUserData(data); + process->pid_ = simix_process_maxpid++; + process->name_ = std::string(name); + process->host_ = host; + process->set_user_data(data); process->simcall.issuer = process; if (parent_process != nullptr) { - process->ppid = parent_process->pid; + process->ppid_ = parent_process->pid_; } /* Process data for auto-restart */ process->code = nullptr; - XBT_VERB("Create context %s", process->name.c_str()); + XBT_VERB("Create context %s", process->get_cname()); if (not simix_global) xbt_die("simix is not initialized, please call MSG_init first"); - process->context = simix_global->context_factory->attach(simix_global->cleanup_process_function, process); + process->context_ = simix_global->context_factory->attach(simix_global->cleanup_process_function, process); /* Add properties */ if (properties != nullptr) @@ -385,16 +373,15 @@ smx_actor_t SIMIX_process_attach(const char* name, void* data, const char* hostn process->set_property(kv.first, kv.second); /* Add the process to it's host process list */ - host->extension()->process_list.push_back(*process); + host->pimpl_->process_list_.push_back(*process); /* Now insert it in the global process list and in the process to run list */ - simix_global->process_list[process->pid] = process; + simix_global->process_list[process->pid_] = process; XBT_DEBUG("Inserting %s(%s) in the to_run list", process->get_cname(), host->get_cname()); simix_global->process_to_run.push_back(process); intrusive_ptr_add_ref(process); - - auto* context = dynamic_cast(process->context); + auto* context = dynamic_cast(process->context_); if (not context) xbt_die("Not a suitable context"); @@ -419,7 +406,7 @@ void SIMIX_process_detach() } /** - * \brief Executes the processes from simix_global->process_to_run. + * @brief Executes the processes from simix_global->process_to_run. * * The processes of simix_global->process_to_run are run (in parallel if * possible). On exit, simix_global->process_to_run is empty, and @@ -436,28 +423,29 @@ void SIMIX_process_runall() } /** - * \brief Internal function to kill a SIMIX process. + * @brief Internal function to kill a SIMIX process. * * This function may be called when a SIMCALL_PROCESS_KILL simcall occurs, * or directly for SIMIX internal purposes. * - * \param process poor victim - * \param issuer the process which has sent the PROCESS_KILL. Important to not schedule twice the same process. + * @param process poor victim + * @param issuer the process which has sent the PROCESS_KILL. Important to not schedule twice the same process. */ void SIMIX_process_kill(smx_actor_t process, smx_actor_t issuer) { - if (process->finished) { + if (process->finished_) { XBT_DEBUG("Ignoring request to kill process %s@%s that is already dead", process->get_cname(), - process->host->get_cname()); + process->host_->get_cname()); return; } - XBT_DEBUG("Actor '%s'@%s is killing actor '%s'@%s", issuer->get_cname(), issuer->host->get_cname(), - process->get_cname(), process->host->get_cname()); + XBT_DEBUG("Actor '%s'@%s is killing actor '%s'@%s", issuer->get_cname(), + (issuer->host_ == nullptr ? "(null)" : issuer->host_->get_cname()), process->get_cname(), + process->host_->get_cname()); - process->context->iwannadie = 1; - process->blocked = 0; - process->suspended = 0; + process->context_->iwannadie = 1; + process->blocked_ = 0; + process->suspended_ = 0; process->exception = nullptr; /* destroy the blocking synchro if any */ @@ -488,8 +476,9 @@ void SIMIX_process_kill(smx_actor_t process, smx_actor_t issuer) { if (i != process->waiting_synchro->simcalls_.end()) process->waiting_synchro->simcalls_.remove(&process->simcall); } else if (sleep != nullptr) { - SIMIX_process_sleep_destroy(process->waiting_synchro); - + if (sleep->surf_sleep) + sleep->surf_sleep->cancel(); + sleep->post(); } else if (raw != nullptr) { SIMIX_synchro_stop_waiting(process, &process->simcall); @@ -504,7 +493,7 @@ void SIMIX_process_kill(smx_actor_t process, smx_actor_t issuer) { if (std::find(begin(simix_global->process_to_run), end(simix_global->process_to_run), process) == end(simix_global->process_to_run) && process != issuer) { - XBT_DEBUG("Inserting %s in the to_run list", process->name.c_str()); + XBT_DEBUG("Inserting %s in the to_run list", process->get_cname()); simix_global->process_to_run.push_back(process); } } @@ -519,7 +508,7 @@ void SIMIX_process_kill(smx_actor_t process, smx_actor_t issuer) { void SIMIX_process_throw(smx_actor_t process, xbt_errcat_t cat, int value, const char *msg) { SMX_EXCEPTION(process, cat, value, msg); - if (process->suspended) + if (process->suspended_) process->resume(); /* cancel the blocking synchro if any */ @@ -544,7 +533,7 @@ void SIMIX_process_throw(smx_actor_t process, xbt_errcat_t cat, int value, const if (std::find(begin(simix_global->process_to_run), end(simix_global->process_to_run), process) == end(simix_global->process_to_run) && process != SIMIX_process_self()) { - XBT_DEBUG("Inserting %s in the to_run list", process->name.c_str()); + XBT_DEBUG("Inserting %s in the to_run list", process->get_cname()); simix_global->process_to_run.push_back(process); } } @@ -566,8 +555,8 @@ void SIMIX_process_throw(smx_actor_t process, xbt_errcat_t cat, int value, const } /** - * \brief Kills all running processes. - * \param issuer this one will not be killed + * @brief Kills all running processes. + * @param issuer this one will not be killed */ void SIMIX_process_killall(smx_actor_t issuer) { @@ -579,9 +568,9 @@ void SIMIX_process_killall(smx_actor_t issuer) void SIMIX_process_change_host(smx_actor_t actor, sg_host_t dest) { xbt_assert((actor != nullptr), "Invalid parameters"); - simgrid::xbt::intrusive_erase(actor->host->extension()->process_list, *actor); - actor->host = dest; - dest->extension()->process_list.push_back(*actor); + simgrid::xbt::intrusive_erase(actor->host_->pimpl_->process_list_, *actor); + actor->host_ = dest; + dest->pimpl_->process_list_.push_back(*actor); } void simcall_HANDLER_process_suspend(smx_simcall_t simcall, smx_actor_t process) @@ -614,12 +603,12 @@ void* SIMIX_process_self_get_data() if (not self) { return nullptr; } - return self->getUserData(); + return self->get_user_data(); } void SIMIX_process_self_set_data(void *data) { - SIMIX_process_self()->setUserData(data); + SIMIX_process_self()->set_user_data(data); } @@ -631,12 +620,12 @@ const char* SIMIX_process_self_get_name() { if (process == nullptr || process == simix_global->maestro_process) return "maestro"; - return process->name.c_str(); + return process->get_cname(); } void simcall_HANDLER_process_join(smx_simcall_t simcall, smx_actor_t process, double timeout) { - if (process->finished) { + if (process->finished_) { // The joined process is already finished, just wake up the issuer process right away simcall_process_sleep__set__result(simcall, SIMIX_DONE); SIMIX_simcall_answer(simcall); @@ -652,12 +641,11 @@ smx_activity_t SIMIX_process_join(smx_actor_t issuer, smx_actor_t process, doubl smx_activity_t res = issuer->sleep(timeout); intrusive_ptr_add_ref(res.get()); SIMIX_process_on_exit(process, - [](void*, void* arg) { + [](int, void* arg) { auto sleep = static_cast(arg); if (sleep->surf_sleep) sleep->surf_sleep->finish(simgrid::kernel::resource::Action::State::FINISHED); intrusive_ptr_release(sleep); - return 0; }, res.get()); return res; @@ -689,41 +677,39 @@ void SIMIX_process_sleep_destroy(smx_activity_t synchro) } /** - * \brief Calling this function makes the process to yield. + * @brief Calling this function makes the process to yield. * * Only the current process can call this function, giving back the control to maestro. * - * \param self the current process + * @param self the current process */ void SIMIX_process_yield(smx_actor_t self) { XBT_DEBUG("Yield actor '%s'", self->get_cname()); /* Go into sleep and return control to maestro */ - self->context->suspend(); + self->context_->suspend(); /* Ok, maestro returned control to us */ - XBT_DEBUG("Control returned to me: '%s'", self->name.c_str()); + XBT_DEBUG("Control returned to me: '%s'", self->get_cname()); - if (self->context->iwannadie){ + if (self->context_->iwannadie) { XBT_DEBUG("I wanna die!"); - self->finished = true; + self->finished_ = true; /* execute the on_exit functions */ SIMIX_process_on_exit_runall(self); /* Add the process to the list of process to restart, only if the host is down */ - if (self->auto_restart && self->host->is_off()) { - SIMIX_host_add_auto_restart_process(self->host, self->get_cname(), self->code, self->getUserData(), - SIMIX_timer_get_date(self->kill_timer), self->get_properties(), - self->auto_restart); + if (self->auto_restart_ && self->host_->is_off()) { + SIMIX_host_add_auto_restart_process(self->host_, self); } - XBT_DEBUG("Process %s@%s is dead", self->get_cname(), self->host->get_cname()); - self->context->stop(); + XBT_DEBUG("Process %s@%s is dead", self->get_cname(), self->host_->get_cname()); + self->context_->stop(); } - if (self->suspended) { + if (self->suspended_) { XBT_DEBUG("Hey! I'm suspended."); xbt_assert(self->exception != nullptr, "Gasp! This exception may be lost by subsequent calls."); - self->suspended = 0; + self->suspended_ = 0; self->suspend(self); } @@ -734,7 +720,7 @@ void SIMIX_process_yield(smx_actor_t self) std::rethrow_exception(std::move(exception)); } - if (SMPI_switch_data_segment && not self->finished) { + if (SMPI_switch_data_segment && not self->finished_) { SMPI_switch_data_segment(self->iface()); } } @@ -754,53 +740,47 @@ smx_actor_t SIMIX_process_from_PID(aid_t PID) void SIMIX_process_on_exit_runall(smx_actor_t process) { simgrid::s4u::Actor::on_destruction(process->iface()); - smx_process_exit_status_t exit_status = (process->context->iwannadie) ? SMX_EXIT_FAILURE : SMX_EXIT_SUCCESS; + smx_process_exit_status_t exit_status = (process->context_->iwannadie) ? SMX_EXIT_FAILURE : SMX_EXIT_SUCCESS; while (not process->on_exit.empty()) { s_smx_process_exit_fun_t exit_fun = process->on_exit.back(); process->on_exit.pop_back(); - (exit_fun.fun)((void*)exit_status, exit_fun.arg); + (exit_fun.fun)(exit_status, exit_fun.arg); } } -void SIMIX_process_on_exit(smx_actor_t process, int_f_pvoid_pvoid_t fun, void *data) { - xbt_assert(process, "current process not found: are you in maestro context ?"); - - s_smx_process_exit_fun_t exit_fun = {fun, data}; - - process->on_exit.push_back(exit_fun); +void SIMIX_process_on_exit(smx_actor_t process, int_f_pvoid_pvoid_t fun, void* data) +{ + SIMIX_process_on_exit(process, [fun](int a, void* b) { fun((void*)(intptr_t)a, b); }, data); } -/** - * \brief Sets the auto-restart status of the process. - * If set to 1, the process will be automatically restarted when its host comes back. - */ -void SIMIX_process_auto_restart_set(smx_actor_t process, int auto_restart) { - process->auto_restart = auto_restart; +void SIMIX_process_on_exit(smx_actor_t process, std::function fun, void* data) +{ + xbt_assert(process, "current process not found: are you in maestro context ?"); + + process->on_exit.emplace_back(s_smx_process_exit_fun_t{fun, data}); } /** @brief Restart a process, starting it again from the beginning. */ /** - * \ingroup simix_process_management - * \brief Creates and runs a new SIMIX process. + * @ingroup simix_process_management + * @brief Creates and runs a new SIMIX process. * * The structure and the corresponding thread are created and put in the list of ready processes. * - * \param name a name for the process. It is for user-level information and can be nullptr. - * \param code the main function of the process - * \param data a pointer to any data one may want to attach to the new object. It is for user-level information and can + * @param name a name for the process. It is for user-level information and can be nullptr. + * @param code the main function of the process + * @param data a pointer to any data one may want to attach to the new object. It is for user-level information and can * be nullptr. * It can be retrieved with the method ActorImpl::getUserData(). - * \param host where the new agent is executed. - * \param argc first argument passed to \a code - * \param argv second argument passed to \a code - * \param properties the properties of the process + * @param host where the new agent is executed. + * @param argc first argument passed to @a code + * @param argv second argument passed to @a code + * @param properties the properties of the process */ -smx_actor_t simcall_process_create(const char* name, xbt_main_func_t code, void* data, sg_host_t host, int argc, - char** argv, std::map* properties) +smx_actor_t simcall_process_create(std::string name, xbt_main_func_t code, void* data, sg_host_t host, int argc, + char** argv, std::unordered_map* properties) { - if (name == nullptr) - name = ""; - auto wrapped_code = simgrid::xbt::wrapMain(code, argc, argv); + auto wrapped_code = simgrid::xbt::wrap_main(code, argc, argv); for (int i = 0; i != argc; ++i) xbt_free(argv[i]); xbt_free(argv); @@ -808,11 +788,9 @@ smx_actor_t simcall_process_create(const char* name, xbt_main_func_t code, void* return res; } -smx_actor_t simcall_process_create(const char* name, std::function code, void* data, sg_host_t host, - std::map* properties) +smx_actor_t simcall_process_create(std::string name, simgrid::simix::ActorCode code, void* data, sg_host_t host, + std::unordered_map* properties) { - if (name == nullptr) - name = ""; smx_actor_t self = SIMIX_process_self(); return simgrid::simix::simcall([name, code, data, host, properties, self] { return SIMIX_process_create(name, std::move(code), data, host, properties, self);