X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/1fbb18e000b17e77468b3e0a71017952803454f3..42e69c5d43675587aae0bb367b8bf0746f6be13a:/src/xbt/backtrace_linux.c diff --git a/src/xbt/backtrace_linux.c b/src/xbt/backtrace_linux.c index af6621a216..d7e6d49292 100644 --- a/src/xbt/backtrace_linux.c +++ b/src/xbt/backtrace_linux.c @@ -80,7 +80,8 @@ void xbt_backtrace_current(xbt_ex_t * e) e->used = backtrace((void **) e->bt, XBT_BACKTRACE_SIZE); if (e->used == 0) { fprintf(stderr, "The backtrace() function failed, which probably means that the memory is exhausted. Here is a crude dump of the exception that I was trying to build:"); - fprintf(stderr, "%s:%s(%d) [%s:%d] %s", e->host,e->procname,e->pid, e->file,e->line,e->msg); + fprintf(stderr, "%s(%d) [%s:%d] %s", + e->procname, e->pid, e->file, e->line, e->msg); fprintf(stderr, "Bailing out now since there is nothing I can do without a decent amount of memory. Please go fix the memleaks\n"); exit(1); } @@ -116,7 +117,7 @@ void xbt_ex_setup_backtrace(xbt_ex_t * e) //FIXME: This code could be greatly im e->bt_strings = NULL; - if (!xbt_binary_name) /* no binary name, nothing to do */ + if (xbt_binary_name == NULL) /* no binary name, nothing to do */ return; if (e->used <= 1) @@ -200,22 +201,21 @@ void xbt_ex_setup_backtrace(xbt_ex_t * e) //FIXME: This code could be greatly im } for (i = 0; i < e->used; i++) { - char *fgets_res; XBT_DEBUG("Looking for symbol %d, addr = '%s'", i, addrs[i]); - fgets_res = fgets(line_func, 1024, pipe); - if (fgets_res == NULL) - THROWF(system_error, 0, - "Cannot run fgets to look for symbol %d, addr %s", i, - addrs[i]); - line_func[strlen(line_func) - 1] = '\0'; - fgets_res = fgets(line_pos, 1024, pipe); - if (fgets_res == NULL) - THROWF(system_error, 0, - "Cannot run fgets to look for symbol %d, addr %s", i, - addrs[i]); - line_pos[strlen(line_pos) - 1] = '\0'; - - if (strcmp("??", line_func)) { + if (fgets(line_func, 1024, pipe)) { + line_func[strlen(line_func) - 1] = '\0'; + } else { + XBT_VERB("Cannot run fgets to look for symbol %d, addr %s", i, addrs[i]); + strcpy(line_func, "???"); + } + if (fgets(line_pos, 1024, pipe)) { + line_pos[strlen(line_pos) - 1] = '\0'; + } else { + XBT_VERB("Cannot run fgets to look for symbol %d, addr %s", i, addrs[i]); + strcpy(line_pos, backtrace_syms[i]); + } + + if (strcmp("??", line_func) != 0) { XBT_DEBUG("Found static symbol %s() at %s", line_func, line_pos); e->bt_strings[i] = bprintf("** In %s() at %s", line_func, line_pos); @@ -307,16 +307,18 @@ void xbt_ex_setup_backtrace(xbt_ex_t * e) //FIXME: This code could be greatly im if (!subpipe) { xbt_die("Cannot fork addr2line to display the backtrace"); } - fgets_res = fgets(line_func, 1024, subpipe); - if (fgets_res == NULL) - THROWF(system_error, 0, "Cannot read result of subcommand %s", - subcmd); - line_func[strlen(line_func) - 1] = '\0'; - fgets_res = fgets(line_pos, 1024, subpipe); - if (fgets_res == NULL) - THROWF(system_error, 0, "Cannot read result of subcommand %s", - subcmd); - line_pos[strlen(line_pos) - 1] = '\0'; + if (fgets(line_func, 1024, subpipe)) { + line_func[strlen(line_func) - 1] = '\0'; + } else { + XBT_VERB("Cannot read result of subcommand %s", subcmd); + strcpy(line_func, "???"); + } + if (fgets(line_pos, 1024, subpipe)) { + line_pos[strlen(line_pos) - 1] = '\0'; + } else { + XBT_VERB("Cannot read result of subcommand %s", subcmd); + strcpy(line_pos, backtrace_syms[i]); + } pclose(subpipe); free(subcmd); }