X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/15680fe35081dbdd307c437b750dd2da906ba9f8..48d16e98696450e0dc1ae85cfb8f84b41d15b409:/src/s4u/s4u_Storage.cpp

diff --git a/src/s4u/s4u_Storage.cpp b/src/s4u/s4u_Storage.cpp
index 60fcd11b1e..78cfaf6c44 100644
--- a/src/s4u/s4u_Storage.cpp
+++ b/src/s4u/s4u_Storage.cpp
@@ -21,17 +21,17 @@ simgrid::xbt::signal<void(s4u::Storage&)> Storage::on_creation;
 simgrid::xbt::signal<void(s4u::Storage&)> Storage::on_destruction;
 simgrid::xbt::signal<void(s4u::Storage&)> Storage::on_state_change;
 
-Storage::Storage(std::string name, surf::StorageImpl* pimpl) : pimpl_(pimpl), name_(name)
+Storage::Storage(std::string name, surf::StorageImpl* pimpl) : pimpl_(pimpl), name_(std::move(name))
 {
-  simgrid::s4u::Engine::get_instance()->storage_register(name, this);
+  simgrid::s4u::Engine::get_instance()->storage_register(name_, this);
 }
 
-Storage* Storage::by_name(std::string name)
+Storage* Storage::by_name(const std::string& name)
 {
   return Engine::get_instance()->storage_by_name(name);
 }
 
-Storage* Storage::by_name_or_null(std::string name)
+Storage* Storage::by_name_or_null(const std::string& name)
 {
   return Engine::get_instance()->storage_by_name_or_null(name);
 }
@@ -46,12 +46,12 @@ std::unordered_map<std::string, std::string>* Storage::get_properties()
   return simgrid::simix::simcall([this] { return pimpl_->get_properties(); });
 }
 
-const char* Storage::get_property(std::string key)
+const char* Storage::get_property(const std::string& key)
 {
   return this->pimpl_->get_property(key);
 }
 
-void Storage::set_property(std::string key, std::string value)
+void Storage::set_property(const std::string& key, std::string value)
 {
   simgrid::simix::simcall([this, key, value] { this->pimpl_->set_property(key, value); });
 }