X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/0ce348a43e3205b61d11024b3f0218d5b79293e6..5ed37babb2fa9097abe82df299c0aa259ed84d5a:/src/smpi/include/smpi_group.hpp

diff --git a/src/smpi/include/smpi_group.hpp b/src/smpi/include/smpi_group.hpp
index 73803641d1..a3ba4e4321 100644
--- a/src/smpi/include/smpi_group.hpp
+++ b/src/smpi/include/smpi_group.hpp
@@ -1,4 +1,4 @@
-/* Copyright (c) 2010, 2013-2017. The SimGrid Team.
+/* Copyright (c) 2010-2023. The SimGrid Team.
  * All rights reserved.                                                     */
 
 /* This program is free software; you can redistribute it and/or modify it
@@ -8,41 +8,47 @@
 #define SMPI_GROUP_HPP_INCLUDED
 
 #include "smpi_f2c.hpp"
+#include <smpi/smpi.h>
+#include <map>
+#include <vector>
 
-namespace simgrid{
-namespace smpi{
+namespace simgrid::smpi {
 
 class Group : public F2C{
-  private:
-    int size_;
-    int *rank_to_index_map_;
-    std::unordered_map<int, int> index_to_rank_map_;
-    int refcount_;
-  public:
-    explicit Group();
-    explicit Group(int size);
-    explicit Group(Group* origin);
-    ~Group();
-
-    void set_mapping(int index, int rank);
-    int index(int rank);
-    int rank(int index);
-    void ref();
-    static void unref(MPI_Group group);
-    int size();
-    int compare(MPI_Group group2);
-    int incl(int n, int* ranks, MPI_Group* newgroup);
-    int excl(int n, int *ranks, MPI_Group * newgroup);
-    int group_union(MPI_Group group2, MPI_Group* newgroup);
-    int intersection(MPI_Group group2, MPI_Group* newgroup);
-    int difference(MPI_Group group2, MPI_Group* newgroup);
-    int range_incl(int n, int ranges[][3], MPI_Group * newgroup);
-    int range_excl(int n, int ranges[][3], MPI_Group * newgroup);
-
-    static Group* f2c(int id);
-
+  /* This is actually a map from int to aid_t. We could use std::map here, but looking up a value there costs
+   * O(log(n)). For a vector, this costs O(1). We hence go with the vector.
+   */
+  std::vector<aid_t> rank_to_pid_map_;
+  std::vector<int> pid_to_rank_map_;
+
+  int refcount_ = 1; /* refcount_: start > 0 so that this group never gets freed */
+
+  int incl(const std::vector<int>& ranks, MPI_Group* newgroup) const;
+  int excl(const std::vector<bool>& excl_map, MPI_Group* newgroup) const;
+
+public:
+  Group() = default;
+  explicit Group(int size) : rank_to_pid_map_(size, -1), pid_to_rank_map_(size, MPI_UNDEFINED) {}
+  explicit Group(const Group* origin);
+
+  void set_mapping(aid_t pid, int rank);
+  int rank(aid_t pid) const;
+  aid_t actor(int rank) const;
+  std::string name() const override { return "MPI_Group"; }
+  void ref();
+  static void unref(MPI_Group group);
+  int size() const { return static_cast<int>(rank_to_pid_map_.size()); }
+  int compare(const Group* group2) const;
+  int incl(int n, const int* ranks, MPI_Group* newgroup) const;
+  int excl(int n, const int* ranks, MPI_Group* newgroup) const;
+  int group_union(const Group* group2, MPI_Group* newgroup) const;
+  int intersection(const Group* group2, MPI_Group* newgroup) const;
+  int difference(const Group* group2, MPI_Group* newgroup) const;
+  int range_incl(int n, const int ranges[][3], MPI_Group* newgroup) const;
+  int range_excl(int n, const int ranges[][3], MPI_Group* newgroup) const;
+
+  static Group* f2c(int id);
 };
-}
-}
+} // namespace simgrid::smpi
 
 #endif