X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/0a9b604048c4568bb2c2709f3b824da719a7e737..ab4d43a39df33bb5f24c3b2cc6d576130b16a649:/src/xbt/config.cpp diff --git a/src/xbt/config.cpp b/src/xbt/config.cpp index b705a39410..84c6b7b10a 100644 --- a/src/xbt/config.cpp +++ b/src/xbt/config.cpp @@ -1,40 +1,40 @@ -/* Copyright (c) 2004-2014,2016. The SimGrid Team. - * All rights reserved. */ +/* Copyright (c) 2004-2018. The SimGrid Team. All rights reserved. */ -#include +/* This program is free software; you can redistribute it and/or modify it + * under the terms of the license (GNU LGPL) which comes with this package. */ +#include + +#include #include #include #include #include +#include #include #include -#include +#include #include +#include +#include -#include -#include +#include "simgrid/sg_config.hpp" +#include "xbt/dynar.h" +#include "xbt/log.h" #include "xbt/misc.h" #include "xbt/sysdep.h" -#include "xbt/log.h" -#include "xbt/ex.h" -#include "xbt/dynar.h" -#include "xbt/dict.h" - -// ***** +#include +#include +#include XBT_LOG_NEW_DEFAULT_SUBCATEGORY(xbt_cfg, xbt, "configuration support"); -XBT_EXPORT_NO_IMPORT(xbt_cfg_t) simgrid_config = NULL; +XBT_EXPORT_NO_IMPORT xbt_cfg_t simgrid_config = nullptr; namespace simgrid { namespace config { -missing_key_error::~missing_key_error() {} - -class Config; - namespace { const char* true_values[] = { @@ -44,18 +44,18 @@ const char* false_values[] = { "no", "off", "false", "0" }; -static bool parseBool(const char* value) +static bool parse_bool(const char* value) { - for (const char* true_value : true_values) + for (const char* const& true_value : true_values) if (std::strcmp(true_value, value) == 0) return true; - for (const char* false_value : false_values) + for (const char* const& false_value : false_values) if (std::strcmp(false_value, value) == 0) return false; throw std::range_error("not a boolean"); } -static double parseDouble(const char* value) +static double parse_double(const char* value) { char* end; errno = 0; @@ -70,7 +70,7 @@ static double parseDouble(const char* value) return res; } -static long int parseLong(const char* value) +static long int parse_long(const char* value) { char* end; errno = 0; @@ -91,34 +91,38 @@ static long int parseLong(const char* value) // ***** ConfigType ***** /// A trait which define possible options types: -template struct ConfigType; +template class ConfigType; -template<> struct ConfigType { +template <> class ConfigType { +public: static constexpr const char* type_name = "int"; static inline double parse(const char* value) { - return parseLong(value); + return parse_long(value); } }; -template<> struct ConfigType { +template <> class ConfigType { +public: static constexpr const char* type_name = "double"; static inline double parse(const char* value) { - return parseDouble(value); + return parse_double(value); } }; -template<> struct ConfigType { +template <> class ConfigType { +public: static constexpr const char* type_name = "string"; static inline std::string parse(const char* value) { return std::string(value); } }; -template<> struct ConfigType { +template <> class ConfigType { +public: static constexpr const char* type_name = "boolean"; static inline bool parse(const char* value) { - return parseBool(value); + return parse_bool(value); } }; @@ -130,49 +134,44 @@ template class TypedConfigurationElement; // **** ConfigurationElement **** class ConfigurationElement { -protected: +private: std::string key; std::string desc; bool isdefault = true; public: - /* Callback */ xbt_cfg_cb_t old_callback = nullptr; - ConfigurationElement(const char* key, const char* desc) - : key(key ? key : ""), desc(desc ? desc : "") {} + ConfigurationElement(const char* key, const char* desc) : key(key ? key : ""), desc(desc ? desc : "") {} ConfigurationElement(const char* key, const char* desc, xbt_cfg_cb_t cb) : key(key ? key : ""), desc(desc ? desc : ""), old_callback(cb) {} - virtual ~ConfigurationElement(); + virtual ~ConfigurationElement() = default; - virtual std::string getStringValue() = 0; - virtual void setStringValue(const char* value) = 0; - virtual const char* getTypeName() = 0; + virtual std::string get_string_value() = 0; + virtual void set_string_value(const char* value) = 0; + virtual const char* get_type_name() = 0; - template - T const& getValue() const + template T const& get_value() const { - return dynamic_cast&>(*this).getValue(); + return dynamic_cast&>(*this).get_value(); } - template - void setValue(T value) + template void set_value(T value) { - dynamic_cast&>(*this).setValue(std::move(value)); + dynamic_cast&>(*this).set_value(std::move(value)); } - template - void setDefaultValue(T value) + template void set_default_value(T value) { - dynamic_cast&>(*this).setDefaultValue(std::move(value)); + dynamic_cast&>(*this).set_default_value(std::move(value)); } - bool isDefault() const { return isdefault; } + void unset_default() { isdefault = false; } + bool is_default() const { return isdefault; } - std::string const& getDescription() const { return desc; } + std::string const& get_description() const { return desc; } + std::string const& get_key() const { return key; } }; -ConfigurationElement::~ConfigurationElement() {} - // **** TypedConfigurationElement **** // TODO, could we use boost::any with some Type* reference? @@ -186,73 +185,64 @@ public: TypedConfigurationElement(const char* key, const char* desc, T value = T()) : ConfigurationElement(key, desc), content(std::move(value)) {} - TypedConfigurationElement(const char* key, const char* desc, T value, - xbt_cfg_cb_t cb) - : ConfigurationElement(key, desc, cb), content(std::move(value)) + TypedConfigurationElement(const char* key, const char* desc, T value, xbt_cfg_cb_t cb) + : ConfigurationElement(key, desc, cb), content(std::move(value)) {} - TypedConfigurationElement(const char* key, const char* desc, T value, - std::function callback) - : ConfigurationElement(key, desc), content(std::move(value)), - callback(std::move(callback)) + TypedConfigurationElement(const char* key, const char* desc, T value, std::function callback) + : ConfigurationElement(key, desc), content(std::move(value)), callback(std::move(callback)) {} - ~TypedConfigurationElement() override; + ~TypedConfigurationElement() = default; - std::string getStringValue() override; - const char* getTypeName() override; - void setStringValue(const char* value) override; + std::string get_string_value() override; + const char* get_type_name() override; + void set_string_value(const char* value) override; void update() { if (old_callback) - this->old_callback(key.c_str()); + this->old_callback(get_key().c_str()); if (this->callback) this->callback(this->content); } - T const& getValue() const { return content; } + T const& get_value() const { return content; } - void setValue(T value) + void set_value(T value) { this->content = std::move(value); this->update(); + this->unset_default(); } - void setDefaultValue(T value) + void set_default_value(T value) { - if (this->isdefault) { + if (this->is_default()) { this->content = std::move(value); this->update(); } else { - XBT_DEBUG("Do not override configuration variable '%s' with value '%s'" - " because it was already set.", key.c_str(), to_string(value).c_str()); + XBT_DEBUG("Do not override configuration variable '%s' with value '%s' because it was already set.", + get_key().c_str(), to_string(value).c_str()); } } }; -template -std::string TypedConfigurationElement::getStringValue() // override +template std::string TypedConfigurationElement::get_string_value() // override { return to_string(content); } -template -void TypedConfigurationElement::setStringValue(const char* value) // override +template void TypedConfigurationElement::set_string_value(const char* value) // override { this->content = ConfigType::parse(value); - this->isdefault = false; + this->unset_default(); this->update(); } -template -const char* TypedConfigurationElement::getTypeName() // override +template const char* TypedConfigurationElement::get_type_name() // override { return ConfigType::type_name; } -template -TypedConfigurationElement::~TypedConfigurationElement() -{} - } // end of anonymous namespace // **** Config **** @@ -260,9 +250,10 @@ TypedConfigurationElement::~TypedConfigurationElement() class Config { private: // name -> ConfigElement: - xbt_dict_t options; - // alias -> xbt_dict_elm_t from options: - xbt_dict_t aliases; + std::map options; + // alias -> ConfigElement from options: + std::map aliases; + bool warn_for_aliases = true; public: Config(); @@ -273,84 +264,69 @@ public: Config& operator=(Config const&) = delete; ConfigurationElement& operator[](const char* name); - template - TypedConfigurationElement& getTyped(const char* name); void alias(const char* realname, const char* aliasname); - template - simgrid::config::TypedConfigurationElement* - registerOption(const char* name, A&&... a) + template + simgrid::config::TypedConfigurationElement* register_option(const char* name, A&&... a) { - xbt_assert(xbt_dict_get_or_null(this->options, name) == nullptr, - "Refusing to register the config element '%s' twice.", name); - TypedConfigurationElement* variable = - new TypedConfigurationElement(name, std::forward(a)...); - XBT_DEBUG("Register cfg elm %s (%s) of type %s @%p in set %p)", - name, - variable->getDescription().c_str(), - variable->getTypeName(), variable, this); - xbt_dict_set(this->options, name, variable, NULL); + xbt_assert(options.find(name) == options.end(), "Refusing to register the config element '%s' twice.", name); + TypedConfigurationElement* variable = new TypedConfigurationElement(name, std::forward(a)...); + XBT_DEBUG("Register cfg elm %s (%s) of type %s @%p in set %p)", name, variable->get_description().c_str(), + variable->get_type_name(), variable, this); + options.insert({name, variable}); variable->update(); return variable; } // Debug: void dump(const char *name, const char *indent); - void showAliases(); + void show_aliases(); void help(); protected: - xbt_dictelm_t getDictElement(const char* name); + ConfigurationElement* get_dict_element(const char* name); }; -/* Internal stuff used in cache to free a variable */ -static void xbt_cfgelm_free(void *data) +Config::Config() { - if (data) - delete (simgrid::config::ConfigurationElement*) data; + atexit(&sg_config_finalize); } - -Config::Config() : - options(xbt_dict_new_homogeneous(xbt_cfgelm_free)), - aliases(xbt_dict_new_homogeneous(NULL)) -{} - Config::~Config() { XBT_DEBUG("Frees cfg set %p", this); - xbt_dict_free(&this->options); - xbt_dict_free(&this->aliases); -} - -inline -xbt_dictelm_t Config::getDictElement(const char* name) -{ - // We are interested in the options dictelm: - xbt_dictelm_t res = xbt_dict_get_elm_or_null(options, name); - if (res) - return res; - // The aliases dict stores pointers to the options dictelm: - res = (xbt_dictelm_t) xbt_dict_get_or_null(aliases, name); - if (res) - XBT_INFO("Option %s has been renamed to %s. Consider switching.", name, res->key); - return res; + for (auto const& elm : options) + delete elm.second; +} + +inline ConfigurationElement* Config::get_dict_element(const char* name) +{ + auto opt = options.find(name); + if (opt != options.end()) { + return opt->second; + } else { + auto als = aliases.find(name); + if (als != aliases.end()) { + ConfigurationElement* res = als->second; + if (warn_for_aliases) + XBT_INFO("Option %s has been renamed to %s. Consider switching.", name, res->get_key().c_str()); + return res; + } else { + THROWF(not_found_error, 0, "Bad config key: %s", name); + } + } } -inline -ConfigurationElement& Config::operator[](const char* name) +inline ConfigurationElement& Config::operator[](const char* name) { - xbt_dictelm_t elm = getDictElement(name); - if (elm == nullptr) - throw simgrid::config::missing_key_error(std::string("Bad config key, ") + name); - return *(ConfigurationElement*)elm->content; + return *(get_dict_element(name)); } void Config::alias(const char* realname, const char* aliasname) { - xbt_assert(this->getDictElement(aliasname) == nullptr, "Alias '%s' already.", aliasname); - xbt_dictelm_t element = this->getDictElement(realname); + xbt_assert(aliases.find(aliasname) == aliases.end(), "Alias '%s' already.", aliasname); + ConfigurationElement* element = this->get_dict_element(realname); xbt_assert(element, "Cannot define an alias to the non-existing option '%s'.", realname); - xbt_dict_set(this->aliases, aliasname, element, NULL); + this->aliases.insert({aliasname, element}); } /** @brief Dump a config set for debuging purpose @@ -360,112 +336,83 @@ void Config::alias(const char* realname, const char* aliasname) */ void Config::dump(const char *name, const char *indent) { - xbt_dict_t dict = this->options; - xbt_dict_cursor_t cursor = NULL; - simgrid::config::ConfigurationElement* variable = NULL; - char *key = NULL; - if (name) printf("%s>> Dumping of the config set '%s':\n", indent, name); - xbt_dict_foreach(dict, cursor, key, variable) - printf("%s %s: ()%s) %s", indent, key, - variable->getTypeName(), - variable->getStringValue().c_str()); + for (auto const& elm : options) + printf("%s %s: ()%s) %s", indent, elm.first.c_str(), elm.second->get_type_name(), + elm.second->get_string_value().c_str()); if (name) printf("%s<< End of the config set '%s'\n", indent, name); fflush(stdout); - - xbt_dict_cursor_free(&cursor); } -/** @brief Displays the declared aliases and their description */ -void Config::showAliases() +/** @brief Displays the declared aliases and their replacement */ +void Config::show_aliases() { - xbt_dict_cursor_t dict_cursor; - unsigned int dynar_cursor; - xbt_dictelm_t dictel; - char *name; - xbt_dynar_t names = xbt_dynar_new(sizeof(char *), NULL); - - xbt_dict_foreach(this->aliases, dict_cursor, name, dictel) - xbt_dynar_push(names, &name); - xbt_dynar_sort_strings(names); - - xbt_dynar_foreach(names, dynar_cursor, name) - printf(" %s: %s\n", name, (*this)[name].getDescription().c_str()); + for (auto const& elm : aliases) + printf(" %-40s %s\n", elm.first.c_str(), elm.second->get_key().c_str()); } /** @brief Displays the declared options and their description */ void Config::help() { - xbt_dict_cursor_t dict_cursor; - unsigned int dynar_cursor; - simgrid::config::ConfigurationElement* variable; - char *name; - xbt_dynar_t names = xbt_dynar_new(sizeof(char *), NULL); - - xbt_dict_foreach(this->options, dict_cursor, name, variable) - xbt_dynar_push(names, &name); - xbt_dynar_sort_strings(names); - - xbt_dynar_foreach(names, dynar_cursor, name) { - variable = (simgrid::config::ConfigurationElement*) xbt_dict_get(this->options, name); - printf(" %s: %s\n", name, variable->getDescription().c_str()); - printf(" Type: %s; ", variable->getTypeName()); - printf("Current value: %s\n", variable->getStringValue().c_str()); + for (auto const& elm : options) { + simgrid::config::ConfigurationElement* variable = this->options.at(elm.first); + printf(" %s: %s\n", elm.first.c_str(), variable->get_description().c_str()); + printf(" Type: %s; ", variable->get_type_name()); + printf("Current value: %s\n", variable->get_string_value().c_str()); } - xbt_dynar_free(&names); } -// ***** getConfig ***** +// ***** get_config ***** -template -XBT_PUBLIC(T const&) getConfig(const char* name) +template XBT_PUBLIC T const& get_config(const char* name) { - return (*simgrid_config)[name].getValue(); + return (*simgrid_config)[name].get_value(); } -template XBT_PUBLIC(int const&) getConfig(const char* name); -template XBT_PUBLIC(double const&) getConfig(const char* name); -template XBT_PUBLIC(bool const&) getConfig(const char* name); -template XBT_PUBLIC(std::string const&) getConfig(const char* name); +template XBT_PUBLIC int const& get_config(const char* name); +template XBT_PUBLIC double const& get_config(const char* name); +template XBT_PUBLIC bool const& get_config(const char* name); +template XBT_PUBLIC std::string const& get_config(const char* name); // ***** alias ***** -void alias(const char* realname, const char* aliasname) +void alias(const char* realname, std::initializer_list aliases) { - simgrid_config->alias(realname, aliasname); + for (auto const& aliasname : aliases) + simgrid_config->alias(realname, aliasname); } -// ***** declareFlag ***** +// ***** declare_flag ***** -template -XBT_PUBLIC(void) declareFlag(const char* name, const char* description, - T value, std::function callback) +template +XBT_PUBLIC void declare_flag(const char* name, const char* description, T value, std::function callback) { - if (simgrid_config == NULL) + if (simgrid_config == nullptr) simgrid_config = xbt_cfg_new(); - simgrid_config->registerOption( - name, description, std::move(value), std::move(callback)); + simgrid_config->register_option(name, description, std::move(value), std::move(callback)); } -template XBT_PUBLIC(void) declareFlag(const char* name, - const char* description, int value, std::function callback); -template XBT_PUBLIC(void) declareFlag(const char* name, - const char* description, double value, std::function callback); -template XBT_PUBLIC(void) declareFlag(const char* name, - const char* description, bool value, std::function callback); -template XBT_PUBLIC(void) declareFlag(const char* name, - const char* description, std::string value, std::function callback); - +template XBT_PUBLIC void declare_flag(const char* name, const char* description, int value, + std::function callback); +template XBT_PUBLIC void declare_flag(const char* name, const char* description, double value, + std::function callback); +template XBT_PUBLIC void declare_flag(const char* name, const char* description, bool value, + std::function callback); +template XBT_PUBLIC void declare_flag(const char* name, const char* description, std::string value, + std::function callback); } } // ***** C bindings ***** -xbt_cfg_t xbt_cfg_new(void) { return new simgrid::config::Config(); } +xbt_cfg_t xbt_cfg_new() +{ + return new simgrid::config::Config(); +} void xbt_cfg_free(xbt_cfg_t * cfg) { delete *cfg; } void xbt_cfg_dump(const char *name, const char *indent, xbt_cfg_t cfg) @@ -478,42 +425,47 @@ void xbt_cfg_dump(const char *name, const char *indent, xbt_cfg_t cfg) void xbt_cfg_register_double(const char *name, double default_value, xbt_cfg_cb_t cb_set, const char *desc) { - if (simgrid_config == NULL) + if (simgrid_config == nullptr) simgrid_config = xbt_cfg_new(); - simgrid_config->registerOption(name, desc, default_value, cb_set); + simgrid_config->register_option(name, desc, default_value, cb_set); } void xbt_cfg_register_int(const char *name, int default_value,xbt_cfg_cb_t cb_set, const char *desc) { - if (simgrid_config == NULL) + if (simgrid_config == nullptr) simgrid_config = xbt_cfg_new(); - simgrid_config->registerOption(name, desc, default_value, cb_set); + simgrid_config->register_option(name, desc, default_value, cb_set); } void xbt_cfg_register_string(const char *name, const char *default_value, xbt_cfg_cb_t cb_set, const char *desc) { - if (simgrid_config == NULL) + if (simgrid_config == nullptr) simgrid_config = xbt_cfg_new(); - simgrid_config->registerOption(name, desc, - default_value ? default_value : "", cb_set); + simgrid_config->register_option(name, desc, default_value ? default_value : "", cb_set); } void xbt_cfg_register_boolean(const char *name, const char*default_value,xbt_cfg_cb_t cb_set, const char *desc) { - if (simgrid_config == NULL) + if (simgrid_config == nullptr) simgrid_config = xbt_cfg_new(); - simgrid_config->registerOption(name, desc, simgrid::config::parseBool(default_value), cb_set); + simgrid_config->register_option(name, desc, simgrid::config::parse_bool(default_value), cb_set); } void xbt_cfg_register_alias(const char *realname, const char *aliasname) { - if (simgrid_config == NULL) + if (simgrid_config == nullptr) simgrid_config = xbt_cfg_new(); simgrid_config->alias(realname, aliasname); } -void xbt_cfg_aliases(void) { simgrid_config->showAliases(); } -void xbt_cfg_help(void) { simgrid_config->help(); } +void xbt_cfg_aliases() +{ + simgrid_config->show_aliases(); +} +void xbt_cfg_help() +{ + simgrid_config->help(); +} /*----[ Setting ]---------------------------------------------------------*/ @@ -527,87 +479,42 @@ void xbt_cfg_help(void) { simgrid_config->help(); } */ void xbt_cfg_set_parse(const char *options) { - if (!options || !strlen(options)) { /* nothing to do */ + if (not options || not strlen(options)) { /* nothing to do */ return; } - char *optionlist_cpy = xbt_strdup(options); XBT_DEBUG("List to parse and set:'%s'", options); - char *option = optionlist_cpy; - while (1) { /* breaks in the code */ - if (!option) - break; - char *name = option; - int len = strlen(name); - XBT_DEBUG("Still to parse and set: '%s'. len=%d; option-name=%ld", name, len, (long) (option - name)); - - /* Pass the value */ - while (option - name <= (len - 1) && *option != ' ' && *option != '\n' && *option != '\t' && *option != ',') { - XBT_DEBUG("Take %c.", *option); - option++; - } - if (option - name == len) { - XBT_DEBUG("Boundary=EOL"); - option = NULL; /* don't do next iteration */ - } else { - XBT_DEBUG("Boundary on '%c'. len=%d;option-name=%ld", *option, len, (long) (option - name)); - /* Pass the following blank chars */ - *(option++) = '\0'; - while (option - name < (len - 1) && (*option == ' ' || *option == '\n' || *option == '\t')) { - /* fprintf(stderr,"Ignore a blank char.\n"); */ - option++; - } - if (option - name == len - 1) - option = NULL; /* don't do next iteration */ - } - XBT_DEBUG("parse now:'%s'; parse later:'%s'", name, option); - - if (name[0] == ' ' || name[0] == '\n' || name[0] == '\t') + std::string optionlist(options); + while (not optionlist.empty()) { + XBT_DEBUG("Still to parse and set: '%s'", optionlist.c_str()); + + // skip separators + size_t pos = optionlist.find_first_not_of(" \t\n,"); + optionlist.erase(0, pos); + // find option + pos = optionlist.find_first_of(" \t\n,"); + std::string name = optionlist.substr(0, pos); + optionlist.erase(0, pos); + XBT_DEBUG("parse now:'%s'; parse later:'%s'", name.c_str(), optionlist.c_str()); + + if (name.empty()) continue; - if (!strlen(name)) - break; - char *val = strchr(name, ':'); - xbt_assert(val, "Option '%s' badly formatted. Should be of the form 'name:value'", name); - /* don't free(optionlist_cpy) if the assert fails, 'name' points inside it */ - *(val++) = '\0'; + pos = name.find(':'); + xbt_assert(pos != std::string::npos, "Option '%s' badly formatted. Should be of the form 'name:value'", + name.c_str()); - if (strncmp(name, "contexts/", strlen("contexts/")) && strncmp(name, "path", strlen("path"))) - XBT_INFO("Configuration change: Set '%s' to '%s'", name, val); + std::string val = name.substr(pos + 1); + name.erase(pos); - try { - (*simgrid_config)[name].setStringValue(val); - } - catch (simgrid::config::missing_key_error& e) { - goto on_missing_key; - } - catch (...) { - goto on_exception; - } - } - - free(optionlist_cpy); - return; + const std::string path("path"); + if (name.compare(0, path.length(), path) != 0) + XBT_INFO("Configuration change: Set '%s' to '%s'", name.c_str(), val.c_str()); -on_missing_key: - free(optionlist_cpy); - THROWF(not_found_error, 0, "Could not set variables %s", options); - return; -on_exception: - free(optionlist_cpy); - THROWF(unknown_error, 0, "Could not set variables %s", options); - return; + (*simgrid_config)[name.c_str()].set_string_value(val.c_str()); + } } -// Horrible mess to translate C++ exceptions to C exceptions: -// Exit from the catch blog (and do the correct exceptio cleaning) -// before attempting to THROWF. -#define TRANSLATE_EXCEPTIONS(...) \ - catch(simgrid::config::missing_key_error& e) { goto on_exception; } \ - catch(...) { goto on_missing_key; } \ - on_missing_key: THROWF(not_found_error, 0, __VA_ARGS__); \ - on_exception: THROWF(not_found_error, 0, __VA_ARGS__); - /** @brief Set the value of a variable, using the string representation of that value * * @param key name of the variable to modify @@ -616,11 +523,7 @@ on_exception: void xbt_cfg_set_as_string(const char *key, const char *value) { - try { - (*simgrid_config)[key].setStringValue(value); - return; - } - TRANSLATE_EXCEPTIONS("Could not set variable %s as string %s", key, value); + (*simgrid_config)[key].set_string_value(value); } /** @brief Set an integer value to \a name within \a cfg if it wasn't changed yet @@ -630,12 +533,7 @@ void xbt_cfg_set_as_string(const char *key, const char *value) */ void xbt_cfg_setdefault_int(const char *key, int value) { - try { - (*simgrid_config)[key].setDefaultValue(value); - return; - } - TRANSLATE_EXCEPTIONS("Could not set variable %s to default integer %i", - key, value); + (*simgrid_config)[key].set_default_value(value); } /** @brief Set an integer value to \a name within \a cfg if it wasn't changed yet @@ -645,12 +543,7 @@ void xbt_cfg_setdefault_int(const char *key, int value) */ void xbt_cfg_setdefault_double(const char *key, double value) { - try { - (*simgrid_config)[key].setDefaultValue(value); - return; - } - TRANSLATE_EXCEPTIONS("Could not set variable %s to default double %f", - key, value); + (*simgrid_config)[key].set_default_value(value); } /** @brief Set a string value to \a name within \a cfg if it wasn't changed yet @@ -660,12 +553,7 @@ void xbt_cfg_setdefault_double(const char *key, double value) */ void xbt_cfg_setdefault_string(const char *key, const char *value) { - try { - (*simgrid_config)[key].setDefaultValue(value ? value : ""); - return; - } - TRANSLATE_EXCEPTIONS("Could not set variable %s to default string %s", - key, value); + (*simgrid_config)[key].set_default_value(value ? value : ""); } /** @brief Set an boolean value to \a name within \a cfg if it wasn't changed yet @@ -675,149 +563,105 @@ void xbt_cfg_setdefault_string(const char *key, const char *value) */ void xbt_cfg_setdefault_boolean(const char *key, const char *value) { - try { - (*simgrid_config)[key].setDefaultValue(simgrid::config::parseBool(value)); - return; - } - TRANSLATE_EXCEPTIONS("Could not set variable %s to default boolean %s", - key, value); + (*simgrid_config)[key].set_default_value(simgrid::config::parse_bool(value)); } /** @brief Set an integer value to \a name within \a cfg * - * @param name the name of the variable - * @param val the value of the variable + * @param key the name of the variable + * @param value the value of the variable */ void xbt_cfg_set_int(const char *key, int value) { - try { - (*simgrid_config)[key].setValue(value); - return; - } - TRANSLATE_EXCEPTIONS("Could not set variable %s to integer %i", - key, value); + (*simgrid_config)[key].set_value(value); } /** @brief Set or add a double value to \a name within \a cfg * - * @param name the name of the variable - * @param val the double to set + * @param key the name of the variable + * @param value the double to set */ void xbt_cfg_set_double(const char *key, double value) { - try { - (*simgrid_config)[key].setValue(value); - return; - } - TRANSLATE_EXCEPTIONS("Could not set variable %s to double %f", - key, value); + (*simgrid_config)[key].set_value(value); } /** @brief Set or add a string value to \a name within \a cfg * - * @param cfg the config set - * @param name the name of the variable - * @param val the value to be added + * @param key the name of the variable + * @param value the value to be added * */ -void xbt_cfg_set_string(const char *key, const char *value) +void xbt_cfg_set_string(const char* key, const char* value) { - try { - (*simgrid_config)[key].setValue(value ? value : ""); - return; - } - TRANSLATE_EXCEPTIONS("Could not set variable %s to string %s", - key, value); + (*simgrid_config)[key].set_value(value); } /** @brief Set or add a boolean value to \a name within \a cfg * - * @param name the name of the variable - * @param val the value of the variable + * @param key the name of the variable + * @param value the value of the variable */ void xbt_cfg_set_boolean(const char *key, const char *value) { - try { - (*simgrid_config)[key].setValue(simgrid::config::parseBool(value)); - return; - } - TRANSLATE_EXCEPTIONS("Could not set variable %s to boolean %s", - key, value); + (*simgrid_config)[key].set_value(simgrid::config::parse_bool(value)); } /* Say if the value is the default value */ int xbt_cfg_is_default_value(const char *key) { - try { - return (*simgrid_config)[key].isDefault() ? 1 : 0; - } - TRANSLATE_EXCEPTIONS("Could not get variable %s", key); + return (*simgrid_config)[key].is_default() ? 1 : 0; } /*----[ Getting ]---------------------------------------------------------*/ /** @brief Retrieve an integer value of a variable (get a warning if not uniq) * - * @param name the name of the variable + * @param key the name of the variable * * Returns the first value from the config set under the given name. */ int xbt_cfg_get_int(const char *key) { - try { - return (*simgrid_config)[key].getValue(); - } - TRANSLATE_EXCEPTIONS("Could not get variable %s", key); + return (*simgrid_config)[key].get_value(); } /** @brief Retrieve a double value of a variable (get a warning if not uniq) * - * @param cfg the config set - * @param name the name of the variable + * @param key the name of the variable * * Returns the first value from the config set under the given name. */ double xbt_cfg_get_double(const char *key) { - try { - return (*simgrid_config)[key].getValue(); - } - TRANSLATE_EXCEPTIONS("Could not get variable %s", key); + return (*simgrid_config)[key].get_value(); } /** @brief Retrieve a string value of a variable (get a warning if not uniq) * - * @param cfg the config set - * @param name the name of the variable + * @param key the name of the variable * * Returns the first value from the config set under the given name. * If there is more than one value, it will issue a warning. - * Returns NULL if there is no value. + * Returns nullptr if there is no value. * * \warning the returned value is the actual content of the config set */ -char *xbt_cfg_get_string(const char *key) +std::string xbt_cfg_get_string(const char* key) { - try { - return (char*) (*simgrid_config)[key].getValue().c_str(); - } - TRANSLATE_EXCEPTIONS("Could not get variable %s", key); + return (*simgrid_config)[key].get_value(); } /** @brief Retrieve a boolean value of a variable (get a warning if not uniq) * - * @param cfg the config set - * @param name the name of the variable + * @param key the name of the variable * * Returns the first value from the config set under the given name. * If there is more than one value, it will issue a warning. */ int xbt_cfg_get_boolean(const char *key) { - try { - return (*simgrid_config)[key].getValue() ? 1 : 0; - } - TRANSLATE_EXCEPTIONS("Could not get variable %s", key); + return (*simgrid_config)[key].get_value() ? 1 : 0; } #ifdef SIMGRID_TEST @@ -826,6 +670,7 @@ int xbt_cfg_get_boolean(const char *key) #include "xbt.h" #include "xbt/ex.h" +#include #include @@ -833,15 +678,15 @@ XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(xbt_cfg); XBT_TEST_SUITE("config", "Configuration support"); -XBT_PUBLIC_DATA(xbt_cfg_t) simgrid_config; +XBT_PUBLIC_DATA xbt_cfg_t simgrid_config; static void make_set() { - simgrid_config = NULL; + simgrid_config = nullptr; xbt_log_threshold_set(&_XBT_LOGV(xbt_cfg), xbt_log_priority_critical); - xbt_cfg_register_int("speed", 0, NULL, ""); - xbt_cfg_register_string("peername", "", NULL, ""); - xbt_cfg_register_string("user", "", NULL, ""); + simgrid::config::declare_flag("speed", "description", 0); + simgrid::config::declare_flag("peername", "description", ""); + simgrid::config::declare_flag("user", "description", ""); } /* end_of_make_set */ XBT_TEST_UNIT("memuse", test_config_memuse, "Alloc and free a config set") @@ -861,24 +706,19 @@ XBT_TEST_UNIT("use", test_config_use, "Data retrieving tests") xbt_test_add("Get a single value"); { /* get_single_value */ - int ival; - xbt_cfg_set_parse("peername:toto:42 speed:42"); - ival = xbt_cfg_get_int("speed"); + int ival = simgrid::config::get_config("speed"); if (ival != 42) xbt_test_fail("Speed value = %d, I expected 42", ival); } xbt_test_add("Access to a non-existant entry"); { - xbt_ex_t e; - - TRY { + try { xbt_cfg_set_parse("color:blue"); - } CATCH(e) { + } catch(xbt_ex& e) { if (e.category != not_found_error) xbt_test_exception(e); - xbt_ex_free(e); } } xbt_cfg_free(&simgrid_config); @@ -903,7 +743,7 @@ XBT_TEST_UNIT("c++flags", test_config_cxx_flags, "C++ flags") xbt_test_assert(string_flag == "bar", "Check string flag"); xbt_test_assert(double_flag == 8.0, "Check double flag"); xbt_test_assert(bool_flag1, "Check bool1 flag"); - xbt_test_assert(!bool_flag2, "Check bool2 flag"); + xbt_test_assert(not bool_flag2, "Check bool2 flag"); xbt_cfg_free(&simgrid_config); simgrid_config = temp;