X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/0656fb649a05da91d4e8edab6e1abbcfdb2f4f75..6ab5d8cd5d2eaa1f52b6ec6b17ae12ca645854d1:/src/mc/compare.cpp diff --git a/src/mc/compare.cpp b/src/mc/compare.cpp index b913fae342..f302e81f87 100644 --- a/src/mc/compare.cpp +++ b/src/mc/compare.cpp @@ -55,12 +55,12 @@ public: class ProcessComparisonState { public: - std::vector* to_ignore = nullptr; + const std::vector* to_ignore = nullptr; std::vector equals_to; std::vector types; std::size_t heapsize = 0; - void initHeapInformation(xbt_mheap_t heap, std::vector* i); + void initHeapInformation(xbt_mheap_t heap, const std::vector& i); }; class StateComparator { @@ -77,10 +77,8 @@ public: compared_pointers.clear(); } - int initHeapInformation( - xbt_mheap_t heap1, xbt_mheap_t heap2, - std::vector* i1, - std::vector* i2); + int initHeapInformation(xbt_mheap_t heap1, xbt_mheap_t heap2, const std::vector& i1, + const std::vector& i2); template HeapArea& equals_to_(std::size_t i, std::size_t j) { @@ -133,9 +131,8 @@ public: /************************************************************************************/ -static ssize_t heap_comparison_ignore_size( - std::vector* ignore_list, - const void *address) +static ssize_t heap_comparison_ignore_size(const std::vector* ignore_list, + const void* address) { int start = 0; int end = ignore_list->size() - 1; @@ -154,12 +151,6 @@ static ssize_t heap_comparison_ignore_size( return -1; } -static bool is_on_heap(const void* address) -{ - const xbt_mheap_t heap = mc_model_checker->process().get_heap(); - return address >= heap->heapbase && address < heap->breakval; -} - static bool is_stack(const void *address) { for (auto const& stack : mc_model_checker->process().stack_areas()) @@ -193,19 +184,18 @@ void StateComparator::match_equals(HeapLocationPairs* list) } } -void ProcessComparisonState::initHeapInformation(xbt_mheap_t heap, - std::vector* i) +void ProcessComparisonState::initHeapInformation(xbt_mheap_t heap, const std::vector& i) { auto heaplimit = heap->heaplimit; this->heapsize = heap->heapsize; - this->to_ignore = i; + this->to_ignore = &i; this->equals_to.assign(heaplimit * MAX_FRAGMENT_PER_BLOCK, HeapArea()); this->types.assign(heaplimit * MAX_FRAGMENT_PER_BLOCK, nullptr); } int StateComparator::initHeapInformation(xbt_mheap_t heap1, xbt_mheap_t heap2, - std::vector* i1, - std::vector* i2) + const std::vector& i1, + const std::vector& i2) { if ((heap1->heaplimit != heap2->heaplimit) || (heap1->heapsize != heap2->heapsize)) return -1; @@ -217,19 +207,19 @@ int StateComparator::initHeapInformation(xbt_mheap_t heap1, xbt_mheap_t heap2, } // TODO, have a robust way to find it in O(1) -static inline Region* MC_get_heap_region(Snapshot* snapshot) +static inline Region* MC_get_heap_region(const Snapshot& snapshot) { - for (auto const& region : snapshot->snapshot_regions_) + for (auto const& region : snapshot.snapshot_regions_) if (region->region_type() == simgrid::mc::RegionType::Heap) return region.get(); xbt_die("No heap region"); } -static bool heap_area_differ(StateComparator& state, const void* area1, const void* area2, Snapshot* snapshot1, - Snapshot* snapshot2, HeapLocationPairs* previous, Type* type, int pointer_level); +static bool heap_area_differ(StateComparator& state, const void* area1, const void* area2, const Snapshot& snapshot1, + const Snapshot& snapshot2, HeapLocationPairs* previous, Type* type, int pointer_level); -static bool mmalloc_heap_differ(simgrid::mc::StateComparator& state, simgrid::mc::Snapshot* snapshot1, - simgrid::mc::Snapshot* snapshot2) +static bool mmalloc_heap_differ(simgrid::mc::StateComparator& state, const simgrid::mc::Snapshot& snapshot1, + const simgrid::mc::Snapshot& snapshot2) { const simgrid::mc::RemoteClient& process = mc_model_checker->process(); @@ -248,9 +238,9 @@ static bool mmalloc_heap_differ(simgrid::mc::StateComparator& state, simgrid::mc // This is in snapshot do not use them directly: const malloc_info* heapinfos1 = - snapshot1->read(RemotePtr((std::uint64_t)heapinfo_address)); + snapshot1.read(RemotePtr((std::uint64_t)heapinfo_address)); const malloc_info* heapinfos2 = - snapshot2->read(RemotePtr((std::uint64_t)heapinfo_address)); + snapshot2.read(RemotePtr((std::uint64_t)heapinfo_address)); while (i1 < state.heaplimit) { @@ -264,10 +254,7 @@ static bool mmalloc_heap_differ(simgrid::mc::StateComparator& state, simgrid::mc continue; } - if (heapinfo1->type < 0) { - fprintf(stderr, "Unkown mmalloc block type.\n"); - abort(); - } + xbt_assert(heapinfo1->type >= 0, "Unkown mmalloc block type: %d", heapinfo1->type); void* addr_block1 = ((void*)(((ADDR2UINT(i1)) - 1) * BLOCKSIZE + (char*)state.std_heap_copy.heapbase)); @@ -381,10 +368,7 @@ static bool mmalloc_heap_differ(simgrid::mc::StateComparator& state, simgrid::mc continue; } - if (heapinfo2b->type < 0) { - fprintf(stderr, "Unknown mmalloc block type.\n"); - abort(); - } + xbt_assert(heapinfo2b->type >= 0, "Unkown mmalloc block type: %d", heapinfo2b->type); for (size_t j2 = 0; j2 < (size_t)(BLOCKSIZE >> heapinfo2b->type); j2++) { @@ -474,8 +458,8 @@ static bool mmalloc_heap_differ(simgrid::mc::StateComparator& state, simgrid::mc * @return true when different, false otherwise (same or unknown) */ static bool heap_area_differ_without_type(simgrid::mc::StateComparator& state, const void* real_area1, - const void* real_area2, simgrid::mc::Snapshot* snapshot1, - simgrid::mc::Snapshot* snapshot2, HeapLocationPairs* previous, int size, + const void* real_area2, const simgrid::mc::Snapshot& snapshot1, + const simgrid::mc::Snapshot& snapshot2, HeapLocationPairs* previous, int size, int check_ignore) { const simgrid::mc::RemoteClient& process = mc_model_checker->process(); @@ -505,15 +489,15 @@ static bool heap_area_differ_without_type(simgrid::mc::StateComparator& state, c 1) != 0) { int pointer_align = (i / sizeof(void *)) * sizeof(void *); - const void* addr_pointed1 = snapshot1->read(remote((void**)((const char*)real_area1 + pointer_align))); - const void* addr_pointed2 = snapshot2->read(remote((void**)((const char*)real_area2 + pointer_align))); + const void* addr_pointed1 = snapshot1.read(remote((void* const*)((const char*)real_area1 + pointer_align))); + const void* addr_pointed2 = snapshot2.read(remote((void* const*)((const char*)real_area2 + pointer_align))); if (process.in_maestro_stack(remote(addr_pointed1)) && process.in_maestro_stack(remote(addr_pointed2))) { i = pointer_align + sizeof(void *); continue; } - if (is_on_heap(addr_pointed1) && is_on_heap(addr_pointed2)) { + if (snapshot1.on_heap(addr_pointed1) && snapshot2.on_heap(addr_pointed2)) { // Both addresses are in the heap: if (heap_area_differ(state, addr_pointed1, addr_pointed2, snapshot1, snapshot2, previous, nullptr, 0)) return true; @@ -545,8 +529,8 @@ static bool heap_area_differ_without_type(simgrid::mc::StateComparator& state, c * @return true when different, false otherwise (same or unknown) */ static bool heap_area_differ_with_type(simgrid::mc::StateComparator& state, const void* real_area1, - const void* real_area2, simgrid::mc::Snapshot* snapshot1, - simgrid::mc::Snapshot* snapshot2, HeapLocationPairs* previous, + const void* real_area2, const simgrid::mc::Snapshot& snapshot1, + const simgrid::mc::Snapshot& snapshot2, HeapLocationPairs* previous, simgrid::mc::Type* type, int area_size, int check_ignore, int pointer_level) { // HACK: This should not happen but in pratice, there are some @@ -647,24 +631,24 @@ static bool heap_area_differ_with_type(simgrid::mc::StateComparator& state, cons case DW_TAG_rvalue_reference_type: case DW_TAG_pointer_type: if (type->subtype && type->subtype->type == DW_TAG_subroutine_type) { - addr_pointed1 = snapshot1->read(remote((void* const*)real_area1)); - addr_pointed2 = snapshot2->read(remote((void* const*)real_area2)); + addr_pointed1 = snapshot1.read(remote((void* const*)real_area1)); + addr_pointed2 = snapshot2.read(remote((void* const*)real_area2)); return (addr_pointed1 != addr_pointed2); } pointer_level++; if (pointer_level <= 1) { - addr_pointed1 = snapshot1->read(remote((void* const*)real_area1)); - addr_pointed2 = snapshot2->read(remote((void* const*)real_area2)); - if (is_on_heap(addr_pointed1) && is_on_heap(addr_pointed2)) + addr_pointed1 = snapshot1.read(remote((void* const*)real_area1)); + addr_pointed2 = snapshot2.read(remote((void* const*)real_area2)); + if (snapshot1.on_heap(addr_pointed1) && snapshot2.on_heap(addr_pointed2)) return heap_area_differ(state, addr_pointed1, addr_pointed2, snapshot1, snapshot2, previous, type->subtype, pointer_level); else return (addr_pointed1 != addr_pointed2); } for (size_t i = 0; i < (area_size / sizeof(void*)); i++) { - addr_pointed1 = snapshot1->read(remote((void* const*)((const char*)real_area1 + i * sizeof(void*)))); - addr_pointed2 = snapshot2->read(remote((void* const*)((const char*)real_area2 + i * sizeof(void*)))); - bool differ = is_on_heap(addr_pointed1) && is_on_heap(addr_pointed2) + addr_pointed1 = snapshot1.read(remote((void* const*)((const char*)real_area1 + i * sizeof(void*)))); + addr_pointed2 = snapshot2.read(remote((void* const*)((const char*)real_area2 + i * sizeof(void*)))); + bool differ = snapshot1.on_heap(addr_pointed1) && snapshot2.on_heap(addr_pointed2) ? heap_area_differ(state, addr_pointed1, addr_pointed2, snapshot1, snapshot2, previous, type->subtype, pointer_level) : addr_pointed1 != addr_pointed2; @@ -689,10 +673,8 @@ static bool heap_area_differ_with_type(simgrid::mc::StateComparator& state, cons } else { for (simgrid::mc::Member& member : type->members) { // TODO, optimize this? (for the offset case) - void* real_member1 = - simgrid::dwarf::resolve_member(real_area1, type, &member, (simgrid::mc::AddressSpace*)snapshot1); - void* real_member2 = - simgrid::dwarf::resolve_member(real_area2, type, &member, (simgrid::mc::AddressSpace*)snapshot2); + void* real_member1 = simgrid::dwarf::resolve_member(real_area1, type, &member, &snapshot1); + void* real_member2 = simgrid::dwarf::resolve_member(real_area2, type, &member, &snapshot2); if (heap_area_differ_with_type(state, real_member1, real_member2, snapshot1, snapshot2, previous, member.type, -1, check_ignore, 0)) return true; @@ -705,10 +687,8 @@ static bool heap_area_differ_with_type(simgrid::mc::StateComparator& state, cons type->byte_size, check_ignore); default: - XBT_VERB("Unknown case: %d", type->type); - break; + THROW_IMPOSSIBLE; } - return false; } /** Infer the type of a part of the block from the type of the block @@ -722,7 +702,7 @@ static bool heap_area_differ_with_type(simgrid::mc::StateComparator& state, cons * @return DWARF type ID for given offset */ static simgrid::mc::Type* get_offset_type(void* real_base_address, simgrid::mc::Type* type, int offset, int area_size, - simgrid::mc::Snapshot* snapshot) + const simgrid::mc::Snapshot& snapshot) { // Beginning of the block, the infered variable type if the type of the block: @@ -748,7 +728,7 @@ static simgrid::mc::Type* get_offset_type(void* real_base_address, simgrid::mc:: if (member.offset() == offset) return member.type; } else { - void* real_member = simgrid::dwarf::resolve_member(real_base_address, type, &member, snapshot); + void* real_member = simgrid::dwarf::resolve_member(real_base_address, type, &member, &snapshot); if ((char*)real_member - (char*)real_base_address == offset) return member.type; } @@ -774,7 +754,7 @@ static simgrid::mc::Type* get_offset_type(void* real_base_address, simgrid::mc:: * @return true when different, false otherwise (same or unknown) */ static bool heap_area_differ(simgrid::mc::StateComparator& state, const void* area1, const void* area2, - simgrid::mc::Snapshot* snapshot1, simgrid::mc::Snapshot* snapshot2, + const simgrid::mc::Snapshot& snapshot1, const simgrid::mc::Snapshot& snapshot2, HeapLocationPairs* previous, simgrid::mc::Type* type, int pointer_level) { const simgrid::mc::RemoteClient& process = mc_model_checker->process(); @@ -798,8 +778,8 @@ static bool heap_area_differ(simgrid::mc::StateComparator& state, const void* ar // This is the address of std_heap->heapinfo in the application process: void* heapinfo_address = &((xbt_mheap_t)process.heap_address)->heapinfo; - const malloc_info* heapinfos1 = snapshot1->read(remote((const malloc_info**)heapinfo_address)); - const malloc_info* heapinfos2 = snapshot2->read(remote((const malloc_info**)heapinfo_address)); + const malloc_info* heapinfos1 = snapshot1.read(remote((const malloc_info**)heapinfo_address)); + const malloc_info* heapinfos2 = snapshot2.read(remote((const malloc_info**)heapinfo_address)); malloc_info heapinfo_temp1; malloc_info heapinfo_temp2; @@ -1057,8 +1037,8 @@ static bool heap_area_differ(simgrid::mc::StateComparator& state, const void* ar /******************************************************************************/ static bool areas_differ_with_type(simgrid::mc::StateComparator& state, const void* real_area1, - simgrid::mc::Snapshot* snapshot1, simgrid::mc::Region* region1, - const void* real_area2, simgrid::mc::Snapshot* snapshot2, + const simgrid::mc::Snapshot& snapshot1, simgrid::mc::Region* region1, + const void* real_area2, const simgrid::mc::Snapshot& snapshot2, simgrid::mc::Region* region2, simgrid::mc::Type* type, int pointer_level) { simgrid::mc::Type* subtype; @@ -1111,8 +1091,8 @@ static bool areas_differ_with_type(simgrid::mc::StateComparator& state, const vo } for (i = 0; i < type->element_count; i++) { size_t off = i * elm_size; - if (areas_differ_with_type(state, (char*)real_area1 + off, snapshot1, region1, (char*)real_area2 + off, - snapshot2, region2, type->subtype, pointer_level)) + if (areas_differ_with_type(state, (const char*)real_area1 + off, snapshot1, region1, + (const char*)real_area2 + off, snapshot2, region2, type->subtype, pointer_level)) return true; } break; @@ -1138,8 +1118,8 @@ static bool areas_differ_with_type(simgrid::mc::StateComparator& state, const vo // * a pointer leads to the read-only segment of the current object // * a pointer lead to a different ELF object - if (is_on_heap(addr_pointed1)) { - if (not is_on_heap(addr_pointed2)) + if (snapshot1.on_heap(addr_pointed1)) { + if (not snapshot2.on_heap(addr_pointed2)) return true; // The pointers are both in the heap: return simgrid::mc::heap_area_differ(state, addr_pointed1, addr_pointed2, snapshot1, snapshot2, nullptr, @@ -1165,10 +1145,10 @@ static bool areas_differ_with_type(simgrid::mc::StateComparator& state, const vo case DW_TAG_structure_type: case DW_TAG_class_type: for (simgrid::mc::Member& member : type->members) { - void* member1 = simgrid::dwarf::resolve_member(real_area1, type, &member, snapshot1); - void* member2 = simgrid::dwarf::resolve_member(real_area2, type, &member, snapshot2); - simgrid::mc::Region* subregion1 = snapshot1->get_region(member1, region1); // region1 is hinted - simgrid::mc::Region* subregion2 = snapshot2->get_region(member2, region2); // region2 is hinted + void* member1 = simgrid::dwarf::resolve_member(real_area1, type, &member, &snapshot1); + void* member2 = simgrid::dwarf::resolve_member(real_area2, type, &member, &snapshot2); + simgrid::mc::Region* subregion1 = snapshot1.get_region(member1, region1); // region1 is hinted + simgrid::mc::Region* subregion2 = snapshot2.get_region(member2, region2); // region2 is hinted if (areas_differ_with_type(state, member1, snapshot1, subregion1, member2, snapshot2, subregion2, member.type, pointer_level)) return true; @@ -1185,12 +1165,12 @@ static bool areas_differ_with_type(simgrid::mc::StateComparator& state, const vo } static bool global_variables_differ(simgrid::mc::StateComparator& state, simgrid::mc::ObjectInformation* object_info, - simgrid::mc::Region* r1, simgrid::mc::Region* r2, simgrid::mc::Snapshot* snapshot1, - simgrid::mc::Snapshot* snapshot2) + simgrid::mc::Region* r1, simgrid::mc::Region* r2, + const simgrid::mc::Snapshot& snapshot1, const simgrid::mc::Snapshot& snapshot2) { xbt_assert(r1 && r2, "Missing region."); - std::vector& variables = object_info->global_variables; + const std::vector& variables = object_info->global_variables; for (simgrid::mc::Variable const& current_var : variables) { @@ -1202,11 +1182,9 @@ static bool global_variables_differ(simgrid::mc::StateComparator& state, simgrid continue; simgrid::mc::Type* bvariable_type = current_var.type; - if (areas_differ_with_type(state, (char*)current_var.address, snapshot1, r1, (char*)current_var.address, snapshot2, - r2, bvariable_type, 0)) { - XBT_VERB("Global variable %s (%p) is different between snapshots", - current_var.name.c_str(), - (char *) current_var.address); + if (areas_differ_with_type(state, current_var.address, snapshot1, r1, current_var.address, snapshot2, r2, + bvariable_type, 0)) { + XBT_VERB("Global variable %s (%p) is different between snapshots", current_var.name.c_str(), current_var.address); return true; } } @@ -1214,9 +1192,9 @@ static bool global_variables_differ(simgrid::mc::StateComparator& state, simgrid return false; } -static bool local_variables_differ(simgrid::mc::StateComparator& state, simgrid::mc::Snapshot* snapshot1, - simgrid::mc::Snapshot* snapshot2, mc_snapshot_stack_t stack1, - mc_snapshot_stack_t stack2) +static bool local_variables_differ(simgrid::mc::StateComparator& state, const simgrid::mc::Snapshot& snapshot1, + const simgrid::mc::Snapshot& snapshot2, const_mc_snapshot_stack_t stack1, + const_mc_snapshot_stack_t stack2) { if (stack1->local_variables.size() != stack2->local_variables.size()) { XBT_VERB("Different number of local variables"); @@ -1224,25 +1202,22 @@ static bool local_variables_differ(simgrid::mc::StateComparator& state, simgrid: } for (unsigned int cursor = 0; cursor < stack1->local_variables.size(); cursor++) { - local_variable_t current_var1 = &stack1->local_variables[cursor]; - local_variable_t current_var2 = &stack2->local_variables[cursor]; + const_local_variable_t current_var1 = &stack1->local_variables[cursor]; + const_local_variable_t current_var2 = &stack2->local_variables[cursor]; if (current_var1->name != current_var2->name || current_var1->subprogram != current_var2->subprogram || current_var1->ip != current_var2->ip) { // TODO, fix current_varX->subprogram->name to include name if DW_TAG_inlined_subprogram - XBT_VERB("Different name of variable (%s - %s) " - "or frame (%s - %s) or ip (%lu - %lu)", - current_var1->name.c_str(), current_var2->name.c_str(), current_var1->subprogram->name.c_str(), + XBT_VERB("Different name of variable (%s - %s) or frame (%s - %s) or ip (%lu - %lu)", current_var1->name.c_str(), + current_var2->name.c_str(), current_var1->subprogram->name.c_str(), current_var2->subprogram->name.c_str(), current_var1->ip, current_var2->ip); return true; } - if (areas_differ_with_type(state, current_var1->address, snapshot1, snapshot1->get_region(current_var1->address), - current_var2->address, snapshot2, snapshot2->get_region(current_var2->address), + if (areas_differ_with_type(state, current_var1->address, snapshot1, snapshot1.get_region(current_var1->address), + current_var2->address, snapshot2, snapshot2.get_region(current_var2->address), current_var1->type, 0)) { - XBT_VERB("Local variable %s (%p - %p) in frame %s " - "is different between snapshots", - current_var1->name.c_str(), current_var1->address, current_var2->address, - current_var1->subprogram->name.c_str()); + XBT_VERB("Local variable %s (%p - %p) in frame %s is different between snapshots", current_var1->name.c_str(), + current_var1->address, current_var2->address, current_var1->subprogram->name.c_str()); return true; } } @@ -1252,7 +1227,7 @@ static bool local_variables_differ(simgrid::mc::StateComparator& state, simgrid: namespace simgrid { namespace mc { -bool snapshot_equal(Snapshot* s1, Snapshot* s2) +bool snapshot_equal(const Snapshot* s1, const Snapshot* s2) { // TODO, make this a field of ModelChecker or something similar static StateComparator state_comparator; @@ -1284,21 +1259,23 @@ bool snapshot_equal(Snapshot* s1, Snapshot* s2) } /* Init heap information used in heap comparison algorithm */ - xbt_mheap_t heap1 = (xbt_mheap_t)s1->read_bytes(alloca(sizeof(struct mdesc)), sizeof(struct mdesc), - remote(process.heap_address), simgrid::mc::ReadOptions::lazy()); - xbt_mheap_t heap2 = (xbt_mheap_t)s2->read_bytes(alloca(sizeof(struct mdesc)), sizeof(struct mdesc), - remote(process.heap_address), simgrid::mc::ReadOptions::lazy()); - if (state_comparator.initHeapInformation(heap1, heap2, &s1->to_ignore_, &s2->to_ignore_) == -1) { + xbt_mheap_t heap1 = + static_cast(s1->read_bytes(alloca(sizeof(struct mdesc)), sizeof(struct mdesc), + remote(process.heap_address), simgrid::mc::ReadOptions::lazy())); + xbt_mheap_t heap2 = + static_cast(s2->read_bytes(alloca(sizeof(struct mdesc)), sizeof(struct mdesc), + remote(process.heap_address), simgrid::mc::ReadOptions::lazy())); + if (state_comparator.initHeapInformation(heap1, heap2, s1->to_ignore_, s2->to_ignore_) == -1) { XBT_VERB("(%d - %d) Different heap information", s1->num_state_, s2->num_state_); return false; } /* Stacks comparison */ for (unsigned int cursor = 0; cursor < s1->stacks_.size(); cursor++) { - mc_snapshot_stack_t stack1 = &s1->stacks_[cursor]; - mc_snapshot_stack_t stack2 = &s2->stacks_[cursor]; + const_mc_snapshot_stack_t stack1 = &s1->stacks_[cursor]; + const_mc_snapshot_stack_t stack2 = &s2->stacks_[cursor]; - if (local_variables_differ(state_comparator, s1, s2, stack1, stack2)) { + if (local_variables_differ(state_comparator, *s1, *s2, stack1, stack2)) { XBT_VERB("(%d - %d) Different local variables between stacks %u", s1->num_state_, s2->num_state_, cursor + 1); return false; } @@ -1321,7 +1298,7 @@ bool snapshot_equal(Snapshot* s1, Snapshot* s2) xbt_assert(region1->object_info()); /* Compare global variables */ - if (global_variables_differ(state_comparator, region1->object_info(), region1, region2, s1, s2)) { + if (global_variables_differ(state_comparator, region1->object_info(), region1, region2, *s1, *s2)) { std::string const& name = region1->object_info()->file_name; XBT_VERB("(%d - %d) Different global variables in %s", s1->num_state_, s2->num_state_, name.c_str()); return false; @@ -1329,7 +1306,7 @@ bool snapshot_equal(Snapshot* s1, Snapshot* s2) } /* Compare heap */ - if (mmalloc_heap_differ(state_comparator, s1, s2)) { + if (mmalloc_heap_differ(state_comparator, *s1, *s2)) { XBT_VERB("(%d - %d) Different heap (mmalloc_compare)", s1->num_state_, s2->num_state_); return false; }