X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/0424e24e1f270b3c65b20e994079679b18be3eb8..9279140e1900ca50c93dd35152f98230b2ca4acf:/src/bindings/java/jxbt_utilities.cpp?ds=sidebyside

diff --git a/src/bindings/java/jxbt_utilities.cpp b/src/bindings/java/jxbt_utilities.cpp
index d6fe7e7539..771ad2a404 100644
--- a/src/bindings/java/jxbt_utilities.cpp
+++ b/src/bindings/java/jxbt_utilities.cpp
@@ -1,25 +1,19 @@
 /* Various JNI helper functions                                             */
 
-/* Copyright (c) 2007-2014. The SimGrid Team.
- * All rights reserved.                                                     */
+/* Copyright (c) 2007-2021. The SimGrid Team. All rights reserved.          */
 
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
 
-#include <stdlib.h>             /* abort */
-#include "xbt/misc.h"
+#include "jxbt_utilities.hpp"
+#include "xbt/string.hpp"
 #include "xbt/sysdep.h"
-#include "xbt/str.h"
-#include "jxbt_utilities.h"
 
 jclass jxbt_get_class(JNIEnv * env, const char *name)
 {
   jclass cls = env->FindClass(name);
-
-  if (!cls) {
-    char *m = bprintf("Class %s not found", name);
-    jxbt_throw_jni(env, m);
-    free(m);
+  if (not cls) {
+    jxbt_throw_jni(env, std::string("Class ") + name + " not found");
     return nullptr;
   }
 
@@ -28,26 +22,18 @@ jclass jxbt_get_class(JNIEnv * env, const char *name)
 
 jmethodID jxbt_get_jmethod(JNIEnv * env, jclass cls, const char *name, const char *signature)
 {
-  jmethodID id;
-
-  if (!cls)
-    return 0;
-  id = env->GetMethodID(cls, name, signature);
-
-  if (!id) {
+  if (not cls)
+    return nullptr;
 
+  jmethodID id = env->GetMethodID(cls, name, signature);
+  if (not id) {
     jmethodID tostr_id = env->GetMethodID(cls, "getName", "()Ljava/lang/String;");
-    jstring jclassname = (jstring) env->CallObjectMethod(cls, tostr_id, nullptr);
-    const char *classname = env->GetStringUTFChars(jclassname, 0);
-
-    char *m = bprintf("Cannot find method %s(%s) in %s", name, signature, classname);
+    auto jclassname    = (jstring)env->CallObjectMethod(cls, tostr_id, nullptr);
+    jstring_wrapper classname(env, jclassname);
+    auto msg = std::string("Cannot find method") + name + "(" + signature + ") in " + classname.value;
 
-    env->ReleaseStringUTFChars(jclassname, classname);
-
-    jxbt_throw_jni(env, m);
-
-    free(m);
-    return 0;
+    jxbt_throw_jni(env, msg);
+    return nullptr;
   }
 
   return id;
@@ -55,25 +41,18 @@ jmethodID jxbt_get_jmethod(JNIEnv * env, jclass cls, const char *name, const cha
 
 jmethodID jxbt_get_static_jmethod(JNIEnv * env, jclass cls, const char *name, const char *signature)
 {
-  jmethodID id;
-
-  if (!cls)
-    return 0;
-  id = env->GetStaticMethodID(cls, name, signature);
+  if (not cls)
+    return nullptr;
 
-  if (!id) {
+  jmethodID id = env->GetStaticMethodID(cls, name, signature);
+  if (not id) {
     jmethodID tostr_id = env->GetMethodID(cls, "getName", "()Ljava/lang/String;");
-    jstring jclassname = (jstring) env->CallObjectMethod(cls, tostr_id, nullptr);
-    const char *classname = env->GetStringUTFChars(jclassname, 0);
+    auto jclassname       = (jstring)env->CallObjectMethod(cls, tostr_id, nullptr);
+    jstring_wrapper classname(env, jclassname);
+    auto msg = std::string("Cannot find static method") + name + "(" + signature + ") in " + classname.value;
 
-    char *m = bprintf("Cannot find static method %s(%s) in %s", name, signature, classname);
-
-    env->ReleaseStringUTFChars(jclassname, classname);
-
-    jxbt_throw_jni(env, m);
-
-    free(m);
-    return 0;
+    jxbt_throw_jni(env, msg);
+    return nullptr;
   }
 
   return id;
@@ -81,69 +60,48 @@ jmethodID jxbt_get_static_jmethod(JNIEnv * env, jclass cls, const char *name, co
 
 jmethodID jxbt_get_static_smethod(JNIEnv * env, const char *classname, const char *name, const char *signature)
 {
-  jclass cls;
-  jmethodID id;
-  cls = jxbt_get_class(env, classname);
-
-  if (!cls)
-    return 0;
-
-  id = env->GetStaticMethodID(cls, name, signature);
-
-  if (!id) {
-    char *m = bprintf("Cannot find static method %s(%s) in %s", name, signature, classname);
-
-    jxbt_throw_jni(env, m);
+  jclass cls = jxbt_get_class(env, classname);
+  if (not cls)
+    return nullptr;
 
-    free(m);
-    return 0;
+  jmethodID id = env->GetStaticMethodID(cls, name, signature);
+  if (not id) {
+    jxbt_throw_jni(env, std::string("Cannot find static method") + name + "(" + signature + ") in " + classname);
+    return nullptr;
   }
   return id;
 }
 
 jmethodID jxbt_get_smethod(JNIEnv * env, const char *classname, const char *name, const char *signature)
 {
-  jclass cls;
-  jmethodID id;
-  cls = jxbt_get_class(env, classname);
-
-  if (!cls)
-    return 0;
-
-  id = env->GetMethodID(cls, name, signature);
-
-  if (!id) {
-    char *m = bprintf("Cannot find method %s(%s) in %s", name, signature, classname);
-
-    jxbt_throw_jni(env, m);
+  jclass cls = jxbt_get_class(env, classname);
+  if (not cls)
+    return nullptr;
 
-    free(m);
-    return 0;
+  jmethodID id = env->GetMethodID(cls, name, signature);
+  if (not id) {
+    jxbt_throw_jni(env, std::string("Cannot find method") + name + "(" + signature + ") in " + classname);
+    return nullptr;
   }
   return id;
 }
 
 jfieldID jxbt_get_jfield(JNIEnv * env, jclass cls, const char *name, const char *signature)
 {
-  jfieldID id;
-
-  if (!cls)
-    return 0;
-
-  id = env->GetFieldID(cls, name, signature);
+  if (not cls)
+    return nullptr;
 
-  if (!id) {
+  jfieldID id = env->GetFieldID(cls, name, signature);
+  if (not id) {
     jmethodID getname_id = env->GetMethodID(cls, "getName", "()Ljava/lang/String;");
-    jstring jclassname = (jstring) env->CallObjectMethod(cls, getname_id, nullptr);
-    const char *classname = env->GetStringUTFChars(jclassname, 0);
-    char *m = bprintf("Cannot find field %s %s in %s", signature, name, classname);
+    auto jclassname       = (jstring)env->CallObjectMethod(cls, getname_id, nullptr);
+    const char* classname = env->GetStringUTFChars(jclassname, nullptr);
 
     env->ReleaseStringUTFChars(jclassname, classname);
 
-    jxbt_throw_jni(env, m);
+    jxbt_throw_jni(env, std::string("Cannot find field") + signature + " " + name + " in " + classname);
 
-    free(m);
-    return 0;
+    return nullptr;
   }
 
   return id;
@@ -152,87 +110,74 @@ jfieldID jxbt_get_jfield(JNIEnv * env, jclass cls, const char *name, const char
 jfieldID jxbt_get_sfield(JNIEnv * env, const char *classname, const char *name, const char *signature)
 {
   jclass cls = jxbt_get_class(env, classname);
-  jfieldID id;
-
-  if (!cls)
-    return 0;
-
-  id = env->GetFieldID(cls, name, signature);
-
-  if (!id) {
-    char *m = bprintf("Cannot find field %s %s in %s", signature, name, classname);
-
-    jxbt_throw_jni(env, m);
+  if (not cls)
+    return nullptr;
 
-    free(m);
-    return 0;
+  jfieldID id = env->GetFieldID(cls, name, signature);
+  if (not id) {
+    jxbt_throw_jni(env, std::string("Cannot find field") + signature + " " + name + " in " + classname);
+    return nullptr;
   }
 
   return id;
 }
 
-void jxbt_throw_by_name(JNIEnv * env, const char *name, char *msg)
+void jxbt_throw_by_name(JNIEnv* env, const char* name, const std::string& msg)
 {
   jclass cls = env->FindClass(name);
 
-  xbt_assert(cls, "%s (Plus severe error: class %s not found)\n", msg, name);
-
-  env->ThrowNew(cls, msg);
+  xbt_assert(cls, "%s (Plus severe error: class %s not found)\n", msg.c_str(), name);
 
-  free(msg);
+  env->ThrowNew(cls, msg.c_str());
 }
 
-void jxbt_throw_jni(JNIEnv * env, const char *msg)
+void jxbt_throw_jni(JNIEnv* env, const std::string& msg)
 {
-  jxbt_throw_by_name(env, "org/simgrid/msg/JniException", bprintf("Internal or JNI error: %s", msg));
+  jxbt_throw_by_name(env, "org/simgrid/msg/JniException", "Internal or JNI error: " + msg);
 }
 
-void jxbt_throw_notbound(JNIEnv * env, const char *kind, void *pointer)
+void jxbt_throw_notbound(JNIEnv* env, const std::string& kind, void* pointer)
 {
-  jxbt_throw_by_name(env, "org/simgrid/msg/JniException", bprintf("Internal error: %s %p not bound", kind, pointer));
+  jxbt_throw_by_name(env, "org/simgrid/msg/JniException",
+                     simgrid::xbt::string_printf("Internal error: %s %p not bound", kind.c_str(), pointer));
 }
 
-void jxbt_throw_null(JNIEnv * env, char *msg)
+void jxbt_throw_null(JNIEnv* env, const std::string& msg)
 {
   jxbt_throw_by_name(env, "java/lang/NullPointerException", msg);
 }
 
-void jxbt_throw_illegal(JNIEnv * env, char *msg)
+void jxbt_throw_illegal(JNIEnv* env, const std::string& msg)
 {
   jxbt_throw_by_name(env, "java/lang/IllegalArgumentException", msg);
 }
 
-void jxbt_throw_host_not_found(JNIEnv * env, const char *invalid_name)
-{
-  jxbt_throw_by_name(env, "org/simgrid/msg/HostNotFoundException", bprintf("No such host: %s", invalid_name));
-}
-
-void jxbt_throw_storage_not_found(JNIEnv * env, const char *invalid_name)
+void jxbt_throw_host_not_found(JNIEnv* env, const std::string& invalid_name)
 {
-  jxbt_throw_by_name(env, "org/simgrid/msg/StorageNotFoundException", bprintf("No such storage: %s", invalid_name));
+  jxbt_throw_by_name(env, "org/simgrid/msg/HostNotFoundException", "No such host: " + invalid_name);
 }
 
-void jxbt_throw_process_not_found(JNIEnv * env, const char *invalid_name)
+void jxbt_throw_process_not_found(JNIEnv* env, const std::string& invalid_name)
 {
-  jxbt_throw_by_name(env, "org/simgrid/msg/ProcessNotFoundException", bprintf("No such process: %s", invalid_name));
+  jxbt_throw_by_name(env, "org/simgrid/msg/ProcessNotFoundException", "No such process: " + invalid_name);
 }
 
-void jxbt_throw_transfer_failure(JNIEnv * env, char *details)
+void jxbt_throw_transfer_failure(JNIEnv* env, const std::string& details)
 {
   jxbt_throw_by_name(env, "org/simgrid/msg/TransferFailureException", details);
 }
 
-void jxbt_throw_host_failure(JNIEnv * env, char *details)
+void jxbt_throw_host_failure(JNIEnv* env, const std::string& details)
 {
-  jxbt_throw_by_name(env, "org/simgrid/msg/HostFailureException", bprintf("Host Failure %s", details));
+  jxbt_throw_by_name(env, "org/simgrid/msg/HostFailureException", "Host Failure" + details);
 }
 
-void jxbt_throw_time_out_failure(JNIEnv * env, char *details)
+void jxbt_throw_time_out_failure(JNIEnv* env, const std::string& details)
 {
   jxbt_throw_by_name(env, "org/simgrid/msg/TimeoutException", details);
 }
 
-void jxbt_throw_task_cancelled(JNIEnv * env, char *details)
+void jxbt_throw_task_cancelled(JNIEnv* env, const std::string& details)
 {
   jxbt_throw_by_name(env, "org/simgrid/msg/TaskCancelledException", details);
 }