X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/01c96c4bc37fc4aac70e6b5fe3ff6992a9736c04..ca82f90e6d610b6bb3b038cd9ee48d378cc8a909:/src/mc/checker/simgrid_mc.cpp

diff --git a/src/mc/checker/simgrid_mc.cpp b/src/mc/checker/simgrid_mc.cpp
index 413b22da09..6e91f110ed 100644
--- a/src/mc/checker/simgrid_mc.cpp
+++ b/src/mc/checker/simgrid_mc.cpp
@@ -1,102 +1,68 @@
-/* Copyright (c) 2015. The SimGrid Team.
+/* Copyright (c) 2015-2019. The SimGrid Team.
  * All rights reserved.                                                     */
 
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
 
-#include <exception>
-
-#include <cstdlib>
-#include <cstdio>
-#include <cstring>
-
-#include <utility>
-
-#include <unistd.h>
-
-#include <xbt/log.h>
-
-#include "simgrid/sg_config.h"
-#include "src/xbt_modinter.h"
-
-#include "src/mc/mc_base.h"
-#include "src/mc/mc_private.h"
-#include "src/mc/mc_protocol.h"
-#include "src/mc/mc_safety.h"
-#include "src/mc/mc_comm_pattern.h"
-#include "src/mc/mc_exit.h"
+#include "simgrid/sg_config.hpp"
 #include "src/mc/Session.hpp"
 #include "src/mc/checker/Checker.hpp"
+#include "src/mc/mc_config.hpp"
+#include "src/mc/mc_exit.hpp"
 
-XBT_LOG_NEW_DEFAULT_SUBCATEGORY(mc_main, mc, "Entry point for simgrid-mc");
+#include <cstring>
+#include <memory>
+#include <unistd.h>
 
 static inline
 char** argvdup(int argc, char** argv)
 {
-  char** argv_copy = xbt_new(char*, argc+1);
+  char** argv_copy = new char*[argc + 1];
   std::memcpy(argv_copy, argv, sizeof(char*) * argc);
   argv_copy[argc] = nullptr;
   return argv_copy;
 }
 
-static
-std::unique_ptr<simgrid::mc::Checker> createChecker(simgrid::mc::Session& session)
+static std::unique_ptr<simgrid::mc::Checker> create_checker(simgrid::mc::Session& session)
 {
   if (_sg_mc_comms_determinism || _sg_mc_send_determinism)
-    return std::unique_ptr<simgrid::mc::Checker>(
-      simgrid::mc::createCommunicationDeterminismChecker(session));
-  else if (!_sg_mc_property_file || _sg_mc_property_file[0] == '\0')
-    return std::unique_ptr<simgrid::mc::Checker>(
-      simgrid::mc::createSafetyChecker(session));
+    return std::unique_ptr<simgrid::mc::Checker>(simgrid::mc::createCommunicationDeterminismChecker(session));
+  else if (_sg_mc_property_file.get().empty())
+    return std::unique_ptr<simgrid::mc::Checker>(simgrid::mc::createSafetyChecker(session));
   else
-    return std::unique_ptr<simgrid::mc::Checker>(
-      simgrid::mc::createLivenessChecker(session));
+    return std::unique_ptr<simgrid::mc::Checker>(simgrid::mc::createLivenessChecker(session));
 }
 
 int main(int argc, char** argv)
 {
-  using simgrid::mc::Session;
-
-  try {
-    if (argc < 2)
-      xbt_die("Missing arguments.\n");
+  if (argc < 2)
+    xbt_die("Missing arguments.\n");
 
-    // Currently, we need this before sg_config_init:
-    _sg_do_model_check = 1;
+  // Currently, we need this before sg_config_init:
+  _sg_do_model_check = 1;
 
-    // The initialization function can touch argv.
-    // We make a copy of argv before modifying it in order to pass the original
-    // value to the model-checked:
-    char** argv_copy = argvdup(argc, argv);
-    xbt_log_init(&argc, argv);
-    sg_config_init(&argc, argv);
+  // The initialization function can touch argv.
+  // We make a copy of argv before modifying it in order to pass the original
+  // value to the model-checked:
+  char** argv_copy = argvdup(argc, argv);
+  xbt_log_init(&argc, argv);
+  sg_config_init(&argc, argv);
 
-    std::unique_ptr<Session> session =
-      std::unique_ptr<Session>(Session::spawnvp(argv_copy[1], argv_copy+1));
-    free(argv_copy);
+  simgrid::mc::session = new simgrid::mc::Session([argv_copy] { execvp(argv_copy[1], argv_copy + 1); });
+  delete[] argv_copy;
 
-    simgrid::mc::session = session.get();
-    std::unique_ptr<simgrid::mc::Checker> checker = createChecker(*session);
-    int res = SIMGRID_MC_EXIT_SUCCESS;
-    try {
-      checker->run();
-    } catch (simgrid::mc::DeadlockError& de) {
-      res = SIMGRID_MC_EXIT_DEADLOCK;
-    } catch (simgrid::mc::TerminationError& te) {
-      res = SIMGRID_MC_EXIT_NON_TERMINATION;
-    } catch (simgrid::mc::LivenessError& le) {
-      res = SIMGRID_MC_EXIT_LIVENESS;
-    }
-    checker = nullptr;
-    session->close();
-    return res;
-  }
-  catch(std::exception& e) {
-    XBT_ERROR("Exception: %s", e.what());
-    return SIMGRID_MC_EXIT_ERROR;
-  }
-  catch(...) {
-    XBT_ERROR("Unknown exception");
-    return SIMGRID_MC_EXIT_ERROR;
+  std::unique_ptr<simgrid::mc::Checker> checker = create_checker(*simgrid::mc::session);
+  int res                                       = SIMGRID_MC_EXIT_SUCCESS;
+  try {
+    checker->run();
+  } catch (const simgrid::mc::DeadlockError&) {
+    res = SIMGRID_MC_EXIT_DEADLOCK;
+  } catch (const simgrid::mc::TerminationError&) {
+    res = SIMGRID_MC_EXIT_NON_TERMINATION;
+  } catch (const simgrid::mc::LivenessError&) {
+    res = SIMGRID_MC_EXIT_LIVENESS;
   }
+  checker = nullptr;
+  simgrid::mc::session->close();
+  return res;
 }