X-Git-Url: http://info.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/005cf0f71b3817a9e93de0b0c3bd92f216ef5c7f..f5fd55f293d7e019e8c23e7ff76e2b3743e40cd6:/src/msg/m_process.c diff --git a/src/msg/m_process.c b/src/msg/m_process.c index 6e8f6ba5f1..d6598a9c3a 100644 --- a/src/msg/m_process.c +++ b/src/msg/m_process.c @@ -28,12 +28,21 @@ XBT_LOG_NEW_DEFAULT_SUBCATEGORY(msg_process, msg, /******************************** Process ************************************/ void __MSG_process_cleanup(smx_process_t smx_proc) { - /* arg is a pointer to a simix process, we can get the msg process with the field data */ - m_process_t proc = SIMIX_req_process_get_data(smx_proc); + /* This function should be always be executed by the process being + * cleaned up */ + if(smx_proc != SIMIX_process_self()) + THROW_IMPOSSIBLE; + + /* arg is no longer used, just kept to avoid changing the interface */ + m_process_t proc = SIMIX_process_self_get_data(); + #ifdef HAVE_TRACING TRACE_msg_process_end(proc); #endif - xbt_fifo_remove(msg_global->process_list, proc); + + if(msg_global) + xbt_fifo_remove(msg_global->process_list, proc); + SIMIX_process_cleanup(smx_proc); if (proc->name) { free(proc->name); @@ -49,15 +58,16 @@ void __MSG_process_cleanup(smx_process_t smx_proc) } /* This function creates a MSG process. It has the prototype enforced by SIMIX_function_register_process_create */ -void *_MSG_process_create_from_SIMIX(const char *name, - xbt_main_func_t code, void *data, - char *hostname, int argc, char **argv, - xbt_dict_t properties) +void _MSG_process_create_from_SIMIX(void* process, const char *name, + xbt_main_func_t code, void *data, + char *hostname, int argc, char **argv, + xbt_dict_t properties) { m_host_t host = MSG_get_host_by_name(hostname); - return (void *) MSG_process_create_with_environment(name, code, data, + m_process_t p = MSG_process_create_with_environment(name, code, data, host, argc, argv, properties); + *((m_process_t*) process) = p; } /** \ingroup m_process_management @@ -142,16 +152,8 @@ m_process_t MSG_process_create_with_environment(const char *name, { simdata_process_t simdata = NULL; m_process_t process = xbt_new0(s_m_process_t, 1); - smx_process_t smx_process = NULL; xbt_assert0(((code != NULL) && (host != NULL)), "Invalid parameters"); - smx_process = SIMIX_process_create(name, code, (void *) process, host->name, - argc, argv, properties); - if (!smx_process) { - xbt_free(process); - return NULL; - } - simdata = xbt_new0(s_simdata_process_t, 1); /* Simulator Data */ @@ -161,7 +163,6 @@ m_process_t MSG_process_create_with_environment(const char *name, simdata->m_host = host; simdata->argc = argc; simdata->argv = argv; - simdata->s_process = smx_process; if (SIMIX_process_self()) { simdata->PPID = MSG_process_get_PID(SIMIX_process_self_get_data()); @@ -170,16 +171,32 @@ m_process_t MSG_process_create_with_environment(const char *name, } simdata->last_errno = MSG_OK; - /* Process structure */ process->name = xbt_strdup(name); process->simdata = simdata; process->data = data; - xbt_fifo_unshift(msg_global->process_list, process); - return process; + /* Let's create the process: SIMIX may decide to start it right now, + * even before returning the flow control to us */ + SIMIX_req_process_create(&simdata->s_process, name, code, (void *) process, host->name, + argc, argv, properties); + + if (!simdata->s_process) { + /* Undo everything we have just changed */ + msg_global->PID--; + xbt_fifo_remove(msg_global->process_list, process); + xbt_free(process->name); + xbt_free(process); + xbt_free(simdata); + return NULL; + } +#ifdef HAVE_TRACING + TRACE_msg_process_create (process); +#endif + + return process; } void _MSG_process_kill_from_SIMIX(void *p)