Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
Give a p_netcard to simgrid::Host instead of relying on extensions for that
[simgrid.git] / src / surf / surfxml_parse.c
index 34bbc7b..6a81309 100644 (file)
@@ -1,4 +1,4 @@
-/* Copyright (c) 2006-2014. The SimGrid Team.
+/* Copyright (c) 2006-2015. The SimGrid Team.
  * All rights reserved.                                                     */
 
 /* This program is free software; you can redistribute it and/or modify it
@@ -7,14 +7,14 @@
 #include <errno.h>
 #include <math.h>
 #include <stdarg.h> /* va_arg */
-#include <libgen.h>
 
 #include "xbt/misc.h"
 #include "xbt/log.h"
 #include "xbt/str.h"
+#include "xbt/file.h"
 #include "xbt/dict.h"
 #include "surf/surfxml_parse.h"
-#include "surf/surf_private.h"
+#include "src/surf/surf_private.h"
 #include "surf/random_mgr.h"
 #include "simgrid/sg_config.h"
 
@@ -82,7 +82,7 @@ static double surf_parse_get_value_with_unit(const char *string,
   double res;
   int i;
   errno = 0;
-  res = strtod(string, &ptr);
+  res   = strtod(string, &ptr);
   if (errno == ERANGE)
     surf_parse_error("value out of range: %s", string);
   if (ptr == string)
@@ -168,7 +168,7 @@ double surf_parse_get_bandwidth(const char *string)
   return surf_parse_get_value_with_unit(string, units);
 }
 
-double surf_parse_get_power(const char *string)
+double surf_parse_get_speed(const char *string)
 {
   const struct unit_scale units[] = {
     { "yottaflops", 1e24 },
@@ -229,15 +229,15 @@ void STag_surfxml_storage(void)
 }
 void ETag_surfxml_storage(void)
 {
-  s_sg_platf_storage_cbarg_t storage;
+  s_sg_platf_storage_cbarg_t storage = SG_PLATF_STORAGE_INITIALIZER;
   memset(&storage,0,sizeof(storage));
 
-  storage.id = A_surfxml_storage_id;
-  storage.type_id = A_surfxml_storage_typeId;
-  storage.content = A_surfxml_storage_content;
+  storage.id           = A_surfxml_storage_id;
+  storage.type_id      = A_surfxml_storage_typeId;
+  storage.content      = A_surfxml_storage_content;
   storage.content_type = A_surfxml_storage_content___type;
-  storage.properties = current_property_set;
-  storage.attach = A_surfxml_storage_attach;
+  storage.properties   = current_property_set;
+  storage.attach       = A_surfxml_storage_attach;
   sg_platf_new_storage(&storage);
   current_property_set = NULL;
 }
@@ -250,18 +250,18 @@ void STag_surfxml_storage___type(void)
 }
 void ETag_surfxml_storage___type(void)
 {
-  s_sg_platf_storage_type_cbarg_t storage_type;
+  s_sg_platf_storage_type_cbarg_t storage_type = SG_PLATF_STORAGE_TYPE_INITIALIZER;
   memset(&storage_type,0,sizeof(storage_type));
 
-  storage_type.content = A_surfxml_storage___type_content;
-  storage_type.content_type = A_surfxml_storage___type_content___type;
-  storage_type.id = A_surfxml_storage___type_id;
-  storage_type.model = A_surfxml_storage___type_model;
-  storage_type.properties = current_property_set;
+  storage_type.content          = A_surfxml_storage___type_content;
+  storage_type.content_type     = A_surfxml_storage___type_content___type;
+  storage_type.id               = A_surfxml_storage___type_id;
+  storage_type.model            = A_surfxml_storage___type_model;
+  storage_type.properties       = current_property_set;
   storage_type.model_properties = current_model_property_set;
-  storage_type.size = surf_parse_get_size(A_surfxml_storage___type_size);
+  storage_type.size             = surf_parse_get_size(A_surfxml_storage___type_size);
   sg_platf_new_storage_type(&storage_type);
-  current_property_set = NULL;
+  current_property_set       = NULL;
   current_model_property_set = NULL;
 }
 void STag_surfxml_mstorage(void)
@@ -270,10 +270,10 @@ void STag_surfxml_mstorage(void)
 }
 void ETag_surfxml_mstorage(void)
 {
-  s_sg_platf_mstorage_cbarg_t mstorage;
+  s_sg_platf_mstorage_cbarg_t mstorage = SG_PLATF_MSTORAGE_INITIALIZER;
   memset(&mstorage,0,sizeof(mstorage));
 
-  mstorage.name = A_surfxml_mstorage_name;
+  mstorage.name    = A_surfxml_mstorage_name;
   mstorage.type_id = A_surfxml_mstorage_typeId;
   sg_platf_new_mstorage(&mstorage);
 }
@@ -283,10 +283,10 @@ void STag_surfxml_mount(void)
 }
 void ETag_surfxml_mount(void)
 {
-  s_sg_platf_mount_cbarg_t mount;
+  s_sg_platf_mount_cbarg_t mount = SG_PLATF_MOUNT_INITIALIZER;
   memset(&mount,0,sizeof(mount));
 
-  mount.name = A_surfxml_mount_name;
+  mount.name      = A_surfxml_mount_name;
   mount.storageId = A_surfxml_mount_storageId;
   sg_platf_new_mount(&mount);
 }
@@ -294,8 +294,8 @@ void ETag_surfxml_mount(void)
 /*
  * Stuff relative to the <include> tag
  */
-static xbt_dynar_t surf_input_buffer_stack = NULL;
-static xbt_dynar_t surf_file_to_parse_stack = NULL;
+static xbt_dynar_t surf_input_buffer_stack    = NULL;
+static xbt_dynar_t surf_file_to_parse_stack   = NULL;
 static xbt_dynar_t surf_parsed_filename_stack = NULL;
 
 void STag_surfxml_include(void)
@@ -324,7 +324,7 @@ void ETag_surfxml_include(void) {
 
 /** @brief When reaching EOF, check whether we are in an include tag, and behave accordingly if yes
  *
- * This function is called automatically by sedding the parser in buildtools/Cmake/MaintainerMode.cmake
+ * This function is called automatically by sedding the parser in tools/cmake/MaintainerMode.cmake
  * Every FAIL on "Premature EOF" is preceded by a call to this function, which role is to restore the
  * previous buffer if we reached the EOF /of an include file/. Its return code is used to avoid the
  * error message in that case.
@@ -374,7 +374,7 @@ void surf_parse_free_callbacks(void)
 /* Stag and Etag parse functions */
 
 void STag_surfxml_platform(void) {
-  _XBT_GNUC_UNUSED double version = surf_parse_get_double(A_surfxml_platform_version);
+  XBT_ATTRIB_UNUSED double version = surf_parse_get_double(A_surfxml_platform_version);
 
   xbt_assert((version >= 1.0), "******* BIG FAT WARNING *********\n "
       "You're using an ancient XML file.\n"
@@ -430,7 +430,7 @@ void STag_surfxml_prop(void)
 }
 
 void ETag_surfxml_host(void)    {
-  s_sg_platf_host_cbarg_t host;
+  s_sg_platf_host_cbarg_t host = SG_PLATF_HOST_INITIALIZER;
   char* buf;
   memset(&host,0,sizeof(host));
 
@@ -441,34 +441,33 @@ void ETag_surfxml_host(void)    {
 
   buf = A_surfxml_host_power;
   XBT_DEBUG("Buffer: %s", buf);
-  host.power_peak = xbt_dynar_new(sizeof(double), NULL);
+  host.speed_peak = xbt_dynar_new(sizeof(double), NULL);
   if (strchr(buf, ',') == NULL){
-         double power_value = get_cpu_power(A_surfxml_host_power);
-         xbt_dynar_push_as(host.power_peak,double, power_value);
+         double speed = get_cpu_speed(A_surfxml_host_power);
+         xbt_dynar_push_as(host.speed_peak,double, speed);
   }
   else {
          xbt_dynar_t pstate_list = xbt_str_split(buf, ",");
          int i;
          for (i = 0; i < xbt_dynar_length(pstate_list); i++) {
-                 double power_value;
-                 char* power_value_str;
-
-                 xbt_dynar_get_cpy(pstate_list, i, &power_value_str);
-                 xbt_str_trim(power_value_str, NULL);
-                 power_value = get_cpu_power(power_value_str);
-                 xbt_dynar_push_as(host.power_peak, double, power_value);
-                 XBT_DEBUG("Power value: %f", power_value);
+                 double speed;
+                 char* speed_str;
+
+                 xbt_dynar_get_cpy(pstate_list, i, &speed_str);
+                 xbt_str_trim(speed_str, NULL);
+                 speed = get_cpu_speed(speed_str);
+                 xbt_dynar_push_as(host.speed_peak, double, speed);
+                 XBT_DEBUG("Speed value: %f", speed);
          }
          xbt_dynar_free(&pstate_list);
   }
 
   XBT_DEBUG("pstate: %s", A_surfxml_host_pstate);
-  //host.power_peak = get_cpu_power(A_surfxml_host_power);
-  host.power_scale = surf_parse_get_double( A_surfxml_host_availability);
+  host.speed_scale = surf_parse_get_double( A_surfxml_host_availability);
   host.core_amount = surf_parse_get_int(A_surfxml_host_core);
-  host.power_trace = tmgr_trace_new_from_file(A_surfxml_host_availability___file);
+  host.speed_trace = tmgr_trace_new_from_file(A_surfxml_host_availability___file);
   host.state_trace = tmgr_trace_new_from_file(A_surfxml_host_state___file);
-  host.pstate = surf_parse_get_int(A_surfxml_host_pstate);
+  host.pstate      = surf_parse_get_int(A_surfxml_host_pstate);
 
   xbt_assert((A_surfxml_host_state == A_surfxml_host_state_ON) ||
         (A_surfxml_host_state == A_surfxml_host_state_OFF), "Invalid state");
@@ -479,43 +478,44 @@ void ETag_surfxml_host(void)    {
   host.coord = A_surfxml_host_coordinates;
 
   sg_platf_new_host(&host);
+  xbt_dynar_free(&host.speed_peak);
   current_property_set = NULL;
 }
 
 void STag_surfxml_host___link(void){
   XBT_DEBUG("Create a Host_link for %s",A_surfxml_host___link_id);
-  s_sg_platf_host_link_cbarg_t host_link;
+  s_sg_platf_host_link_cbarg_t host_link = SG_PLATF_HOST_LINK_INITIALIZER;
   memset(&host_link,0,sizeof(host_link));
 
-  host_link.id = A_surfxml_host___link_id;
-  host_link.link_up = A_surfxml_host___link_up;
+  host_link.id        = A_surfxml_host___link_id;
+  host_link.link_up   = A_surfxml_host___link_up;
   host_link.link_down = A_surfxml_host___link_down;
-  sg_platf_new_host_link(&host_link);
+  sg_platf_new_netcard(&host_link);
 }
 
 void STag_surfxml_router(void){
-  s_sg_platf_router_cbarg_t router;
+  s_sg_platf_router_cbarg_t router = SG_PLATF_ROUTER_INITIALIZER;
   memset(&router, 0, sizeof(router));
 
-  router.id = A_surfxml_router_id;
+  router.id    = A_surfxml_router_id;
   router.coord = A_surfxml_router_coordinates;
 
   sg_platf_new_router(&router);
 }
 
 void ETag_surfxml_cluster(void){
-  s_sg_platf_cluster_cbarg_t cluster;
+  s_sg_platf_cluster_cbarg_t cluster = SG_PLATF_CLUSTER_INITIALIZER;
   memset(&cluster,0,sizeof(cluster));
   cluster.properties = as_current_property_set;
 
-  cluster.id = A_surfxml_cluster_id;
-  cluster.prefix = A_surfxml_cluster_prefix;
-  cluster.suffix = A_surfxml_cluster_suffix;
-  cluster.radical = A_surfxml_cluster_radical;
-  cluster.power = surf_parse_get_power(A_surfxml_cluster_power);
+  cluster.id          = A_surfxml_cluster_id;
+  cluster.prefix      = A_surfxml_cluster_prefix;
+  cluster.suffix      = A_surfxml_cluster_suffix;
+  cluster.radical     = A_surfxml_cluster_radical;
+  cluster.speed       = surf_parse_get_speed(A_surfxml_cluster_power);
   cluster.core_amount = surf_parse_get_int(A_surfxml_cluster_core);
-  cluster.bw =   surf_parse_get_bandwidth(A_surfxml_cluster_bw);
-  cluster.lat  surf_parse_get_time(A_surfxml_cluster_lat);
+  cluster.bw          = surf_parse_get_bandwidth(A_surfxml_cluster_bw);
+  cluster.lat         = surf_parse_get_time(A_surfxml_cluster_lat);
   if(strcmp(A_surfxml_cluster_bb___bw,""))
     cluster.bb_bw = surf_parse_get_bandwidth(A_surfxml_cluster_bb___bw);
   if(strcmp(A_surfxml_cluster_bb___lat,""))
@@ -587,14 +587,14 @@ void STag_surfxml_cluster(void){
 
 void STag_surfxml_cabinet(void){
   parse_after_config();
-  s_sg_platf_cabinet_cbarg_t cabinet;
+  s_sg_platf_cabinet_cbarg_t cabinet = SG_PLATF_CABINET_INITIALIZER;
   memset(&cabinet,0,sizeof(cabinet));
-  cabinet.id = A_surfxml_cabinet_id;
-  cabinet.prefix = A_surfxml_cabinet_prefix;
-  cabinet.suffix = A_surfxml_cabinet_suffix;
-  cabinet.power = surf_parse_get_power(A_surfxml_cabinet_power);
-  cabinet.bw = surf_parse_get_bandwidth(A_surfxml_cabinet_bw);
-  cabinet.lat = surf_parse_get_time(A_surfxml_cabinet_lat);
+  cabinet.id      = A_surfxml_cabinet_id;
+  cabinet.prefix  = A_surfxml_cabinet_prefix;
+  cabinet.suffix  = A_surfxml_cabinet_suffix;
+  cabinet.speed   = surf_parse_get_speed(A_surfxml_cabinet_power);
+  cabinet.bw      = surf_parse_get_bandwidth(A_surfxml_cabinet_bw);
+  cabinet.lat     = surf_parse_get_time(A_surfxml_cabinet_lat);
   cabinet.radical = A_surfxml_cabinet_radical;
 
   sg_platf_new_cabinet(&cabinet);
@@ -602,16 +602,16 @@ void STag_surfxml_cabinet(void){
 
 void STag_surfxml_peer(void){
   parse_after_config();
-  s_sg_platf_peer_cbarg_t peer;
+  s_sg_platf_peer_cbarg_t peer = SG_PLATF_PEER_INITIALIZER;
   memset(&peer,0,sizeof(peer));
-  peer.id = A_surfxml_peer_id;
-  peer.power = surf_parse_get_power(A_surfxml_peer_power);
-  peer.bw_in = surf_parse_get_bandwidth(A_surfxml_peer_bw___in);
-  peer.bw_out = surf_parse_get_bandwidth(A_surfxml_peer_bw___out);
-  peer.lat = surf_parse_get_time(A_surfxml_peer_lat);
-  peer.coord = A_surfxml_peer_coordinates;
+  peer.id                 = A_surfxml_peer_id;
+  peer.speed              = surf_parse_get_speed(A_surfxml_peer_power);
+  peer.bw_in              = surf_parse_get_bandwidth(A_surfxml_peer_bw___in);
+  peer.bw_out             = surf_parse_get_bandwidth(A_surfxml_peer_bw___out);
+  peer.lat                = surf_parse_get_time(A_surfxml_peer_lat);
+  peer.coord              = A_surfxml_peer_coordinates;
   peer.availability_trace = tmgr_trace_new_from_file(A_surfxml_peer_availability___file);
-  peer.state_trace = tmgr_trace_new_from_file(A_surfxml_peer_state___file);
+  peer.state_trace        = tmgr_trace_new_from_file(A_surfxml_peer_state___file);
 
   sg_platf_new_peer(&peer);
 }
@@ -622,18 +622,18 @@ void STag_surfxml_link(void){
 }
 
 void ETag_surfxml_link(void){
-  s_sg_platf_link_cbarg_t link;
+  s_sg_platf_link_cbarg_t link = SG_PLATF_LINK_INITIALIZER;
   memset(&link,0,sizeof(link));
 
   link.properties = current_property_set;
 
-  link.id = A_surfxml_link_id;
-  link.bandwidth = surf_parse_get_bandwidth(A_surfxml_link_bandwidth);
+  link.id                                            = A_surfxml_link_id;
+  link.bandwidth                                     = surf_parse_get_bandwidth(A_surfxml_link_bandwidth);
   //printf("Link bandwidth [%g]\n", link.bandwidth);
-  link.bandwidth_trace = tmgr_trace_new_from_file(A_surfxml_link_bandwidth___file);
-  link.latency = surf_parse_get_time(A_surfxml_link_latency);
+  link.bandwidth_trace                               = tmgr_trace_new_from_file(A_surfxml_link_bandwidth___file);
+  link.latency                                       = surf_parse_get_time(A_surfxml_link_latency);
   //printf("Link latency [%g]\n", link.latency);
-  link.latency_trace = tmgr_trace_new_from_file(A_surfxml_link_latency___file);
+  link.latency_trace                                 = tmgr_trace_new_from_file(A_surfxml_link_latency___file);
 
   switch (A_surfxml_link_state) {
   case A_surfxml_link_state_ON:
@@ -690,7 +690,7 @@ void STag_surfxml_link___ctn(void){
 }
 
 void ETag_surfxml_backbone(void){
-  s_sg_platf_link_cbarg_t link;
+  s_sg_platf_link_cbarg_t link = SG_PLATF_LINK_INITIALIZER;
   memset(&link,0,sizeof(link));
 
   link.properties = NULL;
@@ -702,7 +702,7 @@ void ETag_surfxml_backbone(void){
   link.policy = SURF_LINK_SHARED;
 
   sg_platf_new_link(&link);
-  routing_cluster_add_backbone(xbt_lib_get_or_null(link_lib, A_surfxml_backbone_id, SURF_LINK_LEVEL));
+  routing_cluster_add_backbone(sg_link_by_name(A_surfxml_backbone_id));
 }
 
 void STag_surfxml_route(void){
@@ -743,13 +743,13 @@ void STag_surfxml_bypassASroute(void){
 }
 
 void ETag_surfxml_route(void){
-  s_sg_platf_route_cbarg_t route;
+  s_sg_platf_route_cbarg_t route = SG_PLATF_ROUTE_INITIALIZER;
   memset(&route,0,sizeof(route));
 
-  route.src = A_surfxml_route_src;
-  route.dst = A_surfxml_route_dst;
-  route.gw_src = NULL;
-  route.gw_dst = NULL;
+  route.src       = A_surfxml_route_src;
+  route.dst       = A_surfxml_route_dst;
+  route.gw_src    = NULL;
+  route.gw_dst    = NULL;
   route.link_list = parsed_link_list;
 
   switch (A_surfxml_route_symmetrical) {
@@ -767,14 +767,14 @@ void ETag_surfxml_route(void){
 }
 
 void ETag_surfxml_ASroute(void){
-  s_sg_platf_route_cbarg_t ASroute;
+  s_sg_platf_route_cbarg_t ASroute = SG_PLATF_ROUTE_INITIALIZER;
   memset(&ASroute,0,sizeof(ASroute));
 
   ASroute.src = A_surfxml_ASroute_src;
   ASroute.dst = A_surfxml_ASroute_dst;
 
-  ASroute.gw_src = sg_routing_edge_by_name_or_null(A_surfxml_ASroute_gw___src);
-  ASroute.gw_dst = sg_routing_edge_by_name_or_null(A_surfxml_ASroute_gw___dst);
+  ASroute.gw_src = sg_netcard_by_name_or_null(A_surfxml_ASroute_gw___src);
+  ASroute.gw_dst = sg_netcard_by_name_or_null(A_surfxml_ASroute_gw___dst);
 
   if (A_surfxml_ASroute_gw___src && !ASroute.gw_src)
     surf_parse_error("gw_src=\"%s\" not found for ASroute from \"%s\" to \"%s\"",
@@ -800,7 +800,7 @@ void ETag_surfxml_ASroute(void){
 }
 
 void ETag_surfxml_bypassRoute(void){
-  s_sg_platf_route_cbarg_t route;
+  s_sg_platf_route_cbarg_t route = SG_PLATF_ROUTE_INITIALIZER;
   memset(&route,0,sizeof(route));
 
   route.src = A_surfxml_bypassRoute_src;
@@ -815,23 +815,23 @@ void ETag_surfxml_bypassRoute(void){
 }
 
 void ETag_surfxml_bypassASroute(void){
-  s_sg_platf_route_cbarg_t ASroute;
+  s_sg_platf_route_cbarg_t ASroute = SG_PLATF_ROUTE_INITIALIZER;
   memset(&ASroute,0,sizeof(ASroute));
 
-  ASroute.src = A_surfxml_bypassASroute_src;
-  ASroute.dst = A_surfxml_bypassASroute_dst;
-  ASroute.link_list = parsed_link_list;
+  ASroute.src         = A_surfxml_bypassASroute_src;
+  ASroute.dst         = A_surfxml_bypassASroute_dst;
+  ASroute.link_list   = parsed_link_list;
   ASroute.symmetrical = FALSE;
 
-  ASroute.gw_src = sg_routing_edge_by_name_or_null(A_surfxml_bypassASroute_gw___src);
-  ASroute.gw_dst = sg_routing_edge_by_name_or_null(A_surfxml_bypassASroute_gw___dst);
+  ASroute.gw_src = sg_netcard_by_name_or_null(A_surfxml_bypassASroute_gw___src);
+  ASroute.gw_dst = sg_netcard_by_name_or_null(A_surfxml_bypassASroute_gw___dst);
 
   sg_platf_new_bypassASroute(&ASroute);
   parsed_link_list = NULL;
 }
 
 void ETag_surfxml_trace(void){
-  s_sg_platf_trace_cbarg_t trace;
+  s_sg_platf_trace_cbarg_t trace = SG_PLATF_TRACE_INITIALIZER;
   memset(&trace,0,sizeof(trace));
 
   trace.id = A_surfxml_trace_id;
@@ -844,7 +844,7 @@ void ETag_surfxml_trace(void){
 
 void STag_surfxml_trace___connect(void){
   parse_after_config();
-  s_sg_platf_trace_connect_cbarg_t trace_connect;
+  s_sg_platf_trace_connect_cbarg_t trace_connect = SG_PLATF_TRACE_CONNECT_INITIALIZER;
   memset(&trace_connect,0,sizeof(trace_connect));
 
   trace_connect.element = A_surfxml_trace___connect_element;
@@ -873,10 +873,10 @@ void STag_surfxml_trace___connect(void){
 
 void STag_surfxml_AS(void){
   parse_after_config();
-  AS_TAG = 1;
+  AS_TAG                   = 1;
   s_sg_platf_AS_cbarg_t AS = SG_PLATF_AS_INITIALIZER;
-  AS.id = A_surfxml_AS_id;
-  AS.routing = (int)A_surfxml_AS_routing;
+  AS.id                    = A_surfxml_AS_id;
+  AS.routing               = (int)A_surfxml_AS_routing;
 
   as_current_property_set = NULL;
 
@@ -884,7 +884,7 @@ void STag_surfxml_AS(void){
 }
 void ETag_surfxml_AS(void){
   if(as_prop_nb){
-    char *name = as_name_tab[as_prop_nb-1];
+    char *name      = as_name_tab[as_prop_nb-1];
     xbt_dict_t dict = as_dict_tab[as_prop_nb-1];
     as_prop_nb--;
     XBT_DEBUG("POP prop %p for AS '%s'",dict,name);
@@ -928,24 +928,24 @@ static int argc;
 static char **argv;
 
 void STag_surfxml_process(void){
-  AS_TAG = 0;
-  argc = 1;
-  argv = xbt_new(char *, 1);
+  AS_TAG  = 0;
+  argc    = 1;
+  argv    = xbt_new(char *, 1);
   argv[0] = xbt_strdup(A_surfxml_process_function);
   xbt_assert(current_property_set == NULL, "Someone forgot to reset the property set to NULL in its closing tag (or XML malformed)");
 }
 
 void ETag_surfxml_process(void){
-  s_sg_platf_process_cbarg_t process;
+  s_sg_platf_process_cbarg_t process = SG_PLATF_PROCESS_INITIALIZER;
   memset(&process,0,sizeof(process));
 
-  process.argc = argc;
-  process.argv = (const char **)argv;
+  process.argc       = argc;
+  process.argv       = (const char **)argv;
   process.properties = current_property_set;
-  process.host = A_surfxml_process_host;
-  process.function = A_surfxml_process_function;
+  process.host       = A_surfxml_process_host;
+  process.function   = A_surfxml_process_function;
   process.start_time = surf_parse_get_double(A_surfxml_process_start___time);
-  process.kill_time = surf_parse_get_double(A_surfxml_process_kill___time);
+  process.kill_time  = surf_parse_get_double(A_surfxml_process_kill___time);
 
   switch (A_surfxml_process_on___failure) {
   case AU_surfxml_process_on___failure:
@@ -974,22 +974,8 @@ void STag_surfxml_model___prop(void){
   xbt_dict_set(current_model_property_set, A_surfxml_model___prop_id, xbt_strdup(A_surfxml_model___prop_value), NULL);
 }
 
-/* ***************************************** */
-/* TUTORIAL: New TAG                         */
-void STag_surfxml_gpu(void)
-{
-  XBT_DEBUG("STag_surfxml_gpu");
-}
-void ETag_surfxml_gpu(void)
-{
-  s_sg_platf_gpu_cbarg_t gpu;
-  memset(&gpu,0,sizeof(gpu));
-
-  gpu.name = A_surfxml_gpu_name;
-
-  sg_platf_new_gpu(&gpu);
-}
-/* ***************************************** */
+void STag_surfxml_gpu(void) {}
+void ETag_surfxml_gpu(void) {}
 
 /* nothing to do in those functions */
 void ETag_surfxml_prop(void){}
@@ -1028,8 +1014,9 @@ void surf_parse_open(const char *file)
 
   if (!surf_parsed_filename_stack)
     surf_parsed_filename_stack = xbt_dynar_new(sizeof(char *), &xbt_free_ref);
+
   surf_parsed_filename = xbt_strdup(file);
-  char *dir = dirname(surf_parsed_filename);
+  char *dir = xbt_dirname(file);
   xbt_dynar_push(surf_path, &dir);
 
   surf_file_to_parse = surf_fopen(file, "r");
@@ -1074,27 +1061,27 @@ int_f_void_t surf_parse = _surf_parse;
  * With XML parser
  */
 
-double get_cpu_power(const char *power)
+double get_cpu_speed(const char *str_speed)
 {
-  double power_scale = 0.0;
+  double speed = 0.0;
   const char *p, *q;
   char *generator;
   random_data_t random = NULL;
   /* randomness is inserted like this: power="$rand(my_random)" */
-  if (((p = strstr(power, "$rand(")) != NULL)
-      && ((q = strstr(power, ")")) != NULL)) {
+  if (((p = strstr(str_speed, "$rand(")) != NULL)
+      && ((q = strstr(str_speed, ")")) != NULL)) {
     if (p < q) {
       generator = xbt_malloc(q - (p + 6) + 1);
       memcpy(generator, p + 6, q - (p + 6));
       generator[q - (p + 6)] = '\0';
       random = xbt_dict_get_or_null(random_data_list, generator);
       xbt_assert(random, "Random generator %s undefined", generator);
-      power_scale = random_generate(random);
+      speed = random_generate(random);
     }
   } else {
-    power_scale = surf_parse_get_power(power);
+    speed = surf_parse_get_speed(str_speed);
   }
-  return power_scale;
+  return speed;
 }
 
 double random_min, random_max, random_mean, random_std_deviation;