Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
add a surf_parse_warn and get surf_parse_error() accepting variable amount of parameters
[simgrid.git] / src / surf / surfxml_parse.c
index aec1820..ab0282a 100644 (file)
@@ -4,6 +4,8 @@
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
 
+#include <stdarg.h> /* va_arg */
+
 #include "xbt/misc.h"
 #include "xbt/log.h"
 #include "xbt/str.h"
@@ -18,11 +20,25 @@ int ETag_surfxml_include_state(void);
 
 #include "simgrid_dtd.c"
 
+char* surf_parsed_filename = NULL; // to locate parse error messages
+
 /*
  * Helping functions
  */
-void surf_parse_error(const char *msg) {
-  xbt_die("Parse error on line %d: %s\n", surf_parse_lineno, msg);
+void surf_parse_error(const char *fmt, ...) {
+       va_list va;
+       va_start(va,fmt);
+       char *msg = bvprintf(fmt,va);
+       va_end(va);
+       xbt_die("Parse error at %s:%d: %s", surf_parsed_filename, surf_parse_lineno, msg);
+}
+void surf_parse_warn(const char *fmt, ...) {
+       va_list va;
+       va_start(va,fmt);
+       char *msg = bvprintf(fmt,va);
+       va_end(va);
+    XBT_WARN("%s:%d: %s", surf_parsed_filename, surf_parse_lineno, msg);
+    free(msg);
 }
 
 double surf_parse_get_double(const char *string) {
@@ -90,21 +106,25 @@ static void add_randomness(void);
 /*
  * Stuff relative to the <include> tag
  */
-
 static xbt_dynar_t surf_input_buffer_stack = NULL;
 static xbt_dynar_t surf_file_to_parse_stack = NULL;
+static xbt_dynar_t surf_parsed_filename_stack = NULL;
 
 void STag_surfxml_include(void)
 {
   XBT_INFO("STag_surfxml_include '%s'",A_surfxml_include_file);
-  xbt_dynar_push(surf_file_to_parse_stack, &surf_file_to_parse); //save old filename
+  xbt_dynar_push(surf_parsed_filename_stack,&surf_parsed_filename); // save old file name
+  surf_parsed_filename = xbt_strdup(A_surfxml_include_file);
 
-  surf_file_to_parse = surf_fopen(A_surfxml_include_file, "r"); // read new filename
+  xbt_dynar_push(surf_file_to_parse_stack, &surf_file_to_parse); //save old file descriptor
+
+  surf_file_to_parse = surf_fopen(A_surfxml_include_file, "r"); // read new file descriptor
   xbt_assert((surf_file_to_parse), "Unable to open \"%s\"\n",
               A_surfxml_include_file);
   xbt_dynar_push(surf_input_buffer_stack,&surf_input_buffer);
   surf_input_buffer = surf_parse__create_buffer(surf_file_to_parse, YY_BUF_SIZE);
   surf_parse_push_buffer_state(surf_input_buffer);
+
   fflush(NULL);
 }
 
@@ -122,18 +142,26 @@ void ETag_surfxml_include(void) {
  *
  * Yeah, that's terribly hackish, but it works. A better solution should be dealed with in flexml
  * directly: a command line flag could instruct it to do the correct thing when #include is encountered
- * on a line.
+ * on a line. One day maybe, if the maya allow it.
  */
 int ETag_surfxml_include_state(void)
 {
   fflush(NULL);
   XBT_INFO("ETag_surfxml_include_state '%s'",A_surfxml_include_file);
-  if(!xbt_dynar_is_empty(surf_input_buffer_stack))
+
+  if(!xbt_dynar_is_empty(surf_input_buffer_stack)) // nope, that's a true premature EOF. Let the parser die verbosely.
          return 1;
+
+  // Yeah, we were in an <include> Restore state and proceed.
   fclose(surf_file_to_parse);
   xbt_dynar_pop(surf_file_to_parse_stack, &surf_file_to_parse);
   surf_parse_pop_buffer_state();
   xbt_dynar_pop(surf_input_buffer_stack,surf_input_buffer);
+
+  // Restore the filename for error messages
+  free(surf_parsed_filename);
+  xbt_dynar_pop(surf_parsed_filename_stack,&surf_parsed_filename);
+
   return 0;
 }
 
@@ -253,29 +281,30 @@ void ETag_surfxml_platform(void){
 }
 
 void STag_surfxml_host(void){
-  s_sg_platf_host_cbarg_t host;
-  memset(&host,0,sizeof(host));
-
   xbt_assert(current_property_set == NULL, "Someone forgot to reset the property set to NULL in its closing tag (or XML malformed)");
-  host.properties = current_property_set = xbt_dict_new();
-
-       host.id = A_surfxml_host_id;
-       host.power_peak = get_cpu_power(A_surfxml_host_power);
-       host.power_scale = surf_parse_get_double( A_surfxml_host_availability);
-       host.core_amount = surf_parse_get_int(A_surfxml_host_core);
-       host.power_trace = tmgr_trace_new(A_surfxml_host_availability_file);
-       host.state_trace = tmgr_trace_new(A_surfxml_host_state_file);
-       xbt_assert((A_surfxml_host_state == A_surfxml_host_state_ON) ||
-                         (A_surfxml_host_state == A_surfxml_host_state_OFF), "Invalid state");
-       if (A_surfxml_host_state == A_surfxml_host_state_ON)
-               host.initial_state = SURF_RESOURCE_ON;
-       if (A_surfxml_host_state == A_surfxml_host_state_OFF)
-               host.initial_state = SURF_RESOURCE_OFF;
-       host.coord = A_surfxml_host_coordinates;
-
-       sg_platf_new_host(&host);
 }
+
 void ETag_surfxml_host(void)    {
+  s_sg_platf_host_cbarg_t host;
+  memset(&host,0,sizeof(host));
+
+  host.properties = current_property_set;
+
+  host.id = A_surfxml_host_id;
+  host.power_peak = get_cpu_power(A_surfxml_host_power);
+  host.power_scale = surf_parse_get_double( A_surfxml_host_availability);
+  host.core_amount = surf_parse_get_int(A_surfxml_host_core);
+  host.power_trace = tmgr_trace_new(A_surfxml_host_availability_file);
+  host.state_trace = tmgr_trace_new(A_surfxml_host_state_file);
+  xbt_assert((A_surfxml_host_state == A_surfxml_host_state_ON) ||
+        (A_surfxml_host_state == A_surfxml_host_state_OFF), "Invalid state");
+  if (A_surfxml_host_state == A_surfxml_host_state_ON)
+    host.initial_state = SURF_RESOURCE_ON;
+  if (A_surfxml_host_state == A_surfxml_host_state_OFF)
+    host.initial_state = SURF_RESOURCE_OFF;
+  host.coord = A_surfxml_host_coordinates;
+
+  sg_platf_new_host(&host);
   current_property_set = NULL;
 }
 
@@ -363,47 +392,50 @@ void ETag_surfxml_peer(void){
   /* nothing to do here */
 }
 void STag_surfxml_link(void){
-  s_sg_platf_link_cbarg_t link;
-  memset(&link,0,sizeof(link));
-
   xbt_assert(current_property_set == NULL, "Someone forgot to reset the property set to NULL in its closing tag (or XML malformed)");
-  link.properties = current_property_set = xbt_dict_new();
-
-       link.id = A_surfxml_link_id;
-       link.bandwidth = surf_parse_get_double(A_surfxml_link_bandwidth);
-       link.bandwidth_trace = tmgr_trace_new(A_surfxml_link_bandwidth_file);
-       link.latency = surf_parse_get_double(A_surfxml_link_latency);
-       link.latency_trace = tmgr_trace_new(A_surfxml_link_latency_file);
-
-       switch (A_surfxml_link_state) {
-       case A_surfxml_link_state_ON:
-               link.state = SURF_RESOURCE_ON;
-               break;
-       case A_surfxml_link_state_OFF:
-               link.state = SURF_RESOURCE_OFF;
-               break;
-       default:
-         surf_parse_error(bprintf("invalid state for link %s",link.id));
-       }
-       link.state_trace = tmgr_trace_new(A_surfxml_link_state_file);
-
-       switch (A_surfxml_link_sharing_policy) {
-       case A_surfxml_link_sharing_policy_SHARED:
-               link.policy = SURF_LINK_SHARED;
-               break;
-       case A_surfxml_link_sharing_policy_FATPIPE:
-                link.policy = SURF_LINK_FATPIPE;
-                break;
-       case A_surfxml_link_sharing_policy_FULLDUPLEX:
-                link.policy = SURF_LINK_FULLDUPLEX;
-                break;
-       default:
-         surf_parse_error(bprintf("Invalid sharing policy in link %s",link.id));
-       }
-
-       sg_platf_new_link(&link);
 }
 void ETag_surfxml_link(void){
+  s_sg_platf_link_cbarg_t link;
+  memset(&link,0,sizeof(link));
+
+  link.properties = current_property_set;
+
+  link.id = A_surfxml_link_id;
+  link.bandwidth = surf_parse_get_double(A_surfxml_link_bandwidth);
+  link.bandwidth_trace = tmgr_trace_new(A_surfxml_link_bandwidth_file);
+  link.latency = surf_parse_get_double(A_surfxml_link_latency);
+  link.latency_trace = tmgr_trace_new(A_surfxml_link_latency_file);
+
+  switch (A_surfxml_link_state) {
+  case A_surfxml_link_state_ON:
+    link.state = SURF_RESOURCE_ON;
+    break;
+  case A_surfxml_link_state_OFF:
+    link.state = SURF_RESOURCE_OFF;
+    break;
+  default:
+    surf_parse_error(bprintf("invalid state for link %s",link.id));
+    break;
+  }
+  link.state_trace = tmgr_trace_new(A_surfxml_link_state_file);
+
+  switch (A_surfxml_link_sharing_policy) {
+  case A_surfxml_link_sharing_policy_SHARED:
+    link.policy = SURF_LINK_SHARED;
+    break;
+  case A_surfxml_link_sharing_policy_FATPIPE:
+     link.policy = SURF_LINK_FATPIPE;
+     break;
+  case A_surfxml_link_sharing_policy_FULLDUPLEX:
+     link.policy = SURF_LINK_FULLDUPLEX;
+     break;
+  default:
+    surf_parse_error(bprintf("Invalid sharing policy in link %s",link.id));
+    break;
+  }
+
+  sg_platf_new_link(&link);
+
   current_property_set = NULL;
 }
 
@@ -443,8 +475,6 @@ void STag_surfxml_bypassRoute(void){
 void STag_surfxml_config(void){
   XBT_DEBUG("START configuration name = %s",A_surfxml_config_id);
   xbt_assert(current_property_set == NULL, "Someone forgot to reset the property set to NULL in its closing tag (or XML malformed)");
-  current_property_set = xbt_dict_new();
-
 }
 void ETag_surfxml_config(void){
   xbt_dict_cursor_t cursor = NULL;
@@ -500,6 +530,10 @@ void surf_parse_open(const char *file)
   if (!surf_file_to_parse_stack)
     surf_file_to_parse_stack = xbt_dynar_new(sizeof(FILE *), NULL);
 
+  if (!surf_file_to_parse_stack)
+    surf_parsed_filename_stack = xbt_dynar_new(sizeof(FILE *), xbt_free_f);
+  surf_parsed_filename = xbt_strdup(file);
+
   surf_file_to_parse = surf_fopen(file, "r");
   xbt_assert((surf_file_to_parse), "Unable to open \"%s\"\n", file);
   surf_input_buffer = surf_parse__create_buffer(surf_file_to_parse, YY_BUF_SIZE);
@@ -511,6 +545,9 @@ void surf_parse_close(void)
 {
   xbt_dynar_free(&surf_input_buffer_stack);
   xbt_dynar_free(&surf_file_to_parse_stack);
+  xbt_dynar_free(&surf_parsed_filename_stack);
+
+  free(surf_parsed_filename);
 
   if (surf_file_to_parse) {
     surf_parse__delete_buffer(surf_input_buffer);
@@ -572,9 +609,9 @@ static XBT_INLINE void surfxml_call_cb_functions(xbt_dynar_t cb_list)
 void parse_properties(void)
 {
   if (!current_property_set)
-      current_property_set = xbt_dict_new();      // Maybe, it should raise an error
+    current_property_set = xbt_dict_new_homogeneous(xbt_free_f); // Maybe, it should raise an error
 
-  xbt_dict_set(current_property_set, A_surfxml_prop_id, xbt_strdup(A_surfxml_prop_value), free);
+  xbt_dict_set(current_property_set, A_surfxml_prop_id, xbt_strdup(A_surfxml_prop_value), NULL);
 }